D19179: Use PointingHand when hovering links in Label

This revision was automatically updated to reflect the committed changes. Closed by commit R858:632c9cce4a3b: Use PointingHand when hovering links in Label (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19179?vs=52136=52197#toc REPOSITORY R858 Qt Quick Controls

D19179: Use PointingHand when hovering links in Label

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. actually the hoverhandler seems not to be adapt for the job, so go for it REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir,

D19179: Use PointingHand when hovering links in Label

filipf added a comment. In D19179#416235 , @leinir wrote: > In D19179#416222 , @filipf wrote: > > > I had to use I think identical code precisely for this use case recently, however it resulted in

D19179: Use PointingHand when hovering links in Label

leinir added a comment. In D19179#416222 , @filipf wrote: > I had to use I think identical code precisely for this use case recently, however it resulted in increased spacing in ColumnLayout (right after MouseArea). Now I'm just a novice

D19179: Use PointingHand when hovering links in Label

leinir added a comment. In D19179#416214 , @mart wrote: > that's the thing in question > https://doc.qt.io/qt-5/qml-qtquick-hoverhandler.html Thanks for the link. Hm, i imagine this would probably end up in a late enough release that

D19179: Use PointingHand when hovering links in Label

filipf added a comment. I had to use I think identical code precisely for this use case recently, however it resulted in increased spacing in ColumnLayout (right after MouseArea). Now I'm just a novice tinkerer so apologies if the question is stupid, but could it cause similar issues if

D19179: Use PointingHand when hovering links in Label

mart added a comment. that's the thing in question https://doc.qt.io/qt-5/qml-qtquick-hoverhandler.html REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir, ngraham, apol, mart, #kirigami Cc: filipf, plasma-devel, jraleigh,

D19179: Use PointingHand when hovering links in Label

mart added a comment. ideally, this should use pointer handlers (which sadly they are 5.12 only) it may use preprocessing how we sometimes did for menus for instance REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir,

D19179: Use PointingHand when hovering links in Label

mart added a comment. I'm very hesitant to add a MouseArea in evert single Label REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir, ngraham, apol, mart, #kirigami Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19179: Use PointingHand when hovering links in Label

apol added a comment. LGTM +1 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D19179 To: leinir, ngraham, apol, mart, #kirigami Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, lesliezhai, ali-mohamed,

D19179: Use PointingHand when hovering links in Label

leinir created this revision. leinir added reviewers: ngraham, apol, mart, Kirigami. leinir added a project: Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This patch simply adds the behaviour usually