D24917: KCM Style port to KConfigXT

2019-10-31 Thread Cyril Rossi
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fbed4b3efcdb: KCM Style port to KConfigXT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24917?vs=68978=69089 REVISION DETAIL

D24917: KCM Style port to KConfigXT

2019-10-29 Thread Cyril Rossi
crossi updated this revision to Diff 68978. crossi added a comment. Move some duplicated code to a function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24917?vs=68671=68978 REVISION DETAIL https://phabricator.kde.org/D24917 AFFECTED FILES

D24917: KCM Style port to KConfigXT

2019-10-25 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmstyle.cpp:317 > + > +m_model->setSelectedStyle(m_settings->widgetStyle()); > That line and the metaenum wrangling could likely be factored out somehow

D24917: KCM Style port to KConfigXT

2019-10-24 Thread Cyril Rossi
crossi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24917 AFFECTED FILES kcms/style/CMakeLists.txt