D25000: Do not assign combobox currentIndex as it breaks binding.

This revision was automatically updated to reflect the committed changes. Closed by commit R858:35fae4b55fc8: Do not assign combobox currentIndex as it breaks binding. (authored by crossi). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi added inline comments. INLINE COMMENTS > davidedmundson wrote in kpropertywriter_p.h:26 > Throwing out another option > > class KPropertyWriter : public QObject, public QQmlPropertyValueSource > { > Q_INVOKABLE bool writeProperty(QVariant value); > } > >

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Looks good to me. Please just wait a bit before pushing to give David a chance to object to my comments. ;-) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kpropertywriter_p.h:26 > Throwing out another option > > class KPropertyWriter : public QObject, public QQmlPropertyValueSource > { > Q_INVOKABLE bool writeProperty(QVariant value); > } > >

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin added a comment. In D25000#556761 , @davidedmundson wrote: > There's a Plasma rule that if we're working round a Qt bug, there should be a Qt bug created and linked before accepting a workaround. > > From the sounds of it we want a

D25000: Do not assign combobox currentIndex as it breaks binding.

davidedmundson added inline comments. INLINE COMMENTS > kpropertywriter_p.h:26 > + > +class KPropertyWriter : public QObject > +{ Throwing out another option class KPropertyWriter : public QObject, public QQmlPropertyValueSource { Q_INVOKABLE bool writeProperty(QVariant value); }

D25000: Do not assign combobox currentIndex as it breaks binding.

davidedmundson added a comment. There's a Plasma rule that if we're working round a Qt bug, there should be a Qt bug created and linked before accepting a workaround. From the sounds of it we want a QQuickControls::ComboBox::setIndex(int) invokable that doesn't update the binding? Or

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi updated this revision to Diff 69055. crossi added a comment. Missing const ref, rename private header accordingly REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25000?vs=69053=69055 REVISION DETAIL

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Almost there! Glad we're getting near a proper fix. Can you confirm this works with *and* without D24916 applied? Can you also confirm this

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi updated this revision to Diff 69053. crossi added a comment. Remove assignement to currentIndex. Add a C++ bypass to setCurrentIndex without breaking the binding. REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi added inline comments. INLINE COMMENTS > ervin wrote in ComboBox.qml:92 > What about that one? :-) Yes, this one breaks as well. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D25000 To: crossi, #plasma, ervin, mart, bport, broulik

D25000: Do not assign combobox currentIndex as it breaks binding.

ervin added a comment. Good start, there's one case still missing... which looks hard to reach, I wonder how to get there. INLINE COMMENTS > ComboBox.qml:92 > if (indexUnderMouse > -1) { > controlRoot.currentIndex = indexUnderMouse; >

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi created this revision. crossi added reviewers: Plasma, ervin, mart, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Binding with combobox index was broken REPOSITORY R858 Qt Quick Controls 2: