This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8aa96ac72dbd: Solid-device-automounter/kcm: show
disconnected known device when disconnecting… (authored by meven).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
meven updated this revision to Diff 77367.
meven added a comment.
Remove bad commit
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27024?vs=77366=77367
BRANCH
arcpatch-D27024
REVISION DETAIL
https://phabricator.kde.org/D27024
AFFECTED FILES
meven updated this revision to Diff 77366.
meven added a comment.
Solid-device-automounter/kcm: correctly update automountOn
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27024?vs=77365=77366
BRANCH
stash{0}
REVISION DETAIL
meven updated this revision to Diff 77365.
meven added a comment.
Add the recently disconnected device at the end of the list of devices
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27024?vs=77361=77365
BRANCH
arcpatch-D27024
REVISION DETAIL
meven updated this revision to Diff 77361.
meven added a comment.
Rebase on master, and follow removal of singleton
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27024?vs=75847=77361
BRANCH
arcpatch-D27024
REVISION DETAIL
ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.
I guess extra care will need to be taken with your other patch moving away
from the singleton (dunno which one is based on which, I might review out of
order).
REPOSITORY
R119 Plasma
meven updated this revision to Diff 75847.
meven marked 2 inline comments as done.
meven added a comment.
Add a missing space, improve comment as suggested
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27024?vs=74667=75847
BRANCH
arcpatch-D27024
ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> DeviceModel.cpp:101
> // is no longer available when the device is gone
> +// Unless we have some settings for the device
> +if
meven created this revision.
meven added reviewers: broulik, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.
REVISION SUMMARY
A user might find odd that when a known device in the UI is unmounted, it
disappears.
