D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

This revision was automatically updated to reflect the committed changes. Closed by commit R119:07b4f3fb6c3c: Solid-device-automounter/kcm: Use KConfigXT in ui (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=76286=76289

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven updated this revision to Diff 76286. meven marked 3 inline comments as done. meven added a comment. Fix indentation and add intermediate variable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=75891=76286 BRANCH arcpatch-D27127_1

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DeviceAutomounterKCM.cpp:44 > : KCModule(parent, args)//DeviceAutomounterKCMFactory::componentData(), > parent) > + , m_devices(new

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > meven wrote in DeviceAutomounterKCM.cpp:57 > Just waiting for this review then, I am preparing the next patch D27480 REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven marked 4 inline comments as done. meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounterKCM.cpp:57 > Sure, moving away from a singleton is always intrusive (just like moving away > from a global variable which it is really). Let's aim for it in a different >

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

ervin added inline comments. INLINE COMMENTS > meven wrote in DeviceAutomounterKCM.cpp:57 > Please beware this will make my patch quite a lot more intrusive, DeviceModel > for instance, will need a field to keep some reference to the > AutomounterSettings Sure, moving away from a singleton is

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > ervin wrote in DeviceAutomounterKCM.cpp:57 > I tend to consider this as a step back to be honest. Singletons tend to be > more trouble down the line when something goes wrong. Please beware this will make my patch quite a lot more intrusive,

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

ervin added inline comments. INLINE COMMENTS > meven wrote in DeviceAutomounterKCM.cpp:57 > I removed the m_settings instead, relying solely on the singleton. I tend to consider this as a step back to be honest. Singletons tend to be more trouble down the line when something goes wrong.

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven added inline comments. INLINE COMMENTS > bport wrote in DeviceAutomounterKCM.cpp:84 > We can also change kcfgc to add parent in constructor It would imply make AutomounterSettings not-static. I would need to change the DeviceModel that uses AutomounterSettings static functions as well.

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven updated this revision to Diff 75891. meven marked an inline comment as done. meven added a comment. Remove m_settings AutomounterSettings member from DeviceAutomounterKCM REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=75845=75891

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

bport added inline comments. INLINE COMMENTS > DeviceAutomounterKCM.cpp:84 > saveLayout(); > +delete m_settings; > } We can also change kcfgc to add parent in constructor REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27127 To: meven, ervin,

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven updated this revision to Diff 75845. meven marked 2 inline comments as done. meven added a comment. Add a delete for m_settings, move m_devices to ctor intialization REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27127?vs=74925=75845 BRANCH

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DeviceAutomounterKCM.cpp:57 > > +m_settings = new AutomounterSettings(); > +addConfig(m_settings, this); Missing this as parent, this is leaked. Also

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

meven created this revision. meven added reviewers: ervin, ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY - Make default button work - Move connection from cpp to .ui - Slight label change