ahmadsamir added a comment.
Ping.
REPOSITORY
R126 KDE CLI Utilities
REVISION DETAIL
https://phabricator.kde.org/D28000
To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, ragreen, ZrenBot, ngraham,
ahmadsamir added a comment.
Ping.
REPOSITORY
R126 KDE CLI Utilities
REVISION DETAIL
https://phabricator.kde.org/D28000
To: ahmadsamir, #plasma, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot,
ahmadsamir added inline comments.
INLINE COMMENTS
> apol wrote in kstart.cpp:184
> Wouldn't it be easier here to just do `windowtitle.compare(info.name(),
> Qt::CaseInsensitive)` and skip the regex?
I thought about that, but looking at the code I found:
void KStart::sendRule() {
apol added inline comments.
INLINE COMMENTS
> kstart.cpp:184
> +const QRegularExpression
> re(QRegularExpression::anchoredPattern(windowtitle.toLower()));
> +if (!re.match(title).hasMatch()) {
> +return; // no match
Wouldn't it be easier here to just do
ahmadsamir updated this revision to Diff 77481.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.
Fix commit message
REPOSITORY
R126 KDE CLI Utilities
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28000?vs=77480=77481
BRANCH
l-qregexp (branched from
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, apol, davidedmundson.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.
TEST PLAN
make && ctest
REPOSITORY
R126 KDE CLI Utilities
BRANCH
l-qregexp (branched from master)
REVISION DETAIL
