This revision was automatically updated to reflect the committed changes.
Closed by commit R111:5cfc09fd4463: Add KSysGuard::Sensors library (authored by
ahiemstra).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=82082=82181
REVISION
ahiemstra updated this revision to Diff 82082.
ahiemstra added a comment.
Maybe right now?
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=82081=82082
BRANCH
sensors_lib
REVISION DETAIL
https://phabricator.kde.org/D28141
AFFECTED
ahiemstra updated this revision to Diff 82081.
ahiemstra added a comment.
Urgh arc
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=82080=82081
BRANCH
sensors_lib
REVISION DETAIL
https://phabricator.kde.org/D28141
AFFECTED FILES
ahiemstra updated this revision to Diff 82080.
ahiemstra added a comment.
- Correct Vlad's name in a few more places
- Make comments in SensorInfo_p.h a bit more useful
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=81577=82080
BRANCH
ngraham added a comment.
+1, excellent work.
INLINE COMMENTS
> Sensor.cpp:2
> +/*
> +Copyright (C) 2019 Vlad Zagorodniy
> +Copyright (C) 2020 Arjen Hiemstra
Update name
> Sensor.cpp:219
> +
> +if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()")
> != -1)
ahiemstra updated this revision to Diff 81577.
ahiemstra added a comment.
Don't eat the lib Arc
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=81576=81577
BRANCH
sensors_lib
REVISION DETAIL
https://phabricator.kde.org/D28141
ahiemstra updated this revision to Diff 81576.
ahiemstra added a comment.
- Don't expose private SensorInfo in public interface of SensorQuery
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=80758=81576
BRANCH
sensors_lib
REVISION
ahiemstra updated this revision to Diff 80758.
ahiemstra added a comment.
- clang-format sensors lib
- Capture this rather than =
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=79072=80758
BRANCH
sensors_lib
REVISION DETAIL
ahiemstra added inline comments.
INLINE COMMENTS
> mart wrote in SensorsPlugin.cpp:2
> also here
Same issue as above.
> mart wrote in SensorsPlugin.h:2
> shouldn't remove existing copyrights?
It's a new file, but for some reason Phab thinks it's copied from formatter.h
(which it has nothing
mart added inline comments.
INLINE COMMENTS
> Sensor.cpp:207
> +
> +if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()")
> != -1) {
> +connect(parent(), SIGNAL(enabledChanged()), this,
> SIGNAL(enabledChanged()));
if (
> SensorDaemonInterface.cpp:87
> +
ahiemstra updated this revision to Diff 79072.
ahiemstra added a comment.
- Fix qmldir file
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=78985=79072
BRANCH
sensors_lib
REVISION DETAIL
https://phabricator.kde.org/D28141
AFFECTED
mart added a comment.
while porting the systemmonitor plasmoids to upstream, i found a couple of
problems:
- gcc didn't like inserting using a const iterator
- qmldir outdated with the old plugin name
diff on top of this phab: https://phabricator.kde.org/P567
REPOSITORY
R111
ahiemstra updated this revision to Diff 78985.
ahiemstra added a comment.
- Update zzag's last name
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=78372=78985
BRANCH
sensors_lib
REVISION DETAIL
https://phabricator.kde.org/D28141
ahiemstra updated this revision to Diff 78372.
ahiemstra added a comment.
- Add some documentation to classes
- Properly install the export header
- Don't use PUBLIC_HEADERS, it's not well supported on earlier CMake
- Rebase, update SensorInfo and Daemon XML to new versions
REPOSITORY
zzag added inline comments.
INLINE COMMENTS
> Sensor.h:2
> +/*
> +Copyright (C) 2019 Vlad Zagorodniy
> +Copyright (C) 2020 Arjen Hiemstra
Could you please update my last name?
git grep -l 'Vlad Zagorodniy' | xargs sed -i 's/Vlad Zagorodniy/Vlad
Zahorodnii/g'
REPOSITORY
R111
ahiemstra updated this revision to Diff 78275.
ahiemstra added a comment.
- Don't use PUBLIC_HEADERS, it's not well supported on earlier CMake
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=78080=78275
BRANCH
sensors_lib
REVISION
ahiemstra updated this revision to Diff 78080.
ahiemstra added a comment.
- Properly install the export header
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=78020=78080
BRANCH
sensors_lib
REVISION DETAIL
ahiemstra updated this revision to Diff 78020.
ahiemstra added a comment.
- Add some documentation to classes
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28141?vs=78017=78020
BRANCH
sensors_lib
REVISION DETAIL
ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
This adds a new library for communicating with a new KSysGuard
DBus-based daemon that
19 matches
Mail list logo
