This revision was automatically updated to reflect the committed changes.
Closed by commit R119:20f451125ce7: KCM/GlobalShortut: convert FOREACH and old
signal syntax (authored by meven).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
meven updated this revision to Diff 80616.
meven added a comment.
Fix for loop
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28282?vs=80614=80616
BRANCH
arcpatch-D28282
REVISION DETAIL
https://phabricator.kde.org/D28282
AFFECTED FILES
meven updated this revision to Diff 80614.
meven added a comment.
Rebasing
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28282?vs=78913=80614
BRANCH
arcpatch-D28282
REVISION DETAIL
https://phabricator.kde.org/D28282
AFFECTED FILES
meven updated this revision to Diff 78913.
meven marked 5 inline comments as done.
meven added a comment.
Adress review (formatting) and fix a couple of indentation issues
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28282?vs=78522=78913
BRANCH
bport added a comment.
Some coding style nitpicking
INLINE COMMENTS
> export_scheme_dialog.cpp:46
> int item=0;
> -Q_FOREACH(QString component, mComponents)
> +for (const QString : qAsConst(mComponents))
> {
{ on same line
> export_scheme_dialog.cpp:74
> +const auto
meven updated this revision to Diff 78522.
meven marked 4 inline comments as done.
meven added a comment.
Review comments, code formating more const
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28282?vs=78457=78522
BRANCH
shortcuts
REVISION
ahmadsamir added inline comments.
INLINE COMMENTS
> export_scheme_dialog.cpp:46
> int item=0;
> -Q_FOREACH(QString component, mComponents)
> +for(QString component : qAsConst(mComponents))
> {
const QString &
> export_scheme_dialog.cpp:74
> +const auto buttons =
davidedmundson added inline comments.
INLINE COMMENTS
> globalshortcuts.cpp:42
> editor = new KGlobalShortcutsEditor(this,
> KShortcutsEditor::GlobalAction);
> -connect(editor, SIGNAL(changed(bool)), this, SIGNAL(changed(bool)));
> +connect(editor, ::changed, this,
>
meven created this revision.
meven added reviewers: ervin, bport, crossi, hchain, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.
TEST PLAN
Builds, changed a shortcut and back again
REPOSITORY
R119 Plasma Desktop
