D28859: Detect QQC2 version at build time with actual detection.

This revision was automatically updated to reflect the committed changes. Closed by commit R858:aa57b34f75f0: Detect QQC2 version at build time with actual detection. (authored by xuetianweng). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng added a comment. In D28859#652379 , @davidedmundson wrote: > So the problem we're solving is that we want to go > > Qt5.12 - QQC2.5 > Qt5.13 - QQC2.6 > Qt5.14 - QQC2.7 > Qt5.15 - QQC2.15 > > correct? > > We now

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng updated this revision to Diff 80646. xuetianweng added a comment. Just fix the version by if-else check. REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28859?vs=80227=80646 BRANCH master REVISION DETAIL

D28859: Detect QQC2 version at build time with actual detection.

davidedmundson added a comment. So the problem we're solving is that we want to go Qt5.12 - QQC2.5 Qt5.13 - QQC2.6 Qt5.14 - QQC2.7 Qt5.15 - QQC2.15 correct? We now know all Qt5 versions, and we know that Qt6 won't have versions. I don't see why need this complicated

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng added a comment. ping? :) REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28859 To: xuetianweng, #plasma, rizzitello, davidedmundson, apol, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng added a comment. In D28859#649191 , @davidedmundson wrote: > I don't understand. > > We're still running this at compile time, so what's the practical difference? The old implement hard-codes it to (minor_version - 7),

D28859: Detect QQC2 version at build time with actual detection.

davidedmundson added a comment. I don't understand. We're still running this at compile time, so what's the practical difference? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28859 To: xuetianweng, #plasma, rizzitello,

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng updated this revision to Diff 80227. xuetianweng added a comment. fix header REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28859?vs=80226=80227 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28859

D28859: Detect QQC2 version at build time with actual detection.

xuetianweng created this revision. xuetianweng added reviewers: Plasma, rizzitello, davidedmundson, apol, mart. xuetianweng added a project: Plasma. Herald added a subscriber: plasma-devel. xuetianweng requested review of this revision. REVISION SUMMARY Whenever qqc release a new version the