D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

2020-04-20 Thread Ahmad Samir
ahmadsamir abandoned this revision. ahmadsamir added a comment. Talking with kbroulik on irc confirms your POV, the format of those patterns aren't documented anywhere so changing the matching now would change the behaviour... I'll abandon this, (I suggest that X-Plasma-DropUrlPatterns

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

2020-04-19 Thread Ahmad Samir
ahmadsamir added a reviewer: broulik. ahmadsamir added a comment. I had trouble finding what urlPatterns would look like, and only found trash:/ and run:/, also couldn't find any documentation about X-Plasma-DropUrlPatterns. Porting regex, especially with the pesky QRegExp::Wildcard,

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

2020-04-19 Thread Aleix Pol Gonzalez
apol added a comment. I wonder, while this will work with all our uses of DropUrlPatterns, this would have been able to work with something like `scheme:/*potato*` which after this patch won't work. In fact, it's called Patterns, not DropUrlWhenStartsWith. I'd appreciate feedback from

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

2020-04-19 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmadsamir requested review of this revision. REVISION SUMMARY AFAICS, from grep'ing for "DropUrlPatterns" in