D28990: Port quicklaunch from KRun::run to CommandLauncherJob

dfaure closed this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28990 To: dfaure, drosca, davidedmundson, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. If you want to rework it that'll be appreciated but I can look into it since I did the pioneer porting of Task manager REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

dfaure added a comment. OK, that's above my head. Shall I push this or you'll rework it all? I just want to be able to deprecated KRun::run and friends :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28990 To: dfaure, drosca, davidedmundson, broulik

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik added a comment. > Does this really use KServiceAction anywhere? It doesn't but it should since it also supports jump list ations. Probably needs similar treatment like I did with task manager in D28286 REPOSITORY R114 Plasma Addons

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

dfaure updated this revision to Diff 80586. dfaure added a comment. Use KNotificationJobUiDelegate REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28990?vs=80568=80586 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28990 AFFECTED

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

dfaure added a comment. Agreed about notification delegate, will do. Does this really use KServiceAction anywhere? I don't see that. Confusing this one and D28988 ? [which however can't use the KServiceAction because of special support for %D and

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik added a comment. Also actually this should probably be refactored completely to use `KServiceAction` rather passing the exec to QML and then back here :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28990 To: dfaure, drosca, davidedmundson, broulik

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

broulik added a comment. Since it's an applet and thus run inside Plasma, do we not rather want the `KNotificationJobUiDelegate`? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28990 To: dfaure, drosca, davidedmundson, broulik Cc: plasma-devel, Orage,

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

dfaure created this revision. dfaure added reviewers: drosca, davidedmundson, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. TEST PLAN Builds, but untested. REPOSITORY R114 Plasma Addons BRANCH master REVISION