D29019: Create a hotspot KCM for Plasma Mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R116:1c9d021daf4e: Create a hotspot KCM for Plasma Mobile (authored by tfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29019?vs=80765=80796#toc REPOSITORY R116 Plasma Network Management

D29019: Create a hotspot KCM for Plasma Mobile

cblack accepted this revision. cblack added a comment. UI seems fine enough. REPOSITORY R116 Plasma Network Management Applet BRANCH mobileHotspotKcm REVISION DETAIL https://phabricator.kde.org/D29019 To: tfella, #vdg, jgrulich, nicolasfella, cblack Cc: cblack, nicolasfella,

D29019: Create a hotspot KCM for Plasma Mobile

tfella added a comment. F8251937: HotspotKcm.png REPOSITORY R116 Plasma Network Management Applet BRANCH mobileHotspotKcm REVISION DETAIL https://phabricator.kde.org/D29019 To: tfella, #vdg, jgrulich, nicolasfella Cc: nicolasfella, plasma-devel,

D29019: Create a hotspot KCM for Plasma Mobile

tfella updated this revision to Diff 80765. tfella added a comment. Use network-wireless-hotspot as icon REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80714=80765 BRANCH mobileHotspotKcm REVISION DETAIL

D29019: Create a hotspot KCM for Plasma Mobile

tfella updated this revision to Diff 80714. tfella marked an inline comment as done. tfella added a comment. Change id REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80689=80714 BRANCH mobileHotspotKcm REVISION DETAIL

D29019: Create a hotspot KCM for Plasma Mobile

jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:39 > +Controls.Switch { > +id: enabled > +Kirigami.FormData.label: i18n("Enabled:") Using adjective as an ID looks weird

D29019: Create a hotspot KCM for Plasma Mobile

tfella updated this revision to Diff 80689. tfella added a comment. fix REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80688=80689 BRANCH mobileHotspotKcm REVISION DETAIL https://phabricator.kde.org/D29019 AFFECTED

D29019: Create a hotspot KCM for Plasma Mobile

tfella added a comment. Git/Arc decided to do weird things, I hope I didn't break it REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29019 To: tfella, #vdg, jgrulich Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29019: Create a hotspot KCM for Plasma Mobile

tfella updated this revision to Diff 80688. tfella marked 6 inline comments as done. tfella added a comment. Fixes REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80683=80688 BRANCH mobileHotspotKcm REVISION DETAIL

D29019: Create a hotspot KCM for Plasma Mobile

nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +project (kcm_mobile_hotspot) > + remove > CMakeLists.txt:11 > +KF5::I18n > +KF5::Plasma > +KF5::QuickAddons KF5::Plasma shouldn't be needed > hotspotsettings.cpp:30 > +{ > +KAboutData* about = new

D29019: Create a hotspot KCM for Plasma Mobile

tfella updated this revision to Diff 80683. tfella added a comment. Whitespace fix REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80679=80683 BRANCH mobileHotspotKcm (branched from master) REVISION DETAIL

D29019: Create a hotspot KCM for Plasma Mobile

tfella created this revision. tfella added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. tfella requested review of this revision. REVISION SUMMARY Implements T12895 . Might