apol updated this revision to Diff 66322.
apol added a comment.
Use KDE's server
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=66273=66322
BRANCH
arcpatch-D5961_1
REVISION DETAIL
https://phabricator.kde.org/D5961
AFFECTED
apol added a comment.
> Shouldn't these be in Kirigami, then?
Let's see what it ends up looking like, we've already moved half this patch
to plasma-workspace.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5961
To: apol, #plasma, vkrause
Cc:
ngraham added a comment.
This doesn't build for me:
[ 82%] Building CXX object
discover/CMakeFiles/plasma-discover.dir/plasmauserfeedback.cpp.o
In file included from
/home/nate/kde/build/discover/discover/plasmauserfeedback.cpp:4:
ngraham added a comment.
After opening the KCM for the first time, the checkbox is checked. I thought
we were going to make this opt-in? If so, it needs to be **unchecked** by
default.
For the message, I would phrase it like this:
> We make Plasma for you. You can help us improve
vkrause added a comment.
+1
INLINE COMMENTS
> DiscoverWindow.qml:71
> +surveyInterval: 30
> +feedbackServer: "http://localhost:8083/;
> +encouragementInterval: 30
https://telemetry.kde.org/
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
apol updated this revision to Diff 66273.
apol added a comment.
Remove the dialog and read the settings globally for Plasma.
Moved the feedback settings to the About page.
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=65968=66273
apol updated this revision to Diff 65968.
apol added a comment.
Rename property
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=65967=65968
BRANCH
arcpatch-D5961_1
REVISION DETAIL
https://phabricator.kde.org/D5961
AFFECTED
apol updated this revision to Diff 65967.
apol added a comment.
Rebase
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=32897=65967
BRANCH
arcpatch-D5961_1
REVISION DETAIL
https://phabricator.kde.org/D5961
AFFECTED FILES
apol updated this revision to Diff 32897.
apol added a comment.
adapt
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=32887=32897
BRANCH
arcpatch-D5961
REVISION DETAIL
https://phabricator.kde.org/D5961
AFFECTED FILES
apol updated this revision to Diff 32887.
apol added a comment.
Rebase to master
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=15686=32887
BRANCH
arcpatch-D5961
REVISION DETAIL
https://phabricator.kde.org/D5961
AFFECTED
apol updated this revision to Diff 15686.
apol marked 4 inline comments as done.
apol added a comment.
- Expose the applicationSourceName to KUserFeedback
- Include a KUserFeedback schema file
- Address Volker's comments
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
vkrause added inline comments.
INLINE COMMENTS
> CMakeLists.txt:30
>
> +find_package(UserFeedback)
> +
Hm, looks like I forgot to rename this to KUserFeedback... Should probably done
to be consistent with naming elsewhere. I'll look into it, and sorry for yet
another SC change.
>
apol updated this revision to Diff 15500.
apol added a comment.
- Include a KUserFeedback schema file
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=15498=15500
BRANCH
kuserfeedback
REVISION DETAIL
apol updated this revision to Diff 15498.
apol added a comment.
- Expose the applicationSourceName to KUserFeedback
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=15366=15498
BRANCH
kuserfeedback
REVISION DETAIL
apol updated this revision to Diff 15366.
apol added a comment.
Adapt to changes kuserfeedback
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=15217=15366
BRANCH
kuserfeedback
REVISION DETAIL
https://phabricator.kde.org/D5961
apol updated this revision to Diff 15217.
apol added a comment.
Adapt to changes in kuserfeedback, make sure more sources are sent
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5961?vs=14805=15217
BRANCH
kuserfeedback
REVISION DETAIL
mart added a comment.
+1
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5961
To: apol, #plasma, vkrause
Cc: mart, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
apol created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Creates components so it can be integrated in any Kirigami application though.
Haven't tested custom information providers yet, need to get
18 matches
Mail list logo
