Re: Remove plasma-desktop/useraccount code?

2015-10-09 Thread kainz.a
if you don't know where to store the avatars, I would prefere to store all pictures in one design repository. Am 09.10.2015 14:02 schrieb "Jonathan Riddell" : > On Fri, Oct 09, 2015 at 01:46:49PM +0200, Vishesh Handa wrote: > > So if you want to delete the code, go ahead, just

Re: Remove plasma-desktop/useraccount code?

2015-10-09 Thread Vishesh Handa
On Sat, Sep 26, 2015 at 3:30 PM, Albert Astals Cid wrote: > Please CC me i'm not subscribed. > > Should we remove plasma-desktop/useraccount since we're not compiling it > anymore? Sadly, we cannot just remove it. It has avatars which are still shipped. A commit without review

Re: Remove plasma-desktop/useraccount code?

2015-10-09 Thread Jonathan Riddell
On Fri, Oct 09, 2015 at 01:46:49PM +0200, Vishesh Handa wrote: > So if you want to delete the code, go ahead, just leave the avatars. I > don't think you even need to go through review, the original person > doing this clearly did not. Nuff of the insulting side comments please, it's grossly

Re: Remove plasma-desktop/useraccount code?

2015-10-09 Thread Vishesh Handa
On Oct 9, 2015 15:40, "Sebastian Kügler" wrote: > > On Friday, October 09, 2015 13:46:49 Vishesh Handa wrote: > > So if you want to delete the code, go ahead, just leave the avatars. I > > don't think you even need to go through review, the original person > > doing this clearly

Re: Remove plasma-desktop/useraccount code?

2015-10-09 Thread Vishesh Handa
On Oct 9, 2015 14:02, "Jonathan Riddell" wrote: > > On Fri, Oct 09, 2015 at 01:46:49PM +0200, Vishesh Handa wrote: > > So if you want to delete the code, go ahead, just leave the avatars. I > > don't think you even need to go through review, the original person > > doing this

Re: Remove plasma-desktop/useraccount code?

2015-10-09 Thread Sebastian Kügler
On Friday, October 09, 2015 13:46:49 Vishesh Handa wrote: > So if you want to delete the code, go ahead, just leave the avatars. I > don't think you even need to go through review, the original person > doing this clearly did not. I think we should try without unnecessary snide remarks. -- sebas

Remove plasma-desktop/useraccount code?

2015-09-26 Thread Albert Astals Cid
Please CC me i'm not subscribed. Should we remove plasma-desktop/useraccount since we're not compiling it anymore? Having there the code with the CMakeLists.txt commented out makes no sense, we have a VCS for a reason. Cheers, Albert ___