Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Dec. 28, 2015, 2:09 p.m.) Status -- This change has been

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Dec. 23, 2015, 9:20 a.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review89948 --- Ship it! libs/mediacenter/lastfmimagefetcher.cpp (line 172)

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Dec. 21, 2015, 2:51 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Dec. 21, 2015, 8:39 a.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 27, 2015, 7:05 a.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 25, 2015, 4:31 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 25, 2015, 4:30 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 23, 2015, 8:05 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88715 --- Do the tests not work anymore? Just curious why were they

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 23, 2015, 1:50 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88730 --- libs/mediacenter/lastfmimagefetcher.cpp (line 152)

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 22, 2015, 2:19 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 22, 2015, 2:23 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 22, 2015, 2:14 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

> On Nov. 13, 2015, 9:23 a.m., Ashish Bansal wrote: > > libs/mediacenter/lastfmimagefetcher.cpp, line 158 > > > > > > As imageFetcher is a signal, append "emit" word in the beginning. > > Although it is an

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88315 --- libs/mediacenter/lastfmimagefetcher.cpp (line 156)

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 13, 2015, 9:27 a.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 12, 2015, 7:21 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88301 --- libs/mediacenter/lastfmimagefetcher.cpp (line 46)

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 12, 2015, 4:36 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- (Updated Nov. 12, 2015, 4:23 p.m.) Review request for Plasma, Ashish

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88159 --- datasources/lastfm/CMakeLists.txt (line 2)

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

> On Nov. 8, 2015, 6:11 p.m., Bhushan Shah wrote: > > datasources/lastfm/CMakeLists.txt, line 2 > > > > > > You sure this builds? there is no > > datasources/lastfm/lastfmimagefetcher.cpp ? Sorry, I somehow

Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ --- Review request for Plasma, Ashish Bansal and Bhushan Shah. Repository: