Re: Review Request 126460: Honor SkipGrouping hint from KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126460/ --- (Updated Jan. 4, 2016, 5:38 p.m.) Status -- This change has been

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

> On Dec. 21, 2015, 9:38 p.m., David Edmundson wrote: > > Stable too? That would require bumping the required frameworks version from 5.15 to 5.18. - Martin --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

> On Dic. 21, 2015, 8:38 p.m., David Edmundson wrote: > > dataengines/notifications/notificationsengine.cpp, line 191 > > > > > > const shipit, modulo this const - Marco

Review Request 126460: Honor SkipGrouping hint from KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126460/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

> On Dec. 21, 2015, 8:38 p.m., David Edmundson wrote: > > This does seem like a much better way to handle the grouping, so I'll +1 > > this. > > > > But as for the actual bug that brought you here: > > Why are we getting two notifications for everything from Plasma in the > > first place? >

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126460/#review89856 --- Ship it! dataengines/notifications/notificationsengine.cpp

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126460/#review89855 --- This does seem like a much better way to handle the grouping,