Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-28 Thread Sergey Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/ --- (Updated Feb. 28, 2016, 11:22 p.m.) Status -- This change has been

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review92872 --- Ship it! I'll fix the issues pointed out by Kai and

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-28 Thread Aleix Pol Gonzalez
> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote: > > src/plasma/private/packages.cpp, line 99 > > > > > > QByteArrayLiteral and below QByteArrayLiteral is a weird thing, let's not get there. - Aleix

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review91889 --- src/declarativeimports/calendar/daysmodel.cpp (line 135)

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review91881 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 17,

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-02-01 Thread Aleix Pol Gonzalez
> On Feb. 1, 2016, 10 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmaextracomponents/plasmaextracomponentsplugin.cpp, > > line 34 > > > > > > I thought QLatin1String was better for comparison? +1

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-17 Thread Sergey Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/ --- (Updated Янв. 17, 2016, 8:50 п.п.) Review request for KDE Frameworks,

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-17 Thread Sergey Popov
> On Янв. 11, 2016, 12:38 п.п., Sebastian Kügler wrote: > > src/declarativeimports/core/corebindingsplugin.cpp, line 77 > > > > > > QString()? > > Aleix Pol Gonzalez wrote: > +1 That was an automated change

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review90890 --- autotests/coronatest.cpp (line 182)

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-11 Thread Aleix Pol Gonzalez
> On Jan. 11, 2016, 1:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 215 > > > > > > Do we really not want the C++11 for here? If we don't, I'd prefer > > Q_FOREACH as replacement, the Q_

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-11 Thread Aleix Pol Gonzalez
> On Jan. 11, 2016, 1:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 182 > > > > > > Why is clazy complaining here? I think the .first() API is actually > > quite nice, don't see anything

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-11 Thread Sebastian Kügler
> On Jan. 11, 2016, 12:38 p.m., Sebastian Kügler wrote: > > autotests/coronatest.cpp, line 215 > > > > > > Do we really not want the C++11 for here? If we don't, I'd prefer > > Q_FOREACH as replacement, the Q_

Re: Review Request 126672: Fix most of Clazy warnings in plasma-framework

2016-01-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126672/#review90785 --- Looks good. +1 - Aleix Pol Gonzalez On Jan. 8, 2016, 2:34