Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/ --- (Updated Feb. 3, 2016, 5:32 p.m.) Status -- This change has been

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Sebastian Kügler
> On Feb. 2, 2016, 12:43 p.m., Sebastian Kügler wrote: > > shell/shellcorona.cpp, line 629 > > > > > > m_screenConfiguration may still be a nullptr here, since it's set only > > after GetConfigOperation

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/ --- (Updated Feb. 2, 2016, 3 p.m.) Review request for Plasma. Bugs: 351777

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/#review91962 --- Ship it! Ship It! - Sebastian Kügler On Feb. 2, 2016,

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/ --- (Updated Feb. 2, 2016, 3:17 p.m.) Review request for Plasma. Bugs:

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Marco Martin
> On Feb. 2, 2016, 9:25 a.m., Marco Martin wrote: > > Ship It! related to this, what could be a timeframe to depend from 5.6 (and finally use the famous qscreen patch?) - Marco --- This is an automatically generated e-mail. To reply,

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Martin Gräßlin
> On Feb. 2, 2016, 10:25 a.m., Marco Martin wrote: > > Ship It! > > Marco Martin wrote: > related to this, what could be a timeframe to depend from 5.6 (and > finally use the famous qscreen patch?) best we discuss it on the mailing list. My suggestion would be ASAP, on the day of the

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/#review91928 --- Ship it! Ship It! - Marco Martin On Feb. 1, 2016,

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread David Edmundson
> On Feb. 2, 2016, 12:43 p.m., Sebastian Kügler wrote: > > shell/shellcorona.cpp, line 629 > > > > > > m_screenConfiguration may still be a nullptr here, since it's set only > > after GetConfigOperation

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Sebastian Kügler
> On Feb. 2, 2016, 12:43 p.m., Sebastian Kügler wrote: > > shell/shellcorona.cpp, line 629 > > > > > > m_screenConfiguration may still be a nullptr here, since it's set only > > after GetConfigOperation

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/#review91946 --- shell/shellcorona.cpp (line 629)

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-02 Thread David Edmundson
> On Feb. 2, 2016, 12:43 p.m., Sebastian Kügler wrote: > > shell/shellcorona.cpp, line 629 > > > > > > m_screenConfiguration may still be a nullptr here, since it's set only > > after GetConfigOperation

Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 126961: Fix the infamous Plasma::Applet::Actions crash

2016-02-01 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126961/#review91912 --- Ship it! Ship It! - Aleix Pol Gonzalez On Feb. 2,