date:20151123

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Aditya Dev Sharma


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 23, 2015, 8:05 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Changes
---

Changes made as per Review.


Repository: plasma-mediacenter


Description (updated)
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList.

After the image is fetched, gotImage emits the signal mediaUpdated (from 
mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing (updated)
---

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Fixed the QThread LastfmImageFetcher Warning.
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126121: [greeter] Use PlasmaShellSurface to position the views

2015-11-23 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126121/
---

(Updated Nov. 23, 2015, 10:47 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Bhushan Shah.


Changes
---

Submitted with commit c5e205fa93cca51eef3b59f81804bcda5147770e by Martin 
Gräßlin to branch Plasma/5.5.


Repository: kscreenlocker


Description
---

This ensures that each view goes on the screen and is positioned
correctly. In addition it ensures that on hot plug of a new screen
a new created view is added to it.


Diffs
-

  greeter/greeterapp.h 35e7aa5a3e4d816b130adc2626f6a8ab31fd 
  greeter/greeterapp.cpp 87ddc5efe362d8d339326b492306b0f087f2bf38 

Diff: https://git.reviewboard.kde.org/r/126121/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126143: [ksmserver] Fall back to session runner if UserSwitcher.qml is broken

2015-11-23 Thread Kai Uwe Broulik



> On Nov. 23, 2015, 10:59 vorm., Martin Gräßlin wrote:
> > and what if krunner fails? That's a rhethorical question. I don't think 
> > that we need a fallback to go to krunner. If it's broken it's broken. Maybe 
> > show a dialog that it's broken (compare KWin tabbox/tabboxhandler.cpp line 
> > 289)

@Marco: Do look and feel packages have a fall back? If so, it should be fine, 
given Breeze will always provide a User Switcher. Thinking of heavily 
customized KDE installs like SuSE (in case they forgot to adjust/add it to 
theirs). Also, the default UserSwitcher.qml was present but broken (contained a 
"1") so could be that the distro-specific copies have that too breaking the 
fallback (if any)?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126143/#review88712
---


On Nov. 23, 2015, 9:26 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126143/
> ---
> 
> (Updated Nov. 23, 2015, 9:26 vorm.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> In case the UserSwitcher.qml file is missing or broken, let's fall back to 
> use KRunner's session runner.
> 
> 
> Diffs
> -
> 
>   ksmserver/server.cpp 9477e54 
>   ksmserver/switchuserdialog.cpp 26d6710 
> 
> Diff: https://git.reviewboard.kde.org/r/126143/diff/
> 
> 
> Testing
> ---
> 
> Broke my UserSwitcher.qml file, got KRunner instead.
> Fixed it, got the proper QML UI again.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126095: [backends/hwcomposer] Announce support for DPMS

2015-11-23 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126095/
---

(Updated Nov. 23, 2015, 10:49 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Kai Uwe Broulik.


Changes
---

Submitted with commit 3361373445d151bc08bc2d92ac4c33e779060933 by Martin 
Gräßlin to branch Plasma/5.5.


Repository: kwin


Description
---

Hooked up to toggle blank output dependent on state.


Diffs
-

  backends/hwcomposer/hwcomposer_backend.h 
3fa40c2ce31a53b62e4c718b90c3867441f35395 
  backends/hwcomposer/hwcomposer_backend.cpp 
8cb972d62e14526853dfef52e9d4e157701071b9 

Diff: https://git.reviewboard.kde.org/r/126095/diff/


Testing
---

tested with the dpms test tool in kwayland.


Thanks,

Martin Gräßlin

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126143: [ksmserver] Fall back to session runner if UserSwitcher.qml is broken

2015-11-23 Thread Martin Gräßlin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126143/#review88712
---


and what if krunner fails? That's a rhethorical question. I don't think that we 
need a fallback to go to krunner. If it's broken it's broken. Maybe show a 
dialog that it's broken (compare KWin tabbox/tabboxhandler.cpp line 289)

- Martin Gräßlin


On Nov. 23, 2015, 10:26 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126143/
> ---
> 
> (Updated Nov. 23, 2015, 10:26 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> In case the UserSwitcher.qml file is missing or broken, let's fall back to 
> use KRunner's session runner.
> 
> 
> Diffs
> -
> 
>   ksmserver/server.cpp 9477e54 
>   ksmserver/switchuserdialog.cpp 26d6710 
> 
> Diff: https://git.reviewboard.kde.org/r/126143/diff/
> 
> 
> Testing
> ---
> 
> Broke my UserSwitcher.qml file, got KRunner instead.
> Fixed it, got the proper QML UI again.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126126: kicker: always show arrows for items with children

2015-11-23 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126126/#review88711
---


I think currently without arrows does look a bit strange with potential 
usability issues, but with arrows always in will probably indeed look a bit 
cluttered..
can you please include a screenshot in such reviews that cause a look change?

- Marco Martin


On Nov. 21, 2015, 12:25 p.m., Pino Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126126/
> ---
> 
> (Updated Nov. 21, 2015, 12:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Always show the arrow in menu items which represent a submenu, instead
> of only when hovering on them. This eases the discovery of which items
> are actually submenus as opposed to actual entries.
> 
> 
> Diffs
> -
> 
>   applets/kicker/package/contents/ui/ItemListDelegate.qml 
> becf13d278862b20f46eacae628364708abadfdc 
> 
> Diff: https://git.reviewboard.kde.org/r/126126/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Pino Toscano
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Kubuntu 15.04 Graphics Driver Issue

2015-11-23 Thread gokul krishna

Hi,

I started using Kubuntu 15.04 around five months back and recently I 
encountered a problem when I updated my graphics driver[1]. Currently I’ve 
Nvidia 860M Graphics driver in my Lenovo Y50-70 laptop. I tried [2] and even 
tried updating and upgrading the whole system by logging in through tty1 using 
' sudo apt-get update/upgrade'  using the LAN cable but then it didn’t work. 
The screen says blank for a long time and after that I've to forcefully turn it 
off. I then tried the following commands in tty1- 
rm -r ~/.kde
rm -r ~/.cache
rm -r ~/.config/plasmarc and then 
kbuildsycoca5

Then I tried editing the boot up option as in one of the links which was 
editing the ‘/etc/default/grub’ file and changed the 
GRUB_CMDLINE_LINUX_DEFAULT=“quiet splash nomodeset” and then saved the file and 
the ran ’sudo update-grub’ but still it turned out to be unsuccessful.  

So the next option which I found was reinstalling the whole version but then 
it’d cost me a lot since I’m working on it. 


[1] https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1432171 

[2] http://ubuntuforums.org/showthread.php?t=2275603 


With Regards,
Gokul Krishna P
Blog  | LinkedIn 
 | Github 


"Simplicity, carried to the extreme, become elegance."___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-23 Thread David Edmundson



> On Nov. 23, 2015, 7:13 a.m., Martin Gräßlin wrote:
> > are you sure it means that? I mean I did read the documentation when 
> > writing that code and did deliberately wrote the code like that. So I'm a 
> > little bit surprised that I got it exactly the other way around.

How do you interpret:
"The texture object owns the texture id and will delete the GL texture when the 
texture object is deleted." ?


Docs aside, relevant Qt code is:

QSGTexture *QSGEngine::createTextureFromId(uint id, const QSize , 
CreateTextureOptions options) const
{
Q_D(const QSGEngine);
if (d->sgRenderContext->isValid()) {
QSGPlainTexture *texture = new QSGPlainTexture();
texture->setTextureId(id);
texture->setHasAlphaChannel(options & TextureHasAlphaChannel);
texture->setOwnsTexture(options & TextureOwnsGLTexture);
texture->setTextureSize(size);
return texture;
}
return 0;
}


QSGPlainTexture::~QSGPlainTexture()
if (m_texture_id && m_owns_texture && QOpenGLContext::currentContext())
QOpenGLContext::currentContext()->functions()->glDeleteTextures(1, 
_texture_id);


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/#review88703
---


On Nov. 22, 2015, 1:57 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126131/
> ---
> 
> (Updated Nov. 22, 2015, 1:57 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> The QSGTextures are created with
> 
> window()->createTextureFromId(m_texture, QSize(w,h),
> QuickWindow::TextureOwnsGLTexture));
> 
> this means we don't want to be deleting textures ourselves too, it will
> be deleted when we delete the QSGTexture, which is a scoped pointer
> inside our QSGNode.
> 
> BUG: 355644
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 2b09657e8ce6bd1cca1acc323d5955b2f1a1efb2 
> 
> Diff: https://git.reviewboard.kde.org/r/126131/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Shantanu Tushar


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88715
---


Do the tests not work anymore? Just curious why were they removed.


libs/mediacenter/lastfmimagefetcher.cpp (line 155)


remove the extra whitespace


- Shantanu Tushar


On Nov. 22, 2015, 2:23 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 22, 2015, 2:23 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList. Created a QList for storing the new media.
> 
> After the image is fetched, gotImage emits the signal imageFetched (from 
> mediaLibrary) with the QList we created earlier. This signal is absorbed by 
> handleNewMedia in PmcMetaDataModel which does the rest.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/medialibrary.h 45744c1 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Builds 100%.
> However the audio scrobbler api doesn't seem to work which I'll fix after 
> this. 
> Also, I get the following Output : http://ix.io/mps
> Apart from it, all the datasources are loaded and media plays as expected.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Minutes Monday Plasma Hangout

2015-11-23 Thread Sebastian Kügler

Present: bshah, jensreu, kbroulik, notmart, mgraesslin, obogdan, sebas
Date: November 23rd, 2015

bshah:
- we have required qt5.5 packages for mobile
- maybe we are hitting : https://bugreports.qt.io/browse/QTBUG-46831
- needs further debugging and fixing
- I plan to build next IMG once this issue is fixed

jensreu:
- working on promo video for apps
- doing obscure print stuff
- sorting some social issues

kbroulik:
- runtime-breakage of themes: should we renew the theme cache when the Plasma 
theme changes
- user switcher is broken, updateing plasma-workspace should fix it
- discussed in-app feature demo with Thomas Pfeiffer
- app-specific channels in plasma-pa would be nice to merge
- would be nice if pulseaudio did the right thing (use newly plugged device by 
default)


notmart:
- unhappy about unreviewed theme changes going into plasma-framework, caused 
breakage again
- interesting bugreport: there was a ton of eventFilters in plasmashell, 
should be fixed now, makes a huge performance difference in some cases (in 
plasma-framework, so will be in next release)
- ironing out theme switching bug
- some fixes in the lineedit component (used on phone)
- mobile controls branch: further cleaning up ( https://phabricator.kde.org/
D409 )

mgraesslin:
- latest intel driver in debian unstable works well again
- fixed some crashers in kwin_wayland (no known crashers now)
- worked a bit on screenlocker/wayland: multi-screen rendering is broken atm
- working on nested kwin_wayland to make debugging multiscreen easier
- plasma startup on wayland is leaky, injection through env vars is possible 
-- working on it with ximion
- notes on startup: https://notes.kde.org/p/ksmserver
- blogpost about session security: http://blog.martin-graesslin.com/blog/
2015/11/looking-at-the-security-of-plasmawayland/

obogdan:
- working on translations

sebas:
- libkscreen in-process stuff ready to merge -- almostish (see: https://
git.reviewboard.kde.org/r/126101/ and http://vizzzion.org/blog/2015/11/
wayland-and-libkscreen-benchmarks/ )
- few adaptions to wayland backend, but already in pretty good shape
- do we want to propose our stuff to http://lists.freedesktop.org/archives/
wayland-devel/2015-November/025486.html ?



-- 
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126143: [ksmserver] Fall back to session runner if UserSwitcher.qml is broken

2015-11-23 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126143/
---

Review request for Plasma and Martin Gräßlin.


Repository: plasma-workspace


Description
---

In case the UserSwitcher.qml file is missing or broken, let's fall back to use 
KRunner's session runner.


Diffs
-

  ksmserver/server.cpp 9477e54 
  ksmserver/switchuserdialog.cpp 26d6710 

Diff: https://git.reviewboard.kde.org/r/126143/diff/


Testing
---

Broke my UserSwitcher.qml file, got KRunner instead.
Fixed it, got the proper QML UI again.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=354250

Kai Uwe Broulik  changed:

   What|Removed |Added

Product|plasmashell |Powerdevil
   Target Milestone|1.0 |---
 CC||k...@privat.broulik.de
 Status|UNCONFIRMED |CONFIRMED
  Component|general |general
 Ever confirmed|0   |1
   Assignee|k...@davidedmundson.co.uk|plasma-devel@kde.org

--- Comment #5 from Kai Uwe Broulik  ---
Seen that too. Looks like PowerDevil resumes and notices the session has, of
course, been idle for quite a while and sends it to sleep.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Aditya Dev Sharma


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/
---

(Updated Nov. 23, 2015, 1:50 p.m.)


Review request for Plasma, Ashish Bansal and Bhushan Shah.


Repository: plasma-mediacenter


Description
---

Implemented it like the other datasources.

Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
handleLastFmNewMedia then calls fetchImage for each newMedia in the 
newMediaList. Created a QList for storing the new media.

After the image is fetched, gotImage emits the signal imageFetched (from 
mediaLibrary) with the QList we created earlier. This signal is absorbed by 
handleNewMedia in PmcMetaDataModel which does the rest.


Diffs (updated)
-

  autotests/CMakeLists.txt 04ba1c3 
  autotests/lastfmimagefetchertest.h eb7cb29 
  autotests/lastfmimagefetchertest.cpp abb3fd6 
  datasources/CMakeLists.txt a7171b7 
  datasources/lastfm/CMakeLists.txt PRE-CREATION 
  datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
  libs/mediacenter/CMakeLists.txt 5a13449 
  libs/mediacenter/lastfmimagefetcher.h ecff37e 
  libs/mediacenter/lastfmimagefetcher.cpp e005077 
  libs/mediacenter/medialibrary.h 45744c1 
  libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 

Diff: https://git.reviewboard.kde.org/r/125993/diff/


Testing
---

Builds 100%.
However the audio scrobbler api doesn't seem to work which I'll fix after this. 
Also, I get the following Output : http://ix.io/mps
Apart from it, all the datasources are loaded and media plays as expected.


Thanks,

Aditya Dev Sharma

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-23 Thread Martin Gräßlin



> On Nov. 23, 2015, 8:13 a.m., Martin Gräßlin wrote:
> > are you sure it means that? I mean I did read the documentation when 
> > writing that code and did deliberately wrote the code like that. So I'm a 
> > little bit surprised that I got it exactly the other way around.
> 
> David Edmundson wrote:
> How do you interpret:
> "The texture object owns the texture id and will delete the GL texture 
> when the texture object is deleted." ?
> 
> 
> Docs aside, relevant Qt code is:
> 
> QSGTexture *QSGEngine::createTextureFromId(uint id, const QSize , 
> CreateTextureOptions options) const
> {
> Q_D(const QSGEngine);
> if (d->sgRenderContext->isValid()) {
> QSGPlainTexture *texture = new QSGPlainTexture();
> texture->setTextureId(id);
> texture->setHasAlphaChannel(options & TextureHasAlphaChannel);
> texture->setOwnsTexture(options & TextureOwnsGLTexture);
> texture->setTextureSize(size);
> return texture;
> }
> return 0;
> }
> 
> 
> QSGPlainTexture::~QSGPlainTexture()
> if (m_texture_id && m_owns_texture && 
> QOpenGLContext::currentContext())
> 
> QOpenGLContext::currentContext()->functions()->glDeleteTextures(1, 
> _texture_id);

given the code in plasma-framework, I'm quite certain that I didn't want Qt to 
take over ownership of it. So I think we should turn it around and make our 
code do what was intended. I just checked and we do proper cleanup handling. 
discardPixmap is called from the dtor, so if we do cleanup, why should Qt?


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/#review88703
---


On Nov. 22, 2015, 2:57 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126131/
> ---
> 
> (Updated Nov. 22, 2015, 2:57 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> The QSGTextures are created with
> 
> window()->createTextureFromId(m_texture, QSize(w,h),
> QuickWindow::TextureOwnsGLTexture));
> 
> this means we don't want to be deleting textures ourselves too, it will
> be deleted when we delete the QSGTexture, which is a scoped pointer
> inside our QSGNode.
> 
> BUG: 355644
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 2b09657e8ce6bd1cca1acc323d5955b2f1a1efb2 
> 
> Diff: https://git.reviewboard.kde.org/r/126131/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

2015-11-23 Thread David Edmundson



> On Nov. 23, 2015, 7:13 a.m., Martin Gräßlin wrote:
> > are you sure it means that? I mean I did read the documentation when 
> > writing that code and did deliberately wrote the code like that. So I'm a 
> > little bit surprised that I got it exactly the other way around.
> 
> David Edmundson wrote:
> How do you interpret:
> "The texture object owns the texture id and will delete the GL texture 
> when the texture object is deleted." ?
> 
> 
> Docs aside, relevant Qt code is:
> 
> QSGTexture *QSGEngine::createTextureFromId(uint id, const QSize , 
> CreateTextureOptions options) const
> {
> Q_D(const QSGEngine);
> if (d->sgRenderContext->isValid()) {
> QSGPlainTexture *texture = new QSGPlainTexture();
> texture->setTextureId(id);
> texture->setHasAlphaChannel(options & TextureHasAlphaChannel);
> texture->setOwnsTexture(options & TextureOwnsGLTexture);
> texture->setTextureSize(size);
> return texture;
> }
> return 0;
> }
> 
> 
> QSGPlainTexture::~QSGPlainTexture()
> if (m_texture_id && m_owns_texture && 
> QOpenGLContext::currentContext())
> 
> QOpenGLContext::currentContext()->functions()->glDeleteTextures(1, 
> _texture_id);
> 
> Martin Gräßlin wrote:
> given the code in plasma-framework, I'm quite certain that I didn't want 
> Qt to take over ownership of it. So I think we should turn it around and make 
> our code do what was intended. I just checked and we do proper cleanup 
> handling. discardPixmap is called from the dtor, so if we do cleanup, why 
> should Qt?

>why should Qt?

Because you told it to :P


but sure, that works too. Will make new RR.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126131/#review88703
---


On Nov. 22, 2015, 1:57 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126131/
> ---
> 
> (Updated Nov. 22, 2015, 1:57 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> The QSGTextures are created with
> 
> window()->createTextureFromId(m_texture, QSize(w,h),
> QuickWindow::TextureOwnsGLTexture));
> 
> this means we don't want to be deleting textures ourselves too, it will
> be deleted when we delete the QSGTexture, which is a scoped pointer
> inside our QSGNode.
> 
> BUG: 355644
> REVIEW:
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/core/windowthumbnail.cpp 
> 2b09657e8ce6bd1cca1acc323d5955b2f1a1efb2 
> 
> Diff: https://git.reviewboard.kde.org/r/126131/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355687] Powerdevil does not act (e.g. suspend, dim) when switching to battery mode

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355687

Kai Uwe Broulik  changed:

   What|Removed |Added

   Version Fixed In||5.5.0
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/powe
   ||rdevil/6b4ffe32367a6413d8c2
   ||70480445a4955d63e71f
 Status|CONFIRMED   |RESOLVED

--- Comment #13 from Kai Uwe Broulik  ---
Git commit 6b4ffe32367a6413d8c270480445a4955d63e71f by Kai Uwe Broulik.
Committed on 23/11/2015 at 14:02.
Pushed by broulik into branch 'Plasma/5.5'.

Use absolute brightness value in conservative check when loading profile

There's a check that ensures the brightness isn't ramped up when we switch
to a more conservative profile and then current brightness is lower.
However, it compared the raw hardware value with the config percentage value.
FIXED-IN: 5.5.0
REVIEW: 126138

M  +7-6daemon/actions/bundled/brightnesscontrol.cpp
M  +6-6daemon/actions/bundled/keyboardbrightnesscontrol.cpp

http://commits.kde.org/powerdevil/6b4ffe32367a6413d8c270480445a4955d63e71f

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 354250] "Switch User" sometimes sends computer to Standby

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=354250

Kai Uwe Broulik  changed:

   What|Removed |Added

   Version Fixed In||5.5.0
  Latest Commit||http://commits.kde.org/powe
   ||rdevil/3c41d4c3eca34c54e0d6
   ||a2b8196f9d8e3dd8dc03
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Kai Uwe Broulik  ---
Git commit 3c41d4c3eca34c54e0d6a2b8196f9d8e3dd8dc03 by Kai Uwe Broulik.
Committed on 23/11/2015 at 14:10.
Pushed by broulik into branch 'Plasma/5.5'.

Simulate user activity when session becomes active

Sessions usually don't switch themselves. This fixes the computer suspending
after
switching to a session that has been idle for a while.
FIXED-IN: 5.5.0

M  +5-0daemon/powerdevilpolicyagent.cpp

http://commits.kde.org/powerdevil/3c41d4c3eca34c54e0d6a2b8196f9d8e3dd8dc03

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Kai Uwe Broulik



> On Nov. 23, 2015, 10:04 nachm., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.
> 
> Eike Hein wrote:
> This will still make it hard for users to access config UI they might 
> have come to rely on (shortcuts) so it's a regression vs. the last stable 
> release. This needs to be addressed somehow, reverting to Plasma 4 behavior 
> is a bit of a stretch IMHO.

Alternatively we could keep the (empty) settings dialog as is and add another 
context menu option for the icon settings, like we do with a couple of applets 
that can spawn a KCM.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/
---

(Updated Nov. 23, 2015, 10:19 p.m.)


Review request for Plasma, Marco Martin and Martin Klapetek.


Changes
---

removed QStringLiteral use for LoadPackage calls becaus they may store the 
string argument in the static variable


Repository: plasma-framework


Description
---

also contains fix for clazy warning regarding iterating over temporary 
roleNames() object

note that for QRegExp constructor and for QIcon::fromTheme() i used 
QLatin1String because QStringLiteral is known to produce crashes-on-exit if the 
code is inside a library


Diffs (updated)
-

  CMakeLists.txt 812dc96 
  src/declarativeimports/core/datamodel.cpp 1c83bc5 
  src/declarativeimports/core/framesvgitem.cpp 9aab228 
  src/declarativeimports/core/iconitem.cpp f32b3d1 
  src/plasma/applet.cpp 89c 
  src/plasma/containment.cpp 1d166f2 
  src/plasma/framesvg.cpp f9379b0 
  src/plasma/pluginloader.cpp bfa5dee 
  src/plasma/private/applet_p.cpp e935d52 
  src/plasma/private/containment_p.cpp 3836772 
  src/plasma/private/theme_p.cpp 7bf81d4 
  src/plasma/scripting/scriptengine.cpp 5b2cf84 
  src/plasma/svg.cpp 20cb31f 
  src/plasma/theme.cpp c49ad4c 
  src/plasmaquick/appletquickitem.cpp efe8611 
  src/plasmaquick/shellpluginloader.cpp 2824760 

Diff: https://git.reviewboard.kde.org/r/126148/diff/


Testing
---

compiles fine


Thanks,

Nick Shaforostoff

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff



> On Nov. 23, 2015, 9:02 p.m., Aleix Pol Gonzalez wrote:
> > CMakeLists.txt, line 122
> > 
> >
> > Why do you drop FAST_CONCATENATION?

ack QT_USE_FAST_CONCATENATION /usr/include/ brings nothing
ack QT_USE_QSTRINGBUILDER /usr/include/ brings real results


On Nov. 23, 2015, 9:02 p.m., Nick Shaforostoff wrote:
> > Regarding QStringLiteral vs QLatin1String for libraries: I read that 
> > thread, but then most of QStringLiterals here sould be dropped as well if 
> > that was the case. I don't think it makes sense to make a special case of 
> > QIcon::fromTheme.

all qstringliteral uses except loadpackage() do not store strings in the static 
containers, i believe. for loadpackage calls i have removed qstringliterals in 
favour of qlatin1string


- Nick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/#review88735
---


On Nov. 23, 2015, 10:19 p.m., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126148/
> ---
> 
> (Updated Nov. 23, 2015, 10:19 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> also contains fix for clazy warning regarding iterating over temporary 
> roleNames() object
> 
> note that for QRegExp constructor and for QIcon::fromTheme() i used 
> QLatin1String because QStringLiteral is known to produce crashes-on-exit if 
> the code is inside a library
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 812dc96 
>   src/declarativeimports/core/datamodel.cpp 1c83bc5 
>   src/declarativeimports/core/framesvgitem.cpp 9aab228 
>   src/declarativeimports/core/iconitem.cpp f32b3d1 
>   src/plasma/applet.cpp 89c 
>   src/plasma/containment.cpp 1d166f2 
>   src/plasma/framesvg.cpp f9379b0 
>   src/plasma/pluginloader.cpp bfa5dee 
>   src/plasma/private/applet_p.cpp e935d52 
>   src/plasma/private/containment_p.cpp 3836772 
>   src/plasma/private/theme_p.cpp 7bf81d4 
>   src/plasma/scripting/scriptengine.cpp 5b2cf84 
>   src/plasma/svg.cpp 20cb31f 
>   src/plasma/theme.cpp c49ad4c 
>   src/plasmaquick/appletquickitem.cpp efe8611 
>   src/plasmaquick/shellpluginloader.cpp 2824760 
> 
> Diff: https://git.reviewboard.kde.org/r/126148/diff/
> 
> 
> Testing
> ---
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-23 Thread Thomas Pfeiffer


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126151/#review88745
---


The interaction seems fine, but since it's a user setting, there should not be 
any polkit request. This would confuse users because they don't expect to need 
admin rights to change their own profile picture.

- Thomas Pfeiffer


On Nov. 23, 2015, 9:50 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126151/
> ---
> 
> (Updated Nov. 23, 2015, 9:50 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Jonathan Riddell.
> 
> 
> Bugs: 354001
> http://bugs.kde.org/show_bug.cgi?id=354001
> 
> 
> Repository: user-manager
> 
> 
> Description
> ---
> 
> Including the avatars, that are no longer installed into /usr/share/kdm/icons 
> but /usr/share/user-manager/avatars. I don't know if there's a FDO location 
> for these.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 7267d24 
>   src/accountinfo.h c6e70b3 
>   src/accountinfo.cpp 878f683 
>   src/avatargallery.h PRE-CREATION 
>   src/avatargallery.cpp PRE-CREATION 
>   src/avatargallery.ui PRE-CREATION 
>   src/pics/Ada Lovelace.png PRE-CREATION 
>   src/pics/Alice in Wonderland.png PRE-CREATION 
>   src/pics/Blackbox.png PRE-CREATION 
>   src/pics/CMakeLists.txt PRE-CREATION 
>   src/pics/Dragon.png PRE-CREATION 
>   src/pics/Grace Hopper.png PRE-CREATION 
>   src/pics/Green.png PRE-CREATION 
>   src/pics/Happy.png PRE-CREATION 
>   src/pics/Kati.png PRE-CREATION 
>   src/pics/Konqui.png PRE-CREATION 
>   src/pics/Leonardo da Vinci.png PRE-CREATION 
>   src/pics/Listening.png PRE-CREATION 
>   src/pics/Logger.png PRE-CREATION 
>   src/pics/Mahatma Gandhi.png PRE-CREATION 
>   src/pics/Mowgli jungle book.png PRE-CREATION 
>   src/pics/Notme.png PRE-CREATION 
>   src/pics/Parley.png PRE-CREATION 
>   src/pics/Rekonqui.png PRE-CREATION 
>   src/pics/TV.png PRE-CREATION 
>   src/pics/User.png PRE-CREATION 
>   src/pics/bomb.png PRE-CREATION 
>   src/pics/sources/Ada Lovelace.svg PRE-CREATION 
>   src/pics/sources/Alice in Wonderland.svg PRE-CREATION 
>   src/pics/sources/Dragon.svg PRE-CREATION 
>   src/pics/sources/Grace Hopper.svg PRE-CREATION 
>   src/pics/sources/Kati.svg PRE-CREATION 
>   src/pics/sources/Konqui.svg PRE-CREATION 
>   src/pics/sources/Leonardo da Vinci.svg PRE-CREATION 
>   src/pics/sources/Logger.svg PRE-CREATION 
>   src/pics/sources/Mahatma Gandhi.svg PRE-CREATION 
>   src/pics/sources/Mowgli jungle book.svg PRE-CREATION 
>   src/pics/sources/Parley.svg PRE-CREATION 
>   src/pics/sources/Rekonqui.svg PRE-CREATION 
>   src/pics/sources/User.svg PRE-CREATION 
>   src/pics/sources/blackbox.svgz PRE-CREATION 
>   src/pics/sources/bomb.svgz PRE-CREATION 
>   src/pics/sources/green.svgz PRE-CREATION 
>   src/pics/sources/happy.svgz PRE-CREATION 
>   src/pics/sources/listening.svgz PRE-CREATION 
>   src/pics/sources/notme.svgz PRE-CREATION 
>   src/pics/sources/tv.svgz PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126151/diff/
> 
> 
> Testing
> ---
> 
> Opened user manager, clicked my icon, clicked "Choose from Gallery", chose an 
> icon, OK. It prompted me three times for Polkit authentication for some 
> reason but in the end it worked, Kickoff also immediately updated its icon.
> 
> 
> File Attachments
> 
> 
> New menu option
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/d91c818f-5051-4857-beb2-b2727614f187__usermanageravatar.png
> Avatar gallery
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/2f16fa25-5eac-4e6a-b24d-7d47ff560ce4__usermanageravatar2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Eike Hein


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


The problem with this is that the old applet had the properties widget embedded 
as a page into the applet config dialog. This probably replaces the latter, 
killing the keyboard shortcut page and making it not possible to configure a 
hotkey anymore ...?

- Eike Hein


On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Eike Hein



> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.

This will still make it hard for users to access config UI they might have come 
to rely on (shortcuts) so it's a regression vs. the last stable release. This 
needs to be addressed somehow, reverting to Plasma 4 behavior is a bit of a 
stretch IMHO.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/#review88737
---



src/declarativeimports/core/datamodel.cpp (line 58)


Why not constBegin()/constEnd()?



src/declarativeimports/core/iconitem.cpp (line 125)


QLatin1Char?



src/plasmaquick/shellpluginloader.cpp (line 41)


we usually don't have more than one statement per line


- Kai Uwe Broulik


On Nov. 23, 2015, 8:36 nachm., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126148/
> ---
> 
> (Updated Nov. 23, 2015, 8:36 nachm.)
> 
> 
> Review request for Plasma, Marco Martin and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> also contains fix for clazy warning regarding iterating over temporary 
> roleNames() object
> 
> note that for QRegExp constructor and for QIcon::fromTheme() i used 
> QLatin1String because QStringLiteral is known to produce crashes-on-exit if 
> the code is inside a library
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 812dc96 
>   src/declarativeimports/core/datamodel.cpp 1c83bc5 
>   src/declarativeimports/core/framesvgitem.cpp 9aab228 
>   src/declarativeimports/core/iconitem.cpp f32b3d1 
>   src/plasma/applet.cpp 89c 
>   src/plasma/containment.cpp 1d166f2 
>   src/plasma/framesvg.cpp f9379b0 
>   src/plasma/pluginloader.cpp bfa5dee 
>   src/plasma/private/applet_p.cpp e935d52 
>   src/plasma/private/containment_p.cpp 3836772 
>   src/plasma/private/theme_p.cpp 7bf81d4 
>   src/plasma/scripting/scriptengine.cpp 5b2cf84 
>   src/plasma/svg.cpp 20cb31f 
>   src/plasma/theme.cpp c49ad4c 
>   src/plasmaquick/appletquickitem.cpp efe8611 
>   src/plasmaquick/shellpluginloader.cpp 2824760 
> 
> Diff: https://git.reviewboard.kde.org/r/126148/diff/
> 
> 
> Testing
> ---
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Kai Uwe Broulik



> On Nov. 23, 2015, 10:04 nachm., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?

The old applet also just opened the KPropertiesDialog.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff



> On Nov. 23, 2015, 9:53 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/core/datamodel.cpp, line 58
> > 
> >
> > Why not constBegin()/constEnd()?

because rNames is const, constBegin()/constEnd() will be called internaly 
anyways, and begin()/end() just look nicer


> On Nov. 23, 2015, 9:53 p.m., Kai Uwe Broulik wrote:
> > src/declarativeimports/core/iconitem.cpp, line 125
> > 
> >
> > QLatin1Char?

yep, i will add that in the commit or the next diff version


> On Nov. 23, 2015, 9:53 p.m., Kai Uwe Broulik wrote:
> > src/plasmaquick/shellpluginloader.cpp, line 41
> > 
> >
> > we usually don't have more than one statement per line

ok, i will remove that change


- Nick


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/#review88737
---


On Nov. 23, 2015, 10:19 p.m., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126148/
> ---
> 
> (Updated Nov. 23, 2015, 10:19 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> also contains fix for clazy warning regarding iterating over temporary 
> roleNames() object
> 
> note that for QRegExp constructor and for QIcon::fromTheme() i used 
> QLatin1String because QStringLiteral is known to produce crashes-on-exit if 
> the code is inside a library
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 812dc96 
>   src/declarativeimports/core/datamodel.cpp 1c83bc5 
>   src/declarativeimports/core/framesvgitem.cpp 9aab228 
>   src/declarativeimports/core/iconitem.cpp f32b3d1 
>   src/plasma/applet.cpp 89c 
>   src/plasma/containment.cpp 1d166f2 
>   src/plasma/framesvg.cpp f9379b0 
>   src/plasma/pluginloader.cpp bfa5dee 
>   src/plasma/private/applet_p.cpp e935d52 
>   src/plasma/private/containment_p.cpp 3836772 
>   src/plasma/private/theme_p.cpp 7bf81d4 
>   src/plasma/scripting/scriptengine.cpp 5b2cf84 
>   src/plasma/svg.cpp 20cb31f 
>   src/plasma/theme.cpp c49ad4c 
>   src/plasmaquick/appletquickitem.cpp efe8611 
>   src/plasmaquick/shellpluginloader.cpp 2824760 
> 
> Diff: https://git.reviewboard.kde.org/r/126148/diff/
> 
> 
> Testing
> ---
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355804] Fresh boot to sddm and a few minutes of inactivity sends computer to Standby

2015-11-23 Thread Martin Gräßlin via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355804

Martin Gräßlin  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |UPSTREAM

--- Comment #1 from Martin Gräßlin  ---
If you really think that this is a bug you need to report it to sddm:
https://github.com/sddm/sddm/issues

Personally I think this is expected behavior and not a bug. Anyway marking as
resolved upstream as this belongs to sddm.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-23 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126151/#review88746
---



File Attachment: Avatar gallery - usermanageravatar2.png


Why is this not a grid? O.=


- Aleix Pol Gonzalez


On Nov. 23, 2015, 10:50 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126151/
> ---
> 
> (Updated Nov. 23, 2015, 10:50 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Jonathan Riddell.
> 
> 
> Bugs: 354001
> http://bugs.kde.org/show_bug.cgi?id=354001
> 
> 
> Repository: user-manager
> 
> 
> Description
> ---
> 
> Including the avatars, that are no longer installed into /usr/share/kdm/icons 
> but /usr/share/user-manager/avatars. I don't know if there's a FDO location 
> for these.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 7267d24 
>   src/accountinfo.h c6e70b3 
>   src/accountinfo.cpp 878f683 
>   src/avatargallery.h PRE-CREATION 
>   src/avatargallery.cpp PRE-CREATION 
>   src/avatargallery.ui PRE-CREATION 
>   src/pics/Ada Lovelace.png PRE-CREATION 
>   src/pics/Alice in Wonderland.png PRE-CREATION 
>   src/pics/Blackbox.png PRE-CREATION 
>   src/pics/CMakeLists.txt PRE-CREATION 
>   src/pics/Dragon.png PRE-CREATION 
>   src/pics/Grace Hopper.png PRE-CREATION 
>   src/pics/Green.png PRE-CREATION 
>   src/pics/Happy.png PRE-CREATION 
>   src/pics/Kati.png PRE-CREATION 
>   src/pics/Konqui.png PRE-CREATION 
>   src/pics/Leonardo da Vinci.png PRE-CREATION 
>   src/pics/Listening.png PRE-CREATION 
>   src/pics/Logger.png PRE-CREATION 
>   src/pics/Mahatma Gandhi.png PRE-CREATION 
>   src/pics/Mowgli jungle book.png PRE-CREATION 
>   src/pics/Notme.png PRE-CREATION 
>   src/pics/Parley.png PRE-CREATION 
>   src/pics/Rekonqui.png PRE-CREATION 
>   src/pics/TV.png PRE-CREATION 
>   src/pics/User.png PRE-CREATION 
>   src/pics/bomb.png PRE-CREATION 
>   src/pics/sources/Ada Lovelace.svg PRE-CREATION 
>   src/pics/sources/Alice in Wonderland.svg PRE-CREATION 
>   src/pics/sources/Dragon.svg PRE-CREATION 
>   src/pics/sources/Grace Hopper.svg PRE-CREATION 
>   src/pics/sources/Kati.svg PRE-CREATION 
>   src/pics/sources/Konqui.svg PRE-CREATION 
>   src/pics/sources/Leonardo da Vinci.svg PRE-CREATION 
>   src/pics/sources/Logger.svg PRE-CREATION 
>   src/pics/sources/Mahatma Gandhi.svg PRE-CREATION 
>   src/pics/sources/Mowgli jungle book.svg PRE-CREATION 
>   src/pics/sources/Parley.svg PRE-CREATION 
>   src/pics/sources/Rekonqui.svg PRE-CREATION 
>   src/pics/sources/User.svg PRE-CREATION 
>   src/pics/sources/blackbox.svgz PRE-CREATION 
>   src/pics/sources/bomb.svgz PRE-CREATION 
>   src/pics/sources/green.svgz PRE-CREATION 
>   src/pics/sources/happy.svgz PRE-CREATION 
>   src/pics/sources/listening.svgz PRE-CREATION 
>   src/pics/sources/notme.svgz PRE-CREATION 
>   src/pics/sources/tv.svgz PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126151/diff/
> 
> 
> Testing
> ---
> 
> Opened user manager, clicked my icon, clicked "Choose from Gallery", chose an 
> icon, OK. It prompted me three times for Polkit authentication for some 
> reason but in the end it worked, Kickoff also immediately updated its icon.
> 
> 
> File Attachments
> 
> 
> New menu option
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/d91c818f-5051-4857-beb2-b2727614f187__usermanageravatar.png
> Avatar gallery
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/2f16fa25-5eac-4e6a-b24d-7d47ff560ce4__usermanageravatar2.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126101: allow loading backends in-process

2015-11-23 Thread Sebastian Kügler



> On Nov. 20, 2015, 10:14 a.m., Daniel Vrátil wrote:
> > src/backendmanager.cpp, line 361
> > 
> >
> > Instead of deleting the AbstractBackend manually here, you could let 
> > QPluginLoader do it by `mLoader->unload()`, then delete mLoader normally 
> > (not via deleteLater()). As a bonus it will unload the plugin binary from 
> > the process (just deleting QPluginLoader does not).

We can't do that actually, since it would mean a behavioural change from the 
out-of-process version. Shutting down the backend would effect the configs we 
handed out to become invalid, so we don't want to do this. (We also don't do 
this in the out-of-process version, but instead keep configs valid on the 
client side after shutting down the backen.)

I've changed the pluginloader to be deleted right away, however, not via 
deleteLater().


- Sebastian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126101/#review88635
---


On Nov. 20, 2015, 12:16 a.m., Sebastian Kügler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126101/
> ---
> 
> (Updated Nov. 20, 2015, 12:16 a.m.)
> 
> 
> Review request for Plasma, Solid, Àlex Fiestas, Aleix Pol Gonzalez, Daniel 
> Vrátil, and Martin Gräßlin.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> ---
> 
> This patchset adds in-process operation to libkscreen
> 
> purpose:
> - allow easier debugging
> - for some backends (qscreen, upcoming kwayland) the out of process operation 
> is not necessary since these backends are well-shielded
> 
> This implementation is backwards compatible and opt-in for running setups.
> 
> If the user exports KSCREEN_BACKEND_INPROCESS=1 before running, all 
> operations will be done in process. Otherwise, the out-of-process mode is 
> used.
> 
> Changes revolve around the ConfigOperations, the BackendManager (which 
> "factories" the backends, either in- or out-of-process), and the plugin 
> loading logic
> 
> Autotests should cover all the cases (and actually a few currently 
> unsupported ones, such as using different backends in the same process).
> 
> Details on performance, etc.: 
> http://vizzzion.org/blog/2015/11/wayland-and-libkscreen-benchmarks/
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 86a0965 
>   autotests/CMakeLists.txt 69af7f0 
>   autotests/testconfigmonitor.cpp a051226 
>   autotests/testinprocess.cpp PRE-CREATION 
>   autotests/testqscreenbackend.cpp da4dbae 
>   autotests/testscreenconfig.cpp ecbcedf 
>   autotests/testxrandr.cpp b9b838a 
>   backends/fake/fake.cpp 60264dd 
>   src/backendlauncher/backendloader.cpp 52051df 
>   src/backendmanager.cpp ca9c746 
>   src/backendmanager_p.h c6418e2 
>   src/config.cpp 75d947d 
>   src/configmonitor.h b6f1189 
>   src/configmonitor.cpp a14bc70 
>   src/configoperation.h 2405d79 
>   src/configoperation.cpp 87fe141 
>   src/configoperation_p.h afdc462 
>   src/getconfigoperation.h c85bfaa 
>   src/getconfigoperation.cpp 22f92b4 
>   src/output.cpp bd381fa 
>   src/setconfigoperation.h 020a990 
>   src/setconfigoperation.cpp 6ea944f 
> 
> Diff: https://git.reviewboard.kde.org/r/126101/diff/
> 
> 
> Testing
> ---
> 
> Added a ton of autotests, made sure all existing ones pass.
> 
> tried "KSCREEN_BACKEND_INPROCESS=1 kcmshell5 kscreen", all working as 
> expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126101: allow loading backends in-process

2015-11-23 Thread Sebastian Kügler


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126101/
---

(Updated Nov. 24, 2015, 3:04 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Solid, Àlex Fiestas, Aleix Pol Gonzalez, Daniel 
Vrátil, and Martin Gräßlin.


Changes
---

Submitted with commit 3382bba2b403f82f3e21e4a89a6631781e5950fe by Sebastian 
Kügler to branch master.


Repository: libkscreen


Description
---

This patchset adds in-process operation to libkscreen

purpose:
- allow easier debugging
- for some backends (qscreen, upcoming kwayland) the out of process operation 
is not necessary since these backends are well-shielded

This implementation is backwards compatible and opt-in for running setups.

If the user exports KSCREEN_BACKEND_INPROCESS=1 before running, all operations 
will be done in process. Otherwise, the out-of-process mode is used.

Changes revolve around the ConfigOperations, the BackendManager (which 
"factories" the backends, either in- or out-of-process), and the plugin loading 
logic

Autotests should cover all the cases (and actually a few currently unsupported 
ones, such as using different backends in the same process).

Details on performance, etc.: 
http://vizzzion.org/blog/2015/11/wayland-and-libkscreen-benchmarks/


Diffs
-

  CMakeLists.txt 86a0965 
  autotests/CMakeLists.txt 69af7f0 
  autotests/testconfigmonitor.cpp a051226 
  autotests/testinprocess.cpp PRE-CREATION 
  autotests/testqscreenbackend.cpp da4dbae 
  autotests/testscreenconfig.cpp ecbcedf 
  autotests/testxrandr.cpp b9b838a 
  backends/fake/fake.cpp 60264dd 
  src/backendlauncher/backendloader.cpp 52051df 
  src/backendmanager.cpp ca9c746 
  src/backendmanager_p.h c6418e2 
  src/config.cpp 75d947d 
  src/configmonitor.h b6f1189 
  src/configmonitor.cpp a14bc70 
  src/configoperation.h 2405d79 
  src/configoperation.cpp 87fe141 
  src/configoperation_p.h afdc462 
  src/getconfigoperation.h c85bfaa 
  src/getconfigoperation.cpp 22f92b4 
  src/output.cpp bd381fa 
  src/setconfigoperation.h 020a990 
  src/setconfigoperation.cpp 6ea944f 

Diff: https://git.reviewboard.kde.org/r/126101/diff/


Testing
---

Added a ton of autotests, made sure all existing ones pass.

tried "KSCREEN_BACKEND_INPROCESS=1 kcmshell5 kscreen", all working as expected.


Thanks,

Sebastian Kügler

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 353356] Powerdevil does not respect the critical level configuration

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=353356

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
 Status|UNCONFIRMED |NEEDSINFO
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Kai Uwe Broulik  ---
Can you check what is configured in System Settings → Power Management → At
critical battery

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 352235] Screens return from DPMS Suspend Mode to Normal Mode When Receiving Google Hangouts Messages

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=352235

--- Comment #2 from Kai Uwe Broulik  ---
Please give a try to https://git.reviewboard.kde.org/r/126145/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 353538] screen switches off when playing video in VLC or even when screen blanking is switched off

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=353538

Kai Uwe Broulik  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||k...@privat.broulik.de
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Kai Uwe Broulik  ---
Could it be that some driver or low level service is turning off the screen? 

Can you run qdbus --system --literal org.freedesktop.login1
/org/freedesktop/login1 org.freedesktop.login1.Manager.ListInhibitors and see
whether "PowerDevil" is listed there?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 345115] allow to disable suspend inhibitiors per activity

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=345115

Kai Uwe Broulik  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||k...@privat.broulik.de
 Status|UNCONFIRMED |CONFIRMED

--- Comment #2 from Kai Uwe Broulik  ---
I like this idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355799] Icons-only task manager has glitches with Breeze Dark theme

2015-11-23 Thread via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355799

--- Comment #2 from radzaqu...@gmail.com ---
Created attachment 95674
  --> https://bugs.kde.org/attachment.cgi?id=95674=edit
Breeze Dark - Glitches

Here is the result with Breeze Dark: look at Dolphin icon & System Settings
icon

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355799] Icons-only task manager has glitches with Breeze Dark theme

2015-11-23 Thread via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355799

--- Comment #1 from radzaqu...@gmail.com ---
Created attachment 95673
  --> https://bugs.kde.org/attachment.cgi?id=95673=edit
Breeze - No glitch

This is the situation with Breeze: everything's OK

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 355804] New: Fresh boot to sddm and a few minutes of inactivity sends computer to Standby

2015-11-23 Thread Gregor Mi via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355804

Bug ID: 355804
   Summary: Fresh boot to sddm and a few minutes of inactivity
sends computer to Standby
   Product: Powerdevil
   Version: 5.4.3
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: codestr...@posteo.org

When I start my laptop and do not login right away (about 1..5 minutes delay)
the computer will go to Standby.

Maybe this is related with https://bugs.kde.org/show_bug.cgi?id=354250

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

2015-11-23 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/
---

(Updated Nov. 23, 2015, 6:59 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 2608e0d5dffad2eed73caaf0044ab20cc60f1baa by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

This allows to drop a .plasmoid file on a panel or desktop and have it 
automatically installed and placed there.

Video: https://www.youtube.com/watch?v=5MnWnt_u5dU


Diffs
-

  src/scriptengines/qml/CMakeLists.txt 2aedf0b 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 18be65f 

Diff: https://git.reviewboard.kde.org/r/125968/diff/


Testing
---

Works

2.) How can I get the pluginId of the applet? KPackage::metadata() is 
deprecated. Perhaps the KJob should be able to tell me eventually?

3.) How can I get the path to the installed package to get the info for 2.

4.) Not sure about linking KNotifications here


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 355799] New: Icons-only task manager has glitches with Breeze Dark theme

2015-11-23 Thread via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355799

Bug ID: 355799
   Summary: Icons-only task manager has glitches with Breeze Dark
theme
   Product: Breeze
   Version: 5.4.3
  Platform: Archlinux Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: radzaqu...@gmail.com

Since updating from 5.4.2 to 5.4.3, there is some visual glitches on the icons
with Breeze Dark.
-Icon backgrounds are sometimes glitchy
-Indicator arrow is far too big for icons with multiple instances 

Reproducible: Always

Steps to Reproduce:
1. Choose Breeze Dark theme
2. Choose Icons-Only Task Manager
3. Open 2 or 3 programs
4. Minimize & expand windows some times
5. Look at the icon background
6. Open 2 instances of the same program
7. Look again at the icon

Actual Results:  
Step 5: icon backgroung is glitchy
Step 7: a big black arrow covers the icon


Tested on Manjaro 15.09 x64 (updated 23-11-2015)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 353356] Powerdevil does not respect the critical level configuration

2015-11-23 Thread LtWorf

https://bugs.kde.org/show_bug.cgi?id=353356

--- Comment #2 from Salvo "LtWorf" Tomaselli  ---
Critical is 6%, low is 10%

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[plasmashell] [Bug 355799] Icons-only task manager has glitches with Breeze Dark theme

2015-11-23 Thread Martin Klapetek via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=355799

Martin Klapetek  changed:

   What|Removed |Added

   Assignee|plasma-devel@kde.org|visual-des...@kde.org
 CC||mklape...@kde.org,
   ||plasma-b...@kde.org
  Component|general |Theme - Breeze
Product|Breeze  |plasmashell
   Target Milestone|--- |1.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

2015-11-23 Thread Marco Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88731
---

Ship it!


Ship It!

- Marco Martin


On Nov. 23, 2015, 5:22 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 23, 2015, 5:22 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 18be65f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

2015-11-23 Thread Ashish Bansal


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125993/#review88730
---



libs/mediacenter/lastfmimagefetcher.cpp (line 152)


Remove trailing white spaces.



libs/mediacenter/lastfmimagefetcher.cpp (line 155)


newMediaList ? 
Haven't we got image for only one media file yet ?



libs/mediacenter/medialibrary.h (line 58)


Change it to :
void mediaUpdated(QSharedPointer);



libs/mediacenter/pmcmetadatamodel.cpp (line 85)


Isn't this gonna duplicate the media in the view ? Check 
PmcMetadataModel::signalUpdate



libs/mediacenter/pmcmetadatamodel.cpp (line 87)


Remove White space error.


- Ashish Bansal


On Nov. 23, 2015, 1:50 p.m., Aditya Dev Sharma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125993/
> ---
> 
> (Updated Nov. 23, 2015, 1:50 p.m.)
> 
> 
> Review request for Plasma, Ashish Bansal and Bhushan Shah.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Implemented it like the other datasources.
> 
> Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . 
> handleLastFmNewMedia then calls fetchImage for each newMedia in the 
> newMediaList. Created a QList for storing the new media.
> 
> After the image is fetched, gotImage emits the signal imageFetched (from 
> mediaLibrary) with the QList we created earlier. This signal is absorbed by 
> handleNewMedia in PmcMetaDataModel which does the rest.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 04ba1c3 
>   autotests/lastfmimagefetchertest.h eb7cb29 
>   autotests/lastfmimagefetchertest.cpp abb3fd6 
>   datasources/CMakeLists.txt a7171b7 
>   datasources/lastfm/CMakeLists.txt PRE-CREATION 
>   datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION 
>   libs/mediacenter/CMakeLists.txt 5a13449 
>   libs/mediacenter/lastfmimagefetcher.h ecff37e 
>   libs/mediacenter/lastfmimagefetcher.cpp e005077 
>   libs/mediacenter/medialibrary.h 45744c1 
>   libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe 
> 
> Diff: https://git.reviewboard.kde.org/r/125993/diff/
> 
> 
> Testing
> ---
> 
> Builds 100%.
> However the audio scrobbler api doesn't seem to work which I'll fix after 
> this. 
> Also, I get the following Output : http://ix.io/mps
> Apart from it, all the datasources are loaded and media plays as expected.
> 
> 
> Thanks,
> 
> Aditya Dev Sharma
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 348082] monitor is randomly powered back on

2015-11-23 Thread Kai Uwe Broulik via KDE Bugzilla

https://bugs.kde.org/show_bug.cgi?id=348082

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de

--- Comment #10 from Kai Uwe Broulik  ---
Could you perhaps try https://git.reviewboard.kde.org/r/126145/ ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/#review88735
---



CMakeLists.txt (line 122)


Why do you drop FAST_CONCATENATION?


Regarding QStringLiteral vs QLatin1String for libraries: I read that thread, 
but then most of QStringLiterals here sould be dropped as well if that was the 
case. I don't think it makes sense to make a special case of QIcon::fromTheme.

- Aleix Pol Gonzalez


On Nov. 23, 2015, 9:36 p.m., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126148/
> ---
> 
> (Updated Nov. 23, 2015, 9:36 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Martin Klapetek.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> also contains fix for clazy warning regarding iterating over temporary 
> roleNames() object
> 
> note that for QRegExp constructor and for QIcon::fromTheme() i used 
> QLatin1String because QStringLiteral is known to produce crashes-on-exit if 
> the code is inside a library
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 812dc96 
>   src/declarativeimports/core/datamodel.cpp 1c83bc5 
>   src/declarativeimports/core/framesvgitem.cpp 9aab228 
>   src/declarativeimports/core/iconitem.cpp f32b3d1 
>   src/plasma/applet.cpp 89c 
>   src/plasma/containment.cpp 1d166f2 
>   src/plasma/framesvg.cpp f9379b0 
>   src/plasma/pluginloader.cpp bfa5dee 
>   src/plasma/private/applet_p.cpp e935d52 
>   src/plasma/private/containment_p.cpp 3836772 
>   src/plasma/private/theme_p.cpp 7bf81d4 
>   src/plasma/scripting/scriptengine.cpp 5b2cf84 
>   src/plasma/svg.cpp 20cb31f 
>   src/plasma/theme.cpp c49ad4c 
>   src/plasmaquick/appletquickitem.cpp efe8611 
>   src/plasmaquick/shellpluginloader.cpp 2824760 
> 
> Diff: https://git.reviewboard.kde.org/r/126148/diff/
> 
> 
> Testing
> ---
> 
> compiles fine
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126148: [plasma-framework] qstring optimizations

2015-11-23 Thread Nick Shaforostoff


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126148/
---

Review request for Plasma, Marco Martin and Martin Klapetek.


Repository: plasma-framework


Description
---

also contains fix for clazy warning regarding iterating over temporary 
roleNames() object

note that for QRegExp constructor and for QIcon::fromTheme() i used 
QLatin1String because QStringLiteral is known to produce crashes-on-exit if the 
code is inside a library


Diffs
-

  CMakeLists.txt 812dc96 
  src/declarativeimports/core/datamodel.cpp 1c83bc5 
  src/declarativeimports/core/framesvgitem.cpp 9aab228 
  src/declarativeimports/core/iconitem.cpp f32b3d1 
  src/plasma/applet.cpp 89c 
  src/plasma/containment.cpp 1d166f2 
  src/plasma/framesvg.cpp f9379b0 
  src/plasma/pluginloader.cpp bfa5dee 
  src/plasma/private/applet_p.cpp e935d52 
  src/plasma/private/containment_p.cpp 3836772 
  src/plasma/private/theme_p.cpp 7bf81d4 
  src/plasma/scripting/scriptengine.cpp 5b2cf84 
  src/plasma/svg.cpp 20cb31f 
  src/plasma/theme.cpp c49ad4c 
  src/plasmaquick/appletquickitem.cpp efe8611 
  src/plasmaquick/shellpluginloader.cpp 2824760 

Diff: https://git.reviewboard.kde.org/r/126148/diff/


Testing
---

compiles fine


Thanks,

Nick Shaforostoff

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126149: [Icon widget] Bring back properties dialog

2015-11-23 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/
---

Review request for Plasma.


Bugs: ?
https://bugs.kde.org/show_bug.cgi?id=?


Repository: plasma-workspace


Description
---

This brings back the KPropertiesDialog to modify an icon's appearance. This has 
been requested at multiple occasions. This has been adapted from the Plasma 4 
icon code.


Diffs
-

  applets/icon/package/contents/ui/main.qml 9286b94 
  applets/icon/plugin/icon_p.h dd7963c 
  applets/icon/plugin/icon_p.cpp e086870 

Diff: https://git.reviewboard.kde.org/r/126149/diff/


Testing
---

Dropped a file from my home onto the desktop -> dialog from the actual file, 
allowing to rename it. The applet reflected the changes.

Dropped an application from kickoff to the desktop -> dialog from a copy of the 
desktop file, allowing to change its icon and description. The applet reflected 
the changes.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126150: Ensure the spinboxes in image slideshow are wide enough

2015-11-23 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126150/
---

Review request for Plasma.


Bugs: 33
https://bugs.kde.org/show_bug.cgi?id=33


Repository: plasma-workspace


Description
---

Should fix https://bugs.kde.org/show_bug.cgi?id=33


Diffs
-

  wallpapers/image/imagepackage/contents/ui/config.qml e66bc23 

Diff: https://git.reviewboard.kde.org/r/126150/diff/


Testing
---

Looks wide enough.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126151: Port avatar gallery from kcm_useraccounts to user-manager

2015-11-23 Thread Kai Uwe Broulik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126151/
---

Review request for Plasma, KDE Usability and Jonathan Riddell.


Bugs: 354001
http://bugs.kde.org/show_bug.cgi?id=354001


Repository: user-manager


Description
---

Including the avatars, that are no longer installed into /usr/share/kdm/icons 
but /usr/share/user-manager/avatars. I don't know if there's a FDO location for 
these.


Diffs
-

  src/CMakeLists.txt 7267d24 
  src/accountinfo.h c6e70b3 
  src/accountinfo.cpp 878f683 
  src/avatargallery.h PRE-CREATION 
  src/avatargallery.cpp PRE-CREATION 
  src/avatargallery.ui PRE-CREATION 
  src/pics/Ada Lovelace.png PRE-CREATION 
  src/pics/Alice in Wonderland.png PRE-CREATION 
  src/pics/Blackbox.png PRE-CREATION 
  src/pics/CMakeLists.txt PRE-CREATION 
  src/pics/Dragon.png PRE-CREATION 
  src/pics/Grace Hopper.png PRE-CREATION 
  src/pics/Green.png PRE-CREATION 
  src/pics/Happy.png PRE-CREATION 
  src/pics/Kati.png PRE-CREATION 
  src/pics/Konqui.png PRE-CREATION 
  src/pics/Leonardo da Vinci.png PRE-CREATION 
  src/pics/Listening.png PRE-CREATION 
  src/pics/Logger.png PRE-CREATION 
  src/pics/Mahatma Gandhi.png PRE-CREATION 
  src/pics/Mowgli jungle book.png PRE-CREATION 
  src/pics/Notme.png PRE-CREATION 
  src/pics/Parley.png PRE-CREATION 
  src/pics/Rekonqui.png PRE-CREATION 
  src/pics/TV.png PRE-CREATION 
  src/pics/User.png PRE-CREATION 
  src/pics/bomb.png PRE-CREATION 
  src/pics/sources/Ada Lovelace.svg PRE-CREATION 
  src/pics/sources/Alice in Wonderland.svg PRE-CREATION 
  src/pics/sources/Dragon.svg PRE-CREATION 
  src/pics/sources/Grace Hopper.svg PRE-CREATION 
  src/pics/sources/Kati.svg PRE-CREATION 
  src/pics/sources/Konqui.svg PRE-CREATION 
  src/pics/sources/Leonardo da Vinci.svg PRE-CREATION 
  src/pics/sources/Logger.svg PRE-CREATION 
  src/pics/sources/Mahatma Gandhi.svg PRE-CREATION 
  src/pics/sources/Mowgli jungle book.svg PRE-CREATION 
  src/pics/sources/Parley.svg PRE-CREATION 
  src/pics/sources/Rekonqui.svg PRE-CREATION 
  src/pics/sources/User.svg PRE-CREATION 
  src/pics/sources/blackbox.svgz PRE-CREATION 
  src/pics/sources/bomb.svgz PRE-CREATION 
  src/pics/sources/green.svgz PRE-CREATION 
  src/pics/sources/happy.svgz PRE-CREATION 
  src/pics/sources/listening.svgz PRE-CREATION 
  src/pics/sources/notme.svgz PRE-CREATION 
  src/pics/sources/tv.svgz PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126151/diff/


Testing
---

Opened user manager, clicked my icon, clicked "Choose from Gallery", chose an 
icon, OK. It prompted me three times for Polkit authentication for some reason 
but in the end it worked, Kickoff also immediately updated its icon.


File Attachments


New menu option
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/d91c818f-5051-4857-beb2-b2727614f187__usermanageravatar.png
Avatar gallery
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/11/23/2f16fa25-5eac-4e6a-b24d-7d47ff560ce4__usermanageravatar2.png


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

49 matches

Mail list logo