[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

broulik added a comment. -1 Can we please stay at *Bytes* per second instead of *Bits*. We don't use that anywhere else, copying files also doesn't use Bytes instead of Bits. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4551 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D4554: Pass args to DataEngine superclass constructor

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is needed so Plasma::DataEngine can construct the metadata TEST PLAN Debug. Lots of

[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

Zren added a comment. Ah, just noticed the title (bytes => bits), and I agree it should remain bytes, or at least be optional. > I proposed bits per second for network monitor only since users internet speeds are advertised/shown as "Mbps" or "Kbps" or the like. Do the math (divide

[kio-extras] [Bug 375732] Dolphin fails to sftp to Linux box when not a direct connection

https://bugs.kde.org/show_bug.cgi?id=375732 Elvis Angelaccio changed: What|Removed |Added Component|bars: location |default

[kio-extras] [Bug 376301] New: sftp.so not closing connections when ProxyCommand is configured

https://bugs.kde.org/show_bug.cgi?id=376301 Bug ID: 376301 Summary: sftp.so not closing connections when ProxyCommand is configured Product: kio-extras Version: unspecified Platform: Ubuntu Packages OS:

[Differential] [Requested Changes To] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni requested changes to this revision. anthonyfieroni added a comment. This revision now requires changes to proceed. One more change, wait for me :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL PREFERENCES

[kio-extras] [Bug 376301] sftp.so not closing connections when ProxyCommand is configured

https://bugs.kde.org/show_bug.cgi?id=376301 Andreas changed: What|Removed |Added Severity|critical|major --- Comment #1 from

[Differential] [Commented On] D4518: Ungrab mouse in taskmanager context menu

anthonyfieroni added a comment. Qt 5.8 has annoying bug, dismiss context menu by left clicking excatly over other window (not desktop or taskmanager) grabbing stays in taskmanager. I will investigate for workaround, if someone has a purpose i'll be happy :) REPOSITORY R119 Plasma Desktop

[Differential] [Commented On] D4171: [Task Manager] Remove arbitrary sizes from tooltip

broulik added a comment. This can be abandoned now, right? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, hein, subdiff Cc:

[Differential] [Accepted] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma,

[Differential] [Commented On] D4171: [Task Manager] Remove arbitrary sizes from tooltip

anthonyfieroni added a comment. It should be :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, hein, subdiff Cc: anthonyfieroni,

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 62 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 17:58:56 + Build duration: 6 min 39 sec CHANGE SET Revision

[Differential] [Accepted] D4400: Plasma 5.10 "Cascade" Wallpaper

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D4400 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kvermette,

[Differential] [Closed] D4400: Plasma 5.10 "Cascade" Wallpaper

broulik closed this revision. broulik added a comment. Has been submitted as https://cgit.kde.org/breeze.git/commit/?id=e3fe5b5d84e076afc7ec0d03bc42f0fe7c446d56 (Phab doesn't let me close non-accepted revisions…) REPOSITORY R31 Breeze REVISION DETAIL

[Differential] [Abandoned] D4171: [Task Manager] Remove arbitrary sizes from tooltip

broulik abandoned this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, #plasma, hein, subdiff Cc: anthonyfieroni, mart, Fuchs,

[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

vishalrao added a comment. In https://phabricator.kde.org/D4551#85078, @broulik wrote: > -1 > > Can we please stay at *Bytes* per second instead of *Bits*. We don't use that anywhere else, copying files also uses Bytes instead of Bits. > > Also, what's up with the 1024

[Differential] [Commented On] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni added a comment. Task.qml line 145 add backend.cancelHighlightWindows(); So when it's pressed button (left, middle, right) on task it show always stop highlight effect :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL

[Differential] [Closed] D4534: [Folder View] Don't show script execution prompt on desktop:/

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c2f74cc8c8dd: [Folder View] Don't show script execution prompt on desktop:/ (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4551: Display speeds in bits per second instead of KiB/s

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8da91cde831c: Display speeds in bits per second instead of KiB/s (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

Important: Plasma Desktop 5.8 Branch broken.

There's a broken merge. Please don't push patches in there Also no making a 5.8 release. I'll talk to sysadmins and get something fixed. David

[Differential] [Commented On] D4550: Task Manager: Make maximum text lines and minimum line length configurable for task buttons.

ppalaga added a comment. Hi Eike und Kai Uwe, Thanks for your feedback. This is my first submission here, although I am a loyal user of KDE since 2001. Please be patient with me. I may have fully inappropriate expectations and I may be violating your processes and rules. I'll be glad

[Differential] [Accepted] D4557: Fix gtk-primary-button-warps-slider with GTK 2

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I thought it was only GTK 3 apps that did that, but fair enough REPOSITORY R99 KDE Gtk Configuration Tool BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4557

[Differential] [Closed] D4557: Fix gtk-primary-button-warps-slider with GTK 2

This revision was automatically updated to reflect the committed changes. Closed by commit R99:4a06c4d34f2d: Fix gtk-primary-button-warps-slider with GTK 2 (authored by elvisangelaccio). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

[Differential] [Updated, 6 lines] D4554: Pass args to DataEngine superclass constructor

davidedmundson updated this revision to Diff 11191. davidedmundson added a comment. And another one REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4554?vs=11190=11191 BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4554

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 744 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/744/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 21:08:00 + Build duration: 14 min CHANGE SET Revision

[Differential] [Request, 4 lines] D4557: Fix gtk-primary-button-warps-slider with GTK 2

elvisangelaccio created this revision. elvisangelaccio added reviewers: apol, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Replace true/false with 1/0. The former works only with GTK 3, but breaks with GTK 2

[Differential] [Accepted] D4554: Pass args to DataEngine superclass constructor

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4554 EMAIL PREFERENCES

[Differential] [Request, 9 lines] D4556: Ref/deref DataEngines even if the metadata is invalid

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Just because the metadata is invalid doesn't mean the DataEngine

[Differential] [Accepted] D4526: Lazy QUrl::fromUserInput in web browser

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D4526 EMAIL PREFERENCES

[Differential] [Commented On] D4540: fix bug with git after update to Plasma 5.9 in neon

cfeck added a comment. The duplicate bug 376318 does not mention 'git', but simply opening a (secure) shell. Do both use the same 'ssh-add' command? If yes, then the comment mentioning 'git' might be misleading. REPOSITORY R105 KDE SSH Password Dialog BRANCH master REVISION DETAIL

[Differential] [Accepted] D4540: fix bug with git after update to Plasma 5.9 in neon

bbuch accepted this revision. This revision is now accepted and ready to land. REPOSITORY R105 KDE SSH Password Dialog BRANCH master REVISION DETAIL https://phabricator.kde.org/D4540 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: idekels, whiting,

[Differential] [Accepted] D4540: fix bug with git after update to Plasma 5.9 in neon

mpyne accepted this revision. mpyne added a comment. The change is fine as far as privacy impact, it shouldn't add any issues that aren't already present. REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D4540 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 63 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 06:09:11 + Build duration: 16 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 64 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 06:57:58 + Build duration: 7 min 46 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 745 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/745/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 05:10:04 + Build duration: 6 min 7 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 613 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/613/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 05:09:39 + Build duration: 16 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 612 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/612/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 03:00:58 + Build duration: 15 min CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 61 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/61/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 11 Feb 2017 06:58:13 + Build duration: 19 min CHANGE SET Revision

[Differential] [Closed] D4532: fix discover desktopid in favorties

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ecfcc8ea6e49: fix discover desktopid in favorties (authored by sitter). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4532?vs=11123=11147 REVISION DETAIL

[Differential] [Closed] D4531: add discover to the system application tab in kickoff

This revision was automatically updated to reflect the committed changes. Closed by commit R119:12193b07f12b: add discover to the system application tab in kickoff (authored by sitter). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4531?vs=11122=11148

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 608 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/608/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 09:25:07 + Build duration: 5 min 34 sec CHANGE SET Revision

[Differential] [Commented On] D4525: Fix crash when invoking Present Windows with the group dialog open.

hein added a comment. No, unsetting taskManagerItem is dumb code IMHO. I'll address your concern a different way. Thanks for the input. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL PREFERENCES

[Differential] [Accepted] D4532: fix discover desktopid in favorties

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4532 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, apol, hein Cc:

[Differential] [Accepted] D4534: [Folder View] Don't show script execution prompt on desktop:/

hein accepted this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4534 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, fvogt, #plasma, davidedmundson, dfaure, hein Cc: plasma-devel, lesliezhai,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 607 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/607/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 09:16:07 + Build duration: 5 min 45 sec CHANGE SET Revision

[Differential] [Request, 15 lines] D4543: [ConfigModel] Emit dataChanged when a ConfigCategory changes

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Had a

[Differential] [Updated] D4543: [ConfigModel] Emit dataChanged when a ConfigCategory changes

broulik updated the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4543 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: plasma-devel, #frameworks, lesliezhai,

[Differential] [Commented On] D4525: Fix crash when invoking Present Windows with the group dialog open.

anthonyfieroni added a comment. You can try in Task.qml onHighlightedChanged: { if (highlighted) { backend.cancelHighlightWindows(); } } If it can help :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4525 EMAIL

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 60 - Still unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 09:15:02 + Build duration: 19 min CHANGE SET Revision

[Differential] [Accepted] D4531: add discover to the system application tab in kickoff

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D4531 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, apol, hein Cc:

[Differential] [Closed] D4533: Avoid a crash on Kwin decoration KCM teardown

This revision was automatically updated to reflect the committed changes. Closed by commit R108:29179f115c81: Avoid a crash on Kwin decoration KCM teardown (authored by davidedmundson). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4533?vs=11126=11151 REVISION

[Differential] [Closed] D4543: [ConfigModel] Emit dataChanged when a ConfigCategory changes

This revision was automatically updated to reflect the committed changes. Closed by commit R242:5becf5bc114e: [ConfigModel] Emit dataChanged when a ConfigCategory changes (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D4544: [Folder View] Support extracting files to sub-directories with drag and drop from Ark

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4544 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, hein, #plasma Cc: plasma-devel,

[Differential] [Accepted] D4343: Greatly improve Folder View performance and mem usage.

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH hein/fastFoldersNew REVISION DETAIL https://phabricator.kde.org/D4343 EMAIL PREFERENCES

[Differential] [Closed] D4345: Remove the TextFix workaround for QML text mouse handling bug.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b893dc9ad6a2: Remove the TextFix workaround for QML text mouse handling bug. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4344: Delay setting the model on the view until listing is finished.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7fd62b59b77f: Delay setting the model on the view until listing is finished. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4343: Greatly improve Folder View performance and mem usage.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:99c903059f59: Greatly improve Folder View performance and mem usage. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4343?vs=10705=11161

[Differential] [Accepted] D4543: [ConfigModel] Emit dataChanged when a ConfigCategory changes

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4543 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4530: WIP: Don't re-show auto-hidden client on geometry change if they're still at a screen edge

graesslin added a comment. We do have autotests for this in autotests/integration/screenedge_client_show_test.cpp REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Updated, 34 lines] D4525: Fix crash when invoking Present Windows with the group dialog open.

hein updated this revision to Diff 11153. hein added a comment. - Do highlighting from the group dialog properly instead of intentionally breaking it via a side effect that caused this crash. - Some extra crash guards. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4525: Fix crash when invoking Present Windows with the group dialog open.

hein added a comment. I feel like both of those are papering over the real bug, which that we never figured out how to exempt the GroupDialog successfully from the highlight effect. This just breaks highlight for group members ... REPOSITORY R119 Plasma Desktop REVISION DETAIL

[Differential] [Updated, 33 lines] D4525: Fix crash when invoking Present Windows with the group dialog open.

hein updated this revision to Diff 11154. hein added a comment. Drop stray debug. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4525?vs=11153=11154 BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4525 AFFECTED FILES

[Differential] [Closed] D2932: Move availableScreenRect/Region up to AppletInterface.

hein closed this revision. hein added a comment. Forgot to close. REVISION DETAIL https://phabricator.kde.org/D2932 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc: lbeltrame, plasma-devel, lesliezhai, ali-mohamed,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 610 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/610/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 11:57:30 + Build duration: 5 min 31 sec CHANGE SET Revision

[Differential] [Updated] D4530: WIP: Don't re-show auto-hidden client on geometry change if they're still at a screen edge

broulik changed the repository for this revision from R131 Plasma Wallpapers to R108 KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D4530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #kwin Cc: plasma-devel,

[Differential] [Accepted] D4535: Fix crash in Screen Locker KCM on teardown

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D4535 EMAIL PREFERENCES

[Differential] [Commented On] D4530: WIP: Don't re-show auto-hidden client on geometry change if they're still at a screen edge

graesslin added inline comments. INLINE COMMENTS > client.cpp:2086-2094 > +const auto = screens()->geometry(screen()); > + > +switch (border) { > +case ElectricTop: > +if (geometry().top() == screenGeometry.top()) { > +

[Differential] [Requested Changes To] D4540: fix bug with git after update to Plasma 5.9 in neon

bbuch requested changes to this revision. bbuch added a reviewer: bbuch. bbuch added a comment. This revision now requires changes to proceed. This doesn't work for Usernames and the resulting keyFile is different from the old behavior. (It contains the closing ": ") Please change the

[Differential] [Updated, 31 lines] D4525: Fix crash when invoking Present Windows with the group dialog open.

hein updated this revision to Diff 11160. hein added a comment. Drop another stray debug. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4525?vs=11154=11160 BRANCH Plasma/5.9 REVISION DETAIL https://phabricator.kde.org/D4525 AFFECTED FILES

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 61 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/61/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 11:35:35 + Build duration: 5 min 55 sec CHANGE SET Revision

[Differential] [Closed] D4535: Fix crash in Screen Locker KCM on teardown

This revision was automatically updated to reflect the committed changes. Closed by commit R133:51c4d6c8db82: Fix crash in Screen Locker KCM on teardown (authored by davidedmundson). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4535?vs=11128=11152

[Differential] [Request, 47 lines] D4544: [Folder View] Support extracting files to sub-directories with drag and drop from Ark

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise when dropping onto a

[Differential] [Closed] D4544: [Folder View] Support extracting files to sub-directories with drag and drop from Ark

This revision was automatically updated to reflect the committed changes. Closed by commit R119:32c7d2d060c7: [Folder View] Support extracting files to sub-directories with drag and drop… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4544?vs=11157=11159#toc

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 609 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/609/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 11:39:30 + Build duration: 15 min CHANGE SET Revision

[Differential] [Updated, 11 lines] D4540: fix bug with git after update to Plasma 5.9 in neon

idekels updated this revision to Diff 11164. idekels added a comment. - changes requested by bbuch 1. Updating https://phabricator.kde.org/D4540: fix bug with git after update to Plasma 5.9 in neon # 2. Enter a brief description of the changes included in this update. 3. The first

[Differential] [Closed] D4215: Make notifications execute the "default" action on click.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6f2b57b4925d: Make notifications execute the "default" action on click. (authored by albertvaka, committed by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 255 lines] D4545: Centralize interaction with notifications

apol created this revision. apol added reviewers: Plasma, mart, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make sure clicking on them will work the same on the popup and the delegate, there were

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 742 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/742/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 12:34:21 + Build duration: 14 min CHANGE SET Revision

[Differential] [Updated] D4546: Add more API to enable custom menu positioning.

hein added a dependent revision: D4547: Use new PlasmaComponents.ContextMenu API for improved placement when at bottom edge.. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4546 EMAIL PREFERENCES

[Differential] [Closed] D4471: Fix KCModule::setAuthAction error checking

This revision was automatically updated to reflect the committed changes. Closed by commit R265:49dbf1beaff2: Fix KCModule::setAuthAction error checking (authored by davidedmundson). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4471?vs=10991=11172

[Differential] [Updated] D4546: Add more API to enable custom menu positioning.

mart added a comment. In https://phabricator.kde.org/D4546#84979, @hein wrote: > Although ... maybe one hack we could do is change the meaning of "TopPosedLeftAlignedPopup" to "bottom edge of menu at top of visualParent" instead of "0,0 of menu at top of visualParent". Marco?

[Differential] [Request, 48 lines] D4550: Task Manager: Make maximum text lines and minimum line length configurable for task buttons.

ppalaga created this revision. ppalaga set the repository for this revision to R119 Plasma Desktop. ppalaga added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This improves the rendering when the task manager is oriented vertically. Before this

[Differential] [Updated] D4550: Task Manager: Make maximum text lines and minimum line length configurable for task buttons.

ppalaga added reviewers: broulik, davidedmundson, hein. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, broulik, davidedmundson, hein Cc: plasma-devel, lesliezhai,

[Differential] [Updated] D4545: Centralize interaction with notifications

apol added a reviewer: albertvaka. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4545 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart, davidedmundson, albertvaka Cc: plasma-devel, lesliezhai,

[Differential] [Request, 50 lines] D4546: Add more API to enable custom menu positioning.

hein created this revision. hein added reviewers: Plasma, mart. hein added a subscriber: plasma-devel. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Without being able to get the menu size it's not possible to

[Differential] [Request, 12 lines] D4547: Use new PlasmaComponents.ContextMenu API for improved placement when at bottom edge.

hein created this revision. hein added reviewers: Plasma, mart. hein added a subscriber: plasma-devel. hein added a dependency: D4546: Add more API to enable custom menu positioning.. Restricted Application added a project: Plasma. REVISION SUMMARY openRelative() will position the menu at the

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

broulik added a comment. We have this openRelateive thing with "bottom left posed" and what not, shouldn't it have a thing for "have the bottom left corner of the menu be at the top of the parent item"? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

hein added a comment. Although ... maybe one hack we could do is change the meaning of "TopPosedLeftAlignedPopup" to "bottom edge of menu at top of visualParent" instead of "0,0 of menu at top of visualParent". Marco? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

[Differential] [Commented On] D4545: Centralize interaction with notifications

albertvaka added inline comments. INLINE COMMENTS > NotificationDelegate.qml:36-37 > > -enabled: true > -checked: notificationItem.containsMouse > - This was there so they highlight on hover. Is it not needed anymore? > NotificationItem.qml:70 > +action("default") > +

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 743 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/743/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 13:45:18 + Build duration: 14 min CHANGE SET Revision

[Differential] [Commented On] D4546: Add more API to enable custom menu positioning.

hein added a comment. I'm not convinced it's worth it. This patch allows writing the same sort of code we already have in ContainmentInterface for context menu placement. If we resort to doing it there then clearly we need it in other places as well. (And I wrote openRelative ...)

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

albertvaka added a comment. What? This shouldn't have been pushed! It still has the old behaviour... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4215 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: albertvaka,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 741 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/741/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 10 Feb 2017 12:19:51 + Build duration: 13 min CHANGE SET Revision

[Differential] [Request, 22 lines] D4551: Display speeds in bits per second instead of KiB/s

vishalrao created this revision. vishalrao set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is a patch to make the Network Monitor desktop plasmoid widget

[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

davidedmundson added a comment. In general fine. INLINE COMMENTS > net.qml:42 > > -delegate: DoublePlotter {} > -} > \ No newline at end of file > +function formatBitSize(value) { > +if (value > 1048576) { formatBitSpeed ? Otherwise it's confusing > net.qml:44 > +

[Differential] [Accepted] D4551: Display speeds in bits per second instead of KiB/s

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4551 EMAIL PREFERENCES

[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

vishalrao added a comment. In https://phabricator.kde.org/D4551#85039, @Zren wrote: > Any reason for not using > > if (...) { > } else if (...) { > } else { > } No real reason, the statements are single lines and returns so thought this is okay - should I change to

[Differential] [Updated, 22 lines] D4551: Display speeds in bits per second instead of KiB/s

vishalrao updated this revision to Diff 11178. vishalrao added a comment. Updated per David's comments. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4551?vs=11176=11178 REVISION DETAIL https://phabricator.kde.org/D4551 AFFECTED FILES

[Differential] [Changed Subscribers] D4551: Display speeds in bits per second instead of KiB/s

sebas added inline comments. INLINE COMMENTS > net.qml:43 > +function formatBitSpeed(value) { > +if (value > 1048576) { > +return i18nc("%1 is the data transfer speed in megabits per > second", "%1 Mbps", (value / 1048576).toFixed(1)); Perhaps explain this "magic

[Differential] [Commented On] D4551: Display speeds in bits per second instead of KiB/s

Zren added a comment. Any reason for not using if (...) { } else if (...) { } else { } REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4551 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vishalrao Cc: Zren,

  1   2   >