Re: Review Request 122339: Add KWorkSpace::isShuttingDown()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122339/#review75755 --- Ship it! I'm not 100 % happy with the blocking dbus call, but

Re: Review Request 122392: Fix Klipper Performance issues

> On Feb. 3, 2015, 8:23 a.m., Martin Gräßlin wrote: > > could you please split the review in a per-commit review? I find it hard to > > review as there are so many changes to different areas. Especially I think > > there are a few no-brainer which could go in quickly, while the threaded > > fi

Re: Merging new PMC design into master

On Tue, Feb 10, 2015 at 11:10 AM, Bhushan Shah wrote: > Hello! > > So, PMC team have developed whole new user interface based upon > feedback from VDG [1] it is being developed in bshah/pmc2 branch of > plasma-mediacenter repo. > > I am going to merge this branch to master (which is already KF5 b

Re: Review Request 122500: Don't delete widgets we don't own when changing styles

> On Feb. 9, 2015, 5:34 p.m., Hugo Pereira Da Costa wrote: > > Although I have no objection against the change, I must admit I don't > > understand what's wrong with the current code, nor the actual description > > of the patch. > > "registerWidget may take an existing widget as a parameter. I

Re: Merging new PMC design into master

On Tue, Feb 10, 2015 at 11:10 AM, Bhushan Shah wrote: > I am going to merge this branch to master (which is already KF5 based) > today, this will allow users and VDG people to try out new user > interface without any hassle, so if you have any objections please > say. +1 Good to merge it to mas

Merging new PMC design into master

Hello! So, PMC team have developed whole new user interface based upon feedback from VDG [1] it is being developed in bshah/pmc2 branch of plasma-mediacenter repo. I am going to merge this branch to master (which is already KF5 based) today, this will allow users and VDG people to try out new use

Re: Review Request 122506: Fix crash due to unsafe access to ShellCorona::m_screenConfiguration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122506/#review75748 --- shell/shellcorona.cpp

Review Request 122506: Fix crash due to unsafe access to ShellCorona::m_screenConfiguration

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122506/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/ --- (Updated Feb. 9, 2015, 10:48 p.m.) Status -- This change has been ma

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |WONTFIX Status|UNCONFIRMED

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #10 from hipersayan_x --- > It brings additional maintenance cost, it brings additional testing costs, > it brings higher chance of things getting broken, leading to more bug > reports etc etc. Ok, then stop making programs just because you

Review Request 122505: Warn about brightness getting too low

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122505/ --- Review request for Plasma and KDE Usability. Repository: plasma-workspace

Re: Review Request 122473: Treat normal selected timezone as local if it matches the local

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122473/ --- (Updated Feb. 9, 2015, 9:15 p.m.) Status -- This change has been mar

Re: Review Request 122500: Don't delete widgets we don't own when changing styles

> On Feb. 9, 2015, 5:34 p.m., Hugo Pereira Da Costa wrote: > > Although I have no objection against the change, I must admit I don't > > understand what's wrong with the current code, nor the actual description > > of the patch. > > "registerWidget may take an existing widget as a parameter. I

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #9 from Martin Klapetek --- > This patch adds just a few lines of code, without affecting in a negative way > to KDE, so why not including it? It brings additional maintenance cost, it brings additional testing costs, it brings higher chan

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 hipersayan_x changed: What|Removed |Added Status|RESOLVED|UNCONFIRMED Resolution|WONTFIX

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 Antonis G. changed: What|Removed |Added CC||gaanto...@civil.auth.gr --- Comment #7 from Antoni

Re: Get panel list and hidding them via C++ module

Hi Sebastian, On Monday 09 February 2015 13:59:21 Sebastian Kügler wrote: > Not possible, the QtQuick code's access to the C++ bits (Applet, Containment > is now very limited by design). > No, the separation between model (Plasma::Applet, Plasma::Containment, etc.) > and the views (implemented in

Re: Review Request 122339: Add KWorkSpace::isShuttingDown()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122339/ --- (Updated Feb. 9, 2015, 7:10 nachm.) Review request for Plasma and Martin

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #6 from hipersayan_x --- Created attachment 90995 --> https://bugs.kde.org/attachment.cgi?id=90995&action=edit kcmshell5 powerdevilglobalconfig with the option added This is how the patch looks like. -- You are receiving this mail becau

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 hipersayan_x changed: What|Removed |Added CC||hipersaya...@gmail.com --- Comment #5 from hiper

Re: Review Request 122392: Fix Klipper Performance issues

> On Feb. 3, 2015, 7:23 a.m., Martin Gräßlin wrote: > > could you please split the review in a per-commit review? I find it hard to > > review as there are so many changes to different areas. Especially I think > > there are a few no-brainer which could go in quickly, while the threaded > > fi

Re: Review Request 122371: Disable session management for kwrited

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122371/ --- (Updated Feb. 9, 2015, 5:52 p.m.) Status -- This change has been mar

[kwrited] [Bug 343550] duplicated kwrited instances increasing with each system boot

https://bugs.kde.org/show_bug.cgi?id=343550 Weng Xuetian changed: What|Removed |Added Version Fixed In||5.2.1 Latest Commit|

Re: Review Request 122500: Don't delete widgets we don't own when changing styles

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122500/#review75715 --- Although I have no objection against the change, I must admit

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75710 --- a bit on the fence about it, hmm.. I assume it would just not

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75709 --- +1 to the idea src/plasma/data/servicetypes/plasma-applet.de

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 9, 2015, 7:47 a.m., Martin Gräßlin wrote: > > kcms/dateandtime/main.cpp, line 143 > > > > > > why wait? If I understand correctly the next dbus calls do not depend > > on the outcome of the first one.

Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 122502: Add a `X-Plasma-Can-Be-Windowed` option to applets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122502/#review75706 --- +1, I assume this defaults to false - Bhushan Shah On Feb.

Re: Review Request 122382: [klipper] Sync history to disk after each change

> On Feb. 3, 2015, 7:36 a.m., Martin Gräßlin wrote: > > David E. just pointed out that this could become quite heavy for the system > > as the history size can be large (up to 2048 items). > > Martin Gräßlin wrote: > Unfortunately I couldn't find out why we support up to 2048 items. Commit

Re: Review Request 122400: Add timedated support into the clock KCM as an optional dependency

> On Feb. 9, 2015, 7:47 a.m., Martin Gräßlin wrote: > > kcms/dateandtime/main.cpp, line 143 > > > > > > why wait? If I understand correctly the next dbus calls do not depend > > on the outcome of the first one.

Re: Review Request 122488: Improved calendar navigation

> On Feb. 9, 2015, 3:20 a.m., Aleix Pol Gonzalez wrote: > > +1 I like it. > > > > Why is it even possible to select a day though? It doesn't do anything at > > the moment... > > > > Maybe it would be food that when hovering a day, the weekday was > > highlighted, it's useful to know what day

Re: Review Request 122488: Improved calendar navigation

> On Feb. 9, 2015, 2:51 p.m., Sebastian Kügler wrote: > > The one thing I'm missing is an indicator for the currently selected year > > and month, should be exactly the same tinting as the selected day. > > > > Otherwise, very nice work. When I implemented the combo-like behaviour, it > > was

Re: Review Request 122488: Improved calendar navigation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75695 --- Ship it! The one thing I'm missing is an indicator for the cu

Review Request 122500: Don't delete widgets we don't own when changing styles

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122500/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 9, 2015, 2:33 p.m.) Review request for Plasma. Repository

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

Re: Review Request 122420: reimplement some of the systemmonitor plasmoids

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122420/ --- (Updated Feb. 9, 2015, 2:19 p.m.) Review request for Plasma. Changes --

Re: theme mixing

Hi Pedro, On Sunday, February 08, 2015 12:10:12 Pedro Rosado wrote: > I don't know if this is the right place, but I wanted to suggest something. > > KDE is by far the most modern and efficient desktop I've came to know (not > dissing all the others), but regarding customization it's falling a li

Re: Get panel list and hidding them via C++ module

Hi Evgeniy, On Monday, February 09, 2015 15:43:05 Evgeniy Alekseev wrote: > Recently I have run into the following problem: how to get panel list (even > w\o additional filtering) and hidding them from an applet? > > With KDE4 I have used the following method: > 1. From plasmoid I have called co

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #3 from Martin Gräßlin --- (In reply to Martin Klapetek from comment #1) > I was wondering this the other day - can the OSD know there's a fullscreen > window above? yes it could know it: get active window, check whether it's fullscreen. Bu

Re: Review Request 122494: KDE Plasma 5 system tray expaned applets resized to take less space on notebooks low resolution screens.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122494/#review75687 --- Doesn't look like an improvement to me, especially the network

Get panel list and hidding them via C++ module

Hello, Recently I have run into the following problem: how to get panel list (even w\o additional filtering) and hidding them from an applet? With KDE4 I have used the following method: 1. From plasmoid I have called containment()->corona() to get pointer to corona object. 2. Then I have used i

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 --- Comment #2 from hipersayan_x --- > (just btw, when filing a bug, being nice and leaving out snarky comments > usually works better) Ok, sorry for that, but this is a real a problem for people who watch movies on a laptop. > I was wondering this the

[Powerdevil] [Bug 343962] Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org --- Comment #1 from Martin

[Powerdevil] [Bug 343962] New: Add option to disable Backlight OSD

https://bugs.kde.org/show_bug.cgi?id=343962 Bug ID: 343962 Summary: Add option to disable Backlight OSD Product: Powerdevil Version: 5.2.0 Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED Severit

Re: Review Request 122371: Disable session management for kwrited

> On Feb. 8, 2015, 1:49 p.m., David Edmundson wrote: > > kwrited.cpp, line 74 > > > > > > why this? It's fine. Since kwrited doesn't have any UI, we can safely get away with this. It will reduce loading the curr

Re: Plasma 5.2, breeze, which tab is active?

On Mon, Feb 9, 2015 at 11:38 AM, David Edmundson wrote: > That inactive tab should only be blue on mouseover. > ​ > Either there's a bug or that screenshot isn't very representative. > Inactive is always blue here, but i seem to be having some other weirdness as well (like no cursor themes). Tes

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. A

[Breeze] [Bug 343961] Smallest size icons look bad on dark themes

https://bugs.kde.org/show_bug.cgi?id=343961 Martin Klapetek changed: What|Removed |Added Assignee|plasma-devel@kde.org|unassigned-b...@kde.org Component|ge

[Breeze] [Bug 343961] New: Smallest size icons look bad on dark themes

https://bugs.kde.org/show_bug.cgi?id=343961 Bug ID: 343961 Summary: Smallest size icons look bad on dark themes Product: Breeze Version: unspecified Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED

Re: Review Request 122488: Improved calendar navigation

> On Feb. 9, 2015, 4:20 a.m., Aleix Pol Gonzalez wrote: > > +1 I like it. > > > > Why is it even possible to select a day though? It doesn't do anything at > > the moment... > > > > Maybe it would be food that when hovering a day, the weekday was > > highlighted, it's useful to know what day

Minutes Monday Plasma Hangout

Present: Kai Uwe, David, Jonathan, Marco, Harald, Excused: Martin G. 9th February, 2015 PSA: No hangout next week, as we'll meet in person for the Plasma sprint David: * Bugfixing Harald: * Started doing ISOs again * switching to 15.04 / 64bits * improved the released scripts (releaseme) to be

Re: Review Request 122488: Improved calendar navigation

> On Feb. 9, 2015, 2:40 a.m., Lukáš Tinkl wrote: > > src/declarativeimports/calendar/qml/MonthView.qml, line 61 > > > > > > I know this is not your code but still... we must absolutely not make > > any asumptions

Re: Review Request 122488: Improved calendar navigation

On Feb. 9, 2015, 2:21 a.m., Kai Uwe Broulik wrote: > > I'd advice against the new C++ functions. You can use setDisplayDate (even > > in QML with the displayedDate property) to accomplish the exact same thing > > and it keeps the C++ API clean. > > If you really want to have the "helper functio

Re: Plasma 5.2, breeze, which tab is active?

That inactive tab should only be blue on mouseover. ​ Either there's a bug or that screenshot isn't very representative. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

theme mixing

Hi there, I don't know if this is the right place, but I wanted to suggest something. KDE is by far the most modern and efficient desktop I've came to know (not dissing all the others), but regarding customization it's falling a little behind. Compared to gnome-look org, KDE look feels abandoned

Re: [KDE Usability] Review Request 122488: Improved calendar navigation

would it be useful to see the events of the day (in an agenda) when you select the day 2015-02-09 4:20 GMT+01:00 Aleix Pol Gonzalez : >This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122488/ > > +1 I like it. > > Why is it even possible to selec

Re: Review Request 122488: Improved calendar navigation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review75677 --- Ship it! I like it. It reminds me an old demo Aza Raskin did

Re: Review Request 122488: Improved calendar navigation

> On Feb. 9, 2015, 1:40 a.m., Lukáš Tinkl wrote: > > src/declarativeimports/calendar/qml/DaysCalendar.qml, line 125 > > > > > > I know this is nitpicking but... how is an arrow pointing to the left > > implement

Re: Review Request 122488: Improved calendar navigation

On Feb. 9, 2015, 1:21 vorm., Kai Uwe Broulik wrote: > > I'd advice against the new C++ functions. You can use setDisplayDate (even > > in QML with the displayedDate property) to accomplish the exact same thing > > and it keeps the C++ API clean. > > If you really want to have the "helper functi

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

> On Jan. 26, 2015, 9:08 a.m., Marco Martin wrote: > > where do you want to use it? > > Iirc Bhushan is working o a global way to make series of kcms accessible > > from plasmoids > > David Edmundson wrote: > Generic is always better. > KDeclarative is used from places outside Plasma. A