Review Request 128633: Wether nor not install the private header?

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128633/ --- Review request for Plasma and Sune Vuorela. Repository: prison

[Differential] [Updated, 82 lines] D2372: Make powerdevil normal executable instead of kded module

bshah updated this revision to Diff 5749. bshah marked 2 inline comments as done. bshah added a comment. - Don't install in kf5 libexec dir - Autostart powerdevil only in KDE - Make PowerDevilApp QGuiApplication instead of QObject REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST

[Differential] [Updated, 10 lines] D2374: [kded] fix monitoring for newly appearing outputs

sebas updated this revision to Diff 5747. sebas added a comment. - use unique connection REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2374?vs=5746=5747 BRANCH sebas/newdockoutputs REVISION DETAIL https://phabricator.kde.org/D2374 AFFECTED

[Powerdevil] [Bug 366402] Closing the lid triggers Sleep

https://bugs.kde.org/show_bug.cgi?id=366402 Weng Xuetian changed: What|Removed |Added CC||wen...@gmail.com --- Comment

[Differential] [Request, 10 lines] D2374: [kded] fix monitoring for newly appearing outputs

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch makes the kded daemon monitor also newly connected outputs, and leads to correctly initialize

[Differential] [Requested Changes To] D2345: use a separate configuration per look and feel

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > shellcorona.cpp:321 > > QString dumpconfigGroupJS(const KConfigGroup , const QString > ) > { If we go with this patch you should filter

[Differential] [Commented On] D2345: use a separate configuration per look and feel

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:394 > I'm confused. > > Should you be getting the current from the current Plasma::Applet* instances > or are you loading state from the config file? I'm doing what i can there. every way to get items

[Differential] [Commented On] D2345: use a separate configuration per look and feel

davidedmundson added inline comments. INLINE COMMENTS > shellcorona.cpp:394 > > //try to parse the items geometries > KConfigGroup genericConf(, QStringLiteral("General")); I'm confused. Should you be getting the current from the current Plasma::Applet* instances or

Re: Discussion for libtaskmanager internals

See above - I agree it's nice to have for the optimal case, but the code is essentially written for simplicity and conservativeness (i.e. assume the optimal case won't be hit). I'm fine with someone doing additional engineering effort to optimize the optimal case, but since it will considerably

Re: Selecting a Plasma logo

On Fri, Aug 5, 2016 at 3:40 PM, Andres Betts wrote: > Hey Sebas, > > Thanks for understanding. As I mentioned before my intention is not > necessarily that don't change my proposal but that we can create more > proposals to show variety. We cannot settle just on 2 orignal

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

bdhruve added a comment. In https://phabricator.kde.org/D1989#44333, @graesslin wrote: > > - KeyPress events to send keys. > > > > However, keyevents are not working as it should, if i press 'a' it types something different. > > might be that this is just not possible to send

[Differential] [Commented On] D2345: use a separate configuration per look and feel

mart added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:469 > plasmshell should have a slot for that invoked by the kcm? i could send the notifychange signal of kglobalsettings, but it's kinda ugly, as it uses an integer as parameter to specify what changed, which is

[Differential] [Accepted] D2356: [shell] Add a dbus call to activate the "main" application launcher

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > shellcorona.cpp:1640 > +if (!applet->globalShortcut().isEmpty()) { > +emit applet->activated(); > +return; the way

[Differential] [Changed Subscribers] D2372: Make powerdevil normal executable instead of kded module

shumski added inline comments. INLINE COMMENTS > CMakeLists.txt:135 > > -install(TARGETS kded_powerdevil DESTINATION ${PLUGIN_INSTALL_DIR}/kf5/kded) > +install(TARGETS powerdevil DESTINATION ${CMAKE_INSTALL_FULL_LIBEXECDIR_KF5}) > +install(FILES ${CMAKE_CURRENT_BINARY_DIR}/powerdevil.desktop

[Plasma Workspace Wallpapers] [Bug 366470] Add unsplash wallpapers to KDE

https://bugs.kde.org/show_bug.cgi?id=366470 --- Comment #4 from Sebastian Kügler --- Ah. Why in progress though? Who is working on it? -- You are receiving this mail because: You are the assignee for the bug.

[Differential] [Updated, 306 lines] D2345: use a separate configuration per look and feel

mart updated this revision to Diff 5742. mart added a comment. - remove graphicsobject hack REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2345?vs=5701=5742 BRANCH mart/separateLookAndFeelLayout REVISION DETAIL

[Differential] [Reopened] D2345: use a separate configuration per look and feel

mart reopened this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2345 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, davidedmundson Cc: davidedmundson, ivan, plasma-devel, lesliezhai,

[Plasma Workspace Wallpapers] [Bug 366470] Add unsplash wallpapers to KDE

https://bugs.kde.org/show_bug.cgi?id=366470 --- Comment #3 from Richard Bos --- Indeed Martin. My idea is not to include each and every wallpaper, but to offer the source via ( wallpaper ) plugin(s). Either by making it easily available to the user, or as a dynamic

[Differential] [Closed] D2345: use a separate configuration per look and feel

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE2ddde5efc1e3: remove graphicsobject hack (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2345?vs=5742=5743#toc REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Commented On] D1989: Introduce QQuickItem to nest kwin_wayland

graesslin added a comment. > - KeyPress events to send keys. > > However, keyevents are not working as it should, if i press 'a' it types something different. might be that this is just not possible to send key events like that. In general QKeyEvent delivers the keysym. That is

[Plasma Workspace Wallpapers] [Bug 366470] Add unsplash wallpapers to KDE

https://bugs.kde.org/show_bug.cgi?id=366470 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org ---

[Differential] [Commented On] D2372: Make powerdevil normal executable instead of kded module

bshah added a comment. Something is wrong with this on wayland, I don't see battery and brightness applet and powerdevil executable seems to exit safely if I remove it.. Here is log of powerdevil executable https://ptpb.pw/9Jtd.. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL

[Differential] [Request, 107 lines] D2372: Make powerdevil normal executable instead of kded module

bshah created this revision. bshah added reviewers: Plasma, broulik, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This will allow kwin to grant permission to powerdevil which no other application should

[Differential] [Closed] D2371: [Wayland] Make it possible to have internal windows decorated

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN981b31232335: [Wayland] Make it possible to have internal windows decorated (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2371?vs=5739=5740

[Plasma Workspace Wallpapers] [Bug 366470] Add unsplash wallpapers to KDE

https://bugs.kde.org/show_bug.cgi?id=366470 Sebastian Kügler changed: What|Removed |Added CC||se...@kde.org

[Differential] [Accepted] D2371: [Wayland] Make it possible to have internal windows decorated

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKWIN KWin BRANCH internal-window-deco REVISION DETAIL https://phabricator.kde.org/D2371 EMAIL PREFERENCES

[Differential] [Request, 59 lines] D2371: [Wayland] Make it possible to have internal windows decorated

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland, sebas. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY With this change KWin can create window decorations for

Re: Review Request 128473: Avoid recursive calls to QPlatformTheme::createPlatformSystemTrayIcon()

> On July 19, 2016, 4:02 a.m., David Edmundson wrote: > > KStatusNotifierItemPrivate::setLegacySystemTrayEnabled(bool enabled) > > already has a recursion check added in > > b45544f3d4dd9cb1873b92a609f45a68f5f6e471 (in knotifications) - which > > basically checks if we're using the KDE

Re: Discussion for libtaskmanager internals

On 08/05/2016 06:12 PM, Michail Vourlakos wrote: > Is this the intended behavior? Yes. A stable lifecycle in the view is achieved by the combination of two effects: The appearance of certain items causes items "earlier" in the lifecycle to be filtered out and sorting things into the same place

[Differential] [Closed] D2369: Convert powerdevil backends to proper plugins

This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL2e2faec92053: Convert powerdevil backends to proper plugins (authored by bshah). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2369?vs=5734=5738

[Differential] [Closed] D2338: [Kickoff] Fix start row for drag not always being correct

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP5eaadb75de3d: [Kickoff] Fix start row for drag not always being correct (authored by net147, committed by bshah). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2338?vs=5642=5737#toc

[Differential] [Closed] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP784b07f26ae8: [Kickoff] Fix being unable to reorder entries in favorites menu after… (authored by net147, committed by bshah). CHANGED PRIOR TO COMMIT

[Differential] [Updated, 159 lines] D2369: Convert powerdevil backends to proper plugins

bshah updated this revision to Diff 5734. bshah marked 4 inline comments as done. bshah added a comment. fixed minor coding style issues and make code failsafe REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2369?vs=5732=5734 BRANCH

[Differential] [Updated] D2369: Convert powerdevil backends to proper plugins

bshah marked an inline comment as done. bshah added a comment. Fixed issues.. REPOSITORY rPOWERDEVIL Powerdevil BRANCH bshah/proper-backends REVISION DETAIL https://phabricator.kde.org/D2369 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah,

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 312 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/312/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 Aug 2016 08:52:10 + Build duration: 8 min 39 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 312 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/312/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 Aug 2016 08:52:10 + Build duration: 8 min 39 sec CHANGE SET Revision

Re: unexpected "show desktop" shortcut (KDE4)

On Saturday, 6 August 2016 10:24:13 BST René J.V. Bertin wrote: > Hi, > > I hit an accidental and as yet unidentified shortcut and am now seeing a > "Show Desktop" entry in the task switcher. I'm 95% sure I deactivated the > "Show Desktop Icon" option in the task switcher settings. Is there a >

Re: Selecting a Plasma logo

Hey Sebastian, Let me explain the reasons about changing the logo and what stage this is at. In my personal view, after working for some time on coming up with a new logo proposal, we received a few comments and changes to it that, to me, had no backing. One idea was shared that others wanted my

Re: Selecting a Plasma logo

Hey Sebas, Thanks for understanding. As I mentioned before my intention is not necessarily that don't change my proposal but that we can create more proposals to show variety. We cannot settle just on 2 orignal proposals and then merge the two to see what comes out. I am pretty sure there many

[Differential] [Accepted] D2369: Convert powerdevil backends to proper plugins

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Looks good to me. > wayland Wayland would still use upower but instead of having XRandRBrightness only use sysfs, this needs some more thought on how we could split that in the

[Differential] [Updated, 147 lines] D2369: Convert powerdevil backends to proper plugins

bshah updated this revision to Diff 5732. bshah added a comment. remove unused stray function loadBackends REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2369?vs=5731=5732 BRANCH bshah/proper-backends REVISION DETAIL

[Differential] [Request, 153 lines] D2369: Convert powerdevil backends to proper plugins

bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This converts the powerdevil backends into proper plugins that are loaded at runtime instead of just

[Differential] [Accepted] D2338: [Kickoff] Fix start row for drag not always being correct

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. There's still something off when I drag a bottom favorite to the top if often ends up in the wrong place or doesn't move at all. This is with and without this patch, so looks good to me.

[Differential] [Accepted] D2337: [Kickoff] Fix being unable to reorder entries in favorites menu after scrolling down

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2337 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: net147, bshah, #plasma, broulik

[Differential] [Closed] D2352: Change default wallpaper plugin to org.kde.color

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENLOCKERebd785d0ba22: Change default wallpaper plugin to org.kde.color (authored by graesslin). REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 311 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/311/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 08 Aug 2016 07:23:04 + Build duration: 17 min CHANGE SET Revision

[Differential] [Closed] D2234: [platforms/x11] Support output removal in nested setup

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINa902ba8ea30d: [platforms/x11] Support output removal in nested setup (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2234?vs=5349=5728

[Differential] [Closed] D2353: Change the default color in the color wallpaper plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEd61bb962a1be: Change the default color in the color wallpaper plugin (authored by graesslin). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2359: [libinput] Add support for gesture events

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN8a83a6fef56a: [libinput] Add support for gesture events (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2359?vs=5693=5726 REVISION DETAIL

Review Request 128626: silence contentHash deprecation warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128626/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage