[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

https://bugs.kde.org/show_bug.cgi?id=366608 Martin Gräßlin changed: What|Removed |Added Status|UNCONFIRMED |CONFIRMED Ever

[Differential] [Request, 2 lines] D2413: Trigger global shortcuts also on key-repeat

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY Restores feature parity with X11. Global shortcuts need to trigger

[Differential] [Request, 1 line] D2412: [applets] Show battery monitor on all platforms and not just desktop

bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This will also enable battery monitor on mobile. See also: https://phabricator.kde.org/D2411

Re: stylesheed folders

I think I will revert the folder stylesheed stuff. Thanks for your feedback and that you help me find a solution. As it's nice and I already blog about it where should I store this feature? cheers Andreas

[Differential] [Changed Subscribers] D2399: New new SDDM theme

bshah added inline comments. INLINE COMMENTS > davidedmundson wrote in KeyboardButton.qml:13 > It was...though that broke when this folder was moved. Good spot. I wonder if it ever worked to translate those in SDDM? Given KDeclarative takes care of loading translation domain IIRC. REPOSITORY

[Differential] [Changed Subscribers] D2411: Remove clone of battery monitor from plasma-phone-components

bshah added a subscriber: plasma-devel. REPOSITORY rPLASMAPHONECOMPONENTS plasma-phone-components REVISION DETAIL https://phabricator.kde.org/D2411 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, #plasma, broulik, mart Cc: plasma-devel

[Differential] [Updated, 5,202 lines] D2409: Update Color KCM

ochurlaud removed rPLASMADESKTOP Plasma Desktop as the repository for this revision. ochurlaud updated this revision to Diff 5843. ochurlaud added a comment. Added a desktop file, finished the app (KAboutData, CommandLineParser,...) Ready to ship, I just wait for your remarks. CHANGES

[Differential] [Commented On] D2399: New new SDDM theme

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in KeyboardButton.qml:13 > is this domain valid for sddm as well? It was...though that broke when this folder was moved. Good spot. > mart wrote in UserDelegate.qml:85 > this version you have is probably is significantly faster

Review Request 128660: Add an optional reveal password button to TextField

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128660/ --- Review request for KDE Frameworks and Plasma. Repository:

[Differential] [Commented On] D2409: Update Color KCM

ochurlaud added a comment. In https://phabricator.kde.org/D2409#45058, @whiting wrote: > I like it. Nice work. I agree I would change Config Scheme to Edit Scheme. Done locally. The executable is now KColorSchemeEditor. If someone could tell me what the

[Differential] [Commented On] D2409: Update Color KCM

whiting added a comment. I like it. Nice work. I agree I would change Config Scheme to Edit Scheme. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud,

[Differential] [Updated] D2409: Update Color KCM

mart added a comment. as a name, what about the whoefully uninspiring kcolorschemeeditor? :) I would like it in plasma-sdk. even keeping it there for a while is fine, it's just important that it's shipped when the new kcm is in, to not have a release with feature loss REPOSITORY

[Differential] [Commented On] D2345: use a separate configuration per look and feel

mart added inline comments. INLINE COMMENTS > ivan wrote in shellcorona.cpp:550 > I agree with Martin. If the user is crazy enough... > > D-Bus was never really meant to be something that the users should be calling > directly anyhow. yeah, agree so,, I'm thinking about exposing 2

[Differential] [Commented On] D2399: New new SDDM theme

mart added inline comments. INLINE COMMENTS > KeyboardButton.qml:13 > > -text: instantiator.objectAt(currentIndex).shortName > +text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Keyboard Layout: > %1", instantiator.objectAt(currentIndex).shortName) > implicitWidth:

[Differential] [Commented On] D2399: New new SDDM theme

mart added a comment. In https://phabricator.kde.org/D2399#45044, @davidedmundson wrote: > Screenshot as requested. > > F255167: Spectacle.h20090.png > > Note the coloured icons for actions will be changing when Andreas pushes some change.

[Differential] [Commented On] D2399: New new SDDM theme

mart added a comment. In https://phabricator.kde.org/D2399#44873, @apol wrote: > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme after all. but also working QML code, that means, it must be maintained. if there are volunteers, awesome, if it stays

Re: stylesheed folders

On Thursday 11 August 2016 17:48:05 Ivan Čukić wrote: > What does the window decoration have in common with a folder? > > This is my screenshot: > https://share.kde.org/index.php/s/l1eQjahyNee0sbO > I liked the idea, but yeah, seeing it in action goes from "extremely cool" to corner cases where

[Differential] [Commented On] D2409: Update Color KCM

colomar added a comment. The KCM looks okay for a first iteration, although for the future, it would make more sense to design it like the Look And Feel or Desktop Theme KCMs, with a grid of bigger previews instead of list + one big preview. What I'd change right now is Config Scheme ->

[Differential] [Commented On] D2399: New new SDDM theme

davidedmundson added a comment. Screenshot as requested. F255167: Spectacle.h20090.png Note the coloured icons for actions will be changing when Andreas pushes some change. Also I have some unresolved comments here:

[Differential] [Closed] D2341: Lazy guard for KServiceGroup::root() being null.

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPe1f5e0304d10: Lazy guard for KServiceGroup::root() being null. (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: stylesheed folders

What does the window decoration have in common with a folder? This is my screenshot: https://share.kde.org/index.php/s/l1eQjahyNee0sbO Cheers, Ivan

[Differential] [Request, 10 lines] D2410: [wayland] Properly implement minimize of ShellClient

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY We need to call Workspace::clientHidden when minimizing. Otherwise

libtaskmanager, QIconItem, Timers cannot be stopped from internal code ?

Hello, I am using the new libtasksmanager with QIconItems for the tasks. For a few days I receive the following error when I close the plasmawindowed application: QObject::~QObject: Timers cannot be stopped from another thread and from plasmashell: QObject::startTimer: Timers cannot be

[Differential] [Closed] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP817b27f44d4a: [Applet Configuration] Match category sidebar style with Breeze widget… (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2398?vs=5838=5839#toc

[Differential] [Updated, 196 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5838. broulik added a comment. Let Layouts do the size calculations more REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2398?vs=5834=5838 REVISION DETAIL https://phabricator.kde.org/D2398 AFFECTED

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

colomar added a comment. Looks great now, thank you for digging into the focus stuff! REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2398 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D2409: Update Color KCM

ochurlaud added a comment. In https://phabricator.kde.org/D2409#45025, @andreaska wrote: > Thanks Oliver, > > can you post some screenshots cause I can't compile it. Updated REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL

[Differential] [Updated] D2409: Update Color KCM

ochurlaud updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, #plasma, mart, andreask, #vdg Cc: andreaska,

[Differential] [Accepted] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. Seems good. INLINE COMMENTS > AppletConfiguration.qml:219 > + > +Column { > +id: categories If you make this this a ColumnLayout the

[Differential] [Commented On] D2409: Update Color KCM

andreaska added a comment. Thanks Oliver, can you post some screenshots cause I can't compile it. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 5,159 lines] D2409: Update Color KCM

ochurlaud created this revision. ochurlaud added reviewers: Plasma, mart, andreask, VDG. ochurlaud set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As

Re: Animate removal from Positioner?

On 10/08/2016 09:23 μμ, Kai Uwe Broulik wrote: Hi, the thing with positioners like Grid and the like is that they're dumb, ie. the item is just gone right away and thus cannot be animated. ListView keeps the item around to animate it but is probably overkill for your usecase. after 12

[Differential] [Updated, 179 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5834. broulik added a comment. Replicate fainter colors when window has no focus (QtQuick Controls don't do that unfortunately but the sidebar does that which is the most prominent part of the window, color-wise) REPOSITORY rPLASMADESKTOP Plasma

Re: Animate removal from Positioner?

A shaderitem that isn't live (so keeps the rendered item seemingly around), use that to render the removal animation while the delegate is already deleted could work. in that case the next to it and before items would ingnore it, so the animation would be very strange... it needs a lot

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

https://bugs.kde.org/show_bug.cgi?id=366608 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org ---

[Differential] [Commented On] D2399: New new SDDM theme

davidedmundson added a comment. In https://phabricator.kde.org/D2399#44873, @apol wrote: > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme after all. Maybe, but this patch is against the SDDM theme that was nearly in 5.7, the old theme was already

Re: stylesheed folders

the contrast shouldn't be the problem cause I'd like to use the select background color (already done) and the select text color (not selected now) sebas screenshot. look the same at my desktop. it would be a bug that was shown with the stylesheed stuff. Yes it is something like cause we can,

[Differential] [Updated, 171 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated the summary for this revision. broulik updated this revision to Diff 5832. broulik added a comment. When tabbing through the dialog, ensure the item with focus is visible, scrolling if neccessary REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Re: stylesheed folders

+1 (for sebas' comment, not for the rainbow folders) I don't mind the idea of being able to customize folder colours, but I don't think that it should be done like this - we do not have the 'folder colour' settings in the colour scheme settings, which means that some other colour will be used to

Re: stylesheed folders

On Thursday, August 11, 2016 12:17:49 PM UTC Sebastian Kügler wrote: > Did you test this with app-specific color schemes? > This I assume is only for the default folders, but what about the folder > icons that are already colored? If I'm using a green folder, and then > change the highlight color

Minutes Monday Plasma Hangout

Sorry for the delay... Minutes Plasma 'hangout', 8-8-2016, 12:00 CET Present: mgraesslin, bshah, Sho, sebas, notmart, Riddell, romangg, kbroulik bshah: * cleaned up patch to powerdevil: https://phabricator.kde.org/D2369 * Debugging the kaccounts and spacebar on phone Sho: - Minor changes to

Re: stylesheed folders

On Thursday, August 11, 2016 12:58:25 AM UTC kainz.a wrote: > since a few days you can find in breeze-icons the posibility that folders > follow the color scheme colors. > > https://kdeonlinux.wordpress.com/2016/08/08/rainbow-folders/ > > As visual changes for folders are very importend for the

Re: Review Request 128313: useraccount icons 128 px and sorted

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128313/#review98313 --- Some names are now not centered under their images. Could

Re: Animate removal from Positioner?

On Wednesday, August 10, 2016 8:24:15 PM UTC Marco Martin wrote: > On Wednesday 10 August 2016 21:18:43 Michail Vourlakos wrote: > > I am creating an alternative plasmoid for tasks and I would like your > > wisdom around QML please.. > > > > > > At some point of my code I am using a

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128654/ --- (Updated Aug. 11, 2016, 11:49 vorm.) Review request for Plasma, David

[Differential] [Request, 25 lines] D2407: [libinput] Expose all input devices through DBus

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY The Connection exposes a new service called

Re: Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128654/#review98311 --- >Unfortunately I couldn't figure out a way to tell whether

[Differential] [Updated, 143 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5829. broulik added a comment. Disable activeFocusOnTab for the content ScrollView, when tabbing from the categories bar we should focus the first control in the page rather than the content ScrollView (it having focus isn't even visible because it

Review Request 128654: [Breeze widget style] Enable focus underline for QtQuick Controls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128654/ --- Review request for Plasma, David Rosca and Hugo Pereira Da Costa.

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik added a comment. F254921: Screenshot_20160811_125837.png REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2398 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 140 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5827. broulik added a comment. More closely match focus behavior of Breeze widget style: Only if the sidebar has focus and the item is current will it get intense blue, white text and selected icon state, otherwise it's a fainter blue with black text

[Differential] [Updated, 111 lines] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik updated this revision to Diff 5826. broulik added a comment. Implement focus handling for category sidebar to match System Settings: - If it has focus the line uses a strong blue and arrow keys can be used to switch between pages - If it has no focus, the line is fainter -

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik added a comment. F254909: Screenshot_20160811_124328.png Fainter blue when it doesn't have focus REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2398 EMAIL PREFERENCES

[Differential] [Commented On] D2404: [Task Manager ToolTipDelegate] If there's room, show two lines of window title

andreaska added a comment. is it possible to have the text two lines the same height than the app icon? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2404 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 4 lines] D2404: [Task Manager ToolTipDelegate] If there's room, show two lines of window title

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If no subtext

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik added a comment. > In System Settings, the full highlight color is only used on the sidebar when it is currently focused Yeah, noticed that, but focus handling in QML is just broken beyond repair so I didn't bother with that. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION

Re: Selecting a Plasma logo

Hi all, For anyone interested I've also posted the SVG file (Andreas asked for it): https://share.kde.org/index.php/s/0HRcGXCt6UCEWxp Cheers, Ivan

[Differential] [Commented On] D2345: use a separate configuration per look and feel

ivan added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:550 > I hate this method. > tough, i need a way from the kcm to reset the current layout to the default. > it's quite dangerous and exporting a dbus method that effectively destroys > the current config is evil... >

[Differential] [Accepted] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

andreaska accepted this revision. andreaska added a reviewer: andreaska. andreaska added a comment. This revision is now accepted and ready to land. +1 for the design improvement REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2398 EMAIL PREFERENCES

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

colomar added a comment. I'm glad that you're fixing this inconsistency! Just for clarification since it can't be seen from the screenshots: In System Settings, the full highlight color is only used on the sidebar when it is currently focused. When the main window area is focused

[Differential] [Request, 84 lines] D2402: [wayland] Unset focused keyboard surface when handling key event internally

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY So far when KWin intercepted a key event a leave was not sent to

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

broulik added a comment. F254624: Screenshot_20160811_093330.png Also on low-dpi looks identical to System Settings spacing-wise REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2398 EMAIL PREFERENCES

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

https://bugs.kde.org/show_bug.cgi?id=366608 --- Comment #6 from Martin Gräßlin --- > So KWin/Wayland requires non-Qt applications to link with KGlobalAccel to > register shortcuts ? This is getting off-topic. -- You are receiving this mail because: You are the assignee

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 70 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 11 Aug 2016 07:08:13 + Build duration: 10 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.7 stable-kf5-qt5 » Linux,gcc - Build # 70 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.7%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/70/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 11 Aug 2016 07:08:13 + Build duration: 10 min CHANGE SET Revision

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

https://bugs.kde.org/show_bug.cgi?id=366608 --- Comment #5 from Matthias Fauconneau --- I think notifying release events would be a better solution since it would allow smoother/finer brightness adjustments than the low rate of key repeats. So KWin/Wayland

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

https://bugs.kde.org/show_bug.cgi?id=366608 --- Comment #4 from Martin Gräßlin --- KGlobalAccel actions are only triggered on press events. There is no additional call when they are released. I played a little bit with my system and there the brightness key sends

[Differential] [Closed] D2396: [Pager] Hide minimized windows

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP092aeb53d36e: [Pager] Hide minimized windows (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2396?vs=5811=5819

[Differential] [Changed Subscribers] D2345: use a separate configuration per look and feel

graesslin added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:550 > I hate this method. > tough, i need a way from the kcm to reset the current layout to the default. > it's quite dangerous and exporting a dbus method that effectively destroys > the current config is evil...

[Powerdevil] [Bug 366608] Brightness keyboard action does not repeat while key is pressed under Wayland

https://bugs.kde.org/show_bug.cgi?id=366608 --- Comment #3 from Matthias Fauconneau --- I think not repeating global shortcuts is the correct behaviour. Still it would make sense for PowerDevil to be notified when the shortcut is released. I am not clear on how

Re: Selecting a Plasma logo

Hi, When I said that I don't really find any of these fitting as a launcher icon, I obviously excluded the K-gear logo - was thinking about the new proposals. Though, the fact that K-gear looks better than the rest might be because we are all accustomed to that one. The same goes for the current