D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-20 Thread Nathaniel Graham
ngraham added a subscriber: bshah. ngraham added a comment. @bshah I think you said you wanted to see how this worked for PlaMo before I landed it? Have you had a chance to do that yet? REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

2020-04-20 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 80719. apol added a comment. Proper initialisation REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80663=80719 BRANCH master REVISION DETAIL

D29033: Remove duplicated code

2020-04-20 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Went through it while reviewing some code. TEST PLAN Been running it for a while, including direct

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread Roman Gilg
romangg added a comment. In D29028#653192 , @apol wrote: > I don't really see why we'd want to support something that is not offering ABI stability and doesn't push Plasma in any direction. It is offering in the same way ABI stability as

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. I don't really see why we'd want to support something that is not offering ABI stability and doesn't push Plasma in any direction. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D29028 To:

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread Roman Gilg
romangg added a comment. In D29028#653150 , @davidedmundson wrote: > I don't see why we should have that in KDE code. Come on man, do you really want to make this ugly? I thought we would still treat each other with respect David. :(

D28873: Add SwipeNavigator component

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. In D28873#653148 , @cblack wrote: > IMO, the affordances of a traditional tab style hint at tabs being editable. This is fairly established: Chrome uses the traditional tab style for its user-manipulatable tabs, while

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't see why we should have that in KDE code. As per manifesto > The project stays true to established practices common to similar KDE projects

D28873: Add SwipeNavigator component

2020-04-20 Thread Carson Black
cblack added a comment. In D28873#652727 , @ngraham wrote: > "Lateral navigation" is basically a tabbed view. So to me this looks like a tabbed view with a different UI for the tabs. We've actually needed a tabbed view component for a while:

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella
tfella updated this revision to Diff 80714. tfella marked an inline comment as done. tfella added a comment. Change id REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80689=80714 BRANCH mobileHotspotKcm REVISION DETAIL

D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-04-20 Thread Roman Gilg
romangg added a comment. In D29024#653096 , @davidedmundson wrote: > KScreen already is a plugin system. You mean libkscreen? It has a plugin system for differentiating between windowing systems, yes. > We don't need to go all

D28688: Document Kirigami::Icon

2020-04-20 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R169:9dba4c8b1583: Document Kirigami::Icon (authored by cblack). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28688?vs=79787=80709#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D28666: Refactor for loops

2020-04-20 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R169:6a0535050b8c: Refactor for loops (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28666?vs=79642=80710 REVISION DETAIL

D28949: Add titlebar colors to Kirigami::PlatformTheme

2020-04-20 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R169:0d5d94ebe086: Add titlebar colors to Kirigami::PlatformTheme (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28949?vs=80476=80708 REVISION

D29029: feat(wayland): add plugin for wlroots based compositors

2020-04-20 Thread Roman Gilg
romangg added a comment. Test on sway. - I noticed one issue with that. KScreen is not at all styled in a sway session. Kai helped me out with that. I needed to set the env var XDG_CURRENT_DESKTOP=KDE. I find this rather a broken

D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-04-20 Thread David Edmundson
davidedmundson added a comment. KScreen already is a plugin system. We don't need to go all inception, and have a plugin load plugins. It doesn't look to bring anything other than complexity. If there is any duplication, we can just add some extra base classes in the lib using the

D29029: feat(wayland): add plugin for wlroots based compositors

2020-04-20 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds a plugin that uses the Wrapland library to interact with compositors supporting the

D29028: feat(wayland): add Wrapland plugin

2020-04-20 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Adds a plugin that uses the Wrapland library to interact with compositors supporting the

D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-04-20 Thread Roman Gilg
romangg updated this revision to Diff 80700. romangg added a comment. Cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29024?vs=80698=80700 BRANCH wayland-plugins REVISION DETAIL https://phabricator.kde.org/D29024 AFFECTED FILES

D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-04-20 Thread Roman Gilg
romangg added inline comments. INLINE COMMENTS > CMakeLists.txt:28 > +TARGETS LibkscreenWaylandPluginKWayland > +DESTINATION ${PLUGIN_INSTALL_DIR}/org.kde.libkscreen.backends/wayland/ > +) That directory fine or are there other suggestions? I would like to centralize over time all

D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-04-20 Thread Roman Gilg
romangg updated this revision to Diff 80698. romangg added a comment. Cleanup REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29024?vs=80695=80698 BRANCH wayland-plugins REVISION DETAIL https://phabricator.kde.org/D29024 AFFECTED FILES

D29022: Update the visiblity check for ActionToolbar by checking width with less-"equal".

2020-04-20 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes. Closed by commit R169:f9d31febf87e: Update the visiblity check for ActionToolbar by checking width with less… (authored by xuetianweng). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D29022: Update the visiblity check for ActionToolbar by checking width with less-"equal".

2020-04-20 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice job! I was actually just about to submit this exact diff. :) REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D29022 To: xuetianweng,

D29024: feat(wayland): support multiple protocol extensions through plugin system

2020-04-20 Thread Roman Gilg
romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY Besides the KWayland output-management protocol there exist other protocol extensions for

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Jan Grulich
jgrulich accepted this revision. jgrulich added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main.qml:39 > +Controls.Switch { > +id: enabled > +Kirigami.FormData.label: i18n("Enabled:") Using adjective as an ID looks weird

D29022: Update the check for ActionToolbar by checking with less-"equal".

2020-04-20 Thread Xuetian Weng
xuetianweng created this revision. xuetianweng added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. xuetianweng requested review of this revision. REVISION SUMMARY Otherwise some action, especially when there is only one action, it will be

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella
tfella updated this revision to Diff 80689. tfella added a comment. fix REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80688=80689 BRANCH mobileHotspotKcm REVISION DETAIL https://phabricator.kde.org/D29019 AFFECTED

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella
tfella added a comment. Git/Arc decided to do weird things, I hope I didn't break it REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29019 To: tfella, #vdg, jgrulich Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella
tfella updated this revision to Diff 80688. tfella marked 6 inline comments as done. tfella added a comment. Fixes REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80683=80688 BRANCH mobileHotspotKcm REVISION DETAIL

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +project (kcm_mobile_hotspot) > + remove > CMakeLists.txt:11 > +KF5::I18n > +KF5::Plasma > +KF5::QuickAddons KF5::Plasma shouldn't be needed > hotspotsettings.cpp:30 > +{ > +KAboutData* about = new

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Here's how it looks with the old KCM: F8249724: Screenshot_20200420_125405.png So my KDE Daemon category has one entry in French for some odd reason. And the two KRunner entries are indeed still there and different, not

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella
tfella updated this revision to Diff 80683. tfella added a comment. Whitespace fix REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80679=80683 BRANCH mobileHotspotKcm (branched from master) REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre added a comment. In D28744#652854 , @ngraham wrote: > Yay. Almost there! I just see a few more things: > > 1. If I delete a whole item from the left-most list, there's no obvious way to get it back (what if I delete a system entry by

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread Björn Feber
GB_2 added a comment. Nitpick: put the "Add Application..." button on the left (T10384 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28744 To: davidre, #vdg, #plasma Cc: GB_2, broulik, davidedmundson, nicolasfella,

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella
tfella created this revision. tfella added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. tfella requested review of this revision. REVISION SUMMARY Implements T12895 . Might

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80675. davidre added a comment. - Implement Kai's idea for importing - Fix importing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80673=80675 BRANCH kcmkeys2 (branched from master) REVISION

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Yay. Almost there! I just see a few more things: 1. If I delete a whole item from the left-most list, there's no obvious way to get it back (what if I delete a system entry by accident?) 2. The Defaults button is present, but always disabled 3. I see

D28651: Load and use global animation settings

2020-04-20 Thread Nathaniel Graham
ngraham added a subscriber: cblack. ngraham added a comment. Works for me now. @hpereiradacosta, @ndavis, and @cblack, are you okay with this? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28651 To: sandsmark, #breeze Cc: cblack, davidedmundson, ngraham,

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80673. davidre added a comment. - Fix scrollview and use level 3 heading - use better string REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80672=80673 BRANCH kcmkeys2 (branched from master)

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre marked an inline comment as done. davidre added a comment. In D28744#652703 , @ngraham wrote: > Clicking the Apply button makes System Settings crash for me: Fixed now. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80672. davidre added a comment. - Fix errors and leave error message disabled REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80631=80672 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28978: [PluginLoader] Replace one usage of QRegExp with QString::startsWith()

2020-04-20 Thread Ahmad Samir
ahmadsamir abandoned this revision. ahmadsamir added a comment. Talking with kbroulik on irc confirms your POV, the format of those patterns aren't documented anywhere so changing the matching now would change the behaviour... I'll abandon this, (I suggest that X-Plasma-DropUrlPatterns

D28627: Adaptive panel opacity

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. In D28627#652538 , @niccolove wrote: > Actually -- this seems to no longer apply panel internal margins? Works for me. In terms of the UI and the scope, I have to agree with @apol though, and maybe go a bit

D28888: Fix navigation regressions

2020-04-20 Thread Marco Martin
mart added a comment. btw may be worth trying to have a stackview that switches between this view and the one before based on page with (wideMode property of pagerow) REPOSITORY R1014 Kirigami Gallery REVISION DETAIL https://phabricator.kde.org/D2 To: cblack, #vdg, #kirigami Cc:

D28888: Fix navigation regressions

2020-04-20 Thread Marco Martin
mart added a comment. if there can't be a super smooth transition between a listview and this thing (perhaps with a stackview, but i'm not sold) then there should always be just the cardlayout with the same cards look, just as a single column REPOSITORY R1014 Kirigami Gallery REVISION

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

2020-04-20 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 80663. apol added a comment. Adadpt to changes in kwayland D28882 REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80408=80663 BRANCH

D28873: Add SwipeNavigator component

2020-04-20 Thread Marco Martin
mart added a comment. In D28873#652747 , @ngraham wrote: > Like you mentioned, don't we want to use the tabbed sidebar view thingy for that? i think it probably depends from the app both from tab numbers and semantics of the app?

D28873: Add SwipeNavigator component

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Like you mentioned, don't we want to use the tabbed sidebar view thingy for that? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To: cblack, #kirigami, #vdg, ngraham Cc: ngraham, niccolove, mart, ndavis, camiloh, plasma-devel,

D28873: Add SwipeNavigator component

2020-04-20 Thread Marco Martin
mart added a comment. This patch is about having the whole app navigation as a tabbed thing, so more like tabs in a webbrowser than a generic tabview (with frame and all which this shouldn't have) so they are 2 different things: i still think a drop in replacement for a tabview will be

D28971: Persist state between launches

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. In D28971#652708 , @mart wrote: > my concern here using qsettings in this place, is that then it kinda clashes when an application uses its own config like it should, from a framework (kconfiggroup, kconfigskeleton

D28949: Add titlebar colors to Kirigami::PlatformTheme

2020-04-20 Thread Marco Martin
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. ok, thanks for the clarification REPOSITORY R169 Kirigami BRANCH cblack/tools-area (branched from master) REVISION DETAIL https://phabricator.kde.org/D28949 To: cblack, #kirigami, mart

D28949: Add titlebar colors to Kirigami::PlatformTheme

2020-04-20 Thread Marco Martin
mart added a comment. what's the "tools area"? are there other use cases than client side decorations? (which we don't want to support) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28949 To: cblack, #kirigami Cc: mart, plasma-devel, fbampaloukas, GB_2,

D28873: Add SwipeNavigator component

2020-04-20 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. "Lateral navigation" is basically a tabbed view. So to me this looks like a tabbed view with a different UI for the tabs. We've actually needed a tabbed view component for a

D28873: Add SwipeNavigator component

2020-04-20 Thread Marco Martin
mart added a comment. In D28873#649459 , @niccolove wrote: > My opinion from the consistency side: I actually think this is a good possibility for the Consistency goal. After some digging around, my opinion is that > > > Tabs should only

D28971: Persist state between launches

2020-04-20 Thread Carson Black
cblack added a comment. In D28971#652708 , @mart wrote: > i always refrained from using any form of config read/write here, and i think we should continue to do so. Are you referring to the gallery (this patch) or to Kirigami?

D28971: Persist state between launches

2020-04-20 Thread Marco Martin
mart added a comment. my concern here using qsettings in this place, is that then it kinda clashes when an application uses its own config like it should, from a framework (kconfiggroup, kconfigskeleton etc) i always refrained from using any form of config read/write here, and i think

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Clicking the Apply button makes System Settings crash for me: P591 System Setting scrash log INLINE COMMENTS > main.qml:118 > +icon.width: Kirigami.Units.iconSizes.small > +

D28945: PageRouter autotests fixes

2020-04-20 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R169:845f282d2d40: PageRouter autotests fixes (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28945?vs=80470=80660 REVISION DETAIL

D29012: Fix variable mixup

2020-04-20 Thread David Redondo
davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Caused icons to be not longer recolored when changing the color scheme until an application is started again TEST PLAN Change

D28842: Raise size of default fixed-width font from 9 to 10pt

2020-04-20 Thread Björn Feber
GB_2 added a comment. Thanks for this :-) REPOSITORY R119 Plasma Desktop BRANCH even-bigger-hack (branched from master) REVISION DETAIL https://phabricator.kde.org/D28842 To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole, ndavis Cc: GB_2, plasma-devel, Orage, LeGast00n,

D28785: Don't request blur when panel is opaque

2020-04-20 Thread Anthony Fieroni
anthonyfieroni added inline comments. INLINE COMMENTS > panelview.cpp:1015 > > QQuickItem *rootObject = this->rootObject(); > if (rootObject) { You have it as `casted` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28785 To: cblack,

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

2020-04-20 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R119:dfc144bf3f45: Port desktoptheme, icons and workspace KCMs to SettingStateBinding (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28985: [Kickoff] Disable tabBar's mouseArea when searching

2020-04-20 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:020c67fc8ba3: [Kickoff] Disable tabBars mouseArea when searching (authored by trmdi, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28985: [Kickoff] Disable tabBar's mouseArea when searching

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Actually not that I think about it, I'd teach you how, but since we're moving to GitLab in a few weeks, it would be a useless skill so I'll just do it now. :) REPOSITORY R119 Plasma Desktop BRANCH fix-kickoff REVISION DETAIL https://phabricator.kde.org/D28985

D28154: Add users KCM

2020-04-20 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > user_manager.desktop:9 > +X-KDE-Weight=40 > +X-KDE-System-Settings-Parent-Category=personalization > +Name=Users You've moved it out of the Account details group. If this is intentional, then we also need to move the KWallet KCM out of that

D28985: [Kickoff] Disable tabBar's mouseArea when searching

2020-04-20 Thread Tranter Madi
trmdi added a comment. In D28985#652097 , @ngraham wrote: > Excellent! > > Please land on the `Plasma/5.18` branch and then merge to master. Let me know if you need a hand with that. Yes, please. I don't know how to do that.

D28154: Add users KCM

2020-04-20 Thread Nathaniel Graham
ngraham added a subscriber: iasensio. ngraham added a comment. @meven this is what it looks like now: F8249229: Screenshot_20200420_074955.png @cblack Mostly okay now, just a few more broken things that need fixing. INLINE COMMENTS >

D28859: Detect QQC2 version at build time with actual detection.

2020-04-20 Thread Xuetian Weng
This revision was automatically updated to reflect the committed changes. Closed by commit R858:aa57b34f75f0: Detect QQC2 version at build time with actual detection. (authored by xuetianweng). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D27669: [kstyle] Tools area

2020-04-20 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Now all of my QtWidgets apps are crashing with a backtrace like this one: Application: Spectacle (spectacle), signal: Segmentation fault Using host libthread_db

D28859: Detect QQC2 version at build time with actual detection.

2020-04-20 Thread Xuetian Weng
xuetianweng added a comment. In D28859#652379 , @davidedmundson wrote: > So the problem we're solving is that we want to go > > Qt5.12 - QQC2.5 > Qt5.13 - QQC2.6 > Qt5.14 - QQC2.7 > Qt5.15 - QQC2.15 > > correct? > > We now

D28859: Detect QQC2 version at build time with actual detection.

2020-04-20 Thread Xuetian Weng
xuetianweng updated this revision to Diff 80646. xuetianweng added a comment. Just fix the version by if-else check. REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28859?vs=80227=80646 BRANCH master REVISION DETAIL

D28710: Make accidental panel and panel widget deletion more difficult

2020-04-20 Thread Nathaniel Graham
ngraham added a comment. Oh gosh, I'm sorry. I didn't mean to to that. :/ Thanks for correcting my mistake! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28710 To: ngraham, #vdg, #plasma, ndavis Cc: mart, davidedmundson, rikmills, broulik, plasma-devel,

D27786: [notifications] Read appname from desktop file if no appname set

2020-04-20 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R120:fd67206ce554: [notifications] Read appname from desktop file if no appname set (authored by nicolasfella). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28625: Use ShadowedRectangle for Card backgrounds

2020-04-20 Thread Arjen Hiemstra
ahiemstra added a comment. In D28625#652529 , @mart wrote: > In D28625#642954 , @cblack wrote: > > > Looks like a nice visual improvement. > > > > Are the changes to the scenegraph stuff related?

D28627: Adaptive panel opacity

2020-04-20 Thread Niccolò Venerandi
niccolove added a comment. Actually -- this seems to no longer apply panel internal margins? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson, plasma-devel, Orage,

D28625: Use ShadowedRectangle for Card backgrounds

2020-04-20 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > AbstractCard.qml:31 > +id: bg > +readonly property color pressedColor: > Qt.tint(Kirigami.Theme.backgroundColor, Qt.rgba( > + > Kirigami.Theme.highlightColor.r, as we have a

D28625: Use ShadowedRectangle for Card backgrounds

2020-04-20 Thread Marco Martin
mart added a comment. In D28625#642954 , @cblack wrote: > Looks like a nice visual improvement. > > Are the changes to the scenegraph stuff related? They don't look like a related change to making the Kirigami.Card use the ShadowedRectangle

D28710: Make accidental panel and panel widget deletion more difficult

2020-04-20 Thread Marco Martin
mart added a comment. I reverted this change in the 5.18 branch, as there shouldn't ever be ui changes in stable branches (unless very, very serious) this change is still valid for master/5.19 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28710 To:

D28154: Add users KCM

2020-04-20 Thread Méven Car
meven added a comment. Is the screenshot current ? ping @ngraham REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: meven, crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag,

D28627: Adaptive panel opacity

2020-04-20 Thread Niccolò Venerandi
niccolove accepted this revision. niccolove added a comment. Works great! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson, plasma-devel, Orage, LeGast00n,

Monday meeting notes for 20/4/2020

2020-04-20 Thread Marco Martin
Nico * We had a virtual Plasma Mobile sprint * Lots of $discussion * Most interesting part was the "training day" which was aimed at new contributors * I gave two talks: "Introduction to Kirigami" and "Porting KDE apps to Android" * some technical difficulties unfortunately * The Plasma Mobile

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

2020-04-20 Thread Ben Cooksley
On Mon, Apr 20, 2020 at 10:29 AM Friedrich W. H. Kossebau wrote: > > Am Sonntag, 19. April 2020, 21:13:01 CEST schrieb Ben Cooksley: > > Hi all, > > > > Another breakage in Qt? > > Should be fixed now (restarted build now completed), with similar traps also > removed for the future, thanks to

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80631. davidre added a comment. Use Nate's string REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80629=80631 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80629. davidre added a comment. - Fix index reset when clicking reset button and use own property for shortcuts listview currentIndex was reset to 0 when resetting, now warnings are generated when switching components need to figure out why

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

2020-04-20 Thread Kai Uwe Broulik
broulik added a comment. > Why not change what the option do ? so how would you reflect a "forever" as a date? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28740 To: broulik, #plasma Cc: bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

2020-04-20 Thread Benjamin Port
bport added a comment. In D28740#652419 , @broulik wrote: > This is for displaying whether do not disturb is on. The "until disabled" option just sets it to one year in the future. But it's odd to show "until 2021", so we don't show the date

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

2020-04-20 Thread Kai Uwe Broulik
broulik added a comment. This is for displaying whether do not disturb is on. The "until disabled" option just sets it to one year in the future. But it's odd to show "until 2021", so we don't show the date when it's too far in the future. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

2020-04-20 Thread Benjamin Port
bport added a comment. According to settings.h documentation When invalid or in the past, do not disturb mode should be considered disabled. So why not setting date to invalid date or one year in the past and do a test if date is in the future REPOSITORY R120 Plasma Workspace

D28990: Port quicklaunch from KRun::run to CommandLauncherJob

2020-04-20 Thread Kai Uwe Broulik
broulik added a comment. > Does this really use KServiceAction anywhere? It doesn't but it should since it also supports jump list ations. Probably needs similar treatment like I did with task manager in D28286 REPOSITORY R114 Plasma Addons

D28461: In sidebar mode show if a module is in default state or not

2020-04-20 Thread Björn Feber
GB_2 added a comment. In D28461#640439 , @The-Feren-OS-Dev wrote: > How about instead of a blue dot there's instead an option in the SySe hamburger button menu to use search to filter out any settings pages where settings haven't been changed,

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80622. davidre added a comment. - Add tooltip to remove toolbutton REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80620=80622 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28744: Rewrite of the global shortcuts kcm

2020-04-20 Thread David Redondo
davidre updated this revision to Diff 80620. davidre added a comment. Make it build again REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80553=80620 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D28859: Detect QQC2 version at build time with actual detection.

2020-04-20 Thread David Edmundson
davidedmundson added a comment. So the problem we're solving is that we want to go Qt5.12 - QQC2.5 Qt5.13 - QQC2.6 Qt5.14 - QQC2.7 Qt5.15 - QQC2.15 correct? We now know all Qt5 versions, and we know that Qt6 won't have versions. I don't see why need this complicated

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-04-20 Thread Méven Car
meven updated this revision to Diff 80616. meven added a comment. Fix for loop REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=80614=80616 BRANCH arcpatch-D28282 REVISION DETAIL https://phabricator.kde.org/D28282 AFFECTED FILES

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

2020-04-20 Thread Méven Car
meven updated this revision to Diff 80614. meven added a comment. Rebasing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=78913=80614 BRANCH arcpatch-D28282 REVISION DETAIL https://phabricator.kde.org/D28282 AFFECTED FILES

D28939: Don't offer sending non-http(s) links and sources via KDE Connect

2020-04-20 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:ec8da2dd5db3: Dont offer sending non-http(s)/ftp links and sources via KDE Connect (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D28965: Support Brave browser

2020-04-20 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R856:257e4dd81f87: Support Brave browser (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28965?vs=80504=80613 REVISION DETAIL

D28629: [WIP] Port KCM to SettingStateBinding

2020-04-20 Thread Cyril Rossi
crossi updated this revision to Diff 80611. crossi added a comment. Work on fonts and style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28629?vs=79508=80611 REVISION DETAIL https://phabricator.kde.org/D28629 AFFECTED FILES

D27669: [kstyle] Tools area

2020-04-20 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > breezestyle.cpp:907 > +auto rect = _helper->toolsAreaToolbarsRect(widget); > +qDebug() << rect; > + Stray qdebug REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma,

D28473: BookmarksRunner: Early return and formatting

2020-04-20 Thread Alexander Lohnau
alex added a comment. Should this(and the following patches) go to a stable branch, because they fix a bug that has been reported (418526)? REPOSITORY R120 Plasma Workspace BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL

  1   2   >