Re: Review Request 126233: Fix extract to desktop:/ by using a StatJob to resolve to local URL

2015-12-03 Thread Elvis Angelaccio
294904 [1], so you could even commit it to Applications/15.12 branch. [1]: https://bugs.kde.org/show_bug.cgi?id=294904 - Elvis Angelaccio On Dec. 3, 2015, 5:29 p.m., Eike Hein wrote: > > --- > This is an automatically generat

How to handle drag-and-drop to the desktop in Plasma 5?

2015-11-30 Thread Elvis Angelaccio
Hi guys, in KDE 4 Ark used to be notified of dropEvents() to the desktop, by having a dbus method called from kde-base/plasma/applets/folderview/iconview.cpp (in particular from the IconView::dropEvent() function). In Plasma 5 this does not work anymore, as kde-base repo has not been ported. But

Re: How to handle drag-and-drop to the desktop in Plasma 5?

2015-12-01 Thread Elvis Angelaccio
2015-12-01 14:13 GMT+01:00 Bhushan Shah : > Hello, > > On Tue, Dec 1, 2015 at 6:39 PM, Marco Martin wrote: > >> > >> In Plasma 5 this does not work anymore, as kde-base repo has not been > >> ported. But I see that drag-and-dropping files from Dolphin to the

Re: Review Request 127012: kio-mtp: port away from deprecated listEntry method

2016-02-08 Thread Elvis Angelaccio
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 8e5464ed809be45b847a08bdf7c9237d1ab44fdf by Elvis Angelaccio to branch master. Repository: kio-extras Description --- As stated in the method's documentation, usage of the true/false argument

Review Request 127012: kio-mtp: port away from deprecated listEntry method

2016-02-08 Thread Elvis Angelaccio
--- Thanks, Elvis Angelaccio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127011: Don't list twice KIO in find_package

2016-02-08 Thread Elvis Angelaccio
--- KIO is currently listed twice in the `find_package` for the frameworks. Diffs - CMakeLists.txt 7dbb38d2afc8fc21d30cc49c4977aeaaf01787b5 Diff: https://git.reviewboard.kde.org/r/127011/diff/ Testing --- Thanks, Elvis Angelaccio

Re: Review Request 127011: Don't list twice KIO in find_package

2016-02-08 Thread Elvis Angelaccio
marked as submitted. Review request for Plasma. Changes --- Submitted with commit 27b0984cfc5b9f8386a0815e4435488cccf9402e by Elvis Angelaccio to branch master. Repository: kio-extras Description --- KIO is currently listed twice in the `find_package` for the frameworks. Diffs

Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
://git.reviewboard.kde.org/r/127643/diff/ Testing --- Thanks, Elvis Angelaccio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
ipv6-after https://git.reviewboard.kde.org/media/uploaded/files/2016/04/13/4ccfd130-99d0-491e-95cb-144cffe10ae7__Spectacle.X19416.png Thanks, Elvis Angelaccio ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
ly, visit: https://git.reviewboard.kde.org/r/127643/#review94571 --- On April 13, 2016, 10:18 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mai

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
- Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127643/#review94574 --- On April 13, 2016, 10:18 a.m., Elvis Angelac

Re: Review Request 127643: Right-align labels in IPv4/IPv6 dialogs

2016-04-13 Thread Elvis Angelaccio
marked as submitted. Review request for Plasma and Jan Grulich. Changes --- Submitted with commit 744a2daa25152fba36d093c0e0a88da496b59650 by Elvis Angelaccio to branch Plasma/5.6. Repository: plasma-nm Description --- The labels in the IPv4/IPv6 tabs (dialogs) are currently right

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread Elvis Angelaccio
> On May 17, 2016, 2:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: The situation of KWallet, and what to do about it?

2016-07-15 Thread Elvis Angelaccio
2016-07-14 1:11 GMT+02:00 Albert Astals Cid <aa...@kde.org>: > El dijous, 7 de juliol de 2016, a les 18:43:57 CEST, Elvis Angelaccio va > escriure: >> Hi, >> thanks for raising this topic! >> >> 2016-07-07 12:36 GMT+02:00 Thomas Pfeiffer <thomas.pfeif.

Re: The situation of KWallet, and what to do about it?

2016-07-07 Thread Elvis Angelaccio
Hi, thanks for raising this topic! 2016-07-07 12:36 GMT+02:00 Thomas Pfeiffer : > Hi everyone, > I'm addressing both the Plasma team and kde-devel because this issue affects > Plasma as well as many applications, and Valentin as the current maintainer > of KWallet as

[Differential] [Commented On] D4475: White list drags from Ark.

2017-02-07 Thread Elvis Angelaccio
elvisangelaccio added a comment. Another possible fix would be to add an empty QUrl to the ark mimeData, i.e. fixing it from the ark side. Question is: are we sure ark is the only application affected by the regression? REPOSITORY R119 Plasma Desktop REVISION DETAIL

[Differential] [Updated, 21 lines] D4480: [kioslave/remote] Fix porting bugs

2017-02-07 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 11019. elvisangelaccio added a comment. - Rebased REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4480?vs=11018=11019 BRANCH bug/376131 REVISION DETAIL https://phabricator.kde.org/D4480 AFFECTED

[Differential] [Request, 23 lines] D4480: [kioslave/remote] Fix porting bugs

2017-02-07 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Commit https://phabricator.kde.org/R120:72e39f083a103e0887624482d6a0ce8b0556dd5e broke the

[Differential] [Closed] D4480: [kioslave/remote] Fix porting bugs

2017-02-07 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R120:566bbf7ba6bc: [kioslave/remote] Fix porting bugs (authored by elvisangelaccio). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4480?vs=11019=11034

[Differential] [Request, 860 lines] D4489: [kioslave/remote] Use kf5 coding style

2017-02-07 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ran `uncrustify-kf5` from kde-dev-scripts. TEST PLAN Builds; still works. REPOSITORY

[kio-extras] [Bug 375552] Search in files does not show results when search string ends with parenthese

2017-01-25 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=375552 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org |plasma

[Differential] [Commented On] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2017-02-22 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > arichardson wrote in kdeplatformfiledialoghelper.cpp:365-370 > I want the version of Qt not KCoreAddons so that won't work. > Do we really need a runtime Qt version check? We link to Qt5PlatformSupport, > is that API stable or do we need

[Differential] [Closed] D4705: Don't assume initialized if there are pending dbus replies

2017-02-22 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R116:2c70ac2a6edd: Don't assume initialized if there are pending dbus replies (authored by elvisangelaccio). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4573: [kioslave/remote] Fix broken kded module

2017-02-20 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R120:2a3b74df7512: [kioslave/remote] Fix broken kded module (authored by elvisangelaccio). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4573?vs=11231=11529

[Differential] [Updated, 899 lines] D3531: Drop kioslave folder, will be in KIO 5.30

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 11556. elvisangelaccio added a comment. Only drop `remote:/` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3531?vs=8573=11556 REVISION DETAIL https://phabricator.kde.org/D3531 AFFECTED FILES

[Differential] [Requested Review] D3531: Drop remote ioslave, will be in KIO 5.32

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma, davidedmundson Cc: bshah, lbeltrame,

[Differential] [Abandoned] D3530: Import plasma-workspace kioslaves

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. I've decided to keep it simple and only move `remote:/` for now. Please continue in https://phabricator.kde.org/D4690. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES

[Differential] [Updated] D3531: Drop remote ioslave, will be in KIO 5.32

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio edited dependencies, added: D4690: Import remote ioslave from plasma-workspace; removed: D3530: Import plasma-workspace kioslaves. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 EMAIL PREFERENCES

[Differential] [Updated] D3530: Import plasma-workspace kioslaves

2017-02-20 Thread Elvis Angelaccio
elvisangelaccio removed a dependent revision: D3531: Drop remote ioslave, will be in KIO 5.32. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #frameworks, #plasma, dfaure Cc: mart, aacid,

[kio-extras] [Bug 376577] Search crashes when started from root folder

2017-02-19 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376577 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Product|dolphin |kio-

[kio-extras] [Bug 376577] filenamesearch crashes when started from root folder

2017-02-19 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376577 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Summary|Search crashes when started |filename

[Differential] [Commented On] D4573: [kioslave/remote] Fix broken kded module

2017-02-17 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4573 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[kio-extras] [Bug 376830] smb share in dolphin is very broken

2017-02-23 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376830 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Version|16.12.0 |unspe

[Differential] [Closed] D4563: Replace warps-slider checkbox with radio buttons

2017-02-23 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R99:57403a78afa2: Replace warps-slider checkbox with radio buttons (authored by elvisangelaccio). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

[Differential] [Request, 8 lines] D4705: Don't assume initialized if there are pending dbus replies

2017-02-21 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY ConnectionEditorBase::initialize() does not count the number of pending dbus replies, so it is currently assuming that if control

[Differential] [Closed] D4594: Don't break compatibility with old configs

2017-02-14 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R99:0a7fafc7e2f4: Don't break compatibility with old configs (authored by elvisangelaccio). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4489: [kioslave/remote] Use kf5 coding style

2017-02-09 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R120:e32b68ed614b: [kioslave/remote] Use kf5 coding style (authored by elvisangelaccio). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4489?vs=11036=11138

[kio-extras] [Bug 375732] Dolphin fails to sftp to Linux box when not a direct connection

2017-02-10 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=375732 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Component|bars: location |d

[Differential] [Closed] D4557: Fix gtk-primary-button-warps-slider with GTK 2

2017-02-10 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R99:4a06c4d34f2d: Fix gtk-primary-button-warps-slider with GTK 2 (authored by elvisangelaccio). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

[Differential] [Request, 4 lines] D4557: Fix gtk-primary-button-warps-slider with GTK 2

2017-02-10 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added reviewers: apol, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Replace true/false with 1/0. The former works only with GTK 3, but breaks with GTK 2

[Differential] [Commented On] D4563: Replace warps-slider checkbox with radio buttons

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio added a comment. Before: F2442494: Screenshot_20170211_120517.png After: F2442498: Screenshot_20170211_120558.png REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

[Differential] [Request, 395 lines] D4563: Replace warps-slider checkbox with radio buttons

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added reviewers: broulik, colomar. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This was suggested by Thomas in https://git.reviewboard.kde.org/r/128475/ but it

[Differential] [Request, 119 lines] D4573: [kioslave/remote] Fix broken kded module

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Commit https://phabricator.kde.org/R120:72e39f083a103e0887624482d6a0ce8b0556dd5e broke the

[Differential] [Updated, 395 lines] D4563: Replace warps-slider checkbox with radio buttons

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 11233. elvisangelaccio added a comment. - Fix strings as suggested by Thomas REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4563?vs=11207=11233 BRANCH master REVISION DETAIL

[Differential] [Commented On] D4563: Replace warps-slider checkbox with radio buttons

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio added a comment. Updated screenshot: F2442795: Screenshot_20170211_184718.png REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D4563 EMAIL PREFERENCES

[Differential] [Updated, 7 lines] D4594: Don't break compatibility with old configs

2017-02-13 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 11275. elvisangelaccio added a comment. Coding style REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4594?vs=11274=11275 BRANCH Plasma/5.8 REVISION DETAIL

[Differential] [Request, 7 lines] D4594: Don't break compatibility with old configs

2017-02-13 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Commit https://phabricator.kde.org/R99:4a06c4d34f2dd8859058618b1dbe9dbd6df9e9b8 doesn't take

[Differential] [Changed Subscribers] D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2017-01-23 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > arichardson wrote in kdeplatformfiledialoghelper.cpp:365-370 > Yes it should be but what is the easy way to do that? Do I have to parse the > result of qVersion()? CMakeLists.txt says the minimum version is 5.5 so I > can't use

[Differential] [Closed] D4565: Port tooltips to KToolTipWidget

2017-02-11 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R124:dfedcd46e2b3: Port tooltips to KToolTipWidget (authored by elvisangelaccio). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4565?vs=11210=11223 REVISION

[Differential] [Closed] D4566: Port tooltips to KToolTipWidget

2017-02-11 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R102:1008fcd219f1: Port tooltips to KToolTipWidget (authored by elvisangelaccio). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4566?vs=11211=11224 REVISION

[Differential] [Request, 348 lines] D4565: Port tooltips to KToolTipWidget

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KToolTipWidget (introduced by kwidgetsaddons 5.30) supersedes the tooltip code (originally

[Differential] [Request, 308 lines] D4566: Port tooltips to KToolTipWidget

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio created this revision. elvisangelaccio added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KToolTipWidget (introduced by kwidgetsaddons 5.30) supersedes the tooltip code (originally

[Differential] [Updated] D4566: Port tooltips to KToolTipWidget

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio added a task: T5004: [kinfocenter] Port tooltips to KToolTipWidget. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D4566 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: plasma-devel,

[Differential] [Updated] D4565: Port tooltips to KToolTipWidget

2017-02-11 Thread Elvis Angelaccio
elvisangelaccio added a task: T5003: [systemsettings] Port tooltips to KToolTipWidget. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D4565 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc:

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-02-11 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added CC||elvis.a

[Differential] [Commented On] D3459: Add top_left_arrow cursor symlinks

2017-01-18 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D3459#78340, @broulik wrote: > Are there other cursors that Mono might use? In Unity's 3D editor I get the same ugly (but mirrored) cursor. I tried symlinking top_right_arrow but that didn't help. Your best bet is

[Differential] [Commented On] D3459: Add top_left_arrow cursor symlinks

2017-01-18 Thread Elvis Angelaccio
elvisangelaccio added a comment. In https://phabricator.kde.org/D3459#78342, @elvisangelaccio wrote: > In https://phabricator.kde.org/D3459#78340, @broulik wrote: > > > Are there other cursors that Mono might use? In Unity's 3D editor I get the same ugly (but mirrored) cursor. I

[kio-extras] [Bug 375249] "File not found" when trying to open file from nfs

2017-01-19 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=375249 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added CC||elvis.a

[kio-extras] [Bug 375333] Folders thumbnails : custom folder icon overridden by default folder icon

2017-01-20 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=375333 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Ever confirmed|0

[kio-extras] [Bug 375305] SFTP file create date is wrong

2017-01-19 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=375305 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Ever confirmed|0

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-02-28 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #3 from Elvis Angelaccio <elvis.angelac...@kde.org> --- It looks like samba doesn't set write permission to the root folder: kio-extras/smb/kio_smb_browser.cpp has two occurrences of: udsentry.insert(KIO::UDSEntry::UDS_ACCESS, (S

[Differential] [Request, 2 lines] D4839: kio_mtp: add write permissions to root storage folder

2017-02-28 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise it's impossible to paste files there. CCBUG: 366795 TEST PLAN I can now paste files to the root folder of my phone's

Review Request 128793: [kio_mtp] Improve warning message

2016-08-29 Thread Elvis Angelaccio
- Thanks, Elvis Angelaccio

Re: Breakout: UI and user vision for cloud services

2016-10-28 Thread Elvis Angelaccio
On Fri, Oct 28, 2016 at 5:00 AM, Martin Klapetek <martin.klape...@gmail.com> wrote: > On Wed, Oct 19, 2016 at 4:54 AM, Elvis Angelaccio <elvis.angelac...@kde.org> > wrote: >> >> >> Hi Martin, >> I'm planning to integrate KAccounts with kio-gdrive, so your

Re: Split the kioslaves out of plasma-workspace?

2016-11-05 Thread Elvis Angelaccio
On Sat, Nov 5, 2016 at 1:07 PM, David Edmundson wrote: > > > On Fri, Nov 4, 2016 at 7:46 PM, Christoph Feck wrote: >> >> On 04.11.2016 19:20, kainz.a wrote: Radical different idea: what about moving Dolphin from Applications to

Re: Split the kioslaves out of plasma-workspace?

2016-11-05 Thread Elvis Angelaccio
On Fri, Nov 4, 2016 at 7:09 PM, Martin Gräßlin <mgraess...@kde.org> wrote: > Am 2016-11-04 15:52, schrieb Elvis Angelaccio: >> >> Hi >> plasma-workspace currently ships the remote:/, applications:/ and >> desktop:/ kioslaves. The remote:/ one is also used by Dol

Re: Breakout: UI and user vision for cloud services

2016-10-19 Thread Elvis Angelaccio
On Wed, Oct 19, 2016 at 5:17 AM, Martin Klapetek wrote: > On Mon, Oct 17, 2016 at 12:54 PM, Jonathan Riddell wrote: >> >> * Services integration - I see more and more users who have >> data locked up in clouds (GDrive, etc.) and rely on accessing it

Re: Split the kioslaves out of plasma-workspace?

2016-11-23 Thread Elvis Angelaccio
On Sat, Nov 5, 2016 at 1:07 PM, David Edmundson wrote: > > > On Fri, Nov 4, 2016 at 7:46 PM, Christoph Feck wrote: >> >> On 04.11.2016 19:20, kainz.a wrote: Radical different idea: what about moving Dolphin from Applications to

Re: commit through git close bug and phabricator diff?

2016-11-13 Thread Elvis Angelaccio
On Sun, Nov 13, 2016 at 10:59 AM, Michail Vourlakos wrote: > One more question please, commiting only through git what do I have to add > to my commit in order to close a phabricator diff and a bugzilla bug and > where (in header or the comments?) > > > for example, "fix

[kio-extras] [Bug 366795] Paste action disabled when copying a local file to smb:// or mtp://

2016-10-30 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=366795 --- Comment #24 from Elvis Angelaccio <elvis.angelac...@kde.org> --- @vlaomao: you need kio 5.26 or later -- You are receiving this mail because: You are the assignee for the bug.

Re: Review Request 128793: [kio_mtp] Improve warning message

2016-11-02 Thread Elvis Angelaccio
Angelaccio On Sept. 7, 2016, 10:35 a.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128793: [kio_mtp] Improve warning message

2016-11-03 Thread Elvis Angelaccio
marked as submitted. Review request for Plasma and KDE Usability. Changes --- Submitted with commit e5619efafdd9c316e6d3e609ddd73939dea3e270 by Elvis Angelaccio to branch master. Repository: kio-extras Description --- Sometimes the "Maybe you need to unlock your device?&quo

Split the kioslaves out of plasma-workspace?

2016-11-04 Thread Elvis Angelaccio
Hi plasma-workspace currently ships the remote:/, applications:/ and desktop:/ kioslaves. The remote:/ one is also used by Dolphin, so currently the dolphin package has an (optional) dependency on plasma-workspace. As discussed in [1], they are 'core' kioslaves (and thus doesn't make sense to

Re: Split the kioslaves out of plasma-workspace?

2016-11-04 Thread Elvis Angelaccio
On Fri, Nov 4, 2016 at 3:59 PM, Marco Martin <notm...@gmail.com> wrote: > On Friday 04 November 2016 15:52:12 Elvis Angelaccio wrote: >> Pro: >> - plasma-workspace 5.9 could hard-depend on this new repo (they would >> have the same release schedule) >> -

Re: Split the kioslaves out of plasma-workspace?

2016-11-27 Thread Elvis Angelaccio
On Thu, Nov 24, 2016 at 1:58 PM, Marco Martin <notm...@gmail.com> wrote: > On Wednesday 23 November 2016 16:56:22 Elvis Angelaccio wrote: >> > I think you're right that they could go in frameworks. I don't think it >> > wouldn't bring any new dependencies and it

[Differential] [Updated, 13 lines] D3714: Enable blurBehind effect if the window hints for it

2017-01-10 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 9993. elvisangelaccio added a comment. - Use always QByteArray - If the property is valid but false, disable blur behind. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

[Differential] [Updated] D3714: Enable blurBehind effect if the window hints for it

2017-01-10 Thread Elvis Angelaccio
elvisangelaccio marked 2 inline comments as done. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D3714 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, graesslin Cc: plasma-devel,

[kio-extras] [Bug 370594] smb cannot create file with a :

2017-01-14 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=370594 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Component|general |d

[Differential] [Closed] D3714: Enable blurBehind effect if the window hints for it

2017-01-10 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R135:102551b7debb: Enable blurBehind effect if the window hints for it (authored by elvisangelaccio). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

[kio-extras] [Bug 359278] Crash when opening smb:// folders

2016-12-27 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=359278 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Summary|SMB crashes Dolphin |Crash when o

[kio-extras] [Bug 369850] Can't browse samba workgroups

2016-12-27 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=369850 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Component|general |d

[kio-extras] [Bug 372860] MTP not usable : connects, then disconnects, then connects...

2016-12-24 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=372860 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Product|dolphin |kio-

D3531: Drop remote ioslave, which is now in KIO 5.32

2017-03-28 Thread Elvis Angelaccio
elvisangelaccio added a comment. I'm going to push this by tomorrow unless someone has objections. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 To: elvisangelaccio, #plasma, davidedmundson Cc: bshah, lbeltrame, davidedmundson, plasma-devel,

D3531: Drop remote ioslave, which is now in KIO 5.32

2017-03-29 Thread Elvis Angelaccio
This revision was automatically updated to reflect the committed changes. Closed by commit R120:f81c73b8e25b: Drop remote ioslave, which is now in KIO 5.32 (authored by elvisangelaccio). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[kio-extras] [Bug 378217] Use user defined in .ssh/config for fish

2017-03-28 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=378217 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Component|general |d

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

2017-03-28 Thread Elvis Angelaccio
elvisangelaccio added a comment. It seems the upstream firefox bug has been fixed, can you update to commit message? Anyway +1 for removing the stepper buttons, currently there is an annoying difference between breeze and breeze-gtk3 scrollbars. REPOSITORY R98 Breeze for Gtk REVISION

D3531: Drop remote ioslave, which is now in KIO 5.32

2017-03-20 Thread Elvis Angelaccio
elvisangelaccio added a comment. Ping? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3531 To: elvisangelaccio, #plasma, davidedmundson Cc: bshah, lbeltrame, davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

[kio-extras] [Bug 376344] cant write to smb shares which has write access

2017-04-09 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=376344 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added CC||marku

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio marked 3 inline comments as done. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5446 To: elvisangelaccio, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio edited the summary of this revision. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5446 To: elvisangelaccio, #plasma, dfaure Cc: plasma-devel, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > elvisangelaccio wrote in qfiledialogtest.cpp:116 > ...or maybe we can turn the assert in a qWarning()? Otherwise if > isMimeFilter() is false we get a name filter instead of a mimetype, a bit > misleading? The problem is that if

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > dfaure wrote in kfiledialog_unittest.cpp:84 > Why use QMimeDatabase, just to then use name()? You could just put > "text/x-chdr" in the data row, no? Leftover from the previous patch, yes doesn't make sense now. > dfaure wrote in

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kdeplatformfiledialoghelper.h:64-67 > Better overrites them, then ifdef in implementation Not possible, only QPlatformFileDialogHelper >= 5.9 has those methods. REPOSITORY R135 Integration for Qt applications in

[kio-extras] [Bug 363593] In dolphin-16.04.1-1.fc25.x86_64, Unknown error code 150 when copying from phone to computer

2017-04-21 Thread Elvis Angelaccio
https://bugs.kde.org/show_bug.cgi?id=363593 Elvis Angelaccio <elvis.angelac...@kde.org> changed: What|Removed |Added Version|16.12.2 |unspe

D4193: KDEPlatformFileDialog: Fix initial directory selection for remote files

2017-04-13 Thread Elvis Angelaccio
elvisangelaccio added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kdeplatformfiledialoghelper.cpp:365-370 > What about `if (qVersion() < QStringLiteral("5.7.1")) {}`? It doesn't work in > the general case but it should work for this specific check. Sorry but I didn't think

D5446: Implement support for selected mime type filters

2017-04-14 Thread Elvis Angelaccio
elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY QFileDialog in Qt 5.9 has better support for mimetype filters and introduces the QFileDialog::selectedMimeTypeFilter() method [1].

D2365: Add failing test case for selected filter from mimetype

2017-04-14 Thread Elvis Angelaccio
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. Superseded by https://phabricator.kde.org/D5446. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D2365 To: elvisangelaccio, graesslin, dfaure Cc: plasma-devel,

D1813: Fix selected name filter with multiple mimetypes

2017-04-14 Thread Elvis Angelaccio
elvisangelaccio abandoned this revision. elvisangelaccio added a comment. Superseded by https://phabricator.kde.org/D5446. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1813 To: elvisangelaccio, #plasma Cc: dfaure, graesslin,

D5446: Implement support for selected mime type filters

2017-04-15 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 13457. elvisangelaccio added a comment. - Removed pointless QMimeDatabase usage in the test - Only run unit test when building against 5.9 REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D5446: Implement support for selected mime type filters

2017-04-22 Thread Elvis Angelaccio
elvisangelaccio updated this revision to Diff 13692. elvisangelaccio added a comment. Properly implement selectedMimeTypeFilter(). KFileFilterCombo::currentFilter() might return invalid mimetypes, so fall back on QMimeDatabase() if necessary. REPOSITORY R135 Integration for Qt

  1   2   3   >