D8146: Don't try to override label heights - PlasmaComponents

nicolasfella abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8146: Don't try to override label heights - PlasmaComponents

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. nicolasfella added a project: Plasma. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Same as https://phabricator.kde.org/D8129 but

D8449: Have a default backend (if one available)

nicolasfella added a comment. https://community.kde.org/Infrastructure/Get_a_Developer_Account REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D8449 To: cryptodude, ivan, #plasma Cc: nicolasfella, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

nicolasfella added a comment. Sometimes it's better to be precise about well-known technical terms instead of hiding them. Would a person who does not know what anti-aliasing is want/need to change that setting? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13225: Move methods to private class

nicolasfella created this revision. nicolasfella added reviewers: drosca, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R994 Pulseaudio Qt Bindings BRANCH private

D13199: Move updateDevice to private class

This revision was automatically updated to reflect the committed changes. Closed by commit R994:65bad933c12c: Move updateDevice to private class (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13199?vs=35126=35181

D13225: Move methods to private class

nicolasfella added a comment. In D13225#275197 , @mart wrote: > does this library have any kind of binary compatibility promise? It is not yet released. REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL

D13199: Move updateDevice to private class

nicolasfella created this revision. nicolasfella added a reviewer: drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN KDE Connect volume control still works REPOSITORY R994

D13717: Implement Seek() and Seeked()

nicolasfella added a comment. +1, setting the position for e.g. Youtube now works from KDE Connect REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D13717 To: mokhtari, broulik Cc: nicolasfella, plasma-devel, #kde_connect, jdvr, yannux, Danial0_0,

D13225: Move methods to private class

This revision was automatically updated to reflect the committed changes. Closed by commit R994:38c0b2d24bd5: Move methods to private class (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13225?vs=35223=36698

D13694: Fix wrong availability of profiles and ports.

nicolasfella added a comment. It may work on your system because Profile reports 2 when available, but the libpulse docs say that anything non-zero should be interpreted as available (for Profile, not Port!) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL

D13694: Fix wrong availability of profiles and ports.

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. Sorry, but this does not solve the issue. Now it only shows the profiles that are not available. I'll try to make clear why: profile->available is either 0 (not

D13694: Fix wrong availability of profiles and ports.

nicolasfella added a comment. It does not regress any more. I did not observe any issue with the previous code so I can't confirm it fixes things, but the change looks sensible to me. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13694 To:

D13770: Only show available ports in port selection

nicolasfella created this revision. nicolasfella added a reviewer: drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Unavailable ports are marked as unavailable, but

D13694: Fix wrong availability of profiles and ports.

nicolasfella added a comment. I found the issue and this patch solves it. +1 from me, but @drosca should also approve since he is the maintainer. While you're at it, can you please make the same change for https://cgit.kde.org/pulseaudio-qt.git ? It suffers from the same issue. REPOSITORY

D13694: Fix wrong availability of profiles and ports.

nicolasfella added a comment. In D13694#283089 , @drosca wrote: > In D13694#282499 , @nicolasfella wrote: > > > This breaks the profile selection Combobox in the KCM. > > > How does this break

D13694: Fix wrong availability of profiles and ports.

nicolasfella requested changes to this revision. nicolasfella added a reviewer: drosca. nicolasfella added a comment. This revision now requires changes to proceed. This breaks the profile selection Combobox in the KCM. From the libpulse doc

D12481: Add dptr to models

This revision was automatically updated to reflect the committed changes. Closed by commit R994:0abe8778072a: Add dptr to models (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12481?vs=32924=33315 REVISION DETAIL

D9671: Show only available profiles in Pulseaudio KCM

nicolasfella added a comment. Feel free to take over, I can't promise to finish it anytime soon REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D9671 To: nicolasfella, #plasma, drosca Cc: plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai,

D10224: Give a default player name

nicolasfella created this revision. nicolasfella added a reviewer: broulik. nicolasfella added a project: Plasma. nicolasfella requested review of this revision. REVISION SUMMARY Default to "Plasma Browser Integration" as a default MPRIS player identity. This makes KDE Connect look prettier.

D10148: KCM: Show only available device profiles

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. This leads to the wrong profile being selected. Because some profiles are excluded from the model the indices don't match anymore. REVISION DETAIL

D10183: Adjust spacing between text and plotter line in Speed tab of nm applet

This revision was automatically updated to reflect the committed changes. Closed by commit R116:e1673f18e942: Adjust spacing between text and plotter line in Speed tab of nm applet (authored by kamathraghavendra, committed by nicolasfella). REPOSITORY R116 Plasma Network Management Applet

D10224: Give a default player name

nicolasfella added a comment. Well, I am trying to fix PBI. The problem is that my Firefox (58.0.1) does not get recognized as such. Chrome works fine. I will try to dig into the underlying issue. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL

D10148: KCM: Show only available device profiles

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Looks good to me REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D10148 REVISION DETAIL https://phabricator.kde.org/D10148 To: drosca, #plasma, nicolasfella

D10224: Give a default player name

nicolasfella abandoned this revision. nicolasfella added a comment. Turns out i wasn't running the latest extension. Works fine now. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10224 To: nicolasfella, broulik, apol Cc: apol, plasma-devel,

D10280: Fix output device context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R115:f5c2a04e8d87: Fix output device context menu (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10280?vs=26463=26492

D9671: Show only available profiles in Pulseaudio KCM

nicolasfella added a comment. In https://phabricator.kde.org/D9671#200326, @broulik wrote: > This breaks the context menu of output devices: > > org.kde.plasma.volume/contents/ui/ListItemBase.qml:315: ReferenceError: Port is not defined > see

D10280: Fix output device context menu

nicolasfella created this revision. nicolasfella added reviewers: broulik, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Port QML type got wrongly removed. TEST

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

nicolasfella added a comment. The glitch: F5728155: 20180222_130510_edited (1).mp4 REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10800 To: mtijink, #plasma, broulik Cc: nicolasfella, plasma-devel,

D10800: Plasma browser MPRIS canPlay shouldn't depend on the actual playing status

nicolasfella added a comment. I can confirm that this fixes the glitch REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D10800 To: mtijink, #plasma, broulik Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14056: Remove FileItemActionPlugin in favor of Purpose plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R97:6fa60e4bf363: Remove FileItemActionPlugin in favor of Purpose plugin (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 37913. nicolasfella added a comment. - Remove unneeded class declaration REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14147?vs=37911=37913 BRANCH gsettings REVISION DETAIL

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 37911. nicolasfella added a comment. - Fail if user sets both USE_GCONF and USE_GSETTINGS - Restore warning when module is unloaded REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D14147: Port from GConf to GSettings

nicolasfella created this revision. nicolasfella added reviewers: drosca, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY CCBUG: 386665 As discussed in

D14340: [Multimedia KCM] Kill PulseAudio device setup

nicolasfella added a comment. Looks like we had the same thought again :D D13935 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14340 To: broulik, #plasma Cc: nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot,

D14026: [Pager] Don't show a window list on hover if there is only one window

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7f729fa1268c: [Pager] Dont show a window list on hover if there is only one window (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14157: Add QT_NO_KEYWORDS definition

nicolasfella created this revision. nicolasfella added reviewers: drosca, broulik, davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN Builds REPOSITORY R115 Plasma

D14147: Port from GConf to GSettings

nicolasfella added a comment. Keyword changes were made in D14107 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To: nicolasfella, drosca, davidedmundson Cc: rikmills, broulik, asturmlechner,

D14157: Add QT_NO_KEYWORDS definition

This revision was automatically updated to reflect the committed changes. Closed by commit R115:dd15322e50ee: Add QT_NO_KEYWORDS definition (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14157?vs=37864=37874

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37735. nicolasfella marked 9 inline comments as done. nicolasfella added a comment. - Fix unref'ing - Save context in variable - Fix * placement - Fix QML style REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D13931: [KCM] Add speaker placement test

nicolasfella added inline comments. INLINE COMMENTS > drosca wrote in Advanced.qml:117 > What is this doing? > > onDataChanged will be triggered only when some property of data in model > changes, and in that case you overwritten the binding that is set in grid, so > grid.pulseObject will no

D14026: [Pager] Don't show a window list on hover if there is only one window

nicolasfella added a comment. @hein Ping? REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 To: nicolasfella, hein, broulik, ngraham Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37743. nicolasfella added a comment. - Use brute force approach REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13931?vs=37735=37743 BRANCH speakertest REVISION DETAIL

D13931: [KCM] Add speaker placement test

nicolasfella added a comment. Thanks for bearing with me! :) REPOSITORY R115 Plasma Audio Volume Applet BRANCH speakertest REVISION DETAIL https://phabricator.kde.org/D13931 To: nicolasfella, drosca Cc: ngraham, #vdg, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13931: [KCM] Add speaker placement test

This revision was automatically updated to reflect the committed changes. Closed by commit R115:ed0c58639d12: [KCM] Add speaker placement test (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13931?vs=37743=37753#toc REPOSITORY R115 Plasma Audio Volume Applet

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 37887. nicolasfella added a comment. - Support both GConf and GSettings REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14147?vs=37836=37887 BRANCH gsettings REVISION DETAIL

D14147: Port from GConf to GSettings

nicolasfella updated this revision to Diff 37888. nicolasfella added a comment. - Don't require GIO - Fix copyright REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14147?vs=37887=37888 BRANCH gsettings REVISION DETAIL

D14147: Port from GConf to GSettings

nicolasfella added a comment. It now defaults to GSettings of found and one can pass -DUSE_GCONF to build it using GConf REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To: nicolasfella, drosca, davidedmundson Cc: rikmills, broulik,

D13935: Remove audio setup from Phonon KCM

nicolasfella abandoned this revision. nicolasfella added a comment. Abandoning in favor of D14340 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13935 To: nicolasfella, #plasma, sitter Cc: plasma-devel, ragreen, Pitel,

D14362: Use unpretty channel name in speakertest

nicolasfella created this revision. nicolasfella added reviewers: drosca, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The speaker test did not work when channel

D14362: Use unpretty channel name in speakertest

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in sink.cpp:100 > Can you check this is still correct? It doesn't seem to play any sounds here front-left/front-right work for me. Rest is untested because I don't have such fancy hardware. Just to be sure: Is your sink

D14026: [Pager] Don't show a window list on hover if there is only one window

nicolasfella updated this revision to Diff 37504. nicolasfella added a comment. - Unrelated change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14026?vs=37503=37504 BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026

D14026: [Pager] Don't show a window list on hover if there is only one window

nicolasfella created this revision. nicolasfella added reviewers: hein, broulik, ngraham. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY If there is only one visible window

D14026: [Pager] Don't show a window list on hover if there is only one window

nicolasfella added a comment. In D14026#289890 , @mart wrote: > but would still make sense to know how that one window is called? The name is still there. Just some cruft around is removed REPOSITORY R119 Plasma Desktop BRANCH

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37534. nicolasfella marked 2 inline comments as done. nicolasfella edited the summary of this revision. nicolasfella added a comment. - Fix indentation in QML - Add i18n calls - Use QLatin1String - Coding style - Switch statement indentation

D13931: [KCM] Add speaker placement test

nicolasfella added a comment. The ComboBox part is a little hacky because I couldn't figure out a nice way to access the model data from outside a delegate REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D13931 To: nicolasfella, drosca Cc:

D14056: Remove FileItemActionPlugin in favor of Purpose plugin

nicolasfella created this revision. nicolasfella added reviewers: broulik, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Depends on D14052

D13931: [KCM] Add speaker placement test

nicolasfella added inline comments. INLINE COMMENTS > drosca wrote in volumefeedback.cpp:36 > What if there is multiple VolumeFeedback instances? It will crash then. > You should either move canberra context to Context class (should probably be > fine) or implement the refcounting of

D13931: [KCM] Add speaker placement test

nicolasfella added a comment. In D13931#290535 , @drosca wrote: > And the whole ComboBox/SinkModel code needs to be changed. You should be able to get the PulseObject from the model just with QML code (see invokables in

D13931: [KCM] Add speaker placement test

nicolasfella added a comment. In D13931#290548 , @drosca wrote: > In D13931#290544 , @nicolasfella wrote: > > > I can get the PulseObject, that is not the problem, the problem is that I can't

D12278: WIP: [Colors KCM] Port to new design

nicolasfella added inline comments. INLINE COMMENTS > colors.cpp:313 > +QStringList colorItemList; > +colorItemList << "BackgroundNormal" > + << "BackgroundAlternate" Can you use an initializer_list here and elsewhere? Also QStringLiteral? See

D13931: [KCM] Add speaker placement test

nicolasfella created this revision. nicolasfella added a reviewer: drosca. Restricted Application added a project: Plasma. Restricted Application edited subscribers, added: plasma-devel; removed: Plasma. nicolasfella requested review of this revision. REVISION SUMMARY An equivalent to the

D13935: Remove audio setup from Phonon KCM

nicolasfella created this revision. nicolasfella added reviewers: Plasma, sitter, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Once D13931

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37602. nicolasfella added a comment. - Remove comment - Remove empty destructor - Add else if REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13931?vs=37601=37602 BRANCH speakertest

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37601. nicolasfella added a comment. Simplify model access Thanks for your help! Now, when I switch profiles I get error messages that pulseObject is null, however it seems to work fine. REPOSITORY R115 Plasma Audio Volume Applet

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37656. nicolasfella added a comment. - refcount CanberraContext REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13931?vs=37602=37656 BRANCH speakertest REVISION DETAIL

D14056: Remove FileItemActionPlugin in favor of Purpose plugin

nicolasfella added a comment. Sending via Bluetooth will be available in Dolphin via the Share menu. (See D13124 ) REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D14056 To: nicolasfella, broulik, drosca Cc: plasma-devel,

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37659. nicolasfella added a comment. - Variable initialization and pointer style - Wait for sound being played before unref'ing context - Merge properties - Remove log - Fix unused parameter warning REPOSITORY R115 Plasma Audio Volume

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37660. nicolasfella added a comment. - Fix context ref'ing in sink REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13931?vs=37659=37660 BRANCH speakertest REVISION DETAIL

D13931: [KCM] Add speaker placement test

nicolasfella added inline comments. INLINE COMMENTS > drosca wrote in Advanced.qml:132 > Make it into one property, without `index` and `role`, either with pasting > the code inline or moving it to separate function. Also it probably should be > `readonly` property. I couldn't make it

D10032: Swap play/pause icons in mediacontroller plasmoid

nicolasfella added a comment. Before F5671035: IMG_20180123_205152_958.jpg After F5671036: IMG_20180123_205201_049.jpg REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10032: Swap play/pause icons in mediacontroller plasmoid

nicolasfella created this revision. nicolasfella added reviewers: Plasma, VDG. nicolasfella added a project: Plasma. nicolasfella requested review of this revision. REVISION SUMMARY The play/pause status of the system tray icon appears inverse to the play/pause button in the plasmoid. This

D12356: Move volume constants into functions

nicolasfella created this revision. nicolasfella added reviewers: drosca, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Get rid of pulse include in context.h TEST

D12356: Move volume constants into functions

This revision was automatically updated to reflect the committed changes. Closed by commit R994:c102a76c9538: Move volume constants into functions (authored by nicolasfella). REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12356?vs=32583=32584

D12356: Move volume constants into functions

nicolasfella added a comment. Weird, it did build for me so I didn't notice, sorry REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D12356 To: nicolasfella, drosca, apol Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12356: Move volume constants into functions

nicolasfella updated this revision to Diff 32583. nicolasfella added a comment. - Fix names REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12356?vs=32573=32583 BRANCH nopulseheader REVISION DETAIL https://phabricator.kde.org/D12356

D12481: Add dptr to models

nicolasfella updated this revision to Diff 32920. nicolasfella added a comment. - Coding style REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12481?vs=32919=32920 BRANCH dptr REVISION DETAIL https://phabricator.kde.org/D12481 AFFECTED

D12481: Add dptr to models

nicolasfella updated this revision to Diff 32921. nicolasfella added a comment. - Add license header REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12481?vs=32920=32921 BRANCH dptr REVISION DETAIL https://phabricator.kde.org/D12481

D12481: Add dptr to models

nicolasfella created this revision. nicolasfella added reviewers: drosca, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Last exported classes without dptr TEST PLAN

D12481: Add dptr to models

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in models.h:81 > Why `void*`? So we can replace it with a "real" private class when we need it without creating a empty one now REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL https://phabricator.kde.org/D12481

D12481: Add dptr to models

nicolasfella updated this revision to Diff 32924. nicolasfella added a comment. - Remove unneeded modifier REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12481?vs=32921=32924 BRANCH dptr REVISION DETAIL

D11021: [Media contoller] Add simple volume control

nicolasfella added a comment. What about a volume slider in the applet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D11021 To: Pitel, #plasma Cc: nicolasfella, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10032: Swap play/pause icons in mediacontroller plasmoid

nicolasfella abandoned this revision. nicolasfella added a comment. Abandoning in favor of D11056 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10032 To: nicolasfella, #plasma, #vdg Cc: rizzitello, abetts,

D16635: Add declarative plugin

nicolasfella created this revision. nicolasfella added reviewers: drosca, broulik, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Make it usable from QML TEST PLAN Use SinkModel from QML

D16828: Allow sharing clipboard items to kdeconnect

nicolasfella added a comment. +1 for using Purpose for this REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16828 To: blaws Cc: nicolasfella, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16635: Add declarative plugin

nicolasfella added a comment. In D16635#354219 , @apol wrote: > Who's the use-case for this? The plasmoid? Yes. @broulik also mentioned the task manager as a potential user REPOSITORY R994 Pulseaudio Qt Bindings REVISION DETAIL

D15827: [applet] Avoid showing a generic audio-card icon

nicolasfella added a comment. In D15827#336757 , @ngraham wrote: > I think showing a generic speaker or microphone icon is a //huge// visual improvement over a sound card, but I agree with @drosca that it's odd to duplicate them. > > Here's

D15889: [Cursors] link *-resize to *_corner cursor

nicolasfella closed this revision. nicolasfella added a comment. Fixed in D15950 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D15889 To: nicolasfella, #breeze, hpereiradacosta, ngraham, andreask Cc: GB_2, plasma-devel, ragreen,

D15950: Link *-resize to the right icons

This revision was automatically updated to reflect the committed changes. Closed by commit R31:63207819b89f: Link *-resize to the right icons (authored by nicolasfella). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15950?vs=42879=42883 REVISION DETAIL

D15950: Link *-resize to the right icons

nicolasfella created this revision. nicolasfella added reviewers: Breeze, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY D15889 did link those to their Breeze

D15920: [cursors] Also link for Breeze Snow

This revision was automatically updated to reflect the committed changes. Closed by commit R31:54c6c189f9ba: [cursors] Also link for Breeze Snow (authored by nicolasfella). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15920?vs=42785=42787 REVISION DETAIL

D15889: [Cursors] link *-resize to *_corner cursor

This revision was automatically updated to reflect the committed changes. Closed by commit R31:baab8494bbe9: [Cursors] link *-resize to *_corner cursor (authored by nicolasfella). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15889?vs=42698=42784 REVISION

D15920: [cursors] Also link for Breeze Snow

nicolasfella created this revision. nicolasfella added reviewers: Breeze, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Same as D15889 for Breeze Snow

D15827: [applet] Avoid showing a generic audio-card icon

nicolasfella created this revision. nicolasfella added reviewers: drosca, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY If the hardware reports "internal" as formfactor the generic

D15889: [Cursors] link *-resize to *_corner cursor

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY BUG: 399194 When hovering at the window corner in Nautilus an Adwaita curser is shown. Link it to the Breeze

D18276: Fix KDE Connect volume control

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R994 Pulseaudio Qt Bindings BRANCH noglibcheck REVISION DETAIL https://phabricator.kde.org/D18276 AFFECTED FILES

D18275: Remove CPOYING

nicolasfella updated this revision to Diff 49557. nicolasfella added a comment. Fix diff REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18275?vs=49556=49557 BRANCH noglibcheck REVISION DETAIL https://phabricator.kde.org/D18275

D18275: Remove CPOYING

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Fix KDE Connect volume control REPOSITORY R994 Pulseaudio Qt Bindings BRANCH noglibcheck REVISION DETAIL

D18276: Fix KDE Connect volume control

nicolasfella updated this revision to Diff 49563. nicolasfella added a comment. Thanks! REPOSITORY R994 Pulseaudio Qt Bindings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18276?vs=49558=49563 BRANCH noglibcheck REVISION DETAIL https://phabricator.kde.org/D18276 AFFECTED

D18341: Support icons from local files in buttons

nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Trying to assign an icon from a file to a button like in import

  1   2   3   4   5   6   >