[Differential] [Accepted] D739: Disable ptrace

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rPOLKITKDEAGENT Policykit (Polkit) KDE Agent BRANCH disable-ptrace REVISION DETAIL https://phabricator.kde.org/D739 EMAIL PREFERENCES

[Differential] [Closed] D729: Add Package to activesettings module

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMASETTINGS9e17097d5f67: Add Package component to activesettings import module (authored by bshah). REPOSITORY rPLASMASETTINGS plasma-settings CHANGES SINCE LAST UPDATE

[Differential] [Updated, 159 lines] D729: Add Package to activesettings module

bshah removed rPLASMASETTINGS plasma-settings as the repository for this revision. bshah updated this revision to Diff 1691. bshah added a comment. uploaded correct diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D729?vs=1690=1691 REVISION DETAIL

[Differential] [Request, 158 lines] D729: Add Package to activesettings module

bshah created this revision. bshah added reviewers: Plasma: Mobile, mart. bshah set the repository for this revision to rPLASMASETTINGS plasma-settings. bshah added a project: Plasma: Mobile. Herald added a subscriber: plasma-devel. REVISION SUMMARY This unbreaks the plasma-settings,

[Differential] [Closed] D1664: Update for Breeze-gtk

bshah closed this revision. bshah added a comment. Commited with https://quickgit.kde.org/?p=breeze-gtk.git=commit=499226afa44cafb342546dd5362c4b0b1c916955 REPOSITORY rBREEZEGTK Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D1664 EMAIL PREFERENCES

[Differential] [Commandeered] D1664: Update for Breeze-gtk

bshah commandeered this revision. bshah added a reviewer: dirrukd. REPOSITORY rBREEZEGTK Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D1664 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, #plasma, mart, dirrukd Cc: davidedmundson,

[Differential] [Accepted] D1811: UpdateClientArea from ShellClient::doSetGeometry if the ShellClient has a strut

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH update-struts-on-geometry-change REVISION DETAIL https://phabricator.kde.org/D1811 EMAIL PREFERENCES

[Differential] [Commented On] D1803: Fix the strut handling for wayland clients

bshah added a comment. Sounds sane, but not completely confident to Accept it. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1803 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, #kwin Cc: bshah,

[Differential] [Accepted] D1747: Set ShellClient on all desktop depending on Plasma Surface role

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH role-implies-on-all-desktops REVISION DETAIL https://phabricator.kde.org/D1747 EMAIL PREFERENCES

[Differential] [Accepted] D1755: [server] Trigger error if a transient request tries to parent to itself

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH error-transient-surface REVISION DETAIL https://phabricator.kde.org/D1755 EMAIL PREFERENCES

[Differential] [Accepted] D1760: Don't setup PlasmaWindowManagement integration for lock screen windows

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH no-plasma-window-lock-screen REVISION DETAIL https://phabricator.kde.org/D1760 EMAIL PREFERENCES

[Differential] [Commented On] D1672: Add support for touch events in fakeinput protocol and interface.

bshah added a comment. In https://phabricator.kde.org/D1672#31046, @graesslin wrote: > I'm wondering: should we ensure that the ids are correct. E.g. a touchUp for id 1 doesn't make sense if we never got a touchDown for id 1. This would require tracking the used ids in

[Differential] [Requested Changes To] D1672: Add support for touch events in fakeinput protocol and interface.

bshah requested changes to this revision. bshah added a reviewer: bshah. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > test_fake_input.cpp:328 > +// without an authentication we shouldn't get the signals > +

[Differential] [Changed Subscribers] D1844: Add Appinfo metadata file

bshah added inline comments. INLINE COMMENTS > plasma-desktop.metainfo.xml:11 > + > +plasma-desktop > + This is wrong, no? there is no plasma-desktop binary anymore? or you mean package name? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Commented On] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

bshah added a comment. +1, This patch definitely improved situation then earlier where kwin_wayland used to crash with this backtrace : https://ptpb.pw/Y_W1.txt REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1857 EMAIL PREFERENCES

[Differential] [Accepted] D1864: Handle ShellClient::windowShown in Workspace

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH handle-window-shown REVISION DETAIL https://phabricator.kde.org/D1864 EMAIL PREFERENCES

[Differential] [Accepted] D1857: Move the loadTexture for X11 pixmap functionality to the EglOnXBackend

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH texture-from-pixmap-x11-only REVISION DETAIL https://phabricator.kde.org/D1857 EMAIL PREFERENCES

[Differential] [Accepted] D1868: [server] Introduce a Resource::unbound signal emitted from unbind handler

bshah accepted this revision. bshah added a reviewer: bshah. REPOSITORY rKWAYLAND KWayland BRANCH resource-unbound REVISION DETAIL https://phabricator.kde.org/D1868 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, sebas,

[Differential] [Commented On] D1844: Add Appinfo metadata file

bshah added a comment. In https://phabricator.kde.org/D1844#34149, @jriddell wrote: > fix binary name Well, even plasmashell is not provided by this :-D should go to plasma-workspace probably REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Abandoned] D1884: Set differential sticky-accept to false

bshah abandoned this revision. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1884 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, graesslin Cc: plasma-devel, jensreuterberg, sebas

[Differential] [Request, 3 lines] D1884: Set differential sticky-accept to false

bshah created this revision. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This allows to reset differential changes to be reverted to "Needs review" after revision REPOSITORY rKWAYLAND KWayland BRANCH

[Differential] [Commented On] D1868: [server] Introduce a Resource::unbound signal emitted from unbind handler

bshah added a comment. Looks good, can't re-accept so shipit! REPOSITORY rKWAYLAND KWayland BRANCH resource-unbound REVISION DETAIL https://phabricator.kde.org/D1868 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, sebas,

[Differential] [Updated, 3 lines] D1884: Set differential sticky-accept to false

bshah updated this revision to Diff 4487. bshah added a comment. set it to actually false REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1884?vs=4486=4487 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1884 AFFECTED FILES

[Differential] [Commented On] D1717: fix flaky build

bshah added a comment. See: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/79/console REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1717 EMAIL PREFERENCES

[Differential] [Accepted] D1716: [Panel Configuration] Close when pressing Escape

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1716 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1715: [Desktop Toolbox] Close toolbox popup before triggering action

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1715 EMAIL PREFERENCES

[Differential] [Request, 1 line] D1717: fix flaky build

bshah created this revision. bshah added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY autotest needs kcm_lookandfeel compiled first, this breaks based on shade of moon TEST PLAN none

[Differential] [Closed] D1717: fix flaky build

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPdcaa8b8a7c69: fix flaky build (authored by bshah). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1717?vs=4073=4074 REVISION DETAIL

[Differential] [Requested Changes To] D1726: Introduce a test server

bshah requested changes to this revision. bshah added a reviewer: bshah. bshah added a comment. This revision now requires changes to proceed. While looking at cmake, I realized one issue.. and to verify this I tried to build it and it didn't even build.. :\ INLINE COMMENTS >

[Differential] [Closed] D1742: Make udev seriously mandatory

This revision was automatically updated to reflect the committed changes. Closed by commit rPOWERDEVIL4a6c8286cea4: Make udev seriously mandatory (authored by bshah). REPOSITORY rPOWERDEVIL Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1742?vs=4152=4154 REVISION DETAIL

[Differential] [Request, 82 lines] D1742: Make udev seriously mandatory

bshah created this revision. bshah added reviewers: Plasma, broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY https://phabricator.kde.org/rPOWERDEVIL73e13daef13d38948b1194d2d1103404fdd808b7 done just half work of

[Differential] [Accepted] D1727: Add a test case for KIdleTime

bshah accepted this revision. bshah added a reviewer: bshah. bshah added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > graesslin wrote in idle_test.cpp:79 > that would be the wrong layer for such a test. It should be in whoever > doesn't pass it along. That

[Differential] [Changed Subscribers] D1727: Add a test case for KIdleTime

bshah added inline comments. INLINE COMMENTS > idle_test.cpp:79 > +QCOMPARE(spy.count(), 0); > +m_fakeInput->requestPointerMove(QSizeF(1, 2)); > +QVERIFY(spy.wait()); In the past we've seen that touch events didn't resume from idle or something... perhaps add testcase for that?

[Differential] [Accepted] D1726: Introduce a test server

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. Looks good. REPOSITORY rKWAYLAND KWayland BRANCH test-server REVISION DETAIL https://phabricator.kde.org/D1726 EMAIL PREFERENCES

[Differential] [Accepted] D1672: Add support for touch events in fakeinput protocol and interface.

bshah accepted this revision. bshah added a comment. Looks good. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, graesslin, Plasma, bshah Cc: bshah, graesslin,

[Differential] [Changed Subscribers] D1697: Don't set the implicitWidth the parent's actual width

bshah added a subscriber: plasma-devel. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1697 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: plasma-devel, Plasma

[Differential] [Changed Subscribers] D1726: Introduce a test server

bshah added inline comments. INLINE COMMENTS > main.cpp:30-33 > +const auto arguments = parser.positionalArguments(); > +if (arguments.size() != 1) { > +return 1; > +} It might be possible that one want to use executable with command line option... lets not restrict it to

[Differential] [Accepted] D1913: Cache the caption of ShellSurface in ShellClient

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH shell-client-cache-caption REVISION DETAIL https://phabricator.kde.org/D1913 EMAIL PREFERENCES

[Differential] [Accepted] D1937: [server] Unset SurfaceInterface pointer in referenced objects when being destroyed

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH unset-surface REVISION DETAIL https://phabricator.kde.org/D1937 EMAIL PREFERENCES

[Differential] [Accepted] D1928: Add a notification role to PlasmaShellSurface

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH plasma-shell-notification REVISION DETAIL https://phabricator.kde.org/D1928 EMAIL PREFERENCES

[Differential] [Accepted] D1927: Do not activate on-screen-display windows

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH osd-no-focus-5.7 REVISION DETAIL https://phabricator.kde.org/D1927 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Accepted] D1963: Guarding the X11 calls not to appear in a wayland session

bshah accepted this revision. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1963 EMAIL PREFERENCES

[Differential] [Request, 140 lines] D1962: Fix bunch of overrides warnings

bshah created this revision. bshah added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY clang-check as well cppcheck complains about it TEST PLAN builds REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Commented On] D1963: Guaring the X11 calls not to appear in a wayland session

bshah added inline comments. INLINE COMMENTS > switcherbackend.cpp:197 > { > -if (isReverseTab(m_actionShortcut[ACTION_NAME_PREVIOUS_ACTIVITY])) { > -switchToActivity(Previous); > +if (QX11Info::isPlatformX11()) { > +// If we are on X11, we have all needed features for

[Differential] [Accepted] D1980: Don't crash if a decoration doesn't get created

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH dont-crash-no-border-5.7 REVISION DETAIL https://phabricator.kde.org/D1980 EMAIL PREFERENCES

[Differential] [Accepted] D1950: Match Prison version exactly

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1950 EMAIL PREFERENCES

[Differential] [Closed] D1962: Fix bunch of overrides warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb227b91df8df: Fix bunch of overrides warnings (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1962?vs=4644=4653

[Differential] [Accepted] D820: Improve setting global lock shortcut

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-action-collection REVISION DETAIL https://phabricator.kde.org/D820 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D821: Drop not needed KF5::Plasma dependency

bshah accepted this revision. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-plasma-dependency REVISION DETAIL https://phabricator.kde.org/D821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, mart, Plasma, bshah Cc: plasma-devel

[Differential] [Commented On] D820: Improve setting global lock shortcut

bshah added a comment. On second thought, Actually maybe, we rename component to (k)screenlocker and provide migration scripts? REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-action-collection REVISION DETAIL https://phabricator.kde.org/D820 EMAIL PREFERENCES

[Differential] [Accepted] D2003: Install a signal handler for SIGABRT and SIGSEGV for kwin_wayland

bshah accepted this revision. bshah added a subscriber: tcberner. bshah added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > main_wayland.cpp:424-426 > +#if HAVE_PR_SET_DUMPABLE > +prctl(PR_SET_DUMPABLE, 1); > +#endif This also need adaption for

[Differential] [Accepted] D1022: [server] Properly initialize Cursor

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-fix-cursor-damage REVISION DETAIL https://phabricator.kde.org/D1022 EMAIL PREFERENCES

[Differential] [Accepted] D1008: [Image Wallpaper] Make color picker visible for all positioning mode.

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Looks good to me, I will submit this patch in master branch. Congratulations on your first patch to KDE. REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Accepted] D827: Suspend/Hibernate through daemon instead of greeter

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH powermanagement-daemon REVISION DETAIL https://phabricator.kde.org/D827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D858: [server] Expose executable path in ClientConnection

bshah added a comment. +1, Looks good to me. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D858 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, mart Cc: bshah, plasma-devel

[Differential] [Accepted] D859: [processui] Safety checks for platform != x11

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rLIBKSYSGUARD KSysguard Library BRANCH fix-on-wayland REVISION DETAIL https://phabricator.kde.org/D859 EMAIL PREFERENCES

[Differential] [Accepted] D846: Enforce wayland QPA for greeter if running on Wayland

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH enforce-qpa-wayland REVISION DETAIL https://phabricator.kde.org/D846 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D955: Remove KCrash from KSldApp

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH no-kcrash REVISION DETAIL https://phabricator.kde.org/D955 EMAIL PREFERENCES

[Differential] [Accepted] D956: Pass a parent QObject to the AbstractLocker and it's subclasses

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH abstract-locker-parent REVISION DETAIL https://phabricator.kde.org/D956 EMAIL PREFERENCES

[Differential] [Accepted] D1398: [autotest] Add a test case for the shadow interface

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH shadow-test REVISION DETAIL https://phabricator.kde.org/D1398 EMAIL PREFERENCES

[Differential] [Accepted] D1401: [client] Fix FakeInput::requestPointerAxis

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH fix-fake-input-axis-5.6 REVISION DETAIL https://phabricator.kde.org/D1401 EMAIL PREFERENCES

[Differential] [Accepted] D1400: [autotests] Add test case for FakeInputInterface

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH fake-input-test REVISION DETAIL https://phabricator.kde.org/D1400 EMAIL PREFERENCES

[Differential] [Accepted] D1389: [autotest] Add a test case for Idle interface

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH test-case-idle REVISION DETAIL https://phabricator.kde.org/D1389 EMAIL PREFERENCES

[Differential] [Accepted] D1359: Support for QT_IM_MODULE qtvirtualkeyboard

bshah accepted this revision. bshah added a reviewer: bshah. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH virtual-keyboard REVISION DETAIL https://phabricator.kde.org/D1359 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, Plasma,

[Differential] [Commented On] D1326: Fix search keyword "animation speed" pointing to the wrong KCM

bshah added a comment. +1, but OpenGL,XRender,video settings keywords also should move away? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1326 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: colomar, Plasma Cc: bshah,

[Differential] [Accepted] D1082: Only require Qt 5.4

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH kcm-remove-themes REVISION DETAIL https://phabricator.kde.org/D1082 EMAIL PREFERENCES

[Differential] [Commented On] D1082: [kcm] Remove QQuickView for themes

bshah added a comment. Accepted given in previous review still stands. REVISION DETAIL https://phabricator.kde.org/D1082 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, Plasma Cc: bshah, plasma-devel

[Differential] [Accepted] D1312: Add auto test for grace time

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH grace-time-test REVISION DETAIL https://phabricator.kde.org/D1312 EMAIL PREFERENCES

[Differential] [Accepted] D1311: Add autotest to verify that screen starts to lock on idle timeout

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH idle-test REVISION DETAIL https://phabricator.kde.org/D1311 EMAIL PREFERENCES

[Differential] [Accepted] D1248: [autotest] Add test case for mapping/unmapping surfaces in a sub-surface tree

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH autotest-subsurface-tree-mapping-test REVISION DETAIL https://phabricator.kde.org/D1248 EMAIL PREFERENCES

[Differential] [Accepted] D1481: Make integration with KScreenLocker optional in WaylandServer

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH disable-lockscreen-integration REVISION DETAIL https://phabricator.kde.org/D1481 EMAIL PREFERENCES

[Differential] [Commented On] D1501: [autotest] Work around "cannot assign undefined" warning

bshah added a comment. This should also be backported to framewokintegration. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1501 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Accepted] D1571: [kcms/touchpad] Disable kded module on platforms != x11

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH touchpad-kded-disable-wayland REVISION DETAIL https://phabricator.kde.org/D1571 EMAIL PREFERENCES

[Differential] [Accepted] D1547: Don't reset InputDevicesModel when devices change

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH debug-console-devices-no-reset REVISION DETAIL https://phabricator.kde.org/D1547 EMAIL PREFERENCES

[Differential] [Accepted] D1597: Bind sending frameRendered to whether we have a Wayland Server not to operation mode

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH frame-rendered-bound-to-wayland-server REVISION DETAIL https://phabricator.kde.org/D1597 EMAIL PREFERENCES

[Differential] [Accepted] D1606: [KSplashQML] Don't wait for KWin to start on Wayland

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Looks good to me.. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1606 EMAIL PREFERENCES

[Differential] [Accepted] D1509: Honor input mask set on internal windows

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH input-mask-internal-window REVISION DETAIL https://phabricator.kde.org/D1509 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D1552: Fix typo in TooltipDelegate

bshah created this revision. bshah added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As pointed by Yuking on IRC REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL

[Differential] [Request, 2 lines] D1546: Fix the building of tests in parallel

bshah created this revision. bshah added reviewers: Plasma, sebas. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY tests depend on kded module, for this check was added in 34acf3 but 6cc50d ported plugin to json

[Differential] [Closed] D1546: Fix the building of tests in parallel

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENc5fec5f1b1d5: Fix the building of tests in parallel (authored by bshah). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1546?vs=3665=3666 REVISION DETAIL

[Differential] [Closed] D1570: fix serializertest by adding missing data

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREEN82cd8f829498: fix serializertest by adding missing data (authored by bshah). REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1570?vs=3714=3742 REVISION

[Differential] [Accepted] D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. Tested and works on mobile. REPOSITORY rKWIN KWin BRANCH vt-integration-through-logind REVISION DETAIL https://phabricator.kde.org/D1444 EMAIL PREFERENCES

[Differential] [Accepted] D1445: Get the logind session to take over through env variable instead of own PID

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Please adjust commit message to remove reference of KWIN_LOGIN_SESSION before landing this. REPOSITORY rKWIN KWin BRANCH logind-session-arg REVISION

[Differential] [Accepted] D1341: Add metainfo.yaml as needed for frameworks

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH metainfo REVISION DETAIL https://phabricator.kde.org/D1341 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation

bshah added a comment. In https://phabricator.kde.org/D1444#27056, @aspotashev wrote: > Does this mean Ctrl+Alt+Fxx won't work without systemd, i.e. I'll need to hard reset my computer when Plasma session crashes or hangs up? You don't need systemd to be your init, and

[Differential] [Accepted] D1396: Add PROJECT_VERSION to CMakeLists.txt

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH project-version-cmakelist REVISION DETAIL https://phabricator.kde.org/D1396 EMAIL PREFERENCES

[Differential] [Request, 68 lines] D1570: fix serializertest by adding missing data

bshah created this revision. bshah added reviewers: Plasma, sebas, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Commit 94f235 introduced test to verify corrupt configs are handled properly but testdata in

[Differential] [Accepted] D1542: [kcms/input] Make mouse KCM work on non-X11

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Sounds sane. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH input-mouse-wayland REVISION DETAIL https://phabricator.kde.org/D1542 EMAIL PREFERENCES

[Differential] [Accepted] D1550: Move everything KCrash related from Application to ApplicationX11

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH kcrash-x11-only REVISION DETAIL https://phabricator.kde.org/D1550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Closed] D1552: Fix typo in TooltipDelegate

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPc05d5a1c0a37: Fix typo in TooltipDelegate (authored by bshah). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1552?vs=3683=3715 REVISION

[Differential] [Accepted] D1681: Bind seat hasKeyboard capability to alphanumeric keyboard availability

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Sane.. REPOSITORY rKWIN KWin BRANCH bind-seat-keyboard-capability-to-alpha REVISION DETAIL https://phabricator.kde.org/D1681 EMAIL PREFERENCES

[Differential] [Accepted] D2294: categorized logging for kscreen kcm

bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Apart from d_ed's comment looks good, perhaps you can change to ecm macro in different revision... REPOSITORY rKSCREEN KScreen BRANCH sebas/kcmcatlogging

[Differential] [Accepted] D2295: improve logging for kscreen

bshah accepted this revision. bshah added a reviewer: bshah. bshah added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > testlog.cpp:88 > +qputenv(KSCREEN_LOGFILE, logfile); > +qputenv(KSCREEN_LOGGING, QByteArray("faLSe")); > + nitpick - cAPs. ;-)

[Differential] [Accepted] D2343: [wayland] Always have a keyboard on the Seat

bshah accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH seat-always-keyboard REVISION DETAIL https://phabricator.kde.org/D2343 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah,

[Differential] [Request, 2,040 lines] D2351: Remove sddm theme from look and feel

bshah created this revision. bshah added reviewers: davidedmundson, sitter. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently we install sddm theme twice, once where sddm expects theme and another in look

[Differential] [Updated] D2351: Remove sddm theme from look and feel

bshah added a reviewer: mart. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2351 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, davidedmundson, sitter, mart Cc: plasma-devel, ali-mohamed,

[Differential] [Commented On] D2352: Change default wallpaper plugin to org.kde.color

bshah added a comment. Perhaps we should as well define the default color used? Not sure how it would work config wise.. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D2352 EMAIL PREFERENCES

[Differential] [Commented On] D2352: Change default wallpaper plugin to org.kde.color

bshah added a comment. In https://phabricator.kde.org/D2352#43900, @bshah wrote: > Perhaps we should as well define the default color used? Not sure how it would work config wise.. Ignore this, cleared up on IRC... "Ship it" from my side.. REPOSITORY rKSCREENLOCKER

[Differential] [Closed] D2351: Remove sddm theme from look and feel

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEab5de0c89fbb: Remove sddm theme from look and feel (authored by bshah). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2351?vs=5679=5680#toc REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Updated, 2,026 lines] D2351: Remove sddm theme from look and feel

bshah updated this revision to Diff 5679. bshah added a comment. update readme REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2351?vs=5672=5679 BRANCH sddm-remove-from-lookandfeel REVISION DETAIL https://phabricator.kde.org/D2351

  1   2   3   >