[Differential] [Requested Changes To] D409: new mobile components

davidedmundson added a subscriber: davidedmundson. davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. This revision now requires changes to proceed. INLINE COMMENTS components/mobilecomponents/ActionGroup.qml:26 to make sure I've got this:

[Differential] [Accepted] D409: new mobile components

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAMOBILE plasma-mobile REVISION DETAIL https://phabricator.kde.org/D409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma:

[Differential] [Commented On] D797: Require user to authenticate when trying to change lock screen settings

davidedmundson added a comment. In fact with this, you can now never remove a user. That's definitely a blocker > When set, prevents, even the superuser, from erasing or changing the contents > of the file. INLINE COMMENTS auth-helper/kscreenlockerauthhelper.cpp:94 Unintuitively, you're

[Differential] [Updated] D797: Require user to authenticate when trying to change lock screen settings

davidedmundson added a comment. This breaks every user's backup script by having root files in the user's home. So I am very much not happy with this idea at all. Especially as it acheives very little anyway, if you have a malicious app on your system - why on Earth does it want to modify your

[Differential] [Commented On] D1765: [KRunner] Disable high dpi scaling

davidedmundson added a comment. That's working round a genuine bug rather than fixing it. If it's in Qt, and you want to do this temporarily, go ahead and ship it. But you have to at least investigate first. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Updated, 832 lines] D1670: New login screen

davidedmundson updated this revision to Diff 4198. davidedmundson added a comment. changes REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1670?vs=4008=4198 BRANCH login REVISION DETAIL https://phabricator.kde.org/D1670 AFFECTED

[Differential] [Updated, 833 lines] D1670: New login screen

davidedmundson updated this revision to Diff 4210. davidedmundson added a comment. Kai's final comments REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1670?vs=4198=4210 BRANCH login REVISION DETAIL

[Differential] [Commented On] D1664: Update for Breeze-gtk

davidedmundson added a comment. Fixed and pushed. REPOSITORY rBREEZEGTK Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D1664 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dirrukd, #plasma, mart Cc: davidedmundson, mart, plasma-devel,

[Differential] [Request, 21 lines] D1768: Pass screen ID to systray applets

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The Corona generally is responsible for managing which screen a containment is on. However

[Differential] [Closed] D1670: New login screen

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE788c0110efcd: New login screen (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1670?vs=4210=4306#toc REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Request, 1 line] D1802: Hide the fact that sebas managed to spell his own name wrong.Not once, but 62 times.

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY git shortlog now shows the right entries REPOSITORY rLIBKSCREEN KScreen Library BRANCH

[Differential] [Accepted] D1757: [Panel] Reduce duplicate enabled borders calculation

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > broulik wrote in Panel.qml:29 > Dunno if we still need this, ie. if we need a way to signal this back

[Differential] [Request, 199 lines] D1772: Port custom collasablebutton to KWidgetAddons::KCollapsibleGroupBox

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Saves duplicating code using a shared implementation. REPOSITORY rKSCREEN KScreen BRANCH

[Differential] [Accepted] D1724: Import Task Manager widgets ports to the new library.

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH importtmng REVISION DETAIL https://phabricator.kde.org/D1724 EMAIL PREFERENCES

[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation

davidedmundson added a comment. @mart See https://phabricator.kde.org/D1756 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson,

[Differential] [Commented On] D1769: [Service Runner] Don't use KRun::runService

davidedmundson added a comment. This now matches what Icon is doing, but Kicker is using: new KRun(QUrl::fromLocalFile(service->entryPath()), 0, true, ...); This puts the kservice parsing into being done by klauncher/kinit which seems more "right". Does using ->exec() skip the

[Differential] [Accepted] D1756: [PanelView] Expose enabled borders as property and also forward it to PanelShadows

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1756 EMAIL PREFERENCES

[Differential] [Accepted] D1722: Import next-gen libtaskmanager.

davidedmundson accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, graesslin, lbeltrame, #plasma, davidedmundson Cc: lbeltrame,

[Differential] [Accepted] D1765: [KRunner] Disable high dpi scaling

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. > but also the TextField sizing is completely broken because Plasma Components don't handle Qt scaling well. Ship it!

[Differential] [Accepted] D1774: Save code by using newly-added KActivities::Consumer signal.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1774 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Accepted] D1769: [Service Runner] Don't use KRun::runService

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1769 EMAIL PREFERENCES

[Differential] [Accepted] D1791: Give a screen to systray applets

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. much neater ++ INLINE COMMENTS > shellcorona.cpp:345 > foreach(Plasma::Containment *containment, containments()) {

[Differential] [Closed] D1768: Pass screen ID to systray applets

davidedmundson closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1768 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, sebas

[Differential] [Commented On] D1826: systemtray container: fix m_internalSystray nullptr crash

davidedmundson added a comment. Surely we should have already returned at line 94. Do you have the bt still? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1826 EMAIL PREFERENCES

[Differential] [Accepted] D1826: systemtray container: fix m_internalSystray nullptr crash

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. My bad. That'll teach me to review on my phone. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1826

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

davidedmundson added a comment. If it's not released, we can't use it. I'm sure you've personally told me that when I've needed Kubuntu to do something in the past. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL

[Differential] [Request, 97 lines] D1815: Add an Activities list into the context menu

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This makes the task manager's context menu match KWin's titlebar context menu. BUG:

[Differential] [Request, 12 lines] D1809: Fix i18n in plasmacalendarintegration

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL

[Differential] [Request, 2 lines] D1810: Don't call a plugin "something plugin"

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The fact that it's a plugin isn't very relevant. REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Abandoned] D1802: Hide the fact that sebas managed to spell his own name wrong.Not once, but 62 times.

davidedmundson abandoned this revision. davidedmundson added a comment. pushed with a more professional commit message, so closing this manually. REPOSITORY rLIBKSCREEN KScreen Library REVISION DETAIL https://phabricator.kde.org/D1802 EMAIL PREFERENCES

[Differential] [Closed] D1810: Don't call a plugin "something plugin"

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE84671a081382: Don't call a plugin "something plugin" (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1809: Fix i18n in plasmacalendarintegration

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6f0a88a2a500: Fix i18n in plasmacalendarintegration (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1802: Hide the fact that sebas managed to spell his own name wrong.Not once, but 62 times.

This revision was automatically updated to reflect the committed changes. Closed by commit rLIBKSCREEN8a23e004e02d: Provide .mailmap file to fix broken locale in git logs (authored by davidedmundson). REPOSITORY rLIBKSCREEN KScreen Library CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D1722: Import next-gen libtaskmanager.

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. I think this is good to go. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1722 EMAIL PREFERENCES

[Differential] [Updated, 818 lines] D1670: New login screen

davidedmundson updated this revision to Diff 4008. davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Fix most of Kai's comments - only missing changing the user selection screen, as I dont' know what icon to use REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Accepted] D1690: kfontinst: Port away from kde_file.h

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. If you go to identity.kde.org you should see an option to upgrade to a developer account then you can commit. Put my

[Differential] [Request, 156 lines] D1814: Add TaskManager requestActivities

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Acts like requestVirtualDesktops only with a QStringList make runningActivities invokable

[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font

davidedmundson added a comment. ok, but it'd have to be 5.8 given we're past dependency freeze. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1816 EMAIL PREFERENCES

[Differential] [Accepted] D1838: Add a prop to toggle the special grouping behavior for tasks in demanding-attention state.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein,

[Differential] [Updated, 26 lines] D1814: Add TaskManager requestActivities

davidedmundson updated this revision to Diff 4339. davidedmundson added a comment. Add docs for wayland side REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1814?vs=4327=4339 BRANCH master REVISION DETAIL

[Differential] [Accepted] D1824: fix name of translation catalog

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rDISCOVER Discover Software Store REVISION DETAIL https://phabricator.kde.org/D1824 EMAIL PREFERENCES

[Differential] [Request, 31 lines] D1850: Write out scaling in QT_SCREEN_SCALE_FACTORS format

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKSCREEN KScreen BRANCH scale_factos REVISION DETAIL https://phabricator.kde.org/D1850

[Differential] [Request, 6 lines] D1849: Write out QT_SCREEN_SCALE_FACTORS instead of deprecated QT_DEVICE_PIXEL_RATIO

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We use QT_SCREEN_SCALE_FACTORS as opposed to QT_SCALE_FACTOR as we need to use one that will

[Differential] [Updated, 230 lines] D1772: Port custom collasablebutton to KWidgetAddons::KCollapsibleGroupBox

davidedmundson updated this revision to Diff 4410. davidedmundson added a comment. - Write out scaling in QT_SCREEN_SCALE_FACTORS format REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1772?vs=4231=4410 BRANCH master REVISION DETAIL

[Differential] [Request, 13 lines] D1859: Prepare KSplash for KDED dropping KSplash support

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We want to drop workspace code from KDED as it doesn't make much sense semantically.

[Differential] [Updated] D1859: Prepare KSplash for KDED dropping KSplash support

davidedmundson added a reviewer: dfaure. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1859 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, dfaure Cc: plasma-devel, sebas

[Differential] [Accepted] D1888: [startkde] Call KSplash dbus after checking for kinit

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. + REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1888 EMAIL PREFERENCES

[Differential] [Closed] D1849: Write out QT_SCREEN_SCALE_FACTORS instead of deprecated QT_DEVICE_PIXEL_RATIO

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE440a3d7c2035: Write out QT_SCREEN_SCALE_FACTORS instead of deprecated QT_DEVICE_PIXEL_RATIO (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST

[Differential] [Commented On] D1722: Import next-gen libtaskmanager.

davidedmundson added a comment. Reviewed up to "libtaskmanager/taskfilterproxymodel.h" Will submit this now, in case phabricator doesn't save it. INLINE COMMENTS > CMakeLists.txt:86 > +endif() > + >

[Differential] [Accepted] D1692: kfontinst: Port away from Kdelibs4Support

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1692 EMAIL PREFERENCES

[Differential] [Accepted] D1745: [Icon Widget] Don't use plasma theme for icon

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1745 EMAIL PREFERENCES

[Differential] [Commented On] D1748: [KCM Keyboard] Delay initializing mouse

davidedmundson added a comment. Why doesn't it work immediately? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1748 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: davidedmundson,

[Differential] [Commented On] D1670: New login screen

davidedmundson added a comment. In https://phabricator.kde.org/D1670#31368, @andreask wrote: > In https://phabricator.kde.org/D1670#31201, @davidedmundson wrote: > > > Fix most of Kai's comments > > > > - only missing changing the user selection screen, as I dont' know what icon

[Differential] [Commented On] D1670: New login screen

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in Background.qml:36 > are we sure that one is implemented with a software renderer? It works with QT_XCB_FORCE_SOFTWARE_OPENGL=1 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Changed Subscribers] D1699: Limit BasicListItem width and elide text

davidedmundson edited subscribers, added: plasma-devel; removed: Plasma. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1699 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: plasma-devel

[Differential] [Changed Subscribers] D1698: A component shouldn't manage it's own geometry

davidedmundson edited subscribers, added: plasma-devel; removed: Plasma. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1698 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: plasma-devel

[Differential] [Request, 5 lines] D1890: Fix crash on kquitapp/logout

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY qDeleteAll will iterate through containments() however this is dynamically changing the list

[Differential] [Commented On] D1890: Fix crash on kquitapp/logout

davidedmundson added a comment. FWIW, longer term I believe the correct fix is to remove all of this. Corona::~Corona will delete containments anyway (as the parent) and we already delete a view if a containment gets deleted. (or at least should) but I'm not going to make a change that

[Differential] [Closed] D1890: Fix crash on kquitapp/logout

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEbf85b2fe7f44: Fix crash on kquitapp/logout (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 4 lines] D1974: Don't set both font and pixel size in DigitalClock

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Digital Clock sets fontSizeMode, this scales the font to fit between a tiny size and a the

[Differential] [Closed] D1814: Add TaskManager requestActivities

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb7f0f2fae7b6: Add TaskManager requestActivities (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1814?vs=4639=4655#toc REPOSITORY rPLASMAWORKSPACE

[Differential] [Closed] D1950: Match Prison version exactly

davidedmundson closed this revision. davidedmundson added a comment. I've submitted this, don't know why phab didn't autoclose REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1950 EMAIL PREFERENCES

[Differential] [Closed] D1815: Add an Activities list into the context menu

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP4ee63deda86b: Add an Activities list into the context menu (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1815?vs=4328=4656#toc REPOSITORY

[Differential] [Request, 3 lines] D1971: Disable high DPI scaling on kscreenlocker

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Plasma already scales, so enabling Qt's scaling acheives nothing. Worst still it highlights

[Differential] [Accepted] D1891: [Holiday Events] Handle holidays spanning multiple days

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1891 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mck182,

[Differential] [Closed] D1859: Prepare KSplash for KDED dropping KSplash support

davidedmundson closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1859 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, dfaure Cc: graesslin, plasma-devel,

[Differential] [Closed] D1850: Write out scaling in QT_SCREEN_SCALE_FACTORS format

davidedmundson closed this revision. davidedmundson added a comment. submitted, just didn't autoclose for some reason. REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D1850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D1895: Finish implementation of mode in which launchers are not kept separate.

davidedmundson added inline comments. INLINE COMMENTS > tasksmodel.cpp:544 > + > + if (i < insertPos) { > + --insertPos; Sure this logic is the right way round? (I'm not convinced it's wrong either, I'm just confused) at the start of the

[Differential] [Accepted] D1896: Expose separate-launchers toggle in config.

davidedmundson accepted this revision. davidedmundson added inline comments. INLINE COMMENTS > main.xml:63 > > - > why? REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1896 EMAIL PREFERENCES

[Differential] [Request, 5 lines] D1933: Avoid appending superfluous \n

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We want a \n between lines, but by always ending with \n we end up with the tooltip subtext

[Differential] [Closed] D1966: Set System Tray AppletItem width properly

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEaa5fde007d70: Set System Tray AppletItem width properly (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1956: Create logging categories via CMake

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEef2fd6d9795e: Create logging categories via CMake (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1960: Fix krunner build without qalculate

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfb870b6f7766: Fix krunner build without qalculate (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 13 lines] D1953: Fix XembedSNIProxy Logging Category Registration

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH logging_categories REVISION DETAIL

[Differential] [Request, 73 lines] D1954: Port KIO Remote to use ECM declare logging category

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1954 AFFECTED

[Differential] [Request, 78 lines] D1956: Create logging categories via CMake

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Also set a consistent naming structure and to be only Info+ by default. This may mean you

[Differential] [Request, 4 lines] D1952: Don't set width and height in a layout

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Layouts adjust the size of the children by changing the width and height replacing our

[Differential] [Request, 5 lines] D1946: Expose WindowGeometry in TasksModel

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ready for Pager/ActivityPager to use and drop their own plugins. (proof of concept Pager seems to work) REPOSITORY

[Differential] [Commented On] D1976: Image of the Day wallpaper plugin

davidedmundson added inline comments. INLINE COMMENTS > bgupta wrote in config.qml:27 > I was initially using ColumnLayout, but the problem there was that the > contents were expanding to fill the entire height of the dialog, with huge > spacing between rows. Using Column just works. oh, you

[Differential] [Commented On] D1976: Image of the Day wallpaper plugin

davidedmundson added a comment. Seems generally good. INLINE COMMENTS > config.qml:27 > + > +Column { > +id: root; If you switch these to ColumnLayout / RowLayout (from QtQuick.Layouts, which you're currently not using) you can get rid of a lot of the anchors and widths in this code.

[Differential] [Closed] D1952: Don't set width and height in a layout

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPdf9e2d1f329b: Don't set width and height in a layout (authored by davidedmundson). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D1954: Port KIO Remote to use ECM declare logging category

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE6efdd7a14eb9: Port KIO Remote to use ECM declare logging category (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1956: Create logging categories via CMake

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in CMakeLists.txt:10 > Why SYSTEM_TRAY and not SYSTEMTRAY? It looks like lots was touched just to > add the underscore. Good question, with a very frustrating answer. otherwise macro creates a file with the guard

[Differential] [Request, 7 lines] D1960: Fix krunner build without qalculate

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Compiles, can copy text REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION

[Differential] [Updated, 194 lines] D1814: Add TaskManager requestActivities

davidedmundson updated this revision to Diff 4639. davidedmundson added a comment. Updated with extra proxy model REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1814?vs=4339=4639 BRANCH activities REVISION DETAIL

[Differential] [Closed] D1949: Revert all login screen changes as per VDG request untilthey have a consistent design.

davidedmundson closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1949 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, broulik, graesslin Cc: graesslin, broulik, plasma-devel,

[Differential] [Closed] D1933: Avoid appending superfluous \n

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMANM1fafa23c80a6: Avoid appending superfluous \n (authored by davidedmundson). REPOSITORY rPLASMANM Plasma Network Management Applet CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1953: Fix XembedSNIProxy Logging Category Registration

davidedmundson added a comment. In https://phabricator.kde.org/D1953#36014, @graesslin wrote: > What was wrong with it? The old code looks correct to me as well. So what does this change "Fix"? I had two Q_LOGGING_CATEGORY's one made by the marco, one done by hand. Then

[Differential] [Accepted] D1893: [Panel Config Overlay] Make spacer size handles narrower

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1893 EMAIL PREFERENCES

[Differential] [Accepted] D1907: [System Tray] Hide popup when user configuring

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1907 EMAIL PREFERENCES

[Differential] [Commented On] D1911: [Smart Launcher Backend] Use KSharedConfig::openConfig

davidedmundson added a comment. what does this achieve? SharedConfig ref counts; you unless there's someone else holding a reference, it'll still be reloading it every time. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1911 EMAIL

[Differential] [Accepted] D1895: Finish implementation of mode in which launchers are not kept separate.

davidedmundson accepted this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH blblblbl (branched from master) REVISION DETAIL https://phabricator.kde.org/D1895 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, mart, davidedmundson

[Differential] [Request, 43 lines] D1986: WIP: Save PanelView settings in terms of grid units

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This is useful for HighDPI otherwise a user needs to manually resize the panel initially

[Differential] [Accepted] D1939: [Calculator Runner] Add "Copy to clipboard" action

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1939 EMAIL PREFERENCES

[Differential] [Updated] D1949: Revert all login screen changes as per VDG request untilthey have a consistent design.

davidedmundson retitled this revision from "Revert all login screen changes as per VDG request until they have a consistent design. Revert "Restore last selected user"" to "Revert all login screen changes as per VDG request until they have a consistent design.". REPOSITORY rPLASMAWORKSPACE

[Differential] [Request, 1,186 lines] D1949: Revert all login screen changes as per VDG request untilthey have a consistent design.Revert "Restore last selected user"

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This reverts commit https://phabricator.kde.org/rPLASMAWORKSPACE4de1116e31f6268bb0676869493101653412d571. Revert "Fix i18n"

[Differential] [Accepted] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1940 EMAIL PREFERENCES

[Differential] [Request, 2 lines] D1950: Match Prison version exactly

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Prison API changes between minor releases. find_package() was finding any version,

[Differential] [Accepted] D807: Fix for Bug 357684

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D807 EMAIL PREFERENCES

[Differential] [Accepted] D787: Properly set modality on AuthDialog

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPOLKITKDEAGENT Policykit (Polkit) KDE Agent BRANCH fix-modality REVISION DETAIL https://phabricator.kde.org/D787 EMAIL PREFERENCES

  1   2   3   4   5   6   7   8   9   10   >