Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Feb. 8, 2017, 12:05 p.m.) Status -- This change has been discarded. Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal
Re: Plasma appet with C++ plugin
On Fri, Apr 29, 2016 at 3:09 PM, Marco Martin <notm...@gmail.com> wrote: > On Tuesday 26 April 2016 22:03:11 Pablo Sánchez RodrÃguez wrote: > > Hello, > > > > My name is Pablo and currently I am writing an applet for Plasma > (Plasmoid). > > > > Due to new functions I would like to implement in my applet, I need to > > create a plugin written in C++ (using Kdeclarative). > > > > My questions are: > > > > Does anybody know where I can find documentation about how to do it? All > I > > could do until now was done watching inside other projects. > > David has wrote some nice blog posts[0] about creating Plasmoid. You might want to check them out. the best way is to start from the application template. > with a recent enough version of plasma framework, in KDevelop (or > KAppTemplate) you should have in the project templates both a pure qml and > a > mixed qml/c++ version. > > a quick introduction to mixed qml/c++ is at > > https://community.kde.org/Plasma/DeveloperGuide#Advanced:_Plasmoids_using_C.2B.2B > > -- > Marco Martin > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > [0] http://blog.davidedmundson.co.uk/node/89 -- *Regards,* *Ashish Bansal* *http://ashish-bansal.in <http://ashish-bansal.in>* ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: robots.txt in quickgit.kde.org
On Tue, Dec 29, 2015 at 3:09 PM, Ben Cooksley <bcooks...@kde.org> wrote: > On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher <ly...@kde.org> wrote: > > On Sun, Dec 27, 2015 at 12:35 PM, Ben Cooksley <bcooks...@kde.org> > wrote: > >>> Is there some place where search engines can easily index our source > >>> code or are we shooting ourselves in the foot here? > >> > >> We could probably make it available by publishing the source trees > >> used by LXR / EBN. > >> This would only have the main branches obviously rather than everything > though. > >> > >> I haven't checked, but LXR may already make it's copy of the code > accessible... > > > > I think making our sourcecode available to search engines is pretty > > important for the reasons already mentioned by others. Do you need > > help for it? If you write down what's needed I can help find someone > > to do it. > > I've now provisioned https://sources.kde.org/ > > Thanks a lot! > > > > > > Cheers > > Lydia > > Regards, > Ben > > > > > -- > > Lydia Pintscher - http://about.me/lydia.pintscher > > KDE e.V. Board of Directors / KDE Community Working Group > > http://kde.org - http://open-advice.org > > > >>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to > unsubscribe << > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- *Regards,* *Ashish Bansal* *http://ashish-bansal.in <http://ashish-bansal.in>* ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
robots.txt in quickgit.kde.org
Hi everyone, "quickgit.kde.org" contains robots.txt[0] which is disallowing search engines to fetch the project repos. I just wanted to know if this is intentional or not? If I recall correctly, mirror of kde repositories on github was created just because it wasn't being indexed by the search engines. [0] https://quickgit.kde.org/robots.txt -- *Regards,* *Ashish Bansal* *http://ashish-bansal.in <http://ashish-bansal.in>* ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review89948 --- Ship it! libs/mediacenter/lastfmimagefetcher.cpp (line 172) <https://git.reviewboard.kde.org/r/125993/#comment61653> Use QTimer:singleShot(0, your_slot) instead for better response and remove runSignal. libs/mediacenter/lastfmimagefetcher.cpp (line 176) <https://git.reviewboard.kde.org/r/125993/#comment61655> May be LastFmImageFetcher::setupImageFetcher ? libs/mediacenter/medialibrary.h (line 59) <https://git.reviewboard.kde.org/r/125993/#comment61657> mediaUpdated still sounds wrong, although I am not sure what it should be named. Anyway replace it with more logically correct name. - Ashish Bansal On Dec. 21, 2015, 2:51 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125993/ > --- > > (Updated Dec. 21, 2015, 2:51 p.m.) > > > Review request for Plasma, Ashish Bansal and Bhushan Shah. > > > Repository: plasma-mediacenter > > > Description > --- > > Implemented it like the other datasources. > > Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . > handleLastFmNewMedia then calls fetchImage for each newMedia in the > newMediaList. > > After the image is fetched, gotImage emits the signal mediaUpdated (from > mediaLibrary). This signal is absorbed by signalUpdate in PmcMetaDataModel. > > > Diffs > - > > autotests/CMakeLists.txt 04ba1c3 > autotests/lastfmimagefetchertest.h eb7cb29 > autotests/lastfmimagefetchertest.cpp abb3fd6 > datasources/CMakeLists.txt a7171b7 > datasources/lastfm/CMakeLists.txt PRE-CREATION > datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION > libs/mediacenter/CMakeLists.txt 5a13449 > libs/mediacenter/lastfmimagefetcher.h ecff37e > libs/mediacenter/lastfmimagefetcher.cpp e005077 > libs/mediacenter/medialibrary.h 45744c1 > libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe > > Diff: https://git.reviewboard.kde.org/r/125993/diff/ > > > Testing > --- > > Builds 100%. > Works as expected. > > > Thanks, > > Aditya Dev Sharma > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88730 --- libs/mediacenter/lastfmimagefetcher.cpp (line 152) <https://git.reviewboard.kde.org/r/125993/#comment60834> Remove trailing white spaces. libs/mediacenter/lastfmimagefetcher.cpp (line 155) <https://git.reviewboard.kde.org/r/125993/#comment60833> newMediaList ? Haven't we got image for only one media file yet ? libs/mediacenter/medialibrary.h (line 58) <https://git.reviewboard.kde.org/r/125993/#comment60837> Change it to : void mediaUpdated(QSharedPointer); libs/mediacenter/pmcmetadatamodel.cpp (line 85) <https://git.reviewboard.kde.org/r/125993/#comment60836> Isn't this gonna duplicate the media in the view ? Check PmcMetadataModel::signalUpdate libs/mediacenter/pmcmetadatamodel.cpp (line 87) <https://git.reviewboard.kde.org/r/125993/#comment60835> Remove White space error. - Ashish Bansal On Nov. 23, 2015, 1:50 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125993/ > --- > > (Updated Nov. 23, 2015, 1:50 p.m.) > > > Review request for Plasma, Ashish Bansal and Bhushan Shah. > > > Repository: plasma-mediacenter > > > Description > --- > > Implemented it like the other datasources. > > Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . > handleLastFmNewMedia then calls fetchImage for each newMedia in the > newMediaList. Created a QList for storing the new media. > > After the image is fetched, gotImage emits the signal imageFetched (from > mediaLibrary) with the QList we created earlier. This signal is absorbed by > handleNewMedia in PmcMetaDataModel which does the rest. > > > Diffs > - > > autotests/CMakeLists.txt 04ba1c3 > autotests/lastfmimagefetchertest.h eb7cb29 > autotests/lastfmimagefetchertest.cpp abb3fd6 > datasources/CMakeLists.txt a7171b7 > datasources/lastfm/CMakeLists.txt PRE-CREATION > datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION > libs/mediacenter/CMakeLists.txt 5a13449 > libs/mediacenter/lastfmimagefetcher.h ecff37e > libs/mediacenter/lastfmimagefetcher.cpp e005077 > libs/mediacenter/medialibrary.h 45744c1 > libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe > > Diff: https://git.reviewboard.kde.org/r/125993/diff/ > > > Testing > --- > > Builds 100%. > However the audio scrobbler api doesn't seem to work which I'll fix after > this. > Also, I get the following Output : http://ix.io/mps > Apart from it, all the datasources are loaded and media plays as expected. > > > Thanks, > > Aditya Dev Sharma > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin
> On Nov. 13, 2015, 9:23 a.m., Ashish Bansal wrote: > > libs/mediacenter/lastfmimagefetcher.cpp, line 158 > > <https://git.reviewboard.kde.org/r/125993/diff/2-3/?file=416650#file416650line158> > > > > As imageFetcher is a signal, append "emit" word in the beginning. > > Although it is an empty macro, but it helps in understanding code better. Sorry, I wanted to say imageFetched, not imageFetcher. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88315 --- On Nov. 12, 2015, 7:21 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125993/ > --- > > (Updated Nov. 12, 2015, 7:21 p.m.) > > > Review request for Plasma, Ashish Bansal and Bhushan Shah. > > > Repository: plasma-mediacenter > > > Description > --- > > Implemented it like the other datasources. > > Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . > handleLastFmNewMedia then calls fetchImage for each newMedia in the > newMediaList > > Removed redundant imageFetched from LastFmImageFetcher > gotImage calls the signal imageFetched in PmcImageCache which is again > connected to signalUpdate in PmcMetaDataModel > > > Diffs > - > > autotests/CMakeLists.txt 04ba1c3 > autotests/lastfmimagefetchertest.h eb7cb29 > autotests/lastfmimagefetchertest.cpp abb3fd6 > datasources/CMakeLists.txt a7171b7 > datasources/lastfm/CMakeLists.txt PRE-CREATION > datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION > libs/mediacenter/CMakeLists.txt 5a13449 > libs/mediacenter/lastfmimagefetcher.h ecff37e > libs/mediacenter/lastfmimagefetcher.cpp e005077 > libs/mediacenter/pmcimagecache.h 6399461 > libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe > > Diff: https://git.reviewboard.kde.org/r/125993/diff/ > > > Testing > --- > > Built and Tested. > > > Thanks, > > Aditya Dev Sharma > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88315 --- libs/mediacenter/lastfmimagefetcher.cpp (line 156) <https://git.reviewboard.kde.org/r/125993/#comment60563> As imageFetcher is a signal, append "emit" word in the beginning. Although it is an empty macro, but it helps in understanding code better. - Ashish Bansal On Nov. 12, 2015, 7:21 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125993/ > --- > > (Updated Nov. 12, 2015, 7:21 p.m.) > > > Review request for Plasma, Ashish Bansal and Bhushan Shah. > > > Repository: plasma-mediacenter > > > Description > --- > > Implemented it like the other datasources. > > Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . > handleLastFmNewMedia then calls fetchImage for each newMedia in the > newMediaList > > Removed redundant imageFetched from LastFmImageFetcher > gotImage calls the signal imageFetched in PmcImageCache which is again > connected to signalUpdate in PmcMetaDataModel > > > Diffs > - > > autotests/CMakeLists.txt 04ba1c3 > autotests/lastfmimagefetchertest.h eb7cb29 > autotests/lastfmimagefetchertest.cpp abb3fd6 > datasources/CMakeLists.txt a7171b7 > datasources/lastfm/CMakeLists.txt PRE-CREATION > datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION > libs/mediacenter/CMakeLists.txt 5a13449 > libs/mediacenter/lastfmimagefetcher.h ecff37e > libs/mediacenter/lastfmimagefetcher.cpp e005077 > libs/mediacenter/pmcimagecache.h 6399461 > libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe > > Diff: https://git.reviewboard.kde.org/r/125993/diff/ > > > Testing > --- > > Built and Tested. > > > Thanks, > > Aditya Dev Sharma > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88301 --- libs/mediacenter/lastfmimagefetcher.cpp (line 46) <https://git.reviewboard.kde.org/r/125993/#comment60554> Use latest Qt5 Signal/Slot signal syntax. libs/mediacenter/lastfmimagefetcher.cpp (line 47) <https://git.reviewboard.kde.org/r/125993/#comment60555> This statement seems to be redundant. If no one outside this class listens to this signal, then just remove it, or modify it and make PmcImageCache listen to it. libs/mediacenter/pmcimagecache.cpp (line 100) <https://git.reviewboard.kde.org/r/125993/#comment60556> As this slot is just emitting another signal, you should remove it and emit signal directly in connect function. - Ashish Bansal On Nov. 12, 2015, 4:23 p.m., Aditya Dev Sharma wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125993/ > --- > > (Updated Nov. 12, 2015, 4:23 p.m.) > > > Review request for Plasma, Ashish Bansal and Bhushan Shah. > > > Repository: plasma-mediacenter > > > Description > --- > > Implemented it like the other datasources. > > Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . > handleLastFmNewMedia then calls fetchImage for each newMedia in the > newMediaList > > To update this info, the signal imageFetched is absorbed by > imageFetchedFromLastFm in PmcImageCache. > Inside this imageFetchedFromLastFm, another signalImageFetchedFromLastFm is > emitted which is then absorbed by signalUpdate in PmcMetaDataModel > > > Diffs > - > > autotests/CMakeLists.txt 04ba1c3 > autotests/lastfmimagefetchertest.h eb7cb29 > autotests/lastfmimagefetchertest.cpp abb3fd6 > datasources/CMakeLists.txt a7171b7 > datasources/lastfm/CMakeLists.txt PRE-CREATION > datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION > libs/mediacenter/CMakeLists.txt 5a13449 > libs/mediacenter/lastfmimagefetcher.h ecff37e > libs/mediacenter/lastfmimagefetcher.cpp e005077 > libs/mediacenter/pmcimagecache.h 6399461 > libs/mediacenter/pmcimagecache.cpp fcfe2a8 > libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe > > Diff: https://git.reviewboard.kde.org/r/125993/diff/ > > > Testing > --- > > Built and Tested. > > > Thanks, > > Aditya Dev Sharma > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated May 2, 2015, 4:46 p.m.) Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- fixed issues Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated May 2, 2015, 7:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- Submitted with commit c806f88e4ea65330719fa1721cdf15ea5cbddb5a by Ashish Bansal to branch master. Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 30, 2015, 9:05 a.m.) Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- fixed issues Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 28, 2015, 2:35 p.m., David Faure wrote:
src/core/global.cpp, line 407
https://git.reviewboard.kde.org/r/123224/diff/3/?file=363223#file363223line407
startsWith('.') (using the QChar overload)
Do we even need this special case, with the way the code is now? It
seems to me that removing this first if() branch would work just the same.
Ashish Bansal wrote:
The first if() has been used for getting . (1).txt instead of .txt (1)
But yeah, code looks nasty with this special case. Should I remove this?
- Ashish
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/#review79629
---
On April 30, 2015, 9:05 a.m., Ashish Bansal wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123224/
---
(Updated April 30, 2015, 9:05 a.m.)
Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK.
Bugs: 341773
https://bugs.kde.org/show_bug.cgi?id=341773
Repository: kio
Description
---
For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong
name(something like filename-1 2.6.tar.gz).
Expected name: filename-1.6 (1).tar.gz
Diffs
-
autotests/globaltest.cpp ff8725d
src/core/global.cpp f18ac10
Diff: https://git.reviewboard.kde.org/r/123224/diff/
Testing
---
Works fine!
Thanks,
Ashish Bansal
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 28, 2015, 2:38 p.m.) Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Arjun AK. Changes --- (David) (but Arjun's patch was then reverted) -- also add bug number. Bugs: 341773 https://bugs.kde.org/show_bug.cgi?id=341773 Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: autotests/globaltest.cpp, line 96 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96 This should be (1).txt? Ashish Bansal wrote: imho if my any file starts with ., that's my dot file and I would not like suggestName to remove the dotness of file instead it should append/increment no. at end. But if you still find no. at the starting as better use case, then no problem I'll change it right away. David Faure wrote: I agree, a dot file should keep starting with a dot. Martin Klapetek wrote: Indeed. I'd suggest .(1).txt maybe to also keep the file extension in tact? Yeah that sounds good. Changed it to . (1).txt :) - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 --- On April 26, 2015, 12:19 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 26, 2015, 12:19 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 25, 2015, 7:42 p.m., David Faure wrote: src/core/global.cpp, line 397 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359785#file359785line397 Why do you assemble a list, and then only look at the last element? You just need an int and a QMimeType, if only the last element matters. Also, why loop over every character? Is the goal to handle .foo.txt vs .tar.gz? There's API for that in QMimeDatabase, it can return the mimetype and even the known suffix without any iteration needed, see QMimeDatabase::suffixForFileName. Ah sorry, I didn't know that QMimeDatabase::suffixForFileName can handle .foo.txt vs .tar.gz :) - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review79509 --- On April 26, 2015, 12:19 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 26, 2015, 12:19 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 26, 2015, 12:19 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Changes --- fixed issues Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs (updated) - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: Just a question - why is the current suggested name wrong? In name filename-1.6.tar.gz, 1.6 denotes package version and new suggested name changes it to filename-1 2.6.tar.gz. It should add 1 after the package version and should not increment package name from 1.6 to 2.6. If i keep calling suggestName, it changes it further to 3.6, 4.6 and so on. So, I hope that explains the current suggested name is wrong :) On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: autotests/globaltest.cpp, line 96 https://git.reviewboard.kde.org/r/123224/diff/2/?file=359784#file359784line96 This should be (1).txt? imho if my any file starts with ., that's my dot file and I would not like suggestName to remove the dotness of file instead it should append/increment no. at end. But if you still find no. at the starting as better use case, then no problem I'll change it right away. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 --- On April 4, 2015, 1:15 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 4, 2015, 1:15 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/ --- (Updated April 4, 2015, 1:15 p.m.) Review request for KDE Frameworks, Plasma and Aleix Pol Gonzalez. Repository: kio Description --- For filenames like filename-1.6.tar.gz, KIO::suggestName suggests wrong name(something like filename-1 2.6.tar.gz). Expected name: filename-1.6 (1).tar.gz Diffs - autotests/globaltest.cpp ff8725d src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/123224/diff/ Testing --- Works fine! Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: Thanks for your time on this, good stuff :) Tried it and the only caveat is that after login is done I have to press the back button (the one on the pmc controller) to get my album list. That should be fixed. Yeah I also figured the same. But I was not able to find out why it is happening and the way to correct it :/ On Nov. 3, 2014, 3:48 a.m., Shantanu Tushar wrote: browsingbackends/onlineservices/picasa/picasamodel.h, lines 60-61 https://git.reviewboard.kde.org/r/120855/diff/3/?file=324518#file324518line60 where do you get these from? I made these keys from my own Google Account. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69698 --- On Nov. 2, 2014, 3:34 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:34 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 2, 2014, 1:31 p.m., Bhushan Shah wrote: browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 https://git.reviewboard.kde.org/r/120855/diff/1/?file=322517#file322517line9 Don't use find_libarary as well as never hardcode locations. Instead use find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example Like this - find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct then it's okay because cmake is unable to find its path for me that's why I hardcoded its path. - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 --- On Oct. 28, 2014, 5:50 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:50 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Nov. 2, 2014, 1:31 p.m., Bhushan Shah wrote: browsingbackends/onlineservices/picasa/CMakeLists.txt, line 9 https://git.reviewboard.kde.org/r/120855/diff/1/?file=322517#file322517line9 Don't use find_libarary as well as never hardcode locations. Instead use find_package.. See L25 of plasma-mediacenter/CMakeLists.txt for example Ashish Bansal wrote: Like this - find_package(LibKGAPI2_LIBRARY REQUIRED). If it is correct then it's okay because cmake is unable to find its path for me that's why I hardcoded its path. Bhushan Shah wrote: umm nope but like this, find_package(LibKGAPI2 REQUIRED) Now, I am getting undefined references to all the functions and variables related to that Library. In ccmake, LibKGAPI2_DIR/usr/lib64/cmake/LibKGAPI2 - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69671 --- On Oct. 28, 2014, 5:50 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:50 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:17 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Removed HardCoded libkgapi2 path. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs (updated) - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Nov. 2, 2014, 3:34 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Now no libkgapi2 linking problems. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs (updated) - browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
On Oct. 28, 2014, 5:34 p.m., Aleix Pol Gonzalez wrote: I'm sorry if it's off-topic, but shouldnt' this be using KAccounts? Well I don't know about KAccounts(Just heard once about it from here : http://lists.kde.org/?l=kde-develm=141434675118408w=2). Is there any limitation of libkgapi2, so that I should use KAccounts?? - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/#review69309 --- On Oct. 28, 2014, 5:14 p.m., Ashish Bansal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:14 p.m.) Review request for Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120855: Add Google two-step verification support to PMC Picasa login
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120855/ --- (Updated Oct. 28, 2014, 5:50 p.m.) Review request for KDEPIM, KDEPIM-Libraries, Plasma, Bhushan Shah, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Changes --- Added kdepim and kdepimlibs in groups Bugs: 336398 http://bugs.kde.org/show_bug.cgi?id=336398 Repository: plasma-mediacenter Description --- Changed auth method from Client Login to OAuth using libkgapi2 Diffs - browsingbackends/onlineservices/picasa/picasabackend.h 7144dc7 browsingbackends/onlineservices/picasa/picasabackend.cpp 6317240 browsingbackends/onlineservices/picasa/picasacomponents/PicasaSidePanel.qml e8f97f7 browsingbackends/onlineservices/picasa/picasacomponents/qmldir c790310 browsingbackends/onlineservices/picasa/picasamodel.h 5bce055 browsingbackends/onlineservices/picasa/picasamodel.cpp 2b64156 CMakeLists.txt abea259 browsingbackends/onlineservices/picasa/CMakeLists.txt bd5052d Diff: https://git.reviewboard.kde.org/r/120855/diff/ Testing --- Everything is working fine except that after successful login, user has to press back to view all the albums. Thanks, Ashish Bansal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
