D28461: In sidebar mode show if a module is in default state or not

bport added a comment. Default indicator discussion is now on https://phabricator.kde.org/T13008 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart Cc: GB_2, mart, ngraham, abetts, filipf,

D28461: In sidebar mode show if a module is in default state or not

ervin accepted this revision. ervin added a comment. LGTM REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart Cc: GB_2, mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik,

D28461: In sidebar mode show if a module is in default state or not

GB_2 added a comment. In D28461#640439 , @The-Feren-OS-Dev wrote: > How about instead of a blue dot there's instead an option in the SySe hamburger button menu to use search to filter out any settings pages where settings haven't been changed,

D28461: In sidebar mode show if a module is in default state or not

bport updated this revision to Diff 79771. bport added a comment. - Factorize QML code - Rename isDefault to showDefaultIndicator REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28461?vs=79499=79771 REVISION DETAIL

D28461: In sidebar mode show if a module is in default state or not

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > MenuItem.h:160 > + > +void updateDefault(); > + I don't like the name much, I think it could be confused with updating actual default value or such...

D28461: In sidebar mode show if a module is in default state or not

bport updated this revision to Diff 79499. bport added a comment. Change icon with a blue dot REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28461?vs=78970=79499 REVISION DETAIL https://phabricator.kde.org/D28461 AFFECTED FILES

D28461: In sidebar mode show if a module is in default state or not

bport added inline comments. INLINE COMMENTS > mart wrote in CategoriesPage.qml:207 > try to keep the item count as small as possible, especially in item delegates. > I would really prefer if we could do without this wrapper Indeed this wrapper is not needed > mart wrote in

D28461: In sidebar mode show if a module is in default state or not

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > broulik wrote in CategoriesPage.qml:207 > `Kirigami.Units.iconSizes.small` and elsewhere > > Why do you need this wrapper `Item`, though? try to keep the item

D28461: In sidebar mode show if a module is in default state or not

The-Feren-OS-Dev added a comment. How about instead of a blue dot there's instead an option in the SySe hamburger button menu to use search to filter out any settings pages where settings haven't been changed, meaning that only settings with changes made to them are then listed in the

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. Yes we will need to have a probe for each KCM, and I currently look to reuse this probe in the KCM that will split a bit more data and UI. Some KCM like pulseaudio one don't need that for example, because there is no default setup REPOSITORY R124 System Settings

D28461: In sidebar mode show if a module is in default state or not

ndavis added a comment. In D28461#639470 , @ngraham wrote: > So every single KCM will need to be patched to add a settings proper in support of this? Oof. Is there no easier way? Perhaps we could find a way to turn it to our advantage?

D28461: In sidebar mode show if a module is in default state or not

ngraham added a comment. So every single KCM will need to be patched to add a settings proper in support of this? Oof. Is there no easier way? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg Cc:

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. In D28461#639056 , @ngraham wrote: > Is D28460 the only other patch that's needed? I applied that and then this patch compiled fine, but I don't see any difference in the sidebar,

D28461: In sidebar mode show if a module is in default state or not

ngraham added a comment. Is D28460 the only other patch that's needed? I applied that and then this patch compiled fine, but I don't see any difference in the sidebar, despite having changed some settings from their default values. REPOSITORY R124

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. In D28461#639022 , @ngraham wrote: > I get a compile error: > > /home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function ‘void MenuItem::updateDefault()’: >

D28461: In sidebar mode show if a module is in default state or not

ngraham added a comment. I get a compile error: /home/nate/kde/src/systemsettings/core/MenuItem.cpp: In member function ‘void MenuItem::updateDefault()’: /home/nate/kde/src/systemsettings/core/MenuItem.cpp:154:36: error: ‘isDefaults’ is not a member of ‘KCModuleLoader’ 154 |

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. In D28461#639016 , @abetts wrote: > If I am understanding correctly, this patch adds icons in the kcm list to indicate changes you can revert by going to the kcm. Basically, default settings have changed and now you have

D28461: In sidebar mode show if a module is in default state or not

abetts added a comment. If I am understanding correctly, this patch adds icons in the kcm list to indicate changes you can revert by going to the kcm. Basically, default settings have changed and now you have the possibility to see that changes have been made. I am not sure that I like the

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. F8208462: image.png Test with a blue dot, took less space than an icon Wa can imagine a tooltip when you go hover the dot explaining it REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461

D28461: In sidebar mode show if a module is in default state or not

ndavis added a comment. maybe it would make more sense to add a different way to view non-default settings? like maybe a summary of custom settings. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. Goal of this feature is to improve user discoverability and allow them to find more easily which settings diverged from defaults one, so they can more easily revert to the default value when needed Indeed the current indicator is not the good one, and I will be happy

D28461: In sidebar mode show if a module is in default state or not

filipf added a comment. Can you explain why we want this? It's going to be visually prominent so we need a good reason. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg Cc: filipf,

D28461: In sidebar mode show if a module is in default state or not

The-Feren-OS-Dev added a comment. IMHO this is wholly pointless a change, currently. Most people won't care about if they've made changes or not in SySe from the defaults, and quite frankly seeing that indicator on the sidebar would potentially even deter user customisation if not utterly

D28461: In sidebar mode show if a module is in default state or not

ndavis added a comment. This is merely an indicator and not a button, right? If so, you should not use `edit-reset` since you cannot actually reset the settings there. I'll try to come up with another indicator. I'm concerned that this indicator will make system settings visually messy.

D28461: In sidebar mode show if a module is in default state or not

broulik added a comment. Please include screenshots when you do UI changes. INLINE COMMENTS > CategoriesPage.qml:207 > + > +width: 16 > +height: 16 `Kirigami.Units.iconSizes.small` and elsewhere Why do you need this wrapper `Item`, though?

D28461: In sidebar mode show if a module is in default state or not

bport created this revision. bport added reviewers: Plasma, ervin, meven, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461