Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/
---

(Updated Nov. 23, 2015, 6:59 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Changes
---

Submitted with commit 2608e0d5dffad2eed73caaf0044ab20cc60f1baa by Kai Uwe 
Broulik to branch master.


Repository: plasma-framework


Description
---

This allows to drop a .plasmoid file on a panel or desktop and have it 
automatically installed and placed there.

Video: https://www.youtube.com/watch?v=5MnWnt_u5dU


Diffs
-

  src/scriptengines/qml/CMakeLists.txt 2aedf0b 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 18be65f 

Diff: https://git.reviewboard.kde.org/r/125968/diff/


Testing
---

Works

2.) How can I get the pluginId of the applet? KPackage::metadata() is 
deprecated. Perhaps the KJob should be able to tell me eventually?

3.) How can I get the path to the installed package to get the info for 2.

4.) Not sure about linking KNotifications here


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88731
---

Ship it!


Ship It!

- Marco Martin


On Nov. 23, 2015, 5:22 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 23, 2015, 5:22 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 18be65f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Heiko Tietze]

> On Nov. 5, 2015, 10:31 p.m., Thomas Pfeiffer wrote:
> > Nice feature!
> > There definitely has to be a way to uninstall a Plasmoid, however. Can't we 
> > show an uninstall button when hovering over a Plasmoid in the widget 
> > gallery?
> > 
> > Also, the labeling of the pupop menu when dropping on the desktop is 
> > unfortunate in general, as it is not self-explanatory at all.
> > What are those heading for, anyway? A context menu should only contain only 
> > action items.
> > I know this is a general problem with this menu (which I have not noticed 
> > yet because apparently I never dropped anything on the desktop recently 
> > which opens such a menu), but you should start here by just using a single 
> > entry "Install Wigdet" instead of "Plasma Package" and "Install".
> 
> Heiko Tietze wrote:
> It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link - and Install in case of plasmoids (I wouldn't just disable 
> this item since it's very rarely used).
> 
> Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
> 
> The notification text is too long, redundant and not informative. But 
> that might be the return value from the installation process.
> 
> Kai Uwe Broulik wrote:
> > It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link
> 
> How should that work? Where should the thing end up if I move/copy/link? 
> If you have a FolderView containment you should get that menu, I think.
> > Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
> 
> At least for wallpapers, I have that planned, also. You can already drop 
> JPEG files and the like and use them as a wallaper, only makes sense to be 
> able to drop wallpaper packages as well. Ordinary packages I'd rather not 
> since we cannot provide this for every package format out there (eg. Kickoff 
> also only allows to uninstall applications via packagekit iirc)
> > But that might be the return value from the installation process.
> 
> It is, I'm hoping for an improved API so I can provide a better error 
> message.

>How should that work? Where should the thing end up if I move/copy/link?

The context menu that pops up after drag 'n drop operations should provide the 
Install additonally. Other operations work like for any other file, i.e. just 
move/copy/link the .plasmoid file to the desktop, folder view or whatever.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88067
---


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Marco Martin]

> On Nov. 5, 2015, 10:31 p.m., Thomas Pfeiffer wrote:
> > Nice feature!
> > There definitely has to be a way to uninstall a Plasmoid, however. Can't we 
> > show an uninstall button when hovering over a Plasmoid in the widget 
> > gallery?
> > 
> > Also, the labeling of the pupop menu when dropping on the desktop is 
> > unfortunate in general, as it is not self-explanatory at all.
> > What are those heading for, anyway? A context menu should only contain only 
> > action items.
> > I know this is a general problem with this menu (which I have not noticed 
> > yet because apparently I never dropped anything on the desktop recently 
> > which opens such a menu), but you should start here by just using a single 
> > entry "Install Wigdet" instead of "Plasma Package" and "Install".
> 
> Heiko Tietze wrote:
> It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link - and Install in case of plasmoids (I wouldn't just disable 
> this item since it's very rarely used).
> 
> Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
> 
> The notification text is too long, redundant and not informative. But 
> that might be the return value from the installation process.
> 
> Kai Uwe Broulik wrote:
> > It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link
> 
> How should that work? Where should the thing end up if I move/copy/link? 
> If you have a FolderView containment you should get that menu, I think.
> > Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
> 
> At least for wallpapers, I have that planned, also. You can already drop 
> JPEG files and the like and use them as a wallaper, only makes sense to be 
> able to drop wallpaper packages as well. Ordinary packages I'd rather not 
> since we cannot provide this for every package format out there (eg. Kickoff 
> also only allows to uninstall applications via packagekit iirc)
> > But that might be the return value from the installation process.
> 
> It is, I'm hoping for an improved API so I can provide a better error 
> message.
> 
> Heiko Tietze wrote:
> >How should that work? Where should the thing end up if I move/copy/link?
> 
> The context menu that pops up after drag 'n drop operations should 
> provide the Install additonally. Other operations work like for any other 
> file, i.e. just move/copy/link the .plasmoid file to the desktop, folder view 
> or whatever.

if the desktop is a folderview, yes.
on a normal desktop or on a panel the move/copy/link operations don't apply 
since there isn't anywhere to copy/move to


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88067
---


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Heiko Tietze]

> On Nov. 5, 2015, 10:31 p.m., Thomas Pfeiffer wrote:
> > Nice feature!
> > There definitely has to be a way to uninstall a Plasmoid, however. Can't we 
> > show an uninstall button when hovering over a Plasmoid in the widget 
> > gallery?
> > 
> > Also, the labeling of the pupop menu when dropping on the desktop is 
> > unfortunate in general, as it is not self-explanatory at all.
> > What are those heading for, anyway? A context menu should only contain only 
> > action items.
> > I know this is a general problem with this menu (which I have not noticed 
> > yet because apparently I never dropped anything on the desktop recently 
> > which opens such a menu), but you should start here by just using a single 
> > entry "Install Wigdet" instead of "Plasma Package" and "Install".

It makes sense to use the default context menu for drag operations with Move, 
Copy, Link - and Install in case of plasmoids (I wouldn't just disable this 
item since it's very rarely used).

Users might expect to be able having wallpapers installed via drag and drop and 
perhaps also ordinary packages.

The notification text is too long, redundant and not informative. But that 
might be the return value from the installation process.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88067
---


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Kai Uwe Broulik]

> On Nov. 5, 2015, 10:31 nachm., Thomas Pfeiffer wrote:
> > Nice feature!
> > There definitely has to be a way to uninstall a Plasmoid, however. Can't we 
> > show an uninstall button when hovering over a Plasmoid in the widget 
> > gallery?
> > 
> > Also, the labeling of the pupop menu when dropping on the desktop is 
> > unfortunate in general, as it is not self-explanatory at all.
> > What are those heading for, anyway? A context menu should only contain only 
> > action items.
> > I know this is a general problem with this menu (which I have not noticed 
> > yet because apparently I never dropped anything on the desktop recently 
> > which opens such a menu), but you should start here by just using a single 
> > entry "Install Wigdet" instead of "Plasma Package" and "Install".
> 
> Heiko Tietze wrote:
> It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link - and Install in case of plasmoids (I wouldn't just disable 
> this item since it's very rarely used).
> 
> Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
> 
> The notification text is too long, redundant and not informative. But 
> that might be the return value from the installation process.

> It makes sense to use the default context menu for drag operations with Move, 
> Copy, Link

How should that work? Where should the thing end up if I move/copy/link? If you 
have a FolderView containment you should get that menu, I think.
> Users might expect to be able having wallpapers installed via drag and drop 
> and perhaps also ordinary packages.

At least for wallpapers, I have that planned, also. You can already drop JPEG 
files and the like and use them as a wallaper, only makes sense to be able to 
drop wallpaper packages as well. Ordinary packages I'd rather not since we 
cannot provide this for every package format out there (eg. Kickoff also only 
allows to uninstall applications via packagekit iirc)
> But that might be the return value from the installation process.

It is, I'm hoping for an improved API so I can provide a better error message.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88067
---


On Nov. 5, 2015, 8:23 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Kai Uwe Broulik]

> On Nov. 5, 2015, 9:22 nachm., Marco Martin wrote:
> > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 692
> > 
> >
> > kpackagetool in the case of the upgrade switch launches a remove job 
> > first then an install.
> > perhaps i should change the job in kpackage to launch an internal 
> > uninstall and reinstall if the version of the new is higher..
> > but i'm not sure all this complexity is good in the install job, or if 
> > i should perhaps do an "info" job to retrieve the metadata of a .plasmoid 
> > and then having the client code to decide what to do with it (remove and 
> > reinstall if needed)
> 
> Marco Martin wrote:
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated.
> uuuh, it's not?
> (but for compressed packages yes, i think should be a job)

What do you mean by "upgrade switch"?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88061
---


On Nov. 5, 2015, 8:23 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Marco Martin]

> On Nov. 5, 2015, 9:22 p.m., Marco Martin wrote:
> > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 692
> > 
> >
> > kpackagetool in the case of the upgrade switch launches a remove job 
> > first then an install.
> > perhaps i should change the job in kpackage to launch an internal 
> > uninstall and reinstall if the version of the new is higher..
> > but i'm not sure all this complexity is good in the install job, or if 
> > i should perhaps do an "info" job to retrieve the metadata of a .plasmoid 
> > and then having the client code to decide what to do with it (remove and 
> > reinstall if needed)
> 
> Marco Martin wrote:
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated.
> uuuh, it's not?
> (but for compressed packages yes, i think should be a job)
> 
> Kai Uwe Broulik wrote:
> What do you mean by "upgrade switch"?

kpackagetool -u whatever.plasmoid


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88061
---


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Heiko Tietze]

> On Nov. 5, 2015, 10:31 p.m., Thomas Pfeiffer wrote:
> > Nice feature!
> > There definitely has to be a way to uninstall a Plasmoid, however. Can't we 
> > show an uninstall button when hovering over a Plasmoid in the widget 
> > gallery?
> > 
> > Also, the labeling of the pupop menu when dropping on the desktop is 
> > unfortunate in general, as it is not self-explanatory at all.
> > What are those heading for, anyway? A context menu should only contain only 
> > action items.
> > I know this is a general problem with this menu (which I have not noticed 
> > yet because apparently I never dropped anything on the desktop recently 
> > which opens such a menu), but you should start here by just using a single 
> > entry "Install Wigdet" instead of "Plasma Package" and "Install".
> 
> Heiko Tietze wrote:
> It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link - and Install in case of plasmoids (I wouldn't just disable 
> this item since it's very rarely used).
> 
> Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
> 
> The notification text is too long, redundant and not informative. But 
> that might be the return value from the installation process.
> 
> Kai Uwe Broulik wrote:
> > It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link
> 
> How should that work? Where should the thing end up if I move/copy/link? 
> If you have a FolderView containment you should get that menu, I think.
> > Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
> 
> At least for wallpapers, I have that planned, also. You can already drop 
> JPEG files and the like and use them as a wallaper, only makes sense to be 
> able to drop wallpaper packages as well. Ordinary packages I'd rather not 
> since we cannot provide this for every package format out there (eg. Kickoff 
> also only allows to uninstall applications via packagekit iirc)
> > But that might be the return value from the installation process.
> 
> It is, I'm hoping for an improved API so I can provide a better error 
> message.
> 
> Heiko Tietze wrote:
> >How should that work? Where should the thing end up if I move/copy/link?
> 
> The context menu that pops up after drag 'n drop operations should 
> provide the Install additonally. Other operations work like for any other 
> file, i.e. just move/copy/link the .plasmoid file to the desktop, folder view 
> or whatever.
> 
> Marco Martin wrote:
> if the desktop is a folderview, yes.
> on a normal desktop or on a panel the move/copy/link operations don't 
> apply since there isn't anywhere to copy/move to

Sure, there it has to be only one context menu too with create a note, an icon 
(which is just a shortcut, right?), and install (if it is a plasmoid). BTW: 
this context menu should be harmonized with the default; the header is strange.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88067
---


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure 

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Thomas Pfeiffer]

> On Nov. 5, 2015, 10:31 p.m., Thomas Pfeiffer wrote:
> > Nice feature!
> > There definitely has to be a way to uninstall a Plasmoid, however. Can't we 
> > show an uninstall button when hovering over a Plasmoid in the widget 
> > gallery?
> > 
> > Also, the labeling of the pupop menu when dropping on the desktop is 
> > unfortunate in general, as it is not self-explanatory at all.
> > What are those heading for, anyway? A context menu should only contain only 
> > action items.
> > I know this is a general problem with this menu (which I have not noticed 
> > yet because apparently I never dropped anything on the desktop recently 
> > which opens such a menu), but you should start here by just using a single 
> > entry "Install Wigdet" instead of "Plasma Package" and "Install".
> 
> Heiko Tietze wrote:
> It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link - and Install in case of plasmoids (I wouldn't just disable 
> this item since it's very rarely used).
> 
> Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
> 
> The notification text is too long, redundant and not informative. But 
> that might be the return value from the installation process.
> 
> Kai Uwe Broulik wrote:
> > It makes sense to use the default context menu for drag operations with 
> Move, Copy, Link
> 
> How should that work? Where should the thing end up if I move/copy/link? 
> If you have a FolderView containment you should get that menu, I think.
> > Users might expect to be able having wallpapers installed via drag and 
> drop and perhaps also ordinary packages.
> 
> At least for wallpapers, I have that planned, also. You can already drop 
> JPEG files and the like and use them as a wallaper, only makes sense to be 
> able to drop wallpaper packages as well. Ordinary packages I'd rather not 
> since we cannot provide this for every package format out there (eg. Kickoff 
> also only allows to uninstall applications via packagekit iirc)
> > But that might be the return value from the installation process.
> 
> It is, I'm hoping for an improved API so I can provide a better error 
> message.
> 
> Heiko Tietze wrote:
> >How should that work? Where should the thing end up if I move/copy/link?
> 
> The context menu that pops up after drag 'n drop operations should 
> provide the Install additonally. Other operations work like for any other 
> file, i.e. just move/copy/link the .plasmoid file to the desktop, folder view 
> or whatever.
> 
> Marco Martin wrote:
> if the desktop is a folderview, yes.
> on a normal desktop or on a panel the move/copy/link operations don't 
> apply since there isn't anywhere to copy/move to
> 
> Heiko Tietze wrote:
> Sure, there it has to be only one context menu too with create a note, an 
> icon (which is just a shortcut, right?), and install (if it is a plasmoid). 
> BTW: this context menu should be harmonized with the default; the header is 
> strange.

Exactly, as I already said above: Get rid of those headers (I meant to write 
"headings" but forgot the "s", sorry), they do not belong in a context menu. If 
stating only the action would make it ambiguous, change the label so that it 
becomes clear.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88067
---


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> 

Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/
---

Review request for Plasma and KDE Usability.


Repository: plasma-framework


Description
---

This allows to drop a .plasmoid file on a panel or desktop and have it 
automatically installed and placed there.

Video: https://www.youtube.com/watch?v=5MnWnt_u5dU


Diffs
-

  src/scriptengines/qml/CMakeLists.txt 2aedf0b 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 

Diff: https://git.reviewboard.kde.org/r/125968/diff/


Testing
---

Works, as long as the applet is not yet installed

1.) How can I properly check the install status? The docs just say "returns a 
KJob allowing to track installation progress". I don't see a way to check for 
"applet already installed" (should update existing one if newer?) or 
"installation failed". In the former case I just want to add the already 
installed applet

1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
way to uninstall user-installed applets :/ Perhaps a delete button with undo 
like in the wallpaper selection should be added

2.) How can I get the pluginId of the applet? KPackage::metadata() is 
deprecated. Perhaps the KJob should be able to tell me eventually?

3.) How can I get the path to the installed package to get the info for 2.

4.) Not sure about linking KNotifications here

5.) I want an icon for the action :)

Please disregard the qDebug()s


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Thomas Pfeiffer]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88067
---


Nice feature!
There definitely has to be a way to uninstall a Plasmoid, however. Can't we 
show an uninstall button when hovering over a Plasmoid in the widget gallery?

Also, the labeling of the pupop menu when dropping on the desktop is 
unfortunate in general, as it is not self-explanatory at all.
What are those heading for, anyway? A context menu should only contain only 
action items.
I know this is a general problem with this menu (which I have not noticed yet 
because apparently I never dropped anything on the desktop recently which opens 
such a menu), but you should start here by just using a single entry "Install 
Wigdet" instead of "Plasma Package" and "Install".

- Thomas Pfeiffer


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Marco Martin]

> On Nov. 5, 2015, 9:22 p.m., Marco Martin wrote:
> > src/scriptengines/qml/plasmoid/containmentinterface.cpp, line 692
> > 
> >
> > kpackagetool in the case of the upgrade switch launches a remove job 
> > first then an install.
> > perhaps i should change the job in kpackage to launch an internal 
> > uninstall and reinstall if the version of the new is higher..
> > but i'm not sure all this complexity is good in the install job, or if 
> > i should perhaps do an "info" job to retrieve the metadata of a .plasmoid 
> > and then having the client code to decide what to do with it (remove and 
> > reinstall if needed)

2.) How can I get the pluginId of the applet? KPackage::metadata() is 
deprecated.
uuuh, it's not?
(but for compressed packages yes, i think should be a job)


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88061
---


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125968: WIP: Install .plasmoid file when dropping it onto containment

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125968/#review88061
---



src/scriptengines/qml/plasmoid/containmentinterface.cpp (line 692)


kpackagetool in the case of the upgrade switch launches a remove job first 
then an install.
perhaps i should change the job in kpackage to launch an internal uninstall 
and reinstall if the version of the new is higher..
but i'm not sure all this complexity is good in the install job, or if i 
should perhaps do an "info" job to retrieve the metadata of a .plasmoid and 
then having the client code to decide what to do with it (remove and reinstall 
if needed)


- Marco Martin


On Nov. 5, 2015, 8:23 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125968/
> ---
> 
> (Updated Nov. 5, 2015, 8:23 p.m.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> This allows to drop a .plasmoid file on a panel or desktop and have it 
> automatically installed and placed there.
> 
> Video: https://www.youtube.com/watch?v=5MnWnt_u5dU
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/CMakeLists.txt 2aedf0b 
>   src/scriptengines/qml/plasmoid/containmentinterface.cpp 772031f 
> 
> Diff: https://git.reviewboard.kde.org/r/125968/diff/
> 
> 
> Testing
> ---
> 
> Works, as long as the applet is not yet installed
> 
> 1.) How can I properly check the install status? The docs just say "returns a 
> KJob allowing to track installation progress". I don't see a way to check for 
> "applet already installed" (should update existing one if newer?) or 
> "installation failed". In the former case I just want to add the already 
> installed applet
> 
> 1a.) btw since we no longer have a tooltip in the widget explorer, there's no 
> way to uninstall user-installed applets :/ Perhaps a delete button with undo 
> like in the wallpaper selection should be added
> 
> 2.) How can I get the pluginId of the applet? KPackage::metadata() is 
> deprecated. Perhaps the KJob should be able to tell me eventually?
> 
> 3.) How can I get the path to the installed package to get the info for 2.
> 
> 4.) Not sure about linking KNotifications here
> 
> 5.) I want an icon for the action :)
> 
> Please disregard the qDebug()s
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel