Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread David Edmundson
> On Nov. 18, 2015, 2:40 p.m., David Edmundson wrote: > > won't make a difference, SDDM sources a tonne before we get to you. > > David Edmundson wrote: > more specifically: > > https://github.com/sddm/sddm/blob/master/data/scripts/wayland-session > > we also have anything

Review Request 126104: Make networkmanager-qt an optional dependency

2015-11-18 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126104/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-11-18 Thread Martin Klapetek
> On Nov. 18, 2015, 10:14 a.m., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > > > > > Add context this Isn't "this" caputred implicitly? - Martin

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-18 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125705/ --- (Updated Nov. 18, 2015, 5:38 p.m.) Status -- This change has been

Re: Review Request 126018: Use the plural form for "Notification" category

2015-11-18 Thread Martin Klapetek
> On Nov. 10, 2015, 10:57 p.m., Martin Klapetek wrote: > > > should I change also X-KDE-System-Settings-Category=notification to > > > notifications > > > > I don't think so, it would require changing everywhere. Unless there is > > nothing actually using it, in which case, yes. > > Luigi

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread Matthias Klumpp
> On Nov. 18, 2015, 2:57 nachm., Matthias Klumpp wrote: > > It just wanted to write what David wrote ;-) > > Maybe a way to resolve this is to filter environment variables in KWin or > > before starting KWin, so anything pointing to directories in $HOME gets > > stripped away (unsetting LD_*

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread Martin Gräßlin
> On Nov. 18, 2015, 3:40 p.m., David Edmundson wrote: > > won't make a difference, SDDM sources a tonne before we get to you. > > David Edmundson wrote: > more specifically: > > https://github.com/sddm/sddm/blob/master/data/scripts/wayland-session > > we also have anything

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread Martin Gräßlin
> On Nov. 18, 2015, 3:57 p.m., Matthias Klumpp wrote: > > It just wanted to write what David wrote ;-) > > Maybe a way to resolve this is to filter environment variables in KWin or > > before starting KWin, so anything pointing to directories in $HOME gets > > stripped away (unsetting LD_*

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread Martin Gräßlin
> On Nov. 18, 2015, 3:57 p.m., Matthias Klumpp wrote: > > It just wanted to write what David wrote ;-) > > Maybe a way to resolve this is to filter environment variables in KWin or > > before starting KWin, so anything pointing to directories in $HOME gets > > stripped away (unsetting LD_*

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126102/ --- (Updated Nov. 18, 2015, 4:36 p.m.) Status -- This change has been

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-11-18 Thread David Edmundson
> On Nov. 18, 2015, 9:14 a.m., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > > > > > Add context this > > Martin Klapetek wrote: > Isn't "this"

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-11-18 Thread Martin Klapetek
> On Nov. 18, 2015, 10:14 a.m., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > > > > > Add context this > > Martin Klapetek wrote: > Isn't "this"

[Breeze] [Bug 355560] New: Missing Breeze Cursor themes after update

2015-11-18 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355560 Bug ID: 355560 Summary: Missing Breeze Cursor themes after update Product: Breeze Version: 5.4.3 Platform: Fedora RPMs OS: Linux Status: UNCONFIRMED Severity:

[Breeze] [Bug 355560] Missing Breeze Cursor themes after update

2015-11-18 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355560 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org ---

[Breeze] [Bug 355561] Breeze themes look a bit inconsistent after recent update

2015-11-18 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355561 hotmusic...@mail.bg changed: What|Removed |Added Platform|Other |Fedora RPMs -- You are receiving this

[Breeze] [Bug 355561] New: Breeze themes look a bit inconsistent after recent update

2015-11-18 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355561 Bug ID: 355561 Summary: Breeze themes look a bit inconsistent after recent update Product: Breeze Version: 5.4.3 Platform: Other OS: Linux Status:

[plasmashell] [Bug 355561] Breeze themes look a bit inconsistent after recent update

2015-11-18 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355561 Martin Klapetek changed: What|Removed |Added CC||mklape...@kde.org,

Re: Review Request 125991: [Widget Explorer] Allow uninstalling user-installed applets

2015-11-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125991/#review88548 --- Ping I don't want to ease people installing applets (cf

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-11-18 Thread Kai Uwe Broulik
> On Nov. 18, 2015, 9:14 vorm., Kai Uwe Broulik wrote: > > plasmacalendarintegration/qmlhelper/holidayeventshelperplugin.cpp, line 37 > > > > > > Add context this > > Martin Klapetek wrote: > Isn't "this"

Re: Release plasma-framework + kdeclarative beta with plasma 5.5beta?

2015-11-18 Thread Martin Klapetek
On Wed, Nov 18, 2015 at 9:38 AM, David Edmundson wrote: > > On Wed, Nov 18, 2015 at 2:25 PM, Martin Klapetek < > martin.klape...@gmail.com> wrote: > >> Hi, >> >> so there's a plasma 5.5 beta release in the following days >> and there is some stuff in workspace that

Re: RFC: plasmoid templates in plasma-sdk

2015-11-18 Thread Marco Martin
On Monday 16 November 2015, Sebastian Kügler wrote: > > yes, makes sense, most important is to have them in places harder to > > forget about > > If in plasma-framework, it would kind of fit in with all the example > plasmoid code. Not sure if that, or plasma-sdk, both make sense to me, > perhaps

[Breeze] [Bug 355540] New: Tooltips color wrong in gtk applications

2015-11-18 Thread 郭云鹤
https://bugs.kde.org/show_bug.cgi?id=355540 Bug ID: 355540 Summary: Tooltips color wrong in gtk applications Product: Breeze Version: unspecified Platform: openSUSE RPMs OS: Linux Status: UNCONFIRMED

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-18 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126089/ --- (Updated Nov. 18, 2015, 11:10 a.m.) Review request for Plasma.

Re: Review Request 125705: Use LANG for month names in calendar applet

2015-11-18 Thread David Edmundson
> On Oct. 28, 2015, 8:44 p.m., Martin Klapetek wrote: > > So...any word on this? > > Albert Astals Cid wrote: > Re-reading your comment, if i understand it correctly, you claim it is a > bug in Qt that it does obey LC_DATE for month names when according to you > LC_DATE is only for the

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-18 Thread Marco Martin
> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote: > > themeexplorer/package/contents/ui/ColorEditor.qml, lines 326-329 > > > > > > Does keyboard navigation work with that still? ie. return/escape? Also > >

Re: Review Request 126098: Install session file for plasma on wayland

2015-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126098/#review88514 --- Ship it! Ship It! - Martin Gräßlin On Nov. 17, 2015, 4:55

Re: Review Request 126101: allow loading backends in-process

2015-11-18 Thread Daniel Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126101/#review88510 --- src/backendlauncher/backendloader.cpp (line 122)

Re: Review Request 126089: Metadata and color edit for plasma theme explorer

2015-11-18 Thread Marco Martin
> On Nov. 17, 2015, 1:24 p.m., Kai Uwe Broulik wrote: > > themeexplorer/package/contents/ui/ColorEditor.qml, line 97 > > > > > > I think if you made the ColumnLayout the contentItem the Dialog would > > deduce

Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126102/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126102/#review88511 --- startkde/startplasma.cmake (line 20)

Re: Review Request 125862: Add simple calendar events plugin based on KHolidays

2015-11-18 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125862/#review88512 --- plasmacalendarintegration/HolidaysConfig.qml (line 62)

Re: Review Request 126098: Install session file for plasma on wayland

2015-11-18 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126098/ --- (Updated Nov. 18, 2015, 9:38 a.m.) Status -- This change has been

Re: Release plasma-framework + kdeclarative beta with plasma 5.5beta?

2015-11-18 Thread David Edmundson
On Wed, Nov 18, 2015 at 2:25 PM, Martin Klapetek wrote: > Hi, > > so there's a plasma 5.5 beta release in the following days > and there is some stuff in workspace that requires latest > plasma-framework + kdeclarative, > Then it needs reverting, you missed the

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread Martin Gräßlin
> On Nov. 18, 2015, 3:40 p.m., David Edmundson wrote: > > won't make a difference, SDDM sources a tonne before we get to you. > > David Edmundson wrote: > more specifically: > > https://github.com/sddm/sddm/blob/master/data/scripts/wayland-session > > we also have anything

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126102/#review88528 --- It just wanted to write what David wrote ;-) Maybe a way to

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread David Edmundson
> On Nov. 18, 2015, 2:40 p.m., David Edmundson wrote: > > won't make a difference, SDDM sources a tonne before we get to you. more specifically: https://github.com/sddm/sddm/blob/master/data/scripts/wayland-session we also have anything loaded from pam_env which can include ~/.pam_environment

Release plasma-framework + kdeclarative beta with plasma 5.5beta?

2015-11-18 Thread Martin Klapetek
Hi, so there's a plasma 5.5 beta release in the following days and there is some stuff in workspace that requires latest plasma-framework + kdeclarative, their qml imports to be more precise. The final 5.5 will be out when those frameworks are out but for the beta, we'll be releasing half-broken

Re: Review Request 126102: [startkde] Move sourceing of env scripts to startplasma

2015-11-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126102/#review88525 --- won't make a difference, SDDM sources a tonne before we get

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-11-18 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124675/ --- (Updated Nov. 18, 2015, 10:51 p.m.) Status -- This change has been

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-11-18 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124675/#review88552 --- Sorry, was there an extra discussion that's not mentioned on

[plasmashell] [Bug 355563] Taskbar is cluttered and colorfull

2015-11-18 Thread Martin Klapetek via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355563 Martin Klapetek changed: What|Removed |Added Assignee|plasma-devel@kde.org|visual-des...@kde.org

Re: Review Request 126100: [KRunner] Forward KRunner switchUser to KSMServer

2015-11-18 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126100/#review88555 --- Ship it! - Vishesh Handa On Nov. 17, 2015, 7:09 p.m., Kai

[Breeze] [Bug 355563] Taskbar is cluttered and colorfull

2015-11-18 Thread Christoph Feck via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355563 Christoph Feck changed: What|Removed |Added Component|window decoration |general

Re: Review Request 125465: kcm_keyboard: Use udev device notifier when xcb-xinput is not available

2015-11-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125465/ --- (Updated Nov. 18, 2015, 10:03 p.m.) Status -- This change has been

[Breeze] [Bug 355560] Missing Breeze Cursor themes after update

2015-11-18 Thread Rex Dieter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355560 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu

Re: [kde-promo] 5.5 announcement

2015-11-18 Thread Martin Klapetek
On Wed, Nov 18, 2015 at 1:36 PM, Jonathan Riddell wrote: > > Thanks for the various suggestions and corrections I've had, should be all > in > > https://www.kde.org/announcements/plasma-5.4.95.php > > Is anyone able to take a screenshot of "Legacy System Tray Icons" with the >

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-11-18 Thread Gregor Mi
> On Nov. 18, 2015, 11:28 p.m., David Edmundson wrote: > > Sorry, was there an extra discussion that's not mentioned on here? Hi David, the original requirement was to ask the VDG team and follow their decision (as you said 3 month ago). The comment "Nevertheless, we agreed that since greying

Re: Review Request 126107: Use absolute path to kwin_wayland

2015-11-18 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126107/#review88564 --- +1 - Bhushan Shah On Nov. 19, 2015, 12:14 p.m., Martin

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Martin Gräßlin
> On Nov. 19, 2015, 8:22 a.m., Thomas Lübking wrote: > > Is the full path required because of security concerns or because > > startplasmacompositor is broken (lacks proper environment setup)? security concerns. Problem is that an env scripct (which are sourced for reasons by the login

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126106/#review88569 --- Ship it! Ship It! - Thomas Lübking On Nov. 19, 2015, 6:44

Review Request 126107: Use absolute path to kwin_wayland

2015-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126107/ --- Review request for Plasma, David Edmundson and Matthias Klumpp.

Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126106/ --- Review request for kwin, Plasma, David Edmundson, and Matthias Klumpp.

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126106/#review88563 --- Is it posssible to put it in seperate file? Because

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Martin Gräßlin
> On Nov. 19, 2015, 7:53 a.m., Bhushan Shah wrote: > > Is it posssible to put it in seperate file? Because CMakeConfig is named as > > DBusInterface and no-one would expect it to have path to kwin_wayland. well I used what we have. I'm open with introducing a new file or renaming after Plasma

Re: Review Request 126106: Add path to kwin_wayland binary to KWin's installed CMakeConfig

2015-11-18 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126106/#review88567 --- Is the full path required because of security concerns or

[Breeze] [Bug 355560] Missing Breeze Cursor themes after update

2015-11-18 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355560 --- Comment #2 from hotmusic...@mail.bg --- I'll fill a bug in their Bugzilla and will link this one to it. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing