On Mon, Jun 28, 2010 at 09:30:45AM +0800, Axel Lin wrote:
When acpi_evaluate_object() is passed ACPI_ALLOCATE_BUFFER,
the caller must kfree the returned buffer if AE_OK is returned.
The callers of wmi_get_event_data() pass ACPI_ALLOCATE_BUFFER,
and thus must check its return value before
On Wed, Jun 30, 2010 at 05:25:46PM +0800, Axel Lin wrote:
If dell_new_hk_type is true, dell_legacy_wmi_keymap will point to a memory
allocated in setup_new_hk_map().
In this case, the memory is not freed in current implementation.
This patch fixes the leak by kfree(dell_wmi_keymap) if
Other patches in this series add the same info to /sys/... and
/proc/ioports.
The info removed should never have been used in an application,
eventually someone read it manually.
/proc/acpi is deprecated for more than a year anyway...
Signed-off-by: Thomas Renninger tr...@suse.de
CC: Alexey
There is a general interface for that now (provided by
other patches in this patch series):
/sys/devices/system/ec/*/io
Signed-off-by: Thomas Renninger tr...@suse.de
CC: Alexey Starikovskiy astarikovs...@suse.de
CC: Len Brown l...@kernel.org
CC: linux-ker...@vger.kernel.org
CC:
Formerly these have been exposed through /proc/..
Better register them where all IO ports should get registered
and scream loud if someone else claims to use them.
EC data and command port typically should show up like this
then:
...
0060-0060 : keyboard
0062-0062 : EC data
0064-0064 :
These patches are diffed against the test branch of the ACPI tree, but also
patch fine with 2.6.35-rc3.
I thought about tainting the kernel if someone writes to the EC, but as
userspace can also write to graphics IO, PCI config or MSRs, it shouldn't
matter that much.
Eventually this should still
On Thu, 2010-07-01 at 17:02 +0200, Thomas Renninger wrote:
These patches are diffed against the test branch of the ACPI tree, but also
patch fine with 2.6.35-rc3.
I thought about tainting the kernel if someone writes to the EC, but as
userspace can also write to graphics IO, PCI config or
On Thu, 01 Jul 2010, Thomas Renninger wrote:
Soes your helper userspace util do the differential analysis that
thinkpad-acpi used to (the * after values that changed since last read)?
No.
But this should not be important enough to not get this removed.
Consider it a feature request ;-)
input_free_device should only be used if input_register_device()
was not called yet or if it failed.
This patch removes unnecessary input_free_device calls.
Yes, indeed. Good catch. The patch looks good to me - thanks.
Acked-by: Jonathan Woithe jwoi...@physics.adelaide.edu.au
