Re: [PATCH] acpi ec_sys: Be more cautious about ec write access

2010-07-31 Thread Thomas Renninger
On Friday 30 July 2010 06:37:17 pm Henrique de Moraes Holschuh wrote: On Thu, 29 Jul 2010, Thomas Renninger wrote: - Only allow root to read/write io file (sever bug!) I'd go further, and only allow CAP_SYS_RAWIO. I'll have a look and eventually come up with something on-top. + The

Re: [PATCH] acpi ec_sys: Export fields of all regions from the EC to debugfs readable

2010-07-31 Thread Thomas Renninger
On Saturday 31 July 2010 01:30:53 am Andrew Morton wrote: On Fri, 30 Jul 2010 17:47:04 +0200 Thomas Renninger tr...@suse.de wrote: -static int acpi_ec_open_io(struct inode *i, struct file *f) +static int acpi_ec_open(struct inode *i, struct file *f) { f-private_data = i-i_private;