[PATCH v2] asus-nb-wmi: Add another wapf=4 quirk

2014-11-24 Thread Hans de Goede
Wifi on this laptop does not work unless asus-nb-wmi.wapf=4 is specified on the kerne commandline, add a quirk for this. Cc: sta...@vger.kernel.org BugLink: https://bugs.launchpad.net/bugs/1173681 Signed-off-by: Hans de Goede hdego...@redhat.com --- drivers/platform/x86/asus-nb-wmi.c | 9

[PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2014-11-24 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Mon, 24 Nov 2014 20:30:29 +0100 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle

Re: Reported key not released

2014-11-24 Thread Matthew Garrett
On Sun, Nov 23, 2014 at 02:13:30PM +0100, Pali Rohár wrote: When I enable or disable this switch it correctly enable or disable devices (and also hard rfkill status is set correctly). If the switch changes the rfkill state, you shouldn't be emitting any presses - the rfkill state change will

Re: [PATCH 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2014-11-24 Thread Matthew Garrett
On Sun, Nov 23, 2014 at 04:09:19PM +0100, Pali Rohár wrote: + /* NOTE: rbtn controls all radio devices, not only WLAN + but rfkill interface does not support ANY type + so WLAN type is used + */ If it controls multiple radio types then you should register

Re: [PATCH 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2014-11-24 Thread Pali Rohár
On Monday 24 November 2014 21:09:05 Matthew Garrett wrote: On Sun, Nov 23, 2014 at 04:09:19PM +0100, Pali Rohár wrote: + /* NOTE: rbtn controls all radio devices, not only WLAN +but rfkill interface does not support ANY type +so WLAN type is used +*/ If it

Re: Reported key not released

2014-11-24 Thread Pali Rohár
On Monday 24 November 2014 21:04:33 Matthew Garrett wrote: On Sun, Nov 23, 2014 at 02:13:30PM +0100, Pali Rohár wrote: When I enable or disable this switch it correctly enable or disable devices (and also hard rfkill status is set correctly). If the switch changes the rfkill state, you

[PATCH 1/1] Sony-laptop: Deletion of an unnecessary check before the function call pci_dev_put

2014-11-24 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Mon, 24 Nov 2014 22:00:21 +0100 The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2014-11-24 Thread Anisse Astier
Hi Markus, Le lundi 24 novembre 2014, 20:40:22 SF Markus Elfring a écrit : From: Markus Elfring elfr...@users.sourceforge.net Date: Mon, 24 Nov 2014 20:30:29 +0100 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test

Re: [PATCH 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2014-11-24 Thread Matthew Garrett
On Mon, Nov 24, 2014 at 09:55:47PM +0100, Pali Rohár wrote: This is complicated. HW switch controls all radio devices and you do not know which are present in specified running machine. Also list of devices which HW switch controls can be edited in BIOS (on some machines). So what to do?

Re: Reported key not released

2014-11-24 Thread Matthew Garrett
On Mon, Nov 24, 2014 at 09:58:32PM +0100, Pali Rohár wrote: So kernel should filter i8042 atk key press events which represent HW switch? Yeah - the firmware is sending an Update rfkill state message, not a real keypress. If you're already listening for those events through a filter then

Re: [PATCH 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver

2014-11-24 Thread Pali Rohár
On Monday 24 November 2014 22:50:26 Matthew Garrett wrote: On Mon, Nov 24, 2014 at 09:55:47PM +0100, Pali Rohár wrote: This is complicated. HW switch controls all radio devices and you do not know which are present in specified running machine. Also list of devices which HW switch controls

Re: [PATCH 1/1] platform: x86: Deletion of checks before backlight_device_unregister()

2014-11-24 Thread SF Markus Elfring
This issue was detected by using the Coccinelle software. What script was used ? A semantic patch approach which I published on the mailing lists in March is in action on my software development system for a while. Is it in scripts/coccinelle ? Not yet. I hope that the involved update

[PATCH v2] toshiba_acpi: Fix regression caused by backlight extra check code

2014-11-24 Thread Azael Avalos
Bug 86521 uncovered that some TOS6208 devices also return non zero values on a write call to the backlight method, thus getting caught and bailed out by the extra check code. This patch changes the set_lcd_brightness function to its original state by just adapting it to the new function format.