Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

On Tuesday 29 December 2015 13:44:13 Michał Kępień wrote: > > > > According to Dell WMI document mentioned in ML dicussion > > > > archived at > > > > http://www.spinics.net/lists/platform-driver-x86/msg07220.html > > > > OS should check Dell WMI descriptor structure. > > > > > > "Should" or

Re: [PATCH v3 5/5] platform:x86: Makefile/Kconfig/MAINTAINERS changes for Intel Telemetry

On Wed, Dec 23, 2015 at 04:14:41PM +0530, Souvik Kumar Chakravarty wrote: > Makefile, Kconfig & MAINTAINERS changes for compiling Telemetry. > It depends on PUNIT and PMC IPC drivers. ... > +config INTEL_TELEMETRY > + tristate "Intel SoC Telemetry Driver" > + default n > + depends on

Re: [PATCH v2 4/5] platform:x86: Add Intel Telemetry Debugfs interfaces

On Tuesday, December 29, 2015 04:50:05 PM Darren Hart wrote: > On Wed, Dec 23, 2015 at 04:14:16PM +0530, Souvik Kumar Chakravarty wrote: > > This implements debugfs interfaces for reading the telemetry > > samples from SSRAM and configuring firmware trace verbosity. > > Interface created under

Re: [PATCH v3 1/5] platform:x86: Add Intel Telemetry Core Driver

On Wed, Dec 23, 2015 at 04:12:30PM +0530, Souvik Kumar Chakravarty wrote: > Intel PM Telemetry is a software mechanism via which various SoC > PM and performance related parameters like PM counters, firmware > trace verbosity, the status of different devices inside the SoC, etc > can be monitored

Re: [PATCH v2 4/5] platform:x86: Add Intel Telemetry Debugfs interfaces

On Wed, Dec 23, 2015 at 04:14:16PM +0530, Souvik Kumar Chakravarty wrote: > This implements debugfs interfaces for reading the telemetry > samples from SSRAM and configuring firmware trace verbosity. > Interface created under /sys/kernel/debug/telemetry What was the rationale for placing this

Re: [PATCH v4 3/5] platform:x86: Add Intel telemetry platform driver

On Wed, Dec 23, 2015 at 04:13:32PM +0530, Souvik Kumar Chakravarty wrote: Hi Souvik, In general this series is looking pretty good. Clean and consistent for the most part. This one and the debugfs one in particular do have some issues I'd like to see addressed. > Telemetry platform driver

Re: [PATCH v3 5/5] platform:x86: Makefile/Kconfig/MAINTAINERS changes for Intel Telemetry

On Tuesday, December 29, 2015 04:59:10 PM Darren Hart wrote: > On Wed, Dec 23, 2015 at 04:14:41PM +0530, Souvik Kumar Chakravarty wrote: > > Makefile, Kconfig & MAINTAINERS changes for compiling Telemetry. > > It depends on PUNIT and PMC IPC drivers. > > ... > > > +config INTEL_TELEMETRY > > +

RE: [PATCH v4 2/5] platform:x86: Add Intel telemetry platform device

+ Rafael -Original Message- From: Chakravarty, Souvik K Sent: Wednesday, December 23, 2015 4:13 PM To: platform-driver-x86@vger.kernel.org Cc: dvh...@infradead.org; Kasagar, Srinidhi ; Zha, Qipeng ; Muralidhar, Rajeev D

RE: [PATCH v4 3/5] platform:x86: Add Intel telemetry platform driver

+Rafael -Original Message- From: Chakravarty, Souvik K Sent: Wednesday, December 23, 2015 4:14 PM To: platform-driver-x86@vger.kernel.org Cc: dvh...@infradead.org; Kasagar, Srinidhi ; Zha, Qipeng ; Muralidhar, Rajeev D

RE: [PATCH v3 1/5] platform:x86: Add Intel Telemetry Core Driver

+ Rafael -Original Message- From: Chakravarty, Souvik K Sent: Wednesday, December 23, 2015 4:13 PM To: platform-driver-x86@vger.kernel.org Cc: dvh...@infradead.org; Kasagar, Srinidhi ; Zha, Qipeng ; Muralidhar, Rajeev D

Re: [PATCH v3 5/5] platform:x86: Makefile/Kconfig/MAINTAINERS changes for Intel Telemetry

On Wed, Dec 30, 2015 at 02:59:09AM +0100, Rafael Wysocki wrote: > On Tuesday, December 29, 2015 04:59:10 PM Darren Hart wrote: > > On Wed, Dec 23, 2015 at 04:14:41PM +0530, Souvik Kumar Chakravarty wrote: > > > Makefile, Kconfig & MAINTAINERS changes for compiling Telemetry. > > > It depends on

RE: [PATCH v2 4/5] platform:x86: Add Intel Telemetry Debugfs interfaces

> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver- > x86-ow...@vger.kernel.org] On Behalf Of Rafael J. Wysocki > Sent: Wednesday, December 30, 2015 7:42 AM > To: Darren Hart > Cc: Chakravarty, Souvik K

RE: [PATCH v2 4/5] platform:x86: Add Intel Telemetry Debugfs interfaces

+ rafael > -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver- > x86-ow...@vger.kernel.org] On Behalf Of Souvik Kumar Chakravarty > Sent: Wednesday, December 23, 2015 4:14 PM > To: platform-driver-x86@vger.kernel.org > Cc: dvh...@infradead.org;

RE: [PATCH v4 3/5] platform:x86: Add Intel telemetry platform driver

> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver- > x86-ow...@vger.kernel.org] On Behalf Of Darren Hart > Sent: Wednesday, December 30, 2015 6:28 AM > To: Chakravarty, Souvik K > Cc:

RE: [PATCH v2 4/5] platform:x86: Add Intel Telemetry Debugfs interfaces

> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver- > x86-ow...@vger.kernel.org] On Behalf Of Darren Hart > Sent: Wednesday, December 30, 2015 6:20 AM > To: Chakravarty, Souvik K ; Rafael Wysocki >

Re: [PATCH v2 4/5] platform:x86: Add Intel Telemetry Debugfs interfaces

On Wed, Dec 30, 2015 at 03:12:09AM +0100, Rafael Wysocki wrote: > On Tuesday, December 29, 2015 04:50:05 PM Darren Hart wrote: > > On Wed, Dec 23, 2015 at 04:14:16PM +0530, Souvik Kumar Chakravarty wrote: > > > This implements debugfs interfaces for reading the telemetry > > > samples from SSRAM

Re: [PATCH v2 4/5] platform:x86: Add Intel Telemetry Debugfs interfaces

On Wed, Dec 30, 2015 at 04:48:42AM +, Chakravarty, Souvik K wrote: > > > > -Original Message- > > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver- > > x86-ow...@vger.kernel.org] On Behalf Of Darren Hart > > Sent: Wednesday, December 30, 2015 6:20 AM > > To:

Re: [PATCH 3/5] thinkpad_acpi: Use acpi_video_handles_brightness_key_presses()

Hi, On 28-12-15 00:08, Henrique de Moraes Holschuh wrote: On Tue, 22 Dec 2015, Hans de Goede wrote: Use the new acpi_video_handles_brightness_key_presses function to check if we should report brightness key-presses. This makes the code both easier to read and makes it properly report

Re: [PATCH 0/2] Fixes for dell-wmi

> > > This patch series adds check if Dell WMI descriptor structure is > > > valid and fixes processing WMI events on devices with WMI > > > interface version 0. > > > > > > After testing, second patch is good candidate for backporting into > > > stable kernels, but problem is that it cannot be

Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

> > > According to Dell WMI document mentioned in ML dicussion archived > > > at http://www.spinics.net/lists/platform-driver-x86/msg07220.html > > > OS should check Dell WMI descriptor structure. > > > > "Should" or "can"? I skimmed through the ACPI-WMI PDF and Mario's > > message again and I