Re: [PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-20 Thread Matthew Garrett
On Thu, May 20, 2010 at 04:35:10PM +0200, Thomas Renninger wrote: > You could have removed the 0/1 manually. > No need to ask for such a tiny change and the patch > had not needed rediffing. Yeah, in the end I didn't worry about it - it's entirely harmless. -- Matthew Garrett | mj...@srcf.ucam.o

Re: [PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-20 Thread Thomas Renninger
On Thursday 20 May 2010 15:42:11 Matthew Garrett wrote: > I've applied this patchset, thanks. Thanks. You could have removed the 0/1 manually. No need to ask for such a tiny change and the patch had not needed rediffing. Thomas -- To unsubscribe from this list: send the line "unsubscribe platf

Re: [PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-20 Thread Matthew Garrett
I've applied this patchset, thanks. -- Matthew Garrett | mj...@srcf.ucam.org -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-20 Thread Matthew Garrett
On Mon, May 03, 2010 at 03:30:15PM +0200, Thomas Renninger wrote: > +module_param(debug_event, bool, 0444); > +MODULE_PARM_DESC(debug_event, > + "Log WMI Events [0/1]"); It's an insanely small nit, but it's already declared as a bool parameter so the 0/1 is kind of unnecessary. --

Re: [PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-04 Thread Carlos Corbacho
On Monday 03 May 2010 14:30:15 Thomas Renninger wrote: > To give people easily an idea what could be WMI driven on their system. > Introduces: > wmi.debug=[01] > > Tested on an acer: > ACPI: WMI: DEBUG Event INTEGER_TYPE - 65535 > > Situation where a driver registers for specific event and debug

Re: [PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-04 Thread Corentin Chary
On Tue, May 4, 2010 at 2:43 PM, Thomas Renninger wrote: > On Tuesday 04 May 2010 01:54:44 pm Corentin Chary wrote: >> On Mon, May 3, 2010 at 3:30 PM, Thomas Renninger wrote: >> > To give people easily an idea what could be WMI driven on their system. > ... >> CCing wmi.c maintainer. > Oh dear, I

Re: [PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-04 Thread Thomas Renninger
On Tuesday 04 May 2010 01:54:44 pm Corentin Chary wrote: > On Mon, May 3, 2010 at 3:30 PM, Thomas Renninger wrote: > > To give people easily an idea what could be WMI driven on their system. ... > CCing wmi.c maintainer. Oh dear, I mixed you up. Both starting with C.. C.. :) Corentin: Do you read

Re: [PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-04 Thread Corentin Chary
On Mon, May 3, 2010 at 3:30 PM, Thomas Renninger wrote: > To give people easily an idea what could be WMI driven on their system. > Introduces: > wmi.debug=[01] > > Tested on an acer: > ACPI: WMI: DEBUG Event INTEGER_TYPE - 65535 > > Situation where a driver registers for specific event and debug

[PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-03 Thread Thomas Renninger
To give people easily an idea what could be WMI driven on their system. Introduces: wmi.debug=[01] Tested on an acer: ACPI: WMI: DEBUG Event INTEGER_TYPE - 65535 Situation where a driver registers for specific event and debug handler gets overridden and set again if the registering driver gets un