Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

2011-12-16 Thread Thomas Renninger
On Friday, December 16, 2011 01:33:33 AM Matthew Garrett wrote: On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote: I think best is to move the thinkpad implementation of getting ACPI handles based on HIDs to osl.c and make it global. I'll send patches. Please review them

Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

2011-12-16 Thread Corentin Chary
On Fri, Dec 16, 2011 at 2:19 PM, Thomas Renninger tr...@suse.de wrote: On Friday, December 16, 2011 01:33:33 AM Matthew Garrett wrote: On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote: I think best is to move the thinkpad implementation of getting ACPI handles based on HIDs

Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

2011-12-16 Thread Seth Forshee
On Fri, Dec 16, 2011 at 02:19:32PM +0100, Thomas Renninger wrote: On Friday, December 16, 2011 01:33:33 AM Matthew Garrett wrote: On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote: I think best is to move the thinkpad implementation of getting ACPI handles based on HIDs

Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

2011-12-15 Thread Thomas Renninger
On Thursday 15 December 2011 19:06:08 Seth Forshee wrote: toshiba_acpi needs to execute an AML method within the EC namespace to make hotkeys work on some platforms. Provide an interface to allow it to easily get a handle to the EC namespace for this purpose. I first liked the idea of making

Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

2011-12-15 Thread Matthew Garrett
On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote: I think best is to move the thinkpad implementation of getting ACPI handles based on HIDs to osl.c and make it global. I'll send patches. Please review them carefully, they are only compile tested. The ec driver is already

Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

2011-12-15 Thread Thomas Renninger
On Friday 16 December 2011 01:33:33 Matthew Garrett wrote: On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote: I think best is to move the thinkpad implementation of getting ACPI handles based on HIDs to osl.c and make it global. I'll send patches. Please review them