Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/msi-wmi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi
() call to acpi_video_register(),
so that we can be sure the dmi quirks have always been applied before
probing.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/video.c b/drivers/acpi
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/apple-gmux.c
b/drivers/platform/x86
acpi_video_unregister_backlight() is now only used by video_detect.c
which is part of the same acpi_video module as video.c, make
acpi_video_unregister_backlight() private to this module.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video.c| 1 -
drivers/acpi
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/sony-laptop.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
Hi,
On 06/09/2015 11:10 AM, Aaron Lu wrote:
On Tue, Jun 09, 2015 at 10:32:25AM +0200, Hans de Goede wrote:
On some systems acpi-video backlight is broken in the sense that it cannot
control the brightness of the backlight, but it must still be called on
resume to power-up the backlight after
Hi,
On 11-06-15 11:19, Pali Rohár wrote:
On Wednesday 10 June 2015 15:01:07 Hans de Goede wrote:
Currently we have 2 kernel commandline options + dmi-quirks in 3 places all
interacting (in interesting ways) to select which which backlight interface
to use. On the commandline we've
Hi,
On 11-06-15 11:00, Aaron Lu wrote:
On Wed, Jun 10, 2015 at 03:01:07PM +0200, Hans de Goede wrote:
Currently we have 2 kernel commandline options + dmi-quirks in 3 places all
interacting (in interesting ways) to select which which backlight interface
to use. On the commandline we've
Hi,
On 11-06-15 03:43, Aaron Lu wrote:
On Tue, Jun 09, 2015 at 11:54:45PM +0200, Hans de Goede wrote:
Hi,
On 06/09/2015 11:10 AM, Aaron Lu wrote:
On Tue, Jun 09, 2015 at 10:32:25AM +0200, Hans de Goede wrote:
On some systems acpi-video backlight is broken in the sense that it cannot
control
Hi,
On 11-06-15 13:47, Pali Rohár wrote:
On Wednesday 10 June 2015 15:01:19 Hans de Goede wrote:
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/dell-laptop.c | 6 ++
1 file
Hi,
On 11-06-15 14:28, Jani Nikula wrote:
On Thu, 11 Jun 2015, Hans de Goede hdego...@redhat.com wrote:
Hi,
On 11-06-15 11:19, Pali Rohár wrote:
On Wednesday 10 June 2015 15:01:07 Hans de Goede wrote:
Currently we have 2 kernel commandline options + dmi-quirks in 3 places all
interacting
Hi,
On 11-06-15 13:43, Pali Rohár wrote:
On Wednesday 10 June 2015 15:01:20 Hans de Goede wrote:
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/dell-wmi.c | 3 ++-
1 file changed, 2
Hi,
On 11-06-15 13:10, Jani Nikula wrote:
On Thu, 11 Jun 2015, Hans de Goede hdego...@redhat.com wrote:
Hi,
On 11-06-15 03:43, Aaron Lu wrote:
On Tue, Jun 09, 2015 at 11:54:45PM +0200, Hans de Goede wrote:
Hi,
On 06/09/2015 11:10 AM, Aaron Lu wrote:
On Tue, Jun 09, 2015 at 10:32:25AM
() call to acpi_video_register(),
so that we can be sure the dmi quirks have always been applied before
probing.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/apple-gmux.c
b/drivers/platform/x86
safe manner, this commit adds locking to make this thread safe.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 43 +--
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Lee, Chun-Yi j...@suse.com
---
drivers/platform/x86/acer-wmi.c | 10 +++---
1 file changed, 3
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/asus-wmi.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/compal-laptop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/compal-laptop.c
b/drivers
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Pali Rohár pali.ro...@gmail.com
---
drivers/platform/x86/dell-laptop.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Pali Rohár pali.ro...@gmail.com
---
drivers/platform/x86/dell-wmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform
to the new backlight interface selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 0f9586b..d00c0f4 100644
--- a/drivers/acpi/video_detect.c
and
it needlessly complicates the code.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 59 ++---
drivers/acpi/video_detect.c | 27 +
2 files changed, 29 insertions(+), 57 deletions(-)
diff --git a/drivers/acpi
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Mattia Dongili malat...@linux.it
---
drivers/platform/x86/sony-laptop.c | 7 ++-
1 file changed, 2
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Azael Avalos coproscef...@gmail.com
---
Changes in v3:
-Drop chunk fixing compiler warning, already fixed.
---
drivers/platform/x86/toshiba_acpi.c | 7
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/samsung-laptop.c | 27 ---
1 file changed, 4 insertions(+), 23
acpi_video_unregister_backlight() is now only used by video_detect.c
which is part of the same acpi_video module as video.c, make
acpi_video_unregister_backlight() private to this module.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 1 -
drivers/acpi
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Henrique de Moraes Holschuh h...@hmh.eng.br
---
drivers/platform/x86/thinkpad_acpi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/eeepc-laptop.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/msi-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/intel_oaktrail.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Jonathan Woithe jwoi...@just42.net
---
drivers/platform/x86/fujitsu-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/asus-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/ideapad-laptop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/ideapad-laptop.c
b/drivers
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/msi-wmi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi
Remove the old backlight interface selection API now that all drivers
have been ported to the new API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 31 ---
include/linux/acpi.h| 19 ---
2 files changed, 50
Hi,
On 06/14/2015 05:15 AM, Azael Avalos wrote:
Hi Hans,
Sorry for the late reply, I was out of town.
2015-06-12 5:23 GMT-06:00 Hans de Goede hdego...@redhat.com:
Port the backlight selection logic to the new backlight interface
selection API.
Also fix a compiler warning about bt_present
This commit also makes changes to drivers/platform/x86/Kconfig to ensure
that drivers which use acpi_video_backlight_support() from video_detect.c,
will not be built-in when acpi_video is not built in. This also changes
some select uses to depends on to avoid dependency loops.
Signed-off-by: Hans de
Most of the patch is moving the dmi quirks for forcing use of the
acpi-video / the native backlight interface to video_detect.c.
What remains is a nice cleanup.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 172
Remove the now unused acpi_video_dmi_demote_vendor() function, this was
never a proper counter part of acpi_video_dmi_promote_vendor() since
the calls to acpi_video_dmi_promote_vendor() are not counted.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 9
unregistering the
acpi_video backlight interface if it was registered before other drivers
which take priority over it are loaded, to video_detect.c where this
logic really belongs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 171
Hi Rafael,
As requested here is a rebased version of my acpi-video backlight interface
selection logic rewrite. This is based on linux-pm/linux-next.
I've also included 3 platform/x86 patches already queued up by Darren as you
will need those to apply some later patches without conflicts. These
This results in a nice cleanup, as we can replace the complicated logic
from should_ignore_backlight_request() with a simple check for the type
being native.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/gpu/drm/i915/intel_opregion.c | 12 +---
1 file changed, 1 insertion
acpi_video_get_capabilities() is only used inside video_detect.c so make
it static. While at it also remove the prototype for the non existent
acpi_video_display_switch_support function from acpi.h
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 3 +--
include
for brightness events I believe that the latter case
will needs to be handled on a case by case basis by filtering out the
duplicate keypresses at the other source for them.
Cc: Seth Forshee seth.fors...@canonical.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c
video bus is
the canonical source for brightness events I believe that the latter case
will needs to be handled on a case by case basis by filtering out the
duplicate keypresses at the other source for them.
Cc: Corentin Chary corentin.ch...@gmail.com
Signed-off-by: Hans de Goede hdego...@redhat.com
-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/asus-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 7543a56..945145d 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86
Hi,
On 10-06-15 23:30, Mattia Dongili wrote:
On Wed, Jun 10, 2015 at 03:01:28PM +0200, Hans de Goede wrote:
Port the backlight selection logic to the new backlight interface
selection API.
This commit also removes various obsolete pr_xxx messages related to
backlight interface selection
on CONFIG_ACPI_VIDEO.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/scan.c | 56 ++
drivers/acpi/video_detect.c | 60 -
include/linux/acpi.h| 8 ++
3 files changed, 58 insertions
Remove the now unused acpi_video_dmi_demote_vendor() function, this was
never a proper counter part of acpi_video_dmi_promote_vendor() since
the calls to acpi_video_dmi_promote_vendor() are not counted.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 9
unregistering the
acpi_video backlight interface if it was registered before other drivers
which take priority over it are loaded, to video_detect.c where this
logic really belongs.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 171
in
video_detect.c in the first place.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/internal.h | 7 ---
drivers/acpi/osl.c | 6 ++
drivers/acpi/video_detect.c | 6 --
include/linux/acpi.h| 1 +
4 files changed, 7 insertions(+), 13 deletions
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/asus-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
to the new backlight interface selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
index 1ae7536..2807bbf 100644
--- a/drivers/acpi/video_detect.c
and
it needlessly complicates the code.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 59 ++---
drivers/acpi/video_detect.c | 27 +
2 files changed, 29 insertions(+), 57 deletions(-)
diff --git a/drivers/acpi
acpi_video_get_capabilities() is only used inside video_detect.c so make
it static. While at it also remove the prototype for the non existent
acpi_video_display_switch_support function from acpi.h
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 3 +--
include
safe manner, this commit adds locking to make this thread safe.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 43 +--
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi
This commit also makes changes to drivers/platform/x86/Kconfig to ensure
that drivers which use acpi_video_backlight_support() from video_detect.c,
will not be built-in when acpi_video is not built in. This also changes
some select uses to depends on to avoid dependency loops.
Signed-off-by: Hans de
Most of the patch is moving the dmi quirks for forcing use of the
acpi-video / the native backlight interface to video_detect.c.
What remains is a nice cleanup.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 178
fix would be to dmi-blacklist the gmux
driver on that system.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/platform/x86/apple-gmux.c
b/drivers/platform/x86/apple-gmux.c
index 45032ce..a7f6412
Hi All,
Here is v2 of my rewrite / cleanup of the acpi-video (and platform/x86)
backlight interface selection logic.
The major change in v2 of this set are 2 changes to the patch titled
acpi-video-detect: video: Make video_detect code part of the video module:
1) The __setup call for the
() call to acpi_video_register(),
so that we can be sure the dmi quirks have always been applied before
probing.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/acpi_video.c b/drivers
This results in a nice cleanup, as we can replace the complicated logic
from should_ignore_backlight_request() with a simple check for the type
being native.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/gpu/drm/i915/intel_opregion.c | 12 +---
1 file changed, 1 insertion
Port the backlight selection logic to the new backlight interface
selection API.
Also fix a compiler warning about bt_present not being initialized.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/toshiba_acpi.c | 9 +++--
1 file changed, 3 insertions(+), 6
Remove the old backlight interface selection API now that all drivers
have been ported to the new API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/video_detect.c | 31 ---
include/linux/acpi.h| 19 ---
2 files changed, 50
acpi_video_unregister_backlight() is now only used by video_detect.c
which is part of the same acpi_video module as video.c, make
acpi_video_unregister_backlight() private to this module.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/acpi/acpi_video.c | 1 -
drivers/acpi
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/eeepc-laptop.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
Reviewed-by: Lee, Chun-Yi j...@suse.com
---
drivers/platform/x86/acer-wmi.c | 10 +++---
1 file changed, 3
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Henrique de Moraes Holschuh h...@hmh.eng.br
---
drivers/platform/x86/thinkpad_acpi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/msi-wmi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Pali Rohár pali.ro...@gmail.com
---
drivers/platform/x86/dell-wmi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/intel_oaktrail.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/msi-laptop.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/ideapad-laptop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/ideapad-laptop.c
b/drivers
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/samsung-laptop.c | 27 ---
1 file changed, 4 insertions(+), 23
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/compal-laptop.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/x86/compal-laptop.c
b/drivers
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/platform/x86/apple-gmux.c
b/drivers/platform/x86
Port the backlight selection logic to the new backlight interface
selection API.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-By: Pali Rohár pali.ro...@gmail.com
---
drivers/platform/x86/dell-laptop.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Mattia Dongili malat...@linux.it
---
drivers/platform/x86/sony-laptop.c | 7 ++-
1 file changed, 2
they are not necessary, if the user wants to know which backlight
interfaces are registered a simple ls /sys/class/backlight suffices.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/asus-wmi.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git
for brightness events I believe that the latter case
will needs to be handled on a case by case basis by filtering out the
duplicate keypresses at the other source for them.
Cc: Seth Forshee seth.fors...@canonical.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/apple-gmux.c
video bus is
the canonical source for brightness events I believe that the latter case
will needs to be handled on a case by case basis by filtering out the
duplicate keypresses at the other source for them.
Cc: Corentin Chary corentin.ch...@gmail.com
Signed-off-by: Hans de Goede hdego...@redhat.com
-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/asus-wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 7543a56..945145d 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86
Hi Darren,
On 01-06-15 19:41, Darren Hart wrote:
On Mon, Jun 01, 2015 at 11:25:05AM +0200, Hans de Goede wrote:
Hi All,
I'm working on cleaning up the currently somewhat convoluted logic to
select which backlight interfaces to register on x86 systems, see:
http://lists.freedesktop.org
Hi,
On 02-06-15 11:59, Jani Nikula wrote:
On Mon, 01 Jun 2015, Hans de Goede hdego...@redhat.com wrote:
Hi All,
I'm working on cleaning up the currently somewhat convoluted logic to
select which backlight interfaces to register on x86 systems, see:
http://lists.freedesktop.org/archives/dri
breakage.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1239050
Cc: sta...@vger.kernel.org
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/platform/x86/ideapad-laptop.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/platform/x86/ideapad-laptop.c
b/drivers
breakage.
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1275490
Cc: sta...@vger.kernel.org
Reported-and-tested-by: Kevin Fenzi <ke...@scrye.com>
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/platform/x86/ideapad-laptop.c | 7 +++
1 file changed, 7 insertions(+)
we default to
acpi_backlight=native there, and that has the same requirement.
Regards,
Hans
>From d2ee1961d2a94a5f7b9f2bf5ae9fb2e6a791f25b Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdego...@redhat.com>
Date: Thu, 17 Dec 2015 09:51:07 +0100
Subject: [PATCH 1/4] acpi-video: Add a
acpi_video_hand
Hi,
On 17-12-15 19:47, Pali Rohár wrote:
Hi Hans! See my comments below about your patches.
From 9355058f5c1d7c815a293e0c0731d85f0a59b4a1 Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdego...@redhat.com>
Date: Thu, 17 Dec 2015 09:59:01 +0100
Subject: [PATCH 2/4] dell-wm
gh. Without
DSDT patching you have to choose between hotkey support and sane
brightness control. Unless you can prove me wrong, which I am hoping
for.
CCing Hans de Goede
Hans, you tried to fix problems with acpi backlight... do you have idea
how to fix above problem with those two brightness
the canonical source, and the events from the other source
should be filtered (using e.g. /lib/udev/hwdb.d/60-keyboard.hwdb).
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/acpi/acpi_video.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/driver
.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/platform/x86/dell-wmi.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index f2d77fe..cb8a9c2 100644
--- a/drivers/platform/x86/dell-wmi.c
,
the previous brightness-up event gets reported. Since the keypresses are
also reported via wmi (if active) and via atkbd (when wmi is not active)
add a quirk to simply filter out the delayed (broken) events.
Reported-and-tested-by: Michał Kępień <ker...@kempniu.pl>
Signed-off-by: Hans de Goede
. there may be no acpi-video
bus on the system at all.
This commit adds a acpi_video_handles_brightness_key_presses() helper
function, making the code needing this functionality both easier to read
and more correct.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/acpi/acpi_video.
.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 0bed473..f453d5d 100644
--- a/drivers/platfo
Hi All,
This patch-set is the result of the discussion surrounding the
backlight issues on the Dell Vostro V131. The first 3 patches
cleanup how some platform/x86 drivers detect if acpi-video
is handling brightness key presses and that they should
not report duplicate events. This is a cleanup
Hi,
On 28-12-15 00:08, Henrique de Moraes Holschuh wrote:
On Tue, 22 Dec 2015, Hans de Goede wrote:
Use the new acpi_video_handles_brightness_key_presses function to check
if we should report brightness key-presses.
This makes the code both easier to read and makes it properly report
key
101 - 197 of 197 matches
Mail list logo
