[PATCH] ideapad-laptop: add new driver

2010-08-12 Thread Ike Panhc
* Video resolution switch - reports KEY_VIDEO_NEXT * S/W rfkill key - reports KEY_WLAN The developing git tree as reference: git://kernel.ubuntu.com/ikepanhc/ideapad-laptop.git This patch made against current checkout of mainline kernel. Signed-off-by: Ike Panhc ike@canonical.com

Re: [PATCH] ideapad-laptop: add new driver

2010-08-13 Thread Ike Panhc
On 08/13/2010 03:01 PM, Corentin Chary wrote: Could you point me where is the rfkill driver? Sorry I do not find it. I will see what I can do. Thanks. Here is the thread http://thread.gmane.org/gmane.linux.drivers.platform.x86.devel/471 Yes, I believe I can. will read patch from David

Re: [PATCH] ideapad-laptop: add new driver

2010-08-13 Thread Ike Panhc
On 08/13/2010 05:34 PM, David Woodhouse wrote: On Fri, 2010-08-13 at 17:27 +0800, Ike Panhc wrote: Yes, IIRC EC will send i8042 keycode when you booting with QS button, not with power button. atkbd.c reports unknown key after booting with QS button. That's interesting. I don't *ever* boot

[PATCH 7/8] ideapad: rewrite the sw rfkill set

2010-08-18 Thread Ike Panhc
Control power of rf modules by ec commands Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad_acpi.c | 37 +++--- 1 files changed, 12 insertions(+), 25 deletions(-) diff --git a/drivers/platform/x86/ideapad_acpi.c b/drivers/platform

Re: [PATCH 5/8] ideapad: use EC command to control camera

2010-08-18 Thread Ike Panhc
Could you give me an example that I can follow? Just point out which C file I shall read. no much knowledge about generic power framework. Thanks On 08/18/2010 04:42 PM, Oliver Neukum wrote: Am Mittwoch, 18. August 2010, 10:38:15 schrieb Ike Panhc: Signed-off-by: Ike Panhc ike

Re: [PATCH 0/8] [Resend] ideapad: using EC command to control rf/camera power

2010-08-18 Thread Ike Panhc
On 08/18/2010 06:35 PM, David Woodhouse wrote: On Wed, 2010-08-18 at 09:36 +0100, Ike Panhc wrote: Once the rfkill of a laptop is set to block, it is no way to unblock with Linux without driver. Thanks for David Woodhouse wrote the first driver solving this. But the \_SB_.GECN and \_SB_

Re: [PATCH 8/8] ideapad: Change the driver name to ideapad_laptop

2010-08-26 Thread Ike Panhc
On 08/26/2010 01:43 PM, Corentin Chary wrote: On Wed, Aug 25, 2010 at 10:56 PM, Len Brown l...@kernel.org wrote: drivers/platform/x86/ideapad_acpi.c | 381 - drivers/platform/x86/ideapad_laptop.c | 381 + Acked-by: Len

[Resend] [PATCH 0/9] ideapad: using EC command to control rf/camera power

2010-10-01 Thread Ike Panhc
: no_bt_rfkill for not setup bluetooth rfkill. Next step for this driver: * Hotkey enablement. Ike Panhc (9): ideapad: add ACPI helpers ideapad: check VPC bit before sync rfkill hw status ideapad: make sure we bind on the correct device ideapad: use return value of _CFG to tell if device

[PATCH 1/9] ideapad: add ACPI helpers

2010-10-01 Thread Ike Panhc
There are two methods under VPC2004 which is used to access VDAT/VCMD of EC register. Add helpers for read and write these two registers. And add read_method_int for reading the return value from ACPI methods which requires no parameter. Signed-off-by: Ike Panhc ike@canonical.com

[PATCH 4/9] ideapad: use return value of _CFG to tell if device exist or not

2010-10-01 Thread Ike Panhc
There are several bits of the return value of _CFG shows if RF/Camera devices exist or not. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad_acpi.c | 44 --- 1 files changed, 10 insertions(+), 34 deletions(-) diff --git a/drivers

[PATCH 5/9] ideapad: use EC command to control camera

2010-10-01 Thread Ike Panhc
Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad_acpi.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/ideapad_acpi.c b/drivers/platform/x86/ideapad_acpi.c index 43a1c89..aacf84e 100644 --- a/drivers

[PATCH 6/9] ideapad: rewrite the hw rfkill notify

2010-10-01 Thread Ike Panhc
1. Read hw rfkill status by ec command 2. Not to touch sw status of each rfkill when hw rfkill notify 3. Initial rfkill status when module loaded Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad_acpi.c | 53 +++--- 1 files changed, 17

[PATCH 7/9] ideapad: rewrite the sw rfkill set

2010-10-01 Thread Ike Panhc
Control power of rf modules by ec commands Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad_acpi.c | 37 +++--- 1 files changed, 12 insertions(+), 25 deletions(-) diff --git a/drivers/platform/x86/ideapad_acpi.c b/drivers/platform

[PATCH 9/9] ideapad: Add param: no_bt_rfkill

2010-10-01 Thread Ike Panhc
. Signed-off-by: Ike Panhc ike@canonical.com Tested-by: Mario 'BitKoenig' Holbe mario.ho...@tu-ilmenau.de --- drivers/platform/x86/ideapad-laptop.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86

Re: [PATCH 3/3] ideapad: add hotkey support

2010-11-18 Thread Ike Panhc
On 11/18/2010 03:35 PM, Corentin Chary wrote: On Wed, Nov 17, 2010 at 10:29 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Nov 17, 2010 at 03:00:38PM +0800, Ike Panhc wrote: Hotkey enabled by this patch: Fn+F3: Video mode switch Fn+F5: software rfkill for wifi For some

Re: [PATCH 3/3] ideapad: add hotkey support

2010-12-02 Thread Ike Panhc
On 12/03/2010 07:41 AM, Dave Hansen wrote: On Wed, 2010-11-17 at 15:00 +0800, Ike Panhc wrote: +static void ideapad_input_report(unsigned long scancode) +{ + sparse_keymap_report_event(ideapad_priv-inputdev, scancode, 1, true); +} I got a little build error about some unresolved

[PATCH v2 0/7] ideapad: hotkey enablement

2010-12-08 Thread Ike Panhc
. These patches are available in the git repository at: git://kernel.ubuntu.com/ikepanhc/ideapad-laptop.git ideapad-laptop Ike Panhc (7): ideapad: add platform driver for ideapad ideapad: let camera power control entry under platform driver ideapad: add hotkey support ideapad: select

[PATCH 1/7] ideapad: add platform driver for ideapad

2010-12-08 Thread Ike Panhc
Create /sys/devices/platform/Ideapad for nodes of ideapad landing. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 54 1 files changed, 47 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/ideapad

[PATCH 2/7] ideapad: let camera power control entry under platform driver

2010-12-09 Thread Ike Panhc
The entry was at /sys/devices/LNXSYSTM:00/../VPC2004:00/camera_power move to /sys/devices/platform/Ideapad/camera_power Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 55 +++-- 1 files changed, 25 insertions(+), 30

[PATCH 3/7] ideapad: add hotkey support

2010-12-09 Thread Ike Panhc
Hotkey enabled by this patch: Fn+F3: Video mode switch Fn+F5: software rfkill for wifi For some ideapad when push Fn+F3, hardware generates Super-P keys, those key will not be enabled by this patch. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c

[PATCH 4/7] ideapad: select INPUT_SPARSEKMAP

2010-12-09 Thread Ike Panhc
: sparse_keymap_report_event [drivers/platform/x86/ideapad-laptop.ko] undefined! To select INPUT_SPARSEKMAP solve this issue. Ref: http://lkml.org/lkml/2010/12/2/340 Signed-off-by: Dave Hansen d...@linux.vnet.ibm.com Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/Kconfig

[PATCH 5/7] ideapad: add markups, unify comments and return result when init

2010-12-09 Thread Ike Panhc
1. Add markups on init and exit functions 2. Unify the comments in the same style 3. Return result when module initial Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions

[PATCH 7/7] ideapad: pass ideapad_priv as argument (part 2)

2010-12-09 Thread Ike Panhc
Passing ideapad_priv as argument and try not to using too much global variable. This is part 2 for rfkill. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 69 + 1 files changed, 27 insertions(+), 42 deletions(-) diff

Re: [PATCH v2 0/7] ideapad: hotkey enablement

2010-12-13 Thread Ike Panhc
On 12/09/2010 04:39 PM, Corentin Chary wrote: acpi_handle is still a global variable becuase we need to pass handle pointer to rfk_set with its opcode but only one data argument available. Of course there is only one data argument available, but since it's a void *, you can use a struct

[PATCH v3 0/6] ideapad: hotkey enablement

2010-12-13 Thread Ike Panhc
and hotkey enablement patch. From Corentin Chary, add documentation about the usage of sysfs node From Dave Hansen, change the platform node name from Ideapad to ideapad These patches are available in the git repository at: git://kernel.ubuntu.com/ikepanhc/ideapad-laptop.git ideapad-laptop Ike Panhc

[PATCH 1/6] ideapad: add platform driver for ideapad

2010-12-13 Thread Ike Panhc
Create /sys/devices/platform/ideapad for nodes of ideapad landing. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 54 1 files changed, 47 insertions(+), 7 deletions(-) diff --git a/drivers/platform/x86/ideapad

[PATCH 2/6] ideapad: let camera power control entry under platform driver

2010-12-13 Thread Ike Panhc
The entry was at /sys/devices/LNXSYSTM:00/../VPC2004:00/camera_power move to /sys/devices/platform/ideapad/camera_power Add document about usage of ideapad node in sysfs. Signed-off-by: Ike Panhc ike@canonical.com --- .../ABI/testing/sysfs-platform-ideapad-laptop |6 ++ drivers

[PATCH 3/6] ideapad: add hotkey support

2010-12-13 Thread Ike Panhc
INPUT_SPARSEKMAP solve this issue. Ref: http://lkml.org/lkml/2010/12/2/340 Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/Kconfig |1 + drivers/platform/x86/ideapad-laptop.c | 72 + 2 files changed, 73 insertions(+), 0 deletions

[PATCH 4/6] ideapad: add markups, unify comments and return result when init

2010-12-13 Thread Ike Panhc
1. Add markups on init and exit functions 2. Unify the comments in the same style 3. Return result when module initial Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 31 +-- 1 files changed, 17 insertions(+), 14 deletions

[PATCH 5/6] ideapad: pass ideapad_priv as argument (part 1)

2010-12-13 Thread Ike Panhc
Passing ideapad_priv as argument and try not to using too much global variable. This is part 1 for platform driver and input device. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 54 + 1 files changed, 28 insertions

[PATCH 6/6] ideapad: pass ideapad_priv as argument (part 2)

2010-12-13 Thread Ike Panhc
Passing ideapad_priv as argument and try not to using too much global variable. This is part 2 for rfkill. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 71 +--- 1 files changed, 29 insertions(+), 42 deletions(-) diff

[PATCH] ideapad: read brightness setting on brightness key notify

2011-02-23 Thread Ike Panhc
. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index 114d952..21b1018 100644 --- a/drivers/platform/x86

Re: [PATCH] ideapad: read brightness setting on brightness key notify

2011-02-23 Thread Ike Panhc
On 02/23/2011 09:47 PM, Matthew Garrett wrote: Which kernel versions does this hit? This patch is made against current checkout of Linus's tree. -- To unsubscribe from this list: send the line unsubscribe platform-driver-x86 in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] ideapad: read brightness setting on brightness key notify

2011-02-23 Thread Ike Panhc
On 02/23/2011 10:22 PM, Matthew Garrett wrote: On Wed, Feb 23, 2011 at 10:07:12PM +0800, Ike Panhc wrote: On 02/23/2011 09:47 PM, Matthew Garrett wrote: Which kernel versions does this hit? This patch is made against current checkout of Linus's tree. The bug, not the patch :) This bug

Re: acer-wmi is unnecessarily loaded on a Lenovo Ideapad S12

2011-03-02 Thread Ike Panhc
On 03/03/2011 02:50 PM, Joey Lee wrote: Hi Ike, Yes, I just simply check the Ideapad S12's DSDT that was dumped by Ville-Pekka Vaino, it also declare VPC2004 devices in EC block. And, per Vaino's mail, he said ideapad-laptop handle the killswitches better on Ideapad S12. Did you

[Stable-38] [PATCH] ideapad: read brightness setting on brightness key notify

2011-04-15 Thread Ike Panhc
. Signed-off-by: Ike Panhc ike@canonical.com Signed-off-by: Matthew Garrett m...@redhat.com (cherry picked from upstream commit 2165136585b5c7d6f118f1d90fbde550bb7de212) --- drivers/platform/x86/ideapad-laptop.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers

Re: Wifi switch not working, linux on IdeaPad S205

2011-05-31 Thread Ike Panhc
switch status. The second one is to find out how to unseal the switch function with wmi (maybe a worse idea). First thing I need to ask is there any side effect to load acer-wmi on your ideapad? On 04/28/2011 04:42 PM, Florian Heyer wrote: On 18.04.2011 03:35, Ike Panhc wrote: In the mean time

Re: Accelerometer and orientation sensor on Lenovo Ideapad S10-3t

2011-06-01 Thread Ike Panhc
On 05/28/2011 08:03 PM, Richard Schütz wrote: On 05/26/11 20:27, Alberto Mardegan wrote: Secondly, I'd like to add support for reading the accelerometer values, as it's done here (again, kudos to Javier): http://gitorious.org/iaps/iaps/blobs/master/iaps.c I know that no one is happy of

[PATCH 1/3] ideapad: Use define for cfg bits

2011-06-02 Thread Ike Panhc
instead of hard code the number. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c

[PATCH 3/3] ideapad: Show negative when no camera

2011-06-02 Thread Ike Panhc
Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index 9c09891..4a54ed1 100644 --- a/drivers/platform

Re: [PATCH 2/3] ideapad: Add nodes in sysfs

2011-06-02 Thread Ike Panhc
On 06/02/2011 05:48 PM, Corentin Chary wrote: Hi Ike, Why do you want to add /sys/devices/platform/ideapad/brightness and /sys/devices/platform/ideapad/backlight ? Both of these files should be handled by the generic backlight class (using brightness and bl_power). This is within

Re: [PATCH 3/3] ideapad: Show negative when no camera

2011-06-02 Thread Ike Panhc
On 06/02/2011 05:43 PM, Corentin Chary wrote: I think it would be better to not add the file when the camera is not available. Another option is to return -ENODEV. But printing -1 doesn't seems right. Agree, making the node invisible is better. -- To unsubscribe from this list: send the line

Re: Wifi switch not working, linux on IdeaPad S205

2011-06-09 Thread Ike Panhc
On 06/07/2011 09:48 PM, Joey Lee wrote: 於 五,2011-06-03 於 14:49 +0200,Florian Heyer 提到: fn+f5 doesn't do anything no matter what state the wifi switch is. Personally i wouldn't mind if only the wifi switch is supported, i mean, you don't need a key combination if you have a real switch for wifi

Re: [PATCH] ideapad: let Fn+F5 also trigger KEY_BLUETOOTH

2011-06-14 Thread Ike Panhc
On 06/14/2011 04:28 PM, Ike Panhc wrote: The design for ideapad Fn-F5 key is not only for wifi but for all radio device including wifi, bluetooth and wwan. Idealy it shall acts like this: wifi on wifi off wifi on wifi off bt on - bt on - bt

Re: Wifi switch not working, linux on IdeaPad S205

2011-06-16 Thread Ike Panhc
On 06/15/2011 05:32 PM, Joey Lee wrote: 於 四,2011-06-09 於 16:36 +0800,Ike Panhc 提到: But Florian said the Fn+F5 doesn't work to him, as you said, the _Q2B works when GWSS is not zero: Method (_Q2B, 0, NotSerialized) /* wifi key? */ { Store (0x2B, P80H

[PATCH 2/3] ideapad: let camera_power node invisiable if no camera

2011-06-22 Thread Ike Panhc
Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index 51d4144..678bbf7 100644

Re: [PATCH 3/3] ideapad: add backlight driver

2011-06-22 Thread Ike Panhc
On 06/23/2011 03:40 AM, Matthew Garrett wrote: +static int ideapad_backlight_get_brightness(struct backlight_device *blightdev) +{ +unsigned long now; + +if (read_ec_data(ideapad_handle, 0x12, now)) +return -EAGAIN; Description says you're using commands on the

Re: [PATCH 2/2] ideapad-laptop: Handle the App-controlled RF event

2011-06-29 Thread Ike Panhc
On 06/28/2011 09:35 PM, Keng-Yu Lin wrote: Notification with VPC2 bit 5 set is generated when the wireless hotkey is pressed. BIOS fires this to notify a Windows application to handle the RF switch. On Linux, there is no such application. This patch implements a toggle for all RF devices

Re: [PATCH 1/2] ideapad-laptop: Ignore an unused VPC notification

2011-06-29 Thread Ike Panhc
On 06/28/2011 09:35 PM, Keng-Yu Lin wrote: BIOS fires notifications in a constant period with VPC bit 1 set when the power cord is unplugged. This event is not known yet to have any effect, but it makes the call to sparse_keymap_report_event() and generates many KEY_UNKNOWNs. This causes

[PATCH 2/3] ideapad: let camera_power node invisiable if no camera

2011-06-30 Thread Ike Panhc
Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index 42b9ba7..1612abd 100644

Re: Wifi switch not working, linux on IdeaPad S205

2011-06-30 Thread Ike Panhc
that ideapad-laptop block your wifi connection even it shows unblocked. On 06/25/2011 05:28 AM, Florian Heyer wrote: On 22.06.2011 11:28, Ike Panhc wrote: Hi Florian, Could you have the same test with ideapad-laptop loaded? I need to make sure ideapad-laptop have the correct rfkill information

Re: Wifi switch not working, linux on IdeaPad S205

2011-07-01 Thread Ike Panhc
On 06/30/2011 11:03 PM, Florian Heyer wrote: On 30.06.2011 16:26, Ike Panhc wrote: Hi Florian, Thanks for your testing, looks like ideapad-laptop reports correct rfkill state. Just two questions to be clarified, 1. Which wifi driver you are using? wl or others? Hello Joey, i'm

Re: [RESEND][PATCH 0/5] Support for the TS-5500 board

2011-08-09 Thread Ike Panhc
I think platform-driver-x86 may not be the best mailing list for your patches. Please try to use scripts/get_maintainer.pl and it can tell you who you shall ask for reviewing. On 08/10/2011 11:32 AM, Vivien Didelot wrote: Le Thu, 28 Jul 2011 17:10:45 -0400, Vivien Didelot

Hi Rene,

2011-08-23 Thread Ike Panhc
backlight power in 'ideapad_backlight_notify_power' to avoid a page fault This patch avoid a page fault in the ideapad-laptop extras when turning the backlight power on or off. Signed-off-by: Rene Bolldorf xsec...@googlemail.com Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform

[PATCH] MAINTAINERS: add new entry for ideapad-laptop

2011-08-25 Thread Ike Panhc
Signed-off-by: Ike Panhc ike@canonical.com --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 069ee3b..cca2a91 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3183,6 +3183,13 @@ F: Documentation/ide/ F

[PATCH 1/5] ideapad: define vpc commands

2011-09-05 Thread Ike Panhc
Better then write hex number everywhere. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 57 +++- 1 files changed, 41 insertions(+), 16 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform

[PATCH 2/5] ideapad: change parameter of ideapad_sync_rfk_state

2011-09-05 Thread Ike Panhc
This could save us a local variable. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index

[PATCH 3/5] ideapad: add event for Novo key

2011-09-05 Thread Ike Panhc
for Linux yet, so I think to report KEY_PROG is fine in anyway. Also change the scancode from hex to decimal because they are related to vpc bit in notify function which is in decimal. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c | 21

[PATCH 4/5] ideapad: add debugfs support

2011-09-05 Thread Ike Panhc
Add two nodes in debugfs which shows cfg value and its meaning, and status info read from VPC2004. Signed-off-by: Ike Panhc ike@canonical.com --- Documentation/ABI/testing/debugfs-ideapad | 19 drivers/platform/x86/ideapad-laptop.c | 152 + 2 files

[PATCH 5/5] ideapad: remove sysfs node for cfg

2011-09-05 Thread Ike Panhc
Replaced by the one in debugfs. Signed-off-by: Ike Panhc ike@canonical.com --- .../ABI/testing/sysfs-platform-ideapad-laptop | 15 --- drivers/platform/x86/ideapad-laptop.c | 12 2 files changed, 0 insertions(+), 27 deletions(-) diff --git

Re: [PATCH 4/5] ideapad: add debugfs support

2011-09-19 Thread Ike Panhc
Some modification. On 09/06/2011 02:32 AM, Ike Panhc wrote: static acpi_handle ideapad_handle; +static struct ideapad_private *ideapad_priv; This is not necessary. static bool no_bt_rfkill; module_param(no_bt_rfkill, bool, 0444); MODULE_PARM_DESC(no_bt_rfkill, No rfkill

[PATCH 4/5] ideapad: add debugfs support

2011-09-19 Thread Ike Panhc
Add two nodes in debugfs which shows cfg value and its meaning, and status info read from VPC2004. Signed-off-by: Ike Panhc ike@canonical.com --- Documentation/ABI/testing/debugfs-ideapad | 19 drivers/platform/x86/ideapad-laptop.c | 149 + 2 files

Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520

2011-10-13 Thread Ike Panhc
Hi Joey, Here you are. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/+attachment/2330828/+files/AcpiTables.txt On 10/14/2011 12:35 AM, joeyli wrote: Hi Ike, 於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到: BugLink: http://launchpad.net/bugs/836865 BugLink: http://launchpad.net

Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520

2011-10-17 Thread Ike Panhc
The full discussion is at https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865 Thank's Joey Lee 於 五,2011-10-14 於 10:48 +0800,Ike Panhc 提到: Hi Joey, Here you are. https://bugs.launchpad.net/ubuntu/+source/linux/+bug/836865/+attachment/2330828/+files/AcpiTables.txt On 10/14

Re: [PATCH] acer-wmi: blacklist Thinkpad edge E520

2011-10-24 Thread Ike Panhc
On 10/25/2011 07:13 AM, Dave Jones wrote: On Tue, Oct 25, 2011 at 06:22:47AM +0800, joeyli wrote: 於 四,2011-10-13 於 14:51 +0800,Ike Panhc 提到: BugLink: http://launchpad.net/bugs/836865 BugLink: http://launchpad.net/bugs/826784 There are reports say that acer-wmi is loaded

Re: [PATCH linux-3.1.y] ideapad: Check if acpi already handle backlight power to avoid a page fault

2012-01-11 Thread Ike Panhc
turning the backlight power on or off. Signed-off-by: Rene Bolldorf xsec...@googlemail.com Signed-off-by: Matthew Garrett m...@redhat.com Signed-off-by: Jonathan Nieder jrnie...@gmail.com Tested-by: Artem X artem@gmail.com Acked-by: Ike Panhc ike@canonical.com --- Artem X wrote

Re: [PATCH] acer-wmi: check wireless capability on AMW0_GUID2 machines

2012-01-11 Thread Ike Panhc
On 01/11/2012 12:26 PM, joeyli wrote: 於 一,2012-01-09 於 22:15 +,Carlos Corbacho 提到: On Monday 09 Jan 2012 18:00:24 joeyli wrote: I just checked and found I also have no AMW0_GUID2 machines on my hand, now. I have some questions about AMW0_GUID2: + Why we enabled wireless capability in

[PATCH] acer-wmi: support for P key on TM8372

2012-01-23 Thread Ike Panhc
From: Merlin Schumacher merlin.schumac...@gmail.com BugLink: http://launchpad.net/bugs/865807 There is no entry for P key on TM8372, so when P key is pressed, only acer_wmi: Unknown key number - 0x29 in dmesg. Signed-off-by: Merlin Schumacher merlin.schumac...@gmail.com Signed-off-by: Ike Panhc

Re: [PATCH] acer-wmi: No wifi rfkill on Lenovo machines

2012-01-24 Thread Ike Panhc
/25/2012 09:57 AM, Ike Panhc wrote: We have several reports which says acer-wmi is loaded on ideapads and register rfkill for wifi which can not be unblocked. Since ideapad-laptop also register rfkill for wifi and it works reliably, it will be fine acer-wmi is not going to register rfkill

Re: [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines

2012-02-03 Thread Ike Panhc
Two modification. * Check quirks also. * for static variable, no need to set to 0 as initial value. On 02/03/2012 04:46 PM, Ike Panhc wrote: We have several reports which says acer-wmi is loaded on ideapads and register rfkill for wifi which can not be unblocked. Since ideapad-laptop also

Re: [PATCH v2] acer-wmi: No wifi rfkill on Lenovo machines

2012-02-06 Thread Ike Panhc
於 16:46 +0800,Ike Panhc 提到: We have several reports which says acer-wmi is loaded on ideapads and register rfkill for wifi which can not be unblocked. Since ideapad-laptop also register rfkill for wifi and it works reliably, it will be fine acer-wmi is not going to register rfkill for wifi

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

2012-03-14 Thread Ike Panhc
Hi Vaclav, Could you try this just-merged patch and see if it fix your problem? http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h=461e74377cfcfc2c0d6bbdfa8fc5fbc21b052c2a On 03/14/2012 11:01 AM, Vaclav Mocek wrote: Hi all, I am an unhappy owner of Lenovo Ideapad S205

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

2012-03-15 Thread Ike Panhc
On 03/16/2012 11:46 AM, Ike Panhc wrote: On 03/16/2012 07:09 AM, Vaclav Mocek wrote: On 03/14/2012 06:16 AM, Ike Panhc wrote: Hi Vaclav, Could you try this just-merged patch and see if it fix your problem? http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commit;h

Re: [PATCH 3.0.y] acer-wmi: No wifi rfkill on Lenovo machines

2012-03-15 Thread Ike Panhc
On 03/15/2012 06:17 AM, Jonathan Nieder wrote: Greg KH wrote: On Wed, Mar 14, 2012 at 04:53:27PM -0500, Jonathan Nieder wrote: Please consider applying 461e74377cfc (acer-wmi: No wifi rfkill on Lenovo machines, 2012-02-03) to the 3.2.y and 3.0.y trees. Now applied. Thanks! That was

Re: drivers/platform/x86/acer-wmi.c: Support for another Lenovo Ideapad S205

2012-03-19 Thread Ike Panhc
On 03/20/2012 10:05 AM, joeyli wrote: Hi Vaclav, 於 二,2012-03-20 於 00:45 +,Vaclav Mocek 提到: Hi Joey, If you want, Please kindly try this patch. [Re]tested, it works. Actually, it was the first thing I tried, but after that I found out there are other sixteen known product names.

[PATCH 1/2] ideapad: remove unused define and fix a typo

2012-05-03 Thread Ike Panhc
After review the current ideapad-laptop, found an unused define and a typo. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform

[PATCH 2/2] ideapad: generate valid key event only

2012-05-03 Thread Ike Panhc
Otherwise will generate KEY_UNKNOWN on un-listed vpc event, which means nothing and is hard for user to report the detail of the event. Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

Re: [PATCH] drivers/platform/x86: Lenovo IdeaPad Z570 support

2012-05-21 Thread Ike Panhc
This is a quick reply. Will make fully review later. On 05/21/2012 11:50 PM, Максим Микитянский wrote: From: Maxim Mikityanskiy maxtra...@gmail.com The patch adds support for Lenovo IdeaPad Z570 laptop. It makes all special keys working, adds possibility to control fan like Windows does and

Re: [patch] ideapad: uninitialized data in ideapad_acpi_add()

2012-06-20 Thread Ike Panhc
Hi Dan, # cat /sys/kernel/debug/ideapad/cfg cfg: 0x887DE140 the uninitialized bit I see your point, perhaps unsigned int will be better then int? On 06/13/2012 12:28 AM, Dan Carpenter wrote: We only initialize the high bits of cfg. It probably doesn't cause a problem

Re: [PATCH 2/2] drivers/input/mouse, drivers/platform/x86: add Lenovo IdeaPad Z570 support

2012-06-20 Thread Ike Panhc
-platform-ideapad-laptop.orig +++ linux/Documentation/ABI/testing/sysfs-platform-ideapad-laptop @@ -5,4 +5,14 @@ Contact: Ike Panhc ike.pan@canonical.c Description: Control the power of camera module. 1 means on, 0 means off. - +What:/sys/devices/platform/ideapad

Re: [patch] ideapad: uninitialized data in ideapad_acpi_add()

2012-06-28 Thread Ike Panhc
On 06/22/2012 09:57 PM, Dan Carpenter wrote: On Wed, Jun 20, 2012 at 08:23:13PM +0800, Ike Panhc wrote: Hi Dan, # cat /sys/kernel/debug/ideapad/cfg cfg: 0x887DE140 the uninitialized bit I see your point, perhaps unsigned int will be better then int? I don't know

Re: [PATCH] drivers/platform/x86: Lenovo IdeaPad Z570 support

2012-07-04 Thread Ike Panhc
On 06/27/2012 02:31 AM, Matthew Garrett wrote: Ike, feelings on this? Do we know that these EC offsets are stable? Hi Maxim, I separate your patch into three smaller patch. It makes me easier to understand the detail. Please review if all function are still working fine on your ideapad --

Re: [PATCH] drivers/platform/x86: Lenovo IdeaPad Z570 support

2012-07-05 Thread Ike Panhc
Thanks. I have the patch tested on my ideapads. They all looks fine. The last thing I need is ACK for psmouse patch. On 07/04/2012 11:09 PM, Maxim Mikityanskiy wrote: Hi Maxim, I separate your patch into three smaller patch. It makes me easier to understand the detail. Please review if all

[PATCH 0/4] ideapad: patches for v3.6 merge window

2012-07-06 Thread Ike Panhc
One minor fix on part 2 for z570 is to let CONFIG_IDEAPAD depends on CONFIG_SERIO_I8042 The following changes since commit 71351f14b3b941eb7178567b1272d934609cb785: Linux 3.5-rc5 (2012-07-05 14:09:43 +0800) are available in the git repository at:

[PATCH 1/4] ideapad: uninitialized data in ideapad_acpi_add()

2012-07-06 Thread Ike Panhc
Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/ideapad-laptop.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c index 4f20f8d..5fdd1aa 100644 --- a/drivers/platform/x86

[PATCH 4/4] ideapad: add Lenovo IdeaPad Z570 support (part 3)

2012-07-06 Thread Ike Panhc
on resume from suspend. It is new, modified version of patch. Now it does not depend on psmouse and does not need patching of input subsystem. Signed-off-by: Maxim Mikityanskiy maxtra...@gmail.com This is the part 3 for fan control Signed-off-by: Ike Panhc ike@canonical.com --- .../ABI

[PATCH 3/4] ideapad: add Lenovo IdeaPad Z570 support (part 2)

2012-07-06 Thread Ike Panhc
on resume from suspend. It is new, modified version of patch. Now it does not depend on psmouse and does not need patching of input subsystem. Signed-off-by: Maxim Mikityanskiy maxtra...@gmail.com This is part 2 for touchpad toggle Signed-off-by: Ike Panhc ike@canonical.com --- drivers

[PATCH 2/4] ideapad: add Lenovo IdeaPad Z570 support (part 1)

2012-07-06 Thread Ike Panhc
on resume from suspend. It is new, modified version of patch. Now it does not depend on psmouse and does not need patching of input subsystem. Signed-off-by: Maxim Mikityanskiy maxtra...@gmail.com This is part 1 for special button handling. Signed-off-by: Ike Panhc ike@canonical.com

[PATCH] ideapad: depends on backlight subsystem and update comment

2013-02-22 Thread Ike Panhc
for this driver. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Ike Panhc ike@canonical.com --- drivers/platform/x86/Kconfig |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index c86bae8..c5bc068

Re: [PATCH] ideapad-laptop: Depend on BACKLIGHT_CLASS_DEVICE instead of selecting it

2013-02-25 Thread Ike Panhc
contains drivers for rfkill switch, hotkey, fan control and backlight control. Acked-by: Ike Panhc ike@canonical.com It might be worthy to consider to apply the same modification for ASUS_LAPTOP, SONY_LAPTOP, EEEPC_LAPTOP, ACPI_CMPC, SAMSUNG_Q10 and THINKPAD_ACPI to avoid the warning

[PATCH] ideapad: Report hard block off if it is never on

2015-12-15 Thread Ike Panhc
is changed. For an ideapad with radio switch and driver loaded with radio off, driver will report unblocked falsely and network manager might not scan if wireless driver reports blocked. Once the switch is on, driver will report correct information. Signed-off-by: Ike Panhc <ike@canonical.

Re: [PATCH] ideapad: Report hard block off if it is never on

2015-12-21 Thread Ike Panhc
On 12/19/2015 06:56 AM, Darren Hart wrote: > On Wed, Dec 16, 2015 at 11:49:33AM +0800, Ike Panhc wrote: > > Hi Ike, > > +David Woodhouse (MODULE_AUTHOR) > >> Hardware radio switch is rare on recently ideapad and some of them >> reported radio hardware blocke