Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

2016-01-04 Thread Andy Lutomirski
On Wed, Dec 30, 2015 at 3:27 AM, Michał Kępień wrote: >> > If you feel like I'm nit-picking and none of the above matters, >> > please feel free to disregard my input and just follow your gut. >> >> It's ok. We just understand it quite differently. And in this case what >>

Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

2015-12-30 Thread Michał Kępień
> > If you feel like I'm nit-picking and none of the above matters, > > please feel free to disregard my input and just follow your gut. > > It's ok. We just understand it quite differently. And in this case what > about changing commit message to something like this? > > === > dell-wmi: Check

Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

2015-12-29 Thread Pali Rohár
On Tuesday 29 December 2015 13:44:13 Michał Kępień wrote: > > > > According to Dell WMI document mentioned in ML dicussion > > > > archived at > > > > http://www.spinics.net/lists/platform-driver-x86/msg07220.html > > > > OS should check Dell WMI descriptor structure. > > > > > > "Should" or

Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

2015-12-29 Thread Michał Kępień
> > > According to Dell WMI document mentioned in ML dicussion archived > > > at http://www.spinics.net/lists/platform-driver-x86/msg07220.html > > > OS should check Dell WMI descriptor structure. > > > > "Should" or "can"? I skimmed through the ACPI-WMI PDF and Mario's > > message again and I

Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

2015-12-28 Thread Michał Kępień
> According to Dell WMI document mentioned in ML dicussion archived at > http://www.spinics.net/lists/platform-driver-x86/msg07220.html OS should > check Dell WMI descriptor structure. "Should" or "can"? I skimmed through the ACPI-WMI PDF and Mario's message again and I couldn't find any

Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

2015-12-28 Thread Pali Rohár
On Monday 28 December 2015 14:37:07 Michał Kępień wrote: > > According to Dell WMI document mentioned in ML dicussion archived > > at http://www.spinics.net/lists/platform-driver-x86/msg07220.html > > OS should check Dell WMI descriptor structure. > > "Should" or "can"? I skimmed through the

Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

2015-12-25 Thread Pali Rohár
On Friday 25 December 2015 02:23:04 Andy Lutomirski wrote: > On Thu, Dec 24, 2015 at 1:18 PM, Pali Rohár > wrote: > > According to Dell WMI document mentioned in ML dicussion archived > > at http://www.spinics.net/lists/platform-driver-x86/msg07220.html > > OS should check

Re: [PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

2015-12-24 Thread Andy Lutomirski
On Thu, Dec 24, 2015 at 1:18 PM, Pali Rohár wrote: > According to Dell WMI document mentioned in ML dicussion archived at > http://www.spinics.net/lists/platform-driver-x86/msg07220.html OS should > check Dell WMI descriptor structure. Structure also provide Dell WMI >

[PATCH 1/2] dell-wmi: Check if Dell WMI descriptor structure is valid

2015-12-24 Thread Pali Rohár
According to Dell WMI document mentioned in ML dicussion archived at http://www.spinics.net/lists/platform-driver-x86/msg07220.html OS should check Dell WMI descriptor structure. Structure also provide Dell WMI interface version which is used later. Signed-off-by: Pali Rohár