Re: [Pm-utils] Move pm/functions and hooks to /usr/lib or /usr/share

2007-03-05 Thread Michael Biebl
2007/3/5, Holger Macht [EMAIL PROTECTED]: On Mon 05. Mar - 22:38:57, Tim Dijkstra wrote: Hi, This has come up before already, but without conclusion I think, so here goes... I think (and the FHS with me) that /etc is the wrong place for pm/functions and pm/hooks, etc. They are not

Re: [Pm-utils] Re: Resume via quirks, not using the DBUS method, Was: Release Candidates ?

2007-03-06 Thread Michael Biebl
2007/3/6, Peter Jones [EMAIL PROTECTED]: On Tue, 2007-03-06 at 16:31 +, Richard Hughes wrote: On 06/03/07, Peter Jones [EMAIL PROTECTED] wrote: On Tue, 2007-02-20 at 21:30 +0100, Stefan Seyfried wrote: Before getting towards 1.0, shouldn't we move over from /etc/ to

Re: [Pm-utils] Re: Resume via quirks, not using the DBUS method, Was: Release Candidates ?

2007-03-09 Thread Michael Biebl
2007/3/9, Frederic Crozat [EMAIL PROTECTED]: Le vendredi 09 mars 2007 à 16:45 +0100, Stefan Seyfried a écrit : On Tue, Mar 06, 2007 at 12:01:03PM -0500, Peter Jones wrote: I find myself wondering if /etc/pm/config shouldn't really be /usr/lib/pm-utils/config , actually. That would make

Re: [Pm-utils] [patch commit] [005] POSIXification of pm-utils

2008-01-27 Thread Michael Biebl
2008/1/27, Victor Lowther [EMAIL PROTECTED]: on_ac_power never returns 255, so simplify our test functions. The original on_ac_power binary does (and we use this binary in Debian), so I'd rather not remove this check for 255. One downside of the pm-utils on_ac_power is, that it relies on hal.

Re: [Pm-utils] [patch commit] [011] POSIXification of pm-utils

2008-01-27 Thread Michael Biebl
2008/1/27, Victor Lowther [EMAIL PROTECTED]: Use file globbing instead of trying to parse the output of ls, change default governor from userspace to performance because performance is the compiled-in default for just about everything that uses cpufreq. + grep -q $GOVERNOR

Re: [Pm-utils] [Patch] TuxOnIce pm/functions patch draft.

2008-01-27 Thread Michael Biebl
2008/1/28, Victor Lowther [EMAIL PROTECTED]: On Jan 27, 2008 8:34 PM, Nigel Cunningham [EMAIL PROTECTED] wrote: do_hibernate() { if [ -d /sys/power/tuxonice ]; then do_tuxonice_hibernate else echo -n ${HIBERNATE_MODE} /sys/power/disk

Re: [Pm-utils] [patch commit] [004] POSIXification of pm-utils

2008-01-27 Thread Michael Biebl
2008/1/27, Victor Lowther [EMAIL PROTECTED]: Modified the main suspend/resume function to use the new locking infrastructure. This patch got rid of one usage of the usleep function. usleep is redhat only ttbomk, so it's safer to simply use sleep. This patch replaces the remainig usleep in

Re: [Pm-utils] [Patch] TuxOnIce pm/functions patch draft.

2008-01-27 Thread Michael Biebl
2008/1/28, Nigel Cunningham [EMAIL PROTECTED]: Michael Biebl wrote: 2008/1/28, Victor Lowther [EMAIL PROTECTED]: I'd say, we should add additional functions hibernate_method() and suspend_method() and two config variables HIBERNATE_METHOD and SUSPEND_METHOD. That sounds good to me. I

Re: [Pm-utils] [patch commit] [012] POSIXification of pm-utils

2008-01-28 Thread Michael Biebl
is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? From 6b58f4f7b2c84d857438c15dddb95c9b34103645 Mon Sep 17 00:00:00 2001 From: Michael Biebl [EMAIL PROTECTED] Date: Mon, 28 Jan 2008 21:52:08 +0100 Subject: [PATCH] Remove even more outdated documentation

Re: [Pm-utils] [patch commit] [000] POSIXification of pm-utils

2008-01-28 Thread Michael Biebl
2008/1/29, Till Maas [EMAIL PROTECTED]: Hiyas, here is an updated patch that will work with the new module handling. MODULEDIR=/Var/run/pm-utils/modules There is a typo: Var And spin_lock still seems to be incorrect. It should be something like this imho: spin_lock() { # $1 =

[Pm-utils] [PATCH] Don't duplicate the functionality of pm-is-supported in pm-action

2008-01-28 Thread Michael Biebl
are pointed away from Earth? From 70a4823d958a645cb37f1f226d0cf99bdbb6cb2d Mon Sep 17 00:00:00 2001 From: Michael Biebl [EMAIL PROTECTED] Date: Tue, 29 Jan 2008 00:13:59 +0100 Subject: [PATCH] Don't duplicate the functionality of pm-is-supported in pm-action Instead of duplicating the checks in pm-action

Re: [Pm-utils] [patch review request] Remove hardcoded /usr/lib/pm-utils/functions dependence

2008-01-30 Thread Michael Biebl
2008/1/30, Victor Lowther [EMAIL PROTECTED]: The attached patch removes our depencence on a hardcoded path to pm/functions. It modifies Makefile.am in the src and pm/sleep.d directories to have make install rewrite the installed scripts to source the final installation location of

[Pm-utils] results after POSIXification

2008-01-30 Thread Michael Biebl
Hi, after Victors extensive patches to make pm-utils posix shell compliant, I ran checkbashims on the resulting scripts. Here are the results: possible bashism in 00logging line 8 (echo -e): echo -e Kernel version: `/bin/uname -a`\n possible bashism in 00logging line 9 (echo -e):

Re: [Pm-utils] POSIXification of pm-utils

2008-01-30 Thread Michael Biebl
2008/1/30, Stefan Seyfried [EMAIL PROTECTED]: On Thu, Jan 17, 2008 at 10:10:23PM -0600, Victor Lowther wrote: The attached patch (against cvs head) makes all the scripting in pm-utils POSIX compliant. This patch has been tested on a basic I still think this is unnecessary (if not stupid).

Re: [Pm-utils] [patch commit] [015] POSIXification of pm-utils

2008-01-30 Thread Michael Biebl
2008/1/30, Stefan Seyfried [EMAIL PROTECTED]: On Mon, Jan 28, 2008 at 07:59:49PM +, Richard Hughes wrote: On Sun, 2008-01-27 at 14:57 -0600, Victor Lowther wrote: All scripts are now POSIX compliant, change shebang lines to have them run under /bin/sh instead of /bin/bash. Also take

Re: [Pm-utils] error in pm-utils under gentoo

2008-01-30 Thread Michael Biebl
2008/1/30, Till Maas [EMAIL PROTECTED]: On Wed January 30 2008, Victor Lowther wrote: 01grub can disappear (if anyone complains, tell them that what they are doing should be handled in an initrd). How can this be done? The way I understand the code, it tries to make sure that after an

Re: [Pm-utils] [patch review request] Remove hardcoded /usr/lib/pm-utils/functions dependence

2008-01-30 Thread Michael Biebl
2008/1/31, Victor Lowther [EMAIL PROTECTED]: Try 2 -- this time with real automake support. Sorry for the size of the patch -- lots of file renames, doncha know. The real changes are in pm/sleep.d/Makefile.am and src/Makefile.am Also sorry that the changes are fugly -- my small amount of

Re: [Pm-utils] [patch review request] Remove hardcoded /usr/lib/pm-utils/functions dependence

2008-01-30 Thread Michael Biebl
2008/1/31, Michael Biebl [EMAIL PROTECTED]: 2008/1/31, Victor Lowther [EMAIL PROTECTED]: Try 2 -- this time with real automake support. Sorry for the size of the patch -- lots of file renames, doncha know. The real changes are in pm/sleep.d/Makefile.am and src/Makefile.am Also sorry

Re: [Pm-utils] pm-utls version

2008-02-11 Thread Michael Biebl
2008/2/11, Victor Lowther [EMAIL PROTECTED]: On Mon, Feb 11, 2008 at 11:03:41PM +0100, Michael Biebl wrote: 2008/2/11, Richard Hughes [EMAIL PROTECTED]: Okay, I would like to make a release some time soon. The version number of pm-utils is currently 0.99.4 I feel we've done so much

Re: [Pm-utils] pm-utls version

2008-02-11 Thread Michael Biebl
2008/2/11, Richard Hughes [EMAIL PROTECTED]: Okay, I would like to make a release some time soon. The version number of pm-utils is currently 0.99.4 I feel we've done so much work, and changed the internals enough to declare a 1.1.0 release - i.e. still unstable, but 1.0.0. Comments? I'd

Re: [Pm-utils] pm-utls version

2008-02-11 Thread Michael Biebl
2008/2/12, Richard Hughes [EMAIL PROTECTED]: On Tue, 2008-02-12 at 00:10 +0100, Michael Biebl wrote: E.g., when s2ram is used, you shouldn't run 20video/99video. s2ram does the video posting etc itself. Are you sure that's valid? I thought the suspend quirks were all moving to hal-info

Re: [Pm-utils] pm-utls version

2008-02-11 Thread Michael Biebl
2008/2/12, Victor Lowther [EMAIL PROTECTED]: On Tue, Feb 12, 2008 at 12:10:55AM +0100, Michael Biebl wrote: 2008/2/11, Victor Lowther [EMAIL PROTECTED]: On Mon, Feb 11, 2008 at 11:03:41PM +0100, Michael Biebl wrote: 2008/2/11, Richard Hughes [EMAIL PROTECTED]: Okay, I would like

Re: [Pm-utils] [PATCH 6/7] This patch adds framebuffer console handling routines.

2008-02-13 Thread Michael Biebl
2008/2/13, Victor Lowther [EMAIL PROTECTED]: It is the only thing that we were missing from the s2ram tools. Serious question: Why don't we just use s2ram at first place instead of reimplementing the functionality? I mean, we already rely on external packages (vbetools) for the video handling

Re: [Pm-utils] [PATCH 6/7] This patch adds framebuffer console handling routines.

2008-02-13 Thread Michael Biebl
2008/2/13, Victor Lowther [EMAIL PROTECTED]: On Wed, Feb 13, 2008 at 05:05:44PM +0100, Michael Biebl wrote: 2008/2/13, Victor Lowther [EMAIL PROTECTED]: It is the only thing that we were missing from the s2ram tools. Serious question: Why don't we just use s2ram at first place instead

Re: [Pm-utils] [PATCH 6/7] This patch adds framebuffer console handling routines.

2008-02-13 Thread Michael Biebl
2008/2/13, Till Maas [EMAIL PROTECTED]: On Wed February 13 2008, Michael Biebl wrote: Serious question: Why don't we just use s2ram at first place instead of reimplementing the functionality? I mean, we already rely on Imho using s2ram (with the quirks provided by hal, and optionally

Re: [Pm-utils] [PATCH 4/4] Clean up generated files and put *.in files in the tarball

2008-02-14 Thread Michael Biebl
2008/2/14, Michael Biebl [EMAIL PROTECTED]: The current Makefile.am are not quite correct. They put the generated files into the tarball, but not the *.in files. They also don't clean up some of the generated files. This patch address that. It also simplifies the Makefile.amS a bit

[Pm-utils] [PATCH 2/4] Consistently use tabs for indentation

2008-02-14 Thread Michael Biebl
I also noticed that we use tab and space indentation inconsistently. This is a cosmetic patch with which uses tab indentation everywhere. -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? ___

Re: [Pm-utils] [PATCH 2/4] Consistently use tabs for indentation

2008-02-14 Thread Michael Biebl
2008/2/14, Michael Biebl [EMAIL PROTECTED]: I also noticed that we use tab and space indentation inconsistently. This is a cosmetic patch with which uses tab indentation everywhere. This time with patch ... -- Why is it that all of the instruments seeking intelligent life in the universe

[Pm-utils] [PATCH 1/4] Add a missing closing bracket in 99video

2008-02-14 Thread Michael Biebl
from Earth? From 7d3aed8c0a0ee38903dcffa77ad19883afbf1ad4 Mon Sep 17 00:00:00 2001 From: Michael Biebl [EMAIL PROTECTED] Date: Thu, 14 Feb 2008 16:17:09 +0100 Subject: [PATCH] Add a missing closing bracket in 99video and apply a consistend style for opening/closing brackets. --- pm/functions.in

[Pm-utils] [PATCH 3/4] Add safety checks for *_fbcon()

2008-02-14 Thread Michael Biebl
in the universe are pointed away from Earth? From 44cd3b7501d7a67602c5143e878de40efd153721 Mon Sep 17 00:00:00 2001 From: Michael Biebl [EMAIL PROTECTED] Date: Thu, 14 Feb 2008 16:26:50 +0100 Subject: [PATCH] Add safety checks for *_fbcon() --- pm/sleep.d/99video |2 ++ 1 files changed, 2

[Pm-utils] [PATCH] Fix inverse file owner check in init_logfile()

2008-02-14 Thread Michael Biebl
Sep 17 00:00:00 2001 From: Michael Biebl [EMAIL PROTECTED] Date: Thu, 14 Feb 2008 17:17:33 +0100 Subject: [PATCH] Fix inverse file owner check in init_logfile() --- pm/functions.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/pm/functions.in b/pm/functions.in index

Re: [Pm-utils] [PATCH 4/4] Clean up generated files and put *.in files in the tarball

2008-02-14 Thread Michael Biebl
2008/2/14, Dan Nicholson [EMAIL PROTECTED]: On Thu, Feb 14, 2008 at 8:04 AM, Michael Biebl [EMAIL PROTECTED] wrote: The current Makefile.am are not quite correct. They put the generated files into the tarball, but not the *.in files. They also don't clean up some of the generated files

Re: [Pm-utils] [PATCH 4/4] Clean up generated files and put *.in files in the tarball

2008-02-14 Thread Michael Biebl
2008/2/14, Dan Nicholson [EMAIL PROTECTED]: On Thu, Feb 14, 2008 at 9:41 AM, Michael Biebl [EMAIL PROTECTED] wrote: I meant separately: bin_SCRIPTS = pm-is-supported dist_bin_SCRIPS = on_ac_power and drop on_ac_power from EXTRA_DIST. Not a big deal, but I'm not a big fan of stuffing

Re: [Pm-utils] [PATCH 01/17] Our on_ac_power script never returns 255.

2008-02-14 Thread Michael Biebl
2008/2/15, Victor Lowther [EMAIL PROTECTED]: This patch series is strictly for cleanups, mainly getting rid on unneeded calls to exit and return. Our on_ac_power never returns 255, so don't bother mentioning it. I wouldn't remove the documentation Instead I'd return 255 in on_ac_power if

Re: [Pm-utils] [PATCH 02/17] Spacing changes in default config file.

2008-02-15 Thread Michael Biebl
2008/2/15, Victor Lowther [EMAIL PROTECTED]: --- pm/defaults |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/pm/defaults b/pm/defaults index d5b6447..6cd7b77 100644 --- a/pm/defaults +++ b/pm/defaults @@ -1,9 +1,6 @@ -

Re: [Pm-utils] [PATCH 07/17] Added an additional check for NetworkManager.

2008-02-15 Thread Michael Biebl
2008/2/15, Victor Lowther [EMAIL PROTECTED]: -command_exists dbus-send || exit 1 +command_exists dbus-send command_exists NetworkManager || exit I would prefer command_exists dbus-send || exit 1 command_exists NetworkManager || exit 1 Is easier to read. Michael -- Why is it that all of

Re: [Pm-utils] [PATCH 07/17] Added an additional check for NetworkManager, removed redundant exit call.

2008-02-15 Thread Michael Biebl
2008/2/15, Dan Nicholson [EMAIL PROTECTED]: On Mon, Feb 11, 2008 at 1:50 PM, Victor Lowther [EMAIL PROTECTED] wrote: --- pm/sleep.d/10NetworkManager |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/pm/sleep.d/10NetworkManager

Re: [Pm-utils] [PATCH 14/17] Remove redundant exit call from 95led

2008-02-15 Thread Michael Biebl
2008/2/15, Victor Lowther [EMAIL PROTECTED]: On Fri, Feb 15, 2008 at 09:07:19AM +0100, Michael Biebl wrote: 2008/2/15, Victor Lowther [EMAIL PROTECTED]: -[ -f /proc/acpi/ibm/led ] || exit 1 I like explicitly returning 1, because you immediately see, that we return 1

Re: [Pm-utils] [PATCH 14/17] Remove redundant exit call from 95led

2008-02-16 Thread Michael Biebl
2008/2/16, Michael Biebl [EMAIL PROTECTED]: 2008/2/16, Victor Lowther [EMAIL PROTECTED]: On Fri, Feb 15, 2008 at 09:07:19AM +0100, Michael Biebl wrote: 2008/2/15, Victor Lowther [EMAIL PROTECTED]: -[ -f /proc/acpi/ibm/led ] || exit 1 I like explicitly returning 1, because

Re: [Pm-utils] [PATCH 14/17] Remove redundant exit call from 95led

2008-02-16 Thread Michael Biebl
2008/2/16, Victor Lowther [EMAIL PROTECTED]: Reserving an exit code for not applicable or skipped woud be fine, but all those || exit 1 and the final exit 0 are redundant. Not quite. Using || exit 1 normalizes the return code in case of an error. Take 20video as an example. Running vbetool

Re: [Pm-utils] [PATCH 14/17] Remove redundant exit call from 95led

2008-02-16 Thread Michael Biebl
2008/2/16, Victor Lowther [EMAIL PROTECTED]: On Sat, Feb 16, 2008 at 07:08:27PM +0100, Michael Biebl wrote: 2008/2/16, Victor Lowther [EMAIL PROTECTED]: Reserving an exit code for not applicable or skipped woud be fine, but all those || exit 1 and the final exit 0 are redundant

Re: [Pm-utils] [PATCH RFC] Merge 20video and 99video

2008-02-27 Thread Michael Biebl
2008/2/17, Victor Lowther [EMAIL PROTECTED]: After examining the source to s2ram and seeing how it does the video quirk handling, I cannot see why 20video an 99video are seperate hooks. This patch aims to rectify that. It does the following things: * Merge the functionality of 20video and

Re: [Pm-utils] [PATCH 6/6] Modified acpi_flag setting to use arithmetic expansion.

2008-02-27 Thread Michael Biebl
2008/2/28, Victor Lowther [EMAIL PROTECTED]: This gets rid of an ugly if statement and makes the code more legible. --- pm/sleep.d/99video | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/pm/sleep.d/99video b/pm/sleep.d/99video index

Re: [Pm-utils] [PATCH 2/6] Added support in the video hook for DISPLAY_QUIRK_NONE.

2008-02-27 Thread Michael Biebl
2008/2/28, Victor Lowther [EMAIL PROTECTED]: When it is set to true, avoid quirk handling by exiting immediatly. --- pm/sleep.d/99video |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/pm/sleep.d/99video b/pm/sleep.d/99video index d46fbfe..92e13f7 100755 ---

Re: [Pm-utils] [PATCH 1/5] Add help function to 99video.

2008-03-03 Thread Michael Biebl
2008/3/2, Victor Lowther [EMAIL PROTECTED]: On Sat, Mar 01, 2008 at 11:14:48AM -0600, Victor Lowther wrote: This patch series applies on top of my most recent video hook merge patch series. It seems to be the best way to free up pm-utils from having to act as the option parser for the

Re: [Pm-utils] [PATCH 3/5] Moved video-specific option processing to 99video.

2008-03-06 Thread Michael Biebl
One downside of this might be, that other hooks/sleep_modules are interested in the quirk information. So they'd have to reparse the command line arguments. Actually, I was intending to just do that: Do the video quirk processing in uswsup. Imo it makes no sense to use vbetools when s2ram is

Re: [Pm-utils] [PATCH 1/1] Do not track the man pages.

2008-03-07 Thread Michael Biebl
2008/3/6, Victor Lowther [EMAIL PROTECTED]: They are generated from the SGML files, so we do not need to track them in git. Ack Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?

Re: [Pm-utils] [PATCH 1/1] Do not track the man pages.

2008-03-07 Thread Michael Biebl
2008/3/7, Michael Biebl [EMAIL PROTECTED]: 2008/3/6, Victor Lowther [EMAIL PROTECTED]: They are generated from the SGML files, so we do not need to track them in git. Ack Shouldn't we add a configure check for docbook2man then? On the other hand, as we distribute the man pages

Re: [Pm-utils] [PATCH 1/5] Add help function to 99video.

2008-03-07 Thread Michael Biebl
2008/3/7, Michael Biebl [EMAIL PROTECTED]: 2008/3/7, Victor Lowther [EMAIL PROTECTED]: On Sat, Mar 01, 2008 at 07:15:03PM -0600, Victor Lowther wrote: On Sat, Mar 01, 2008 at 11:14:48AM -0600, Victor Lowther wrote: This patch series applies on top of my most recent video hook merge

Re: [Pm-utils] [PATCH 1/5] Add help function to 99video.

2008-03-07 Thread Michael Biebl
2008/3/7, Michael Biebl [EMAIL PROTECTED]: Looks like the quirk options parsing in 99video is currently broken. I pushed the fix for that. I also noticed another problem with moving the option parsing into the hooks (and modules): We can't tell anymore, if one of the provided command

[Pm-utils] EUID bash only feature?

2008-03-07 Thread Michael Biebl
Hi, it seems that $EUID is a bash only feature. The attached patch uses $(uid -u) instead. Please review. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? diff --git a/src/pm-action.in b/src/pm-action.in index

Re: [Pm-utils] EUID bash only feature?

2008-03-07 Thread Michael Biebl
2008/3/8, Victor Lowther [EMAIL PROTECTED]: On Sat, Mar 08, 2008 at 02:49:31AM +0100, Michael Biebl wrote: Hi, it seems that $EUID is a bash only feature. The attached patch uses $(uid -u) instead. Well, I do not see a command named uid. You obviously meant id. Yeah, typo

Re: [Pm-utils] [PATCH 1/1] Do not track the man pages.

2008-03-08 Thread Michael Biebl
2008/3/8, Dan Nicholson [EMAIL PROTECTED]: On Fri, Mar 7, 2008 at 2:20 AM, Michael Biebl [EMAIL PROTECTED] wrote: Shouldn't we add a configure check for docbook2man then? On the other hand, as we distribute the man pages in the dist tarball, docbook2man is not strictly necessary

Re: [Pm-utils] Fwd: [PATCH 1/1] Generate ChangeLog on demand.

2008-03-09 Thread Michael Biebl
2008/3/9, Victor Lowther [EMAIL PROTECTED]: On Sun, Mar 09, 2008 at 03:37:23PM +0100, Michael Biebl wrote: Agreed, the merge conflicts are definitely a problem. The original patch series explicitly discarded merge-related ChangeLog entries -- I removed that option when dbn expressed

Re: [Pm-utils] [RFC PATCH 2/3] Split pm-functions.in out from functions.in

2008-03-09 Thread Michael Biebl
2008/3/6, Victor Lowther [EMAIL PROTECTED]: pm-functions.in contains the functionality that should only be used by the pm-utils frontends (pm-action, pm-is-supported, and pm-powersave). functions.in contains code that is shared between the hooks and the pm-utils frontends.

Re: [Pm-utils] [RFC PATCH 2/3] Split pm-functions.in out from functions.in

2008-03-10 Thread Michael Biebl
2008/3/11, Victor Lowther [EMAIL PROTECTED]: On Mon, Mar 10, 2008 at 04:08:49AM +0100, Michael Biebl wrote: 2008/3/6, Victor Lowther [EMAIL PROTECTED]: pm-functions.in contains the functionality that should only be used by the pm-utils frontends (pm-action, pm-is-supported, and pm

Re: [Pm-utils] Release?

2008-03-15 Thread Michael Biebl
2008/3/15, Michael Biebl [EMAIL PROTECTED]: 1.) pm/module.d/uswsusp: Now that it disables the 99video hook, it has to parse the quirks itself and pass it to s2ram in do_suspend and s2both in do_suspend_hybrid This also means, that help() in pm-action.in should also take this into account

Re: [Pm-utils] Release?

2008-03-15 Thread Michael Biebl
2008/3/15, Victor Lowther [EMAIL PROTECTED]: I think it is time to do a release. I have been running the latest version of pm-utils on my laptop for a little over a week, and I have had exactly 0 suspend/resume failures related to pm-utils in that time. Found a bug in the disable_hook

Re: [Pm-utils] Release?

2008-03-15 Thread Michael Biebl
2008/3/15, Victor Lowther [EMAIL PROTECTED]: On Sat, 2008-03-15 at 21:07 +0100, Michael Biebl wrote: 2008/3/15, Michael Biebl [EMAIL PROTECTED]: 1.) pm/module.d/uswsusp: Now that it disables the 99video hook, it has to parse the quirks itself and pass it to s2ram

Re: [Pm-utils] Release?

2008-03-15 Thread Michael Biebl
2008/3/15, Michael Biebl [EMAIL PROTECTED]: 2008/3/15, Victor Lowther [EMAIL PROTECTED]: On Sat, 2008-03-15 at 21:07 +0100, Michael Biebl wrote: 2008/3/15, Michael Biebl [EMAIL PROTECTED]: 1.) pm/module.d/uswsusp: Now that it disables the 99video hook, it has to parse

Re: [Pm-utils] Development flow and fd.o git repo

2008-03-16 Thread Michael Biebl
2008/3/16, Victor Lowther [EMAIL PROTECTED]: I noticed in the latest pull frrom the fd.o git repo that there is a new pmu branch. I presume that this is mbiebl's pmu updates. Sorry, that was actually a mistake on my part. I wanted to push the pmu fixes, and mistakenly pushed

Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

2008-03-16 Thread Michael Biebl
2008/3/16, Victor Lowther [EMAIL PROTECTED]: On Sun, 2008-03-16 at 18:50 +0100, Michael Biebl wrote: Hi, attached is the patch, which parses the video quirks in the uswsusp sleep module and passes this options to s2ram/s2both. In the get_quirks code, ACPI_SLEEP should

Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

2008-03-16 Thread Michael Biebl
2008/3/17, Victor Lowther [EMAIL PROTECTED]: After a bit more review, your patch was not honoring QUIRK_NONE. I readded support for it and pushed changes upstream. Good point. You should have added it after [ $ACPI_SLEEP -ne 0 ] OPTS=$OPTS --acpi_sleep $ACPI_SLEEP though, to make absolutely

Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

2008-03-16 Thread Michael Biebl
2008/3/17, Michael Biebl [EMAIL PROTECTED]: I actually think, that the QUIRK_NONE tests in 99video could/should also be removed. As said, combinations like --quirk-none --quirk-vbe-mode are simply invalid. Or put in other words: The correct behaviour would be to abort the suspend

Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

2008-03-16 Thread Michael Biebl
2008/3/17, Victor Lowther [EMAIL PROTECTED]: On Mon, 2008-03-17 at 03:11 +0100, Michael Biebl wrote: 2008/3/17, Michael Biebl [EMAIL PROTECTED]: 2008/3/17, Victor Lowther [EMAIL PROTECTED]: On Mon, 2008-03-17 at 01:55 +0100, Michael Biebl wrote: 2008/3/17, Victor Lowther

Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

2008-03-16 Thread Michael Biebl
2008/3/17, Victor Lowther [EMAIL PROTECTED]: On Mon, 2008-03-17 at 03:26 +0100, Michael Biebl wrote: 2008/3/17, Michael Biebl [EMAIL PROTECTED]: I actually think, that the QUIRK_NONE tests in 99video could/should also be removed. As said, combinations like --quirk

Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

2008-03-16 Thread Michael Biebl
2008/3/17, Victor Lowther [EMAIL PROTECTED]: On Mon, 2008-03-17 at 04:00 +0100, Michael Biebl wrote: I think, the correct way is to fix the hal fdi file for the given laptop. That's as easy as editing a file in /etc/pm and well documented [1]. I'm sure, Richard will agree. To you

Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

2008-03-17 Thread Michael Biebl
2008/3/18, Victor Lowther [EMAIL PROTECTED]: On Mon, 2008-03-17 at 19:15 -0500, Victor Lowther wrote: I do not want to get rid of using --quirk-none to skip video quirks for now. After patching pm-utils to capture the parameters passed to pm-action and friends, something odd is

[Pm-utils] [RFC] Writing ${HIBERNATE_MODE} unconditionally to /sys/power/disk

2008-03-18 Thread Michael Biebl
Hi, please see http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=450515 for the background. Apparently, writing platform unconditionally to /sys/power/disk can lead to suspend failures, if this method is not supported. If I read the kernel documentation correctly [1], firmware or platform can be

Re: [Pm-utils] [RFC] Writing ${HIBERNATE_MODE} unconditionally to /sys/power/disk

2008-03-18 Thread Michael Biebl
2008/3/18, Victor Lowther [EMAIL PROTECTED]: Or only, if HIBERNATE_MODE is firmware or platform? And is this the correct way to determine if firmware or platform is supported. How about just defaulting to shutdown? True, we might disable the suspend LED, and wake-on-lid probably

Re: [Pm-utils] Release?

2008-03-31 Thread Michael Biebl
2008/3/27, Victor Lowther [EMAIL PROTECTED]: Well, it has been a few days, and no-one has raised any objections. Richard, would you be alright with creating a new release branch and tagging it as a release candidate this Sunday if there are no objections? What date do we target the

Re: [Pm-utils] Release?

2008-03-31 Thread Michael Biebl
2008/4/1, Victor Lowther [EMAIL PROTECTED]: On Mon, 2008-03-31 at 09:13 +0200, Michael Biebl wrote: 2008/3/27, Victor Lowther [EMAIL PROTECTED]: Well, it has been a few days, and no-one has raised any objections. Richard, would you be alright with creating a new release branch

Re: [Pm-utils] wiki spam

2008-04-03 Thread Michael Biebl
2008/4/3, Nigel Cunningham [EMAIL PROTECTED]: On Wed, 2008-04-02 at 20:25 -0500, Victor Lowther wrote: You said it was Moin based, didn't you? I had similar issues with the TuxOnice wiki until I: * made a group that could edit pages, * added all the people with accounts that had validly

Re: [Pm-utils] [PATCH] parse video quirks in uswsusp sleep module

2008-04-28 Thread Michael Biebl
2008/4/28 Stefan Seyfried [EMAIL PROTECTED]: Michael Biebl wrote: I was also wondering, why reset_brighness in 99video isn't using vbetool's (get,set)brightness method. Do you have a machine where that works? I have not seen one for quite some time. They all seem to implement the ACPI

Re: [Pm-utils] pm-utils-1.1.0

2008-04-28 Thread Michael Biebl
2008/4/28 Stefan Seyfried [EMAIL PROTECTED]: Andrey Borzenkov wrote: On Monday 31 March 2008, Richard Hughes wrote: - The HOOK_BLACKLIST environment variable allows you to disable a hook without having to modify it. frankly, this belongs to base functionality, not debug. One

Re: [Pm-utils] [PATCH 4/6] Do not overwrite the log, just append to it.

2008-04-29 Thread Michael Biebl
2008/4/29 Stefan Seyfried [EMAIL PROTECTED]: This is a lame excuse IMVHO, especially if i take a look at what dubious code fixes have gone into pm-utils lately, this is much more security relevant than most of those other improvements ;-) Hi Stefan, I am really surprised, why you are

Re: [Pm-utils] symlinks not relative

2008-04-30 Thread Michael Biebl
2008/5/1 Till Maas [EMAIL PROTECTED]: Hiyas, currently the symlinks that are created in pm-utils (pm-suspend - pm-action, ...) are not relative,. Is it easily possible to change these to # ls -al /usr/sbin/pm-* lrwxrwxrwx 1 root root 29 24. Apr 16:03 /usr/sbin/pm-hibernate -

Re: [Pm-utils] symlinks not relative

2008-04-30 Thread Michael Biebl
2008/5/1 Michael Biebl [EMAIL PROTECTED]: 2008/5/1 Till Maas [EMAIL PROTECTED]: Hiyas, currently the symlinks that are created in pm-utils (pm-suspend - pm-action, ...) are not relative,. Is it easily possible to change these to # ls -al /usr/sbin/pm-* lrwxrwxrwx 1 root root

Re: [Pm-utils] Making cron run after resume?

2008-05-08 Thread Michael Biebl
2008/5/8 Richard Hughes [EMAIL PROTECTED]: In reference to this: https://bugzilla.redhat.com/show_bug.cgi?id=445603 Should we be kicking cron a resume time to do the stuff we should have done whilst suspended? See also http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=469135 (a user request

Re: [Pm-utils] more man pages!

2008-05-13 Thread Michael Biebl
2008/5/13 Victor Lowther [EMAIL PROTECTED]: As a test, I have converted the xml manpages back to SGML and done a bit more cleanup on them to test how well the manpages work with the current SGML based build process -- the results of that conversion process are @

Re: [Pm-utils] more man pages!

2008-05-20 Thread Michael Biebl
2008/5/14 Michael Biebl [EMAIL PROTECTED]: 2008/5/13 Victor Lowther [EMAIL PROTECTED]: As a test, I have converted the xml manpages back to SGML and done a bit more cleanup on them to test how well the manpages work with the current SGML based build process -- the results

Re: [Pm-utils] pm-utils 1.1.2 released

2008-05-26 Thread Michael Biebl
2008/5/26 Victor Lowther [EMAIL PROTECTED]: * If you are running pm-utils on a system that has a video card with a driver that is smart enough to handle quirks by itself, pm-utils will no longer attempt to run its video quirks. Thanks, Matthew Garrett. Unfortunately, the changes from the

Re: [Pm-utils] pm-utils 1.1.2 released

2008-05-27 Thread Michael Biebl
2008/5/27 Michael Biebl [EMAIL PROTECTED]: 2008/5/27 Victor Lowther [EMAIL PROTECTED]: On Tue, 2008-05-27 at 01:53 +0200, Michael Biebl wrote: Given the severity of this breakage, I'd say we have to release a fixed version asap. Indeed. Fix comitted to the repo, and I will release 1.1.2.1

Re: [Pm-utils] pm-utils 1.1.2.1 released

2008-05-28 Thread Michael Biebl
2008/5/28 Victor Lowther [EMAIL PROTECTED]: Hot on the heels of 1.1.2, 1.1.2.1 has been released. * Fix a bug noticed by Michael Biebl that prevents pm-utils from saving commandline parameters correctly. Bad news, the commandline parameter handling is still broken :-/ It worked

Re: [Pm-utils] [PATCH 1/3] Automagically grab quirks from HAL

2008-09-10 Thread Michael Biebl
2008/9/10 Victor Lowther [EMAIL PROTECTED]: Add functionality to grab quirks from HAL if we were not invoked by HAL. To use this functionality, run pm(suspend|hibernate|suspend-hybrid) with --auto-quirks. --- pm/sleep.d/00auto-quirk | 26 ++

[Pm-utils] Problems with 98smart-kernel-video and intel graphics chipsets

2008-09-19 Thread Michael Biebl
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=499442 ---BeginMessage--- On 2008-09-18 12:29 PDT, Michael Biebl writes: Michael Which graphics driver to you use, which version? It's the i915 driver from the 2.6.26-1-686 kernel. If you're referring to the X driver, it's intel driver

Re: [Pm-utils] pm-utils 1.2.1 and 1.1.2.5 released

2008-10-05 Thread Michael Biebl
2008/10/5 Victor Lowther [EMAIL PROTECTED]: On Sun, 2008-10-05 at 12:45 +0200, Michael Biebl wrote: 2008/10/4 Victor Lowther [EMAIL PROTECTED]: I'd expect that --store-quirks-as-fdi will *only* write the fdi file and stop afterwards. No, it only writes the file after a sucessful sleep/wake

Re: [Pm-utils] pm-utils 1.2.1 and 1.1.2.5 released

2008-10-06 Thread Michael Biebl
2008/10/6 Stefan Seyfried [EMAIL PROTECTED]: Michael Biebl wrote: 2008/10/4 Victor Lowther [EMAIL PROTECTED]: I also wonder, if we shouldn't always reset acpi_flags to 0. IMHO yes, you should. s2ram is doing this for quite some time now after I was chasing some strange bug reports

Re: [Pm-utils] pm-suspend very odd behaviour

2008-10-14 Thread Michael Biebl
2008/10/14 Nunzio Losacco [EMAIL PROTECTED]: Hi there, I'm struggling with the suspend issues on my ASUS M6800Ne with Fedora 9. My laptop does suspend or hibernate correctly but it doesn't resume. It seems to wake up some way but the panel backlight remains off. Having a look at Richard

Re: [Pm-utils] RFC - PATCH to functions.in to support Slackware init

2008-10-30 Thread Michael Biebl
2008/10/30 Victor Lowther [EMAIL PROTECTED]: On Wed, 2008-10-29 at 23:15 -0500, Robby Workman wrote: On Wed, 29 Oct 2008 16:44:39 -0500 Victor Lowther [EMAIL PROTECTED] wrote: On Oct 29, 2008, at 4:02 PM, Robby Workman [EMAIL PROTECTED] wrote: I like the idea, I think. I almost prefer to

Re: [Pm-utils] Cutting down on unnecessary hooks

2008-11-26 Thread Michael Biebl
2008/11/26 Matthew Garrett [EMAIL PROTECTED]: On Wed, Nov 26, 2008 at 02:21:36PM -0800, Dan Nicholson wrote: It's maybe useful to set governor from e.g. powersave to performance to speed up the suspend/resume. Especially suspend2disk ... Anyone who's set their governor to powersave

Re: [Pm-utils] Cutting down on unnecessary hooks

2008-11-26 Thread Michael Biebl
2008/11/27 Michael Biebl [EMAIL PROTECTED]: 2008/11/26 Matthew Garrett [EMAIL PROTECTED]: On Wed, Nov 26, 2008 at 02:21:36PM -0800, Dan Nicholson wrote: It's maybe useful to set governor from e.g. powersave to performance to speed up the suspend/resume. Especially suspend2disk

[Pm-utils] [PATCH 1/8] pm-utils 1.2.3 proposed patches

2008-11-29 Thread Michael Biebl
Reset acpi_video_flags before suspend. If no --quirk-s3-* option is passed to pm-suspend, set acpi_video_flags to 0. This allows to reliably test different set of quirks and clears any flags that were set via the kernel boot option. We deliberately ignore the kernel acpi_sleep option, quirks

Re: [Pm-utils] [PATCH 1/8] pm-utils 1.2.3 proposed patches

2008-11-29 Thread Michael Biebl
2008/11/29 Matthew Garrett [EMAIL PROTECTED]: On Sat, Nov 29, 2008 at 06:17:20PM +0100, Michael Biebl wrote: 2008/11/29 Matthew Garrett [EMAIL PROTECTED]: The acpi_sleep parameter is a documented kernel interface and many people currently rely upon it. It's not reasonable to override

Re: [Pm-utils] [PATCH 1/8] pm-utils 1.2.3 proposed patches

2008-11-29 Thread Michael Biebl
2008/11/29 Matthew Garrett [EMAIL PROTECTED]: On Sat, Nov 29, 2008 at 08:38:30PM +0100, Michael Biebl wrote: Oh, and we obviously also want, that users send us their fdi files with the (correct) quirks for their plattform, so everyone benefits. Mostly we want to spend the time and effort

Re: [Pm-utils] Hooks Tutorial

2009-02-07 Thread Michael Biebl
2009/2/7 Pacho Ramos pa...@condmat1.ciencias.uniovi.es: El sáb, 07-02-2009 a las 12:29 -0600, alkos333 escribió: I need to write two suspend hooks: one for xlockscreen and the other for gkrellm. I'd like xlockscreen to lock the screen whenever I suspend/hibernate and I want gkrellm to

Re: [Pm-utils] CFT: pm-utils-1.2.5

2009-04-03 Thread Michael Biebl
2009/4/4 Michael Biebl mbi...@gmail.com: 2009/4/3 Victor Lowther victor.lowt...@gmail.com: pm-utils 1.2.5-rc1 is available for testing.  The major change between it and pm-utils-1.2.4 is support for kernel mode setting video drivers. If your kernel is using KMS, pm-utils will refuse to apply

[Pm-utils] unify boolean config variables

2009-04-29 Thread Michael Biebl
Hi, currently our man pages and config variables are not very consistent with regard to boolean variables. The majority uses true/false, there is HIBERNATE_RESUME_POST_VIDEO which is yes/no and NEED_CLOCK_SYNC, where anything else then is treated as true (see 90clock). I'd like to use

Re: [Pm-utils] unify boolean config variables

2009-04-29 Thread Michael Biebl
2009/4/30 Michael Biebl mbi...@gmail.com: Hi, currently our man pages and config variables are not very consistent with regard to boolean variables. The majority uses true/false, there is HIBERNATE_RESUME_POST_VIDEO which is yes/no and NEED_CLOCK_SYNC, where anything else then is treated

Re: [Pm-utils] unify boolean config variables

2009-06-13 Thread Michael Biebl
Any news on this? 2009/5/4 Victor Lowther victor.lowt...@gmail.com: On Thu, 2009-04-30 at 06:59 +0200, Michael Biebl wrote: Hi, currently our man pages and config variables are not very consistent with regard to boolean variables. The majority uses true/false

  1   2   >