Re: HSLF TextProp refactoring

2007-01-16 Thread Yegor Kozlov
Nick, I'm glad you started this thread. We learned a lot about all this style stuff since the first version of StyleTextPropAtom and with this knowledge in mind the things can be greatly improved. Let's not rush with it. I already have experimental code. As soon as it gets a stable shape I

Re: HSLF TextProp refactoring

2007-01-16 Thread Nick Burch
On Tue, 16 Jan 2007, Yegor Kozlov wrote: Let's not rush with it. I already have experimental code. As soon as it gets a stable shape I will share it and we will discuss. Sounds good (a) The logic in TextPropCollection.addWithName is wrong. It relies on the ordering of properties by mask

HSLF TextProp refactoring

2007-01-15 Thread Nick Burch
Hi All Just a heads-up that I've done the easy bit of the HSLF TextProp refactoring. I've moved the definitions for TextPropCollection and the TextProps into model.textproperties. All the tests still pass. Next up, we should probably shift some of the logic for dealing with TextProps out