AS> if we have testcases, we AS> should be confident to commit... that's the point of testcases, no?
That is my concern. There is a testcase for DrawingGroupRecord but if I apply my fix it fails. I suspect that the test logic is wrong. It checks serialization against artificial data, not against a real xls file. I'd like to clarify it. Regards, Yegor AS> Yeah, Glen is one of the oldest commiters on POI. I imagine, real life would AS> be taking more of his time these days... AS> I'd wait for him to reply a day or two, otherwise, if we have testcases, we AS> should be confident to commit... that's the point of testcases, no? AS> Regards AS> - AS> Avik AS> On Tuesday 27 Mar 2007 7:38:19 pm Yegor Kozlov wrote: >> He doesn't seem to be posting in poi-user and poi-dev for quite a long >> time. >> >> He is the author of org.apache.poi.hssf.record.DrawingGroupRecord >> and I think I found a bug in it. Before applying the fix I would like >> to make sure it is correct and won't break anything. >> >> The bug is in DrawingGroupRecord.writeData. >> If the record is over max record size then continue record is not >> written right after the first portion. Instead it writes two chunks with >> sid=DrawingGroupRecord.sid and continue records only after it. >> >> In other words, DrawingGroupRecord serializes data as follows: >> >> [DrawingGroupRecord] [DrawingGroupRecord] [continued]... >> >> while it should be >> >> [DrawingGroupRecord] [continued] [continued] ... >> >> >> I found it when fixing Bug 28744 and have a test case which fails with >> Glen's code and works fine with my fix. >> >> Regards, >> Yegor >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> Mailing List: http://jakarta.apache.org/site/mail2.html#poi >> The Apache Jakarta POI Project: http://jakarta.apache.org/poi/ AS> --------------------------------------------------------------------- AS> To unsubscribe, e-mail: [EMAIL PROTECTED] AS> Mailing List: http://jakarta.apache.org/site/mail2.html#poi AS> The Apache Jakarta POI Project: http://jakarta.apache.org/poi/ --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] Mailing List: http://jakarta.apache.org/site/mail2.html#poi The Apache Jakarta POI Project: http://jakarta.apache.org/poi/
