Hi,

On Mon, Nov 23, 2009 at 10:22:36PM +0100, Markus Rathgeb wrote:
> This patch adds a new package names 'wpa_supplicant'.
> Official homepage of the package: http://hostap.epitest.fi/wpa_supplicant/
[...]
> +ifdef PTXCONF_WPA_SUPPLICANT_DRIVER_HOSTAP
> +  WPA_SUPPLICANT_CONFIG += "CONFIG_DRIVER_HOSTAP=y"
> +endif
[...]
> +$(STATEDIR)/wpa_supplicant.prepare: $(wpa_supplicant_prepare_deps_default)
> +     @$(call targetinfo, $@)
> +     @$(call clean, $(WPA_SUPPLICANT_DIR)/config.cache)
> +     cd $(WPA_SUPPLICANT_DIR)/$(WPA_SUPPLICANT_NAME) && \
> +       echo "CC=$(CROSS_CC)" > .config && \
> +       echo "CFLAGS += -I$(SYSROOT)/include" >> .config && \
> +       echo "CFLAGS += -I$(SYSROOT)/usr/include" >> .config && \
> +       echo "CONFIG_BACKEND=file" >> .config && \
[...]
> +       echo "LDFLAGS += -L$(SYSROOT)/lib" >> .config && \
> +       echo "LDFLAGS += -L$(SYSROOT)/usr/lib" >> .config && \
> +       for PREP_CONF in $(WPA_SUPPLICANT_CONFIG); do echo $$PREP_CONF >> 
> .config; done
> +     @$(call touch, $@)

Please take a look at rules/busybox.make. I thinks that's a better way to do 
this.
Just add config options without prompt and the correct default for the ones
that don't need to be configured. grep + sed can do the rest.

> +wpa_supplicant_targetinstall: $(STATEDIR)/wpa_supplicant.targetinstall

This is not needed anymore.

> +$(STATEDIR)/wpa_supplicant.targetinstall: 
> $(wpa_supplicant_targetinstall_deps_default)

same here.
And it's @$(call touch) and @$(call targetinfo). The latest
'ptxdist newpacket target' should generate the latest syntax.

Regards,
Michael Olbrich


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

--
ptxdist mailing list
ptxdist@pengutronix.de

Reply via email to