Re: [pulseaudio-discuss] [PATCH v2] Add configurable RTP stream name

f > } > > -pa_xfree(n); > +pa_xfree(n); /* safe for NULL */ > > pa_rtp_context_init_send(>rtp_context, fd, m->core->cookie, payload, > pa_frame_size()); > pa_sap_context_init_send(>sap_context, sap_fd, p); > -- > 2.18.0 > > _

[pulseaudio-discuss] [PATCH 5/8] raop: Fix typo

Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 24bec3e..9dc4942 100644 --- a/src/modules/raop/raop-client.c

[pulseaudio-discuss] [PATCH 8/8] core: Fix gcc-7 -Wimplicit-fallthrough= warnings by rearranging comment

'Fall through.' must appear separately Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/pulsecore/protocol-esound.c | 5 ++--- src/pulsecore/protocol-simple.c | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/pulsecore/protocol-esound.c

[pulseaudio-discuss] [PATCH 1/8] bluetooth: ofono: Fix Coverity warning

Dereference before null check Coverity ID: #1454315 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/bluetooth/backend-ofono.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/bluetooth/backend-ofono.c b/src/modules/bluetooth/b

[pulseaudio-discuss] [PATCH 3/8] bluetooth: bluez5: Fix Coverity warning

Use pa_assert_se() to check return value (pro forma) like everywhere else Coverity ID: #154313 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/bluetooth/bluez5-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/bluetooth/

[pulseaudio-discuss] [PATCH 4/8] raop: Fix gcc-7 warnings, EWOULDBLOCK

Wlogical-op] if (written < 0 && (errno == EAGAIN || errno == EWOULDBLOCK)) { ^~ Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 4 ++-- src/pulsecore/iochannel.c | 2 +- 2 files

[pulseaudio-discuss] [PATCH 6/8] core: Fix gcc-7 -Wimplicit-fallthrough= warnings

=] for (state = NULL; (key = pa_proplist_iterate(i->proplist, ));) { ^~~ pulsecore/sink-input.c:1539:9: note: here case PA_UPDATE_REPLACE: { ^~~~ Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/pulsecore/sink-input.c| 11 +++ src/

[pulseaudio-discuss] [PATCH 2/8] json-test: Fix Coverity warning

Cosmetic resource leak in test code Coverity ID: #1454314 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/tests/json-test.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/tests/json-test.c b/src/tests/json-test.c index 3e956db..0894a30

[pulseaudio-discuss] [PATCH 7/8] core: Fix typo and gcc-7 -Wimplicit-fallthrough= warnings

Correct spelling of 'through' in a comment helps to fix a warning :) also drop some unrelated comments Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/pulsecore/resampler.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/pulsecore/resam

Re: [pulseaudio-discuss] [PATCH 3/4] pactl, pacmd, cli-command: Add send-message command

("%s %s %s %s\n", argv0, _("[options]"), "send-message", > _("RECIPIENT MESSAGE MESSAGE_PARAMETERS")); > printf("%s %s %s\n",argv0, _("[options]"), "subscribe"); > printf(_("\nThe special names @DEFAULT_SINK@, @DEF

Re: [pulseaudio-discuss] Should "sink_master" arguments be renamed to "master_sink"?

because if my preferred modarg naming > scheme isn't obviously better, there's little point in changing the > naming. So, should I write a patch or not? my vote is leave as-is, little benefit and at least I have plenty of scripts loading modules in a specific way thanks,

Re: [pulseaudio-discuss] [PATCH] loopback: Calculate and track minimum possible latency

k_input->update_sink_latency_range = update_sink_latency_range_cb; > +u->sink_input->update_sink_fixed_latency = update_sink_latency_range_cb; > u->sink_input->userdata = u; > > pa_source_output_new_data_init(_output_data); > @@ -1150,9 +1338,11 @@ int pa__init(pa_module *m) { > u->source_output->may_move_to = source_output_may_move_to_cb; > u->source_output->moving = source_output_moving_cb; > u->source_output->suspend = source_output_suspend_cb; > +u->source_output->update_source_latency_range = > update_source_latency_range_cb; > +u->source_output->update_source_fixed_latency = > update_source_latency_range_cb; > u->source_output->userdata = u; > > -update_latency_boundaries(u, u->source_output->source, > u->sink_input->sink); > +update_latency_boundaries(u, u->source_output->source, > u->sink_input->sink, true); > set_sink_input_latency(u, u->sink_input->sink); > set_source_output_latency(u, u->source_output->source); > > @@ -1193,6 +1383,11 @@ int pa__init(pa_module *m) { > && (n = pa_proplist_gets(u->source_output->source->proplist, > PA_PROP_DEVICE_ICON_NAME))) > pa_proplist_sets(u->sink_input->proplist, PA_PROP_MEDIA_ICON_NAME, > n); > > +/* Setup message handler for main thread */ > +u->msg = pa_msgobject_new(loopback_msg); > +u->msg->parent.process_msg = loopback_process_msg_cb; > +u->msg->userdata = u; > + > /* The output thread is not yet running, set effective_source_latency > directly */ > update_effective_source_latency(u, u->source_output->source, NULL); > > -- > 2.10.1 > > ___ > pulseaudio-discuss mailing list > pulseaudio-discuss@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss > -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] ifdef foo

nt. > That unix sockets where the ones that exist as an inode in the > filesystem, where-as TCP sockets are bound to a network port. Is the > comment wrong or am I misunderstanding? p. -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418 ___ pu

Re: [pulseaudio-discuss] [PATCH v3] filter-apply, ladspa-sink, virtual-surround-sink: filter-apply supports ladspa-sink and virtual-surround-sink properly

il; > } > > +u->autoloaded = DEFAULT_AUTOLOADED; > +if (pa_modargs_get_value_boolean(ma, "autoloaded", >autoloaded) < 0) { > +pa_log("Failed to parse autoloaded value"); > +goto fail; > +} > + > if ((u

Re: [pulseaudio-discuss] [PATCH 0/8] more Coverity fixes and cleanups

> > Peter Meerwald-Stadler (8): > >raop: Fix potential dereference after NULL check > >raop: Fix potential NULL dereference > >raop: Log if pa_atoi() fails, latency is not used anyway > >raop: Error out on parsing server port component &g

Re: [pulseaudio-discuss] [PATCH v2 05/10] raop: Fix resource leaks

} else if (pa_safe_streq(mth, "Digest")) { > > rtrim_char(realm, '\"'); > > rtrim_char(nonce, '\"'); yes, this is addressed in a followup patch thanks, regards, p. -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH 4/8] raop: Error out on parsing server port component

don't ignore server port parsing errors as suggested by Hajime Fujita Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> Cc: Hajime Fujita <crisp.fuj...@nifty.com> --- src/modules/raop/raop-client.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-)

[pulseaudio-discuss] [PATCH 6/8] core: Document behaviour of pa_shared_remove() in case name does not exist

ignore pa_shared_remove() return value Coverity ID: #1380672 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/pulsecore/shared.c | 2 +- src/pulsecore/shared.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/shared.c b/src/pul

Re: [pulseaudio-discuss] [PATCH v2 08/10] raop: Silence unchecked return value warnings

patch implementing your suggestion; strictly, this is adding functionality to the code, so maybe better to do it in two patches anyway :) regards, p. -- Peter Meerwald-Stadler Mobile: +43 664 24 44 418 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

[pulseaudio-discuss] [PATCH 7/8] oss: Fix dead code

mode cannot be 0 Coverity ID: #1137964 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/oss/module-oss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/oss/module-oss.c b/src/modules/oss/module-oss.c index 8a5a692..5ad765d

[pulseaudio-discuss] [PATCH 5/8] core: Assert return value of pa_shared_set/_remove() in dbus-shared

it must succeed, or we are leaking memory Coverity ID: #1380674, #1380673 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/pulsecore/dbus-shared.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/dbus-shared.c b/src/pulsecore/dbus-sh

[pulseaudio-discuss] [PATCH 2/8] raop: Fix potential NULL dereference

wath may be NULL, as suggested by Hajime Fujita Coverity ID: #1398156 setting val = NULL is not needed Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> Cc: Hajime Fujita <crisp.fuj...@nifty.com> --- src/modules/raop/raop-client.c | 23 +++ 1 file

[pulseaudio-discuss] [PATCH 8/8] pulse: Explicitly ignore pa_mainloop_run() return value in thread function

Coverity ID: #1137975 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/pulse/thread-mainloop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pulse/thread-mainloop.c b/src/pulse/thread-mainloop.c index cbfc474..993b7ba 100644 --- a/src/pulse/

[pulseaudio-discuss] [PATCH 3/8] raop: Log if pa_atoi() fails, latency is not used anyway

Coverity ID: #1398152 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index e2cf04e..78f86a4 100644 ---

[pulseaudio-discuss] [PATCH 0/8] more Coverity fixes and cleanups

some more Coverity fixes and cleanups also addresses Hajime Fujita's earlier review comments Peter Meerwald-Stadler (8): raop: Fix potential dereference after NULL check raop: Fix potential NULL dereference raop: Log if pa_atoi() fails, latency is not used anyway raop: Error out

[pulseaudio-discuss] [PATCH 1/8] raop: Fix potential dereference after NULL check

Coverity ID: #1398157 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-sink.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/modules/raop/raop-sink.c b/src/modules/raop/raop-sink.c index c5ff8b9..4ca625f 100644 ---

Re: [pulseaudio-discuss] [PATCH 0/3] misc cleanups

> On 07.03.2017 16:56, Peter Meerwald-Stadler wrote: > > Peter Meerwald-Stadler (3): > >build: Use #ifdef to check for #defines > >core-util: Fix description of pa_split() > >raop: Fix check for invalid file descriptor > > > > src/m

[pulseaudio-discuss] [PATCH 0/3] misc cleanups

Peter Meerwald-Stadler (3): build: Use #ifdef to check for #defines core-util: Fix description of pa_split() raop: Fix check for invalid file descriptor src/modules/dbus/module-dbus-protocol.c | 4 ++-- src/modules/raop/raop-client.c | 30 +++--- src

[pulseaudio-discuss] [PATCH 3/3] raop: Fix check for invalid file descriptor

file descriptor 0 is valid Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 30 +++--- src/modules/raop/raop-sink.c | 2 +- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/src/modules/raop/raop-clie

[pulseaudio-discuss] [PATCH 1/3] build: Use #ifdef to check for #defines

r presence of a #define Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/dbus/module-dbus-protocol.c | 4 ++-- src/pulsecore/dbus-util.c | 4 ++-- src/pulsecore/shm.c | 2 +- src/utils/padsp.c | 6 +++--- 4

[pulseaudio-discuss] [PATCH 2/3] core-util: Fix description of pa_split()

Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/pulsecore/core-util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pulsecore/core-util.c b/src/pulsecore/core-util.c index cd1c96d..d4cfa20 100644 --- a/src/pulsecore/core-util.c +++ b/src/pul

Re: [pulseaudio-discuss] New reviewer: Georg Chini

> Georg Chini kindly offered to help with reviewing patches, and we > granted him commit rights too. This should reduce our problems with > keeping up with the incoming patches. great, welcome! -- Peter Meerwald-Stadler Mobile: +43 664

Re: [pulseaudio-discuss] [PATCH v2 01/10] build: Add Coverity scan model

> Ack, go ahead and push this. Do we need to modify our Coverity project > settings? pushed, no need to modify server side Coverity settings Philip can re-enable the periodic scans thanks, p. -- Peter Meerwald-Stadler Mobile: +43 664 24

[pulseaudio-discuss] [PATCH v2 09/10] raop: Fix potential resource leaks

Coverity ID: #1410204, #1410203, #1410202, #1410201, #1410200, #1410199 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/module-raop-discover.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/modules/raop/modul

[pulseaudio-discuss] [PATCH v2 08/10] raop: Silence unchecked return value warnings

Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index c6e1877..d329a09 100644 --- a/src/modules/raop/raop-cl

[pulseaudio-discuss] [PATCH v2 05/10] raop: Fix resource leaks

Coverity ID: #1398158, #1398159 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 4c3083e..0

[pulseaudio-discuss] [PATCH v2 04/10] raop: Fix memleak

use local scope for trs variable simplifying cleanup Coverity ID: #1398160 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/module

[pulseaudio-discuss] [PATCH v2 10/10] raop: Fix potential NULL dereference

'realm' is mandatory Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index d329a09..5248691 100644 ---

[pulseaudio-discuss] [PATCH v2 07/10] raop: Fix indentation

Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 03558f6..c6e1877 100644 --- a/src/modules/raop/raop-cl

[pulseaudio-discuss] [PATCH v2 00/10] Coverity fixes, raop

the first patch commits the model file as used on scan.coverity.com and rewrites pa_assert_se() so that Coverity doesn't complain about side-effects some more Coverity fixes for the raop code Peter Meerwald-Stadler (10): build: Add Coverity scan model raop: Fix double free raop: Fix loop

[pulseaudio-discuss] [PATCH v2 03/10] raop: Fix loop searching for port number

do...while not reachable, loop should try different ports in case EADDRINUSE is returned Coverity ID: #1398161 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/m

[pulseaudio-discuss] [PATCH v2 02/10] raop: Fix double free

make nick variable local, fix double free Coverity CID: #1398162 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-sink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/raop/raop-sink.c b/src/modules/raop/raop-sink.c

[pulseaudio-discuss] [PATCH v2 01/10] build: Add Coverity scan model

to be rewritten for Coverity so that the assignment is not declared a side-effect Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> Cc: Philip Withnall <phi...@tecnocode.co.uk> --- coverity/model.c | 18 ++ src/pulsecore/macro.h | 9 + 2 files changed, 2

Re: [pulseaudio-discuss] Coverity scan

> > https://lost-contact.mit.edu/afs/cs.stanford.edu/pkg/prevent-4.3.1/ > > > i3 > > > 86 > > > _linux26/opt/prevent-linux-4.3.1/doc/prevent_admin.html#N40430 > > > > So there’s still this to try. > > ^-- This is the approach I thin

[pulseaudio-discuss] [PATCH 1/4] roap: Fix double free

make nick variable local, fix double free Coverity CID: #1398162 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-sink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/raop/raop-sink.c b/src/modules/raop/raop-sink.c

[pulseaudio-discuss] [PATCH 2/4] roap-client: Fix loop searching for port number

do...while not reachable, loop should try different ports in case EADDRINUSE is returned Coverity ID: #1398161 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/m

[pulseaudio-discuss] [PATCH 3/4] roap: Fix memleak

use local scope for trs variable simplifying cleanup Coverity ID: #1398160 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/module

[pulseaudio-discuss] [PATCH 4/4] raop: Fix resource leaks

Coverity ID: #1398158, #1398159 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/raop/raop-client.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/modules/raop/raop-client.c b/src/modules/raop/raop-client.c index 4c3083e..0

[pulseaudio-discuss] Coverity scan

= uniquex ; if (!(uniquey)) __coverity_panic__(); } while (0) ideally, this should be on a build server which also has a fixed set of libraries and configure options... thanks, p. -- Peter Meerwald-Stadler +43-664-218 (mobile) ___ pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] sink, source: Add a mode to avoid resampling if possible

sthrough && > !avoid_resampling)) { > pa_log_debug("Default and alternate sample rates are the same, so > there is no point in switching."); > return -1; > } > @@ -1010,7 +1011,12 @@ int pa_source_update_rate(pa_source *

Re: [pulseaudio-discuss] Purpose of 8-byte buffer alignment in cpu-mix-test.c

ve explicit alignment requirements/guarantees on buffers that are potentially processed by SIMDy code; alignment might make the code run faster regards, p. -- Peter Meerwald-Stadler +43-664-218 (mobile) ___ pulseaudio-discuss mailing list pulseaudio-discuss@li

[pulseaudio-discuss] json libraries

Hi, here is a comparison of JSON parsing libraries, http://seriot.ch/parsing_json.php maybe of interest since PA is now using its own code instead of json-c... regards, p. -- Peter Meerwald-Stadler +43-664-218 (mobile) ___ pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH v2 0/6] Coverity cleanups

> > v2 of Coverity cleanups, thanks for feedback from Tanu > > > > Peter Meerwald-Stadler (6): > > padsp: Fix flush and improve error handling > > core: Replace PA_PAGE_SIZE with pa_page_size() > > tests: Assert granularity range in stripnul.c >

[pulseaudio-discuss] [PATCH v2 5/6] sink-input: Avoid potential NULL dereference

if data->sink is NULL, pa_sink_input_new_data_set_sink() may fail to set data->sink; the false retval is ignored, leading to a NULL dereference in pa_sink_get_state(data->sink) below CID 1323591 --- src/pulsecore/sink-input.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[pulseaudio-discuss] [PATCH v2 6/6] sample: RFC: Assert validity of sample_spec

passing an invalid sample_spec to pa_sample_size_of_format(), pa_frame_size(), pa_bytes_per_second(), pa_bytes_to_usec(), pa_usec_to_bytes() currently gives a result of 0 this is problematic as (a) it leads to many potential divide-by-zero issues flagged by Coverity, (b) pa_sample_spec_valid() is

[pulseaudio-discuss] [PATCH v2 3/6] tests: Assert granularity range in stripnul.c

granularity must not be larger than buffer size CID 1138482 --- src/tests/stripnul.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/tests/stripnul.c b/src/tests/stripnul.c index 75390bd..e4b07aa 100644 --- a/src/tests/stripnul.c +++ b/src/tests/stripnul.c @@ -26,6

[pulseaudio-discuss] [PATCH v2 0/6] Coverity cleanups

v2 of Coverity cleanups, thanks for feedback from Tanu Peter Meerwald-Stadler (6): padsp: Fix flush and improve error handling core: Replace PA_PAGE_SIZE with pa_page_size() tests: Assert granularity range in stripnul.c source-output: Avoid potential NULL dereference sink-input: Avoid

[pulseaudio-discuss] [PATCH v2 2/6] core: Replace PA_PAGE_SIZE with pa_page_size()

PA_PAGE_SIZE using sysconf() may return a negative number CID 1137925, CID 1137926, CID 1138485 instead of calling sysconf() directly, add function pa_page_size() which uses the guestimate 4096 in case sysconf(_SC_PAGE_SIZE) fails using PA_ONCE to only evaluate sysconf() once ---

[pulseaudio-discuss] [PATCH 6/6] sample: RFC: Assert validity of sample_spec

passing an invalid sample_spec to pa_sample_size_of_format(), pa_frame_size(), pa_bytes_per_second(), pa_bytes_to_usec(), pa_usec_to_bytes() currently gives a result of 0 this is problematic as (a) it leads to many potential divide-by-zero issues flagged by Coverity, (b) pa_sample_spec_valid() is

[pulseaudio-discuss] [PATCH 4/6] source-output: Avoid potential NULL dereference

if data->source is NULL, pa_source_output_new_data_set_source() may fail to set data->source; the false retval is ignored, leading to a NULL dereference in pa_source_get_state(data->source) below CID 1323590 --- src/pulsecore/source-output.c | 3 ++- 1 file changed, 2 insertions(+), 1

[pulseaudio-discuss] [PATCH 5/6] sink-input: Avoid potential NULL dereference

if data->sink is NULL, pa_sink_input_new_data_set_sink() may fail to set data->sink; the false retval is ignored, leading to a NULL dereference in pa_sink_get_state(data->sink) below CID 1323591 --- src/pulsecore/sink-input.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[pulseaudio-discuss] [PATCH 2/6] core: PA_PAGE_SIZE using sysconf() may return a negative number

/pulsecore/macro.c new file mode 100644 index 000..70cadf1 --- /dev/null +++ b/src/pulsecore/macro.c @@ -0,0 +1,39 @@ +/*** + This file is part of PulseAudio. + + Copyright 2016 Peter Meerwald-Stadler + + PulseAudio is free software; you can redistribute it and/or modify + it under the terms

[pulseaudio-discuss] [PATCH 3/6] tests: Assert granularity range in stripnul.c

CID 1138482 --- src/tests/stripnul.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tests/stripnul.c b/src/tests/stripnul.c index 75390bd..78bb040 100644 --- a/src/tests/stripnul.c +++ b/src/tests/stripnul.c @@ -34,6 +34,7 @@ int main(int argc, char *argv[]) { pa_assert_se(argc >=

[pulseaudio-discuss] [PATCH 1/6] padsp: Fix flush

read() can return a number of bytes read less than k CID 1137981 --- src/utils/padsp.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/utils/padsp.c b/src/utils/padsp.c index 943479b..bb01f7f 100644 --- a/src/utils/padsp.c +++ b/src/utils/padsp.c @@ -1768,11

Re: [pulseaudio-discuss] [PATCH 1/2] bluetooth: Fix potential NULL pointer dereference

> On Wed, 2016-08-17 at 14:43 +0200, Peter Meerwald-Stadler wrote: > > I can't find an easy argument why the NULL dereference can't happen (as I  > > am not intimate with the semantics of the dbus functions involved) > > Sorry, I should have provided an explanation already

[pulseaudio-discuss] [PATCH v2 2/2] bluetooth: Fix negative array index write

From: Peter Meerwald <p.meerw...@bct-electronic.com> CID 1533121 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- v2: use pa_read() as Tanu suggested --- src/modules/bluetooth/backend-native.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a

[pulseaudio-discuss] [PATCH v2 1/2] bluetooth: Reorganize code to avoid Coverity NULL dereference warning

From: Peter Meerwald <p.meerw...@bct-electronic.com> CID 1353122 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- v2: wording as suggested by Tanu, thanks! --- src/modules/bluetooth/bluez4-util.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

Re: [pulseaudio-discuss] [PATCH 1/2] bluetooth: Fix potential NULL pointer dereference

> > CID 1353122 > > > > Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> > > --- > >  src/modules/bluetooth/bluez4-util.c | 10 +- > >  1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/src/modules/blue

[pulseaudio-discuss] [PATCH 2/2] bluetooth: Fix negative array index write

From: Peter Meerwald <p.meerw...@bct-electronic.com> CID 1533121 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/bluetooth/backend-native.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/bluetooth/backend-native.c b

[pulseaudio-discuss] [PATCH 1/2] bluetooth: Fix potential NULL pointer dereference

From: Peter Meerwald <p.meerw...@bct-electronic.com> CID 1353122 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/bluetooth/bluez4-util.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/modules/bluetooth/bluez4-util.c b

[pulseaudio-discuss] [PATCH 3/3] bluetooth: Fix dead code

CID 1353115 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/bluetooth/module-bluez4-discover.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/modules/bluetooth/module-bluez4-discover.c b/src/modules/bluetooth/module-bluez4-discover.c

[pulseaudio-discuss] [PATCH 1/3] Remove newline at end of log messages

Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/daemon/main.c| 14 +++--- src/modules/alsa/alsa-util.c | 16 src/modules/bluetooth/backend-native.c | 2 +- src/modules/bluetooth/bluez4-

[pulseaudio-discuss] [PATCH 2/3] bluetooth: Don't free modargs twice

CID1353139 Signed-off-by: Peter Meerwald-Stadler <pme...@pmeerw.net> --- src/modules/bluetooth/module-bluez5-device.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c

Re: [pulseaudio-discuss] [PATCH v2 00/12] patches addressing some Coverity issues

stream: Check pa_tagstruct_get_format_info() retval in > > pa_create_stream_callback() applied > > alsa: Check pa_modargs_get_value_boolean() retval for use_ucm applied -- Peter Meerwald-Stadler +43-664-218 (mobile) ___ pulseaud

[pulseaudio-discuss] [PATCH] sink-input, source-output: Fix logging, don't overwrite old_value when value == 0

--- src/pulsecore/sink-input.c| 10 -- src/pulsecore/source-output.c | 10 -- 2 files changed, 8 insertions(+), 12 deletions(-) diff --git a/src/pulsecore/sink-input.c b/src/pulsecore/sink-input.c index 1ed5dda..435e63e 100644 --- a/src/pulsecore/sink-input.c +++

Re: [pulseaudio-discuss] [PATCH] sink-input, source-output: Fix a leak during property change logging

ish; > > This doesn't handle correctly the transition from non-utf8 data to > unset (i.e. when both variables are NULL). right -- Peter Meerwald-Stadler +43-664-218 (mobile)___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss

Re: [pulseaudio-discuss] [PATCH] sink-input, source-output: Fix a leak during property change logging

} else > +} else { > +pa_xfree(old_value); > old_value = pa_xstrdup("(data)"); > +} > } else { > if (!value) > goto finish; > -- > 2.7.4 > > ______

Re: [pulseaudio-discuss] need help building/cross compiling tests

e? maybe you libcheck locally install (so headers are available), but not as a dependency for cross-dev pulseaudio? > Or has anybody cross compiled libcheck for arm-linux-gnueabi target? http://libcheck.github.io/check/ regards, p. -- Peter Meerwald-Stadler +43-664-

Re: [pulseaudio-discuss] [PATCH] Added set-(sink|source)-latency-offset commands to pactl and pacmd.

NULL); > > @@ -1580,6 +1590,7 @@ static void help(const char *argv0) { > printf("%s %s %s %s\n", argv0, _("[options]"), > "set-(sink-input|source-output)-mute", _("#N 1|0|toggle")); > printf("%s

Re: [pulseaudio-discuss] [PATCH] Added set-(sink|source)-latency-offset commands to pactl and pacmd.

, > > _("NAME|#N OFFSET")); > > printf("%s %s %s\n", argv0, "set-log-target", _("TARGET")); > > printf("%s %s %s\n", argv0, "set-log-level", _("NUMERIC-LEVEL")); > > printf("%s %s %s\n", argv0, "