[pulseaudio-discuss] [PATCH 1/2] Log feature:Add a new log target to a file descriptor

2011-03-09 Thread Vincent Becker
This patch enables logging of text debug messages (pa_log feature) into a file or a device driver. Example : pulseaudio --log-target=file:./mylog.txt Signed-off-by: Vincent Becker vincentx.bec...@intel.com --- src/daemon/cmdline.c |5 +++-- src/daemon/daemon-conf.c | 26

Re: [pulseaudio-discuss] [PATCH 1/2] Log feature:Add a new log target to a file descriptor

2011-03-09 Thread Maarten Bosmans
2011/3/9 Vincent Becker vincentx.bec...@intel.com: @@ -185,7 +193,23 @@ int pa_daemon_conf_set_log_target(pa_daemon_conf *c, const char *string) {     } else if (!strcmp(string, stderr)) {         c-auto_log_target = 0;         c-log_target = PA_LOG_STDERR; -    } else +    } else if

Re: [pulseaudio-discuss] [PATCH 1/2] Log feature:Add a new log target to a file descriptor

2011-03-09 Thread Becker, VincentX
-Original Message- From: pulseaudio-discuss-boun...@mail.0pointer.de [mailto:pulseaudio- discuss-boun...@mail.0pointer.de] On Behalf Of Maarten Bosmans Sent: Wednesday, March 09, 2011 5:31 PM To: General PulseAudio Discussion Subject: Re: [pulseaudio-discuss] [PATCH 1/2] Log feature:Add

[pulseaudio-discuss] [PATCH 1/2] Log feature:Add a new log target to a file descriptor

2011-03-08 Thread Vincent Becker
This patch enables logging of text debug messages (pa_log feature) into a file or a device driver. Example : pulseaudio --log-target=file:./mylog.txt Signed-off-by: Vincent Becker vincentx.bec...@intel.com --- src/daemon/cmdline.c |5 +++-- src/daemon/daemon-conf.c | 34

Re: [pulseaudio-discuss] [PATCH 1/2] Log feature:Add a new log target to a file descriptor

2011-03-08 Thread Maarten Bosmans
FWIW, I've tested this patch and it works as advertised. As we already decided in the IRC meeting that the concept of the patch was fine, this is ready to go in git master. (with some minor cosmetic adjustments?) Maarten 2011/3/8 Vincent Becker vincentx.bec...@intel.com: This patch enables

Re: [pulseaudio-discuss] [PATCH 1/2] Log feature:Add a new log target to a file descriptor

2011-03-08 Thread Arun Raghavan
Hi, I haven't tested your patch, but some comments on the code below. On Tue, 2011-03-08 at 17:15 +0100, Vincent Becker wrote: This patch enables logging of text debug messages (pa_log feature) into a file or a device driver. Example : pulseaudio --log-target=file:./mylog.txt