Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-25 Thread Becker, VincentX
From: Maarten Bosmans [mailto:mkbosm...@gmail.com] Sent: Friday, February 25, 2011 1:10 AM To: Becker, VincentX Cc: General PulseAudio Discussion Subject: Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature The patches were handled at the meeting yesterday http

Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-25 Thread Becker, VincentX
-Original Message- From: pulseaudio-discuss-boun...@mail.0pointer.de [mailto:pulseaudio- discuss-boun...@mail.0pointer.de] On Behalf Of Paul Menzel Sent: Thursday, February 24, 2011 11:15 PM To: pulseaudio-discuss@mail.0pointer.de Subject: Re: [pulseaudio-discuss] [PATCH 1/2] Add a target

Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-24 Thread Becker, VincentX
From: Maarten Bosmans [mailto:mkbosm...@gmail.com] 2011/2/23 Becker, VincentX vincentx.bec...@intel.com: Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for the inner one. I will try to attend to the irc

Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-24 Thread Paul Menzel
Dear VincentX, please note in the subject what iteration your patch is, e. g. »[PATCH 1/2 v2]«. See `--subject-prefix` in `git help format-patch`. Am Donnerstag, den 24.02.2011, 16:30 + schrieb Becker, VincentX: From 55f84afd8575dadba697c746daa61ee07b333c57 Mon Sep 17 00:00:00 2001 From:

Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-24 Thread Maarten Bosmans
2011/2/24 Becker, VincentX vincentx.bec...@intel.com: From: Maarten Bosmans [mailto:mkbosm...@gmail.com] 2011/2/23 Becker, VincentX vincentx.bec...@intel.com: Thanks for your review Maarten. So you suggest to split this into several patches (2). One for the outer implementation and the other for

Re: [pulseaudio-discuss] [PATCH 1/2] Add a target to the PA log feature

2011-02-24 Thread Colin Guthrie
'Twas brillig, and Paul Menzel at 24/02/11 22:14 did gyre and gimble: Could you add that indentation change in a separate patch? It makes it easier to review in my opinion. It is not necessary though. I think we'll try and avoid the majority of the indentation changes if possible. I appreciate