Re: [pulseaudio-discuss] [PATCH] fix the assumption that volume is always positive

2011-05-26 Thread Colin Guthrie
'Twas brillig, and Lu Guanqun at 26/05/11 09:49 did gyre and gimble: Add a variable to track whether the actual volume is set or not. Suppose this: min volume: -126max volume: 0 then when user wants to set some constant volume to -10, it would fail. Tanu, are you OK with this

Re: [pulseaudio-discuss] [PATCH] fix the assumption that volume is always positive

2011-05-26 Thread Tanu Kaskinen
On Thu, 2011-05-26 at 09:50 +0100, Colin Guthrie wrote: 'Twas brillig, and Lu Guanqun at 26/05/11 09:49 did gyre and gimble: Add a variable to track whether the actual volume is set or not. Suppose this: min volume: -126max volume: 0 then when user wants to set some constant

Re: [pulseaudio-discuss] [PATCH] fix the assumption that volume is always positive

2011-05-26 Thread Tanu Kaskinen
On Thu, 2011-05-26 at 14:08 +0300, Tanu Kaskinen wrote: On Thu, 2011-05-26 at 09:50 +0100, Colin Guthrie wrote: 'Twas brillig, and Lu Guanqun at 26/05/11 09:49 did gyre and gimble: Add a variable to track whether the actual volume is set or not. Suppose this: min volume: -126

Re: [pulseaudio-discuss] [PATCH] fix the assumption that volume is always positive

2011-05-26 Thread Lu Guanqun
On Thu, May 26, 2011 at 09:21:45PM +0800, Colin Guthrie wrote: 'Twas brillig, and Tanu Kaskinen at 26/05/11 13:48 did gyre and gimble: On Thu, 2011-05-26 at 14:08 +0300, Tanu Kaskinen wrote: On Thu, 2011-05-26 at 09:50 +0100, Colin Guthrie wrote: 'Twas brillig, and Lu Guanqun at 26/05/11