On Thu, May 26, 2011 at 01:07:33PM +0200, David Henningsson wrote:
On 2011-05-19 18:44, Jorge Eduardo Candelaria wrote:
+typedef enum pa_jack_event {
+PA_JACK_HEADPHONES,
+PA_JACK_HEADSET,
I'm a little hesitant to whether we should have one headset or whether
that should be
I was asked by Colin to give this a quick review, so...
On 2011-05-19 18:44, Jorge Eduardo Candelaria wrote:
From: Margarita Olaya Cabreram...@slimlogic.co.uk
This patch adds support to module-alsa-card so that we can read jack insertion
and removal events using the input device subsystem.
Sorry for late reply...
On Fri, 2011-05-20 at 09:14 -0500, Jorge Eduardo Candelaria wrote:
+if (event-value)
+pa_hook_fire(u-core-hooks[PA_CORE_HOOK_JACK_INSERT], jack);
+else
+pa_hook_fire(u-core-hooks[PA_CORE_HOOK_JACK_REMOVE], jack);
Firing core hooks
On May 19, 2011, at 3:11 PM, Tanu Kaskinen wrote:
I tried to apply the patch for easier review in meld, but unfortunately
it seems that some helpful software has eaten the first space on lines
that begin with one or more spaces. Because of that, git am doesn't
accept the patch.
I'll
I tried to apply the patch for easier review in meld, but unfortunately
it seems that some helpful software has eaten the first space on lines
that begin with one or more spaces. Because of that, git am doesn't
accept the patch.
I'll review this anyway, without meld.
Overall comments: there is
